[jira] Commented: (LUCENE-1955) Fix Hits deprecation notice
[ https://issues.apache.org/jira/browse/LUCENE-1955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767397#action_12767397 ] Mark Miller commented on LUCENE-1955: - Sorry again ;) I'm slowing everything up - feel free - if you don't, I'll do it when I commit the Highlighter fix in a bit. Just have to throw my noisy laptop out the window and into a brick wall first ... > Fix Hits deprecation notice > --- > > Key: LUCENE-1955 > URL: https://issues.apache.org/jira/browse/LUCENE-1955 > Project: Lucene - Java > Issue Type: Bug > Components: Javadocs >Reporter: Mark Miller >Assignee: Mark Miller >Priority: Minor > Fix For: 2.9.1 > > > Just needs to be committed to 2.9 branch since hits is now removed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Commented: (LUCENE-1955) Fix Hits deprecation notice
[ https://issues.apache.org/jira/browse/LUCENE-1955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767391#action_12767391 ] Michael McCandless commented on LUCENE-1955: Mark do you want to commit this? Or I can. Wanting to cut an RC tomorrow... > Fix Hits deprecation notice > --- > > Key: LUCENE-1955 > URL: https://issues.apache.org/jira/browse/LUCENE-1955 > Project: Lucene - Java > Issue Type: Bug > Components: Javadocs >Reporter: Mark Miller >Assignee: Mark Miller >Priority: Minor > Fix For: 2.9.1 > > > Just needs to be committed to 2.9 branch since hits is now removed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Commented: (LUCENE-1955) Fix Hits deprecation notice
[ https://issues.apache.org/jira/browse/LUCENE-1955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766921#action_12766921 ] Michael McCandless commented on LUCENE-1955: bq. I think we want to point people to Searcher.search instead? Woops sorry I missed this, and, I agree. And your fix looks good to me. Wanna commit that on 2.9.1? > Fix Hits deprecation notice > --- > > Key: LUCENE-1955 > URL: https://issues.apache.org/jira/browse/LUCENE-1955 > Project: Lucene - Java > Issue Type: Bug > Components: Javadocs >Reporter: Mark Miller >Assignee: Mark Miller >Priority: Minor > Fix For: 2.9.1 > > > Just needs to be committed to 2.9 branch since hits is now removed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Commented: (LUCENE-1955) Fix Hits deprecation notice
[
https://issues.apache.org/jira/browse/LUCENE-1955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766910#action_12766910
]
Mark Miller commented on LUCENE-1955:
-
Mike fixed as:
{code}
* @deprecated
* see {...@link TopScoreDocCollector} and {...@link TopDocs} :
*
* TopScoreDocCollector collector = TopScoreDocCollector.create(hitsPerPage,
false);
* searcher.search(new TermQuery(new Term("field", "iterator")), collector);
* ScoreDoc[] docHits = collector.topDocs().scoreDocs;
* for (int i = 0; i < docHits.length; i++) {
* int docId = docHits[i].doc;
* Document d = searcher.doc(docId);
* }
*
{code}
But as we discussed in the past, I think we want to point people to
Searcher.search instead?
> Fix Hits deprecation notice
> ---
>
> Key: LUCENE-1955
> URL: https://issues.apache.org/jira/browse/LUCENE-1955
> Project: Lucene - Java
> Issue Type: Bug
> Components: Javadocs
>Reporter: Mark Miller
>Assignee: Mark Miller
>Priority: Minor
> Fix For: 2.9.1
>
>
> Just needs to be committed to 2.9 branch since hits is now removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
-
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Commented: (LUCENE-1955) Fix Hits deprecation notice
[
https://issues.apache.org/jira/browse/LUCENE-1955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763086#action_12763086
]
Mark Miller commented on LUCENE-1955:
-
Here is what I have so far (taken from an email i sent to the dev list):
{code}
* @deprecated
* see {...@link Searcher#search(Query, int)}, {...@link Searcher#search(Query,
Filter, int)}
* and {...@link Searcher#search(Query, Filter, int, Sort)}:
*
* TopDocs topDocs = searcher.search(query, numHits);
* ScoreDoc[] hits = topDocs.scoreDocs;
* for (int i = 0; i < hits.length; i++) {
* int docId = hits[i].doc;
* Document d = searcher.doc(docId);
* // do something with current hit
* ...
*
*/
{code}
> Fix Hits deprecation notice
> ---
>
> Key: LUCENE-1955
> URL: https://issues.apache.org/jira/browse/LUCENE-1955
> Project: Lucene - Java
> Issue Type: Bug
> Components: Javadocs
>Reporter: Mark Miller
>Assignee: Mark Miller
>Priority: Minor
> Fix For: 2.9.1
>
>
> Just needs to be committed to 2.9 branch since hits is now removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
-
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
