[jira] Commented: (LUCENE-2199) ShingleFilter skips over trie-shingles if outputUnigram is set to false
[
https://issues.apache.org/jira/browse/LUCENE-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12798470#action_12798470
]
Robert Muir commented on LUCENE-2199:
-
simon, your fix makes sense to me... i think you should commit it
ShingleFilter skips over trie-shingles if outputUnigram is set to false
---
Key: LUCENE-2199
URL: https://issues.apache.org/jira/browse/LUCENE-2199
Project: Lucene - Java
Issue Type: Bug
Components: contrib/analyzers
Affects Versions: 2.4, 2.4.1, 2.9, 2.9.1, 3.0
Reporter: Simon Willnauer
Assignee: Simon Willnauer
Fix For: 3.1
Attachments: LUCENE-2199.patch, LUCENE-2199.patch
Spinoff from http://lucene.markmail.org/message/uq4xdjk26yduvnpa
{quote}
I noticed that if I set outputUnigrams to false it gives me the same output
for
maxShingleSize=2 and maxShingleSize=3.
please divide divide this this sentence
when i set maxShingleSize to 4 output is:
please divide please divide this sentence divide this this sentence
I was expecting the output as follows with maxShingleSize=3 and
outputUnigrams=false :
please divide this divide this sentence
{quote}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
-
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Commented: (LUCENE-2199) ShingleFilter skips over trie-shingles if outputUnigram is set to false
[
https://issues.apache.org/jira/browse/LUCENE-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12798474#action_12798474
]
Simon Willnauer commented on LUCENE-2199:
-
I plan to commit this in today or tomorrow. Somebody volunteering to backport?
simon
ShingleFilter skips over trie-shingles if outputUnigram is set to false
---
Key: LUCENE-2199
URL: https://issues.apache.org/jira/browse/LUCENE-2199
Project: Lucene - Java
Issue Type: Bug
Components: contrib/analyzers
Affects Versions: 2.4, 2.4.1, 2.9, 2.9.1, 3.0
Reporter: Simon Willnauer
Assignee: Simon Willnauer
Fix For: 3.1
Attachments: LUCENE-2199.patch, LUCENE-2199.patch
Spinoff from http://lucene.markmail.org/message/uq4xdjk26yduvnpa
{quote}
I noticed that if I set outputUnigrams to false it gives me the same output
for
maxShingleSize=2 and maxShingleSize=3.
please divide divide this this sentence
when i set maxShingleSize to 4 output is:
please divide please divide this sentence divide this this sentence
I was expecting the output as follows with maxShingleSize=3 and
outputUnigrams=false :
please divide this divide this sentence
{quote}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
-
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Commented: (LUCENE-2199) ShingleFilter skips over trie-shingles if outputUnigram is set to false
[
https://issues.apache.org/jira/browse/LUCENE-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12798522#action_12798522
]
Simon Willnauer commented on LUCENE-2199:
-
I committed this in revision 897672
Robert, would you please backport this to 2.9 / 3.0 - thanks for the offer!
simon
ShingleFilter skips over trie-shingles if outputUnigram is set to false
---
Key: LUCENE-2199
URL: https://issues.apache.org/jira/browse/LUCENE-2199
Project: Lucene - Java
Issue Type: Bug
Components: contrib/analyzers
Affects Versions: 2.4, 2.4.1, 2.9, 2.9.1, 3.0
Reporter: Simon Willnauer
Assignee: Simon Willnauer
Fix For: 3.1
Attachments: LUCENE-2199.patch, LUCENE-2199.patch
Spinoff from http://lucene.markmail.org/message/uq4xdjk26yduvnpa
{quote}
I noticed that if I set outputUnigrams to false it gives me the same output
for
maxShingleSize=2 and maxShingleSize=3.
please divide divide this this sentence
when i set maxShingleSize to 4 output is:
please divide please divide this sentence divide this this sentence
I was expecting the output as follows with maxShingleSize=3 and
outputUnigrams=false :
please divide this divide this sentence
{quote}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
-
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Commented: (LUCENE-2199) ShingleFilter skips over trie-shingles if outputUnigram is set to false
[
https://issues.apache.org/jira/browse/LUCENE-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12798162#action_12798162
]
Simon Willnauer commented on LUCENE-2199:
-
We should likely backport this to 2.9 / 3.0 too
ShingleFilter skips over trie-shingles if outputUnigram is set to false
---
Key: LUCENE-2199
URL: https://issues.apache.org/jira/browse/LUCENE-2199
Project: Lucene - Java
Issue Type: Bug
Components: contrib/analyzers
Affects Versions: 2.4, 2.4.1, 2.9, 2.9.1, 3.0
Reporter: Simon Willnauer
Fix For: 3.1
Attachments: LUCENE-2199.patch
Spinoff from http://lucene.markmail.org/message/uq4xdjk26yduvnpa
{quote}
I noticed that if I set outputUnigrams to false it gives me the same output
for
maxShingleSize=2 and maxShingleSize=3.
please divide divide this this sentence
when i set maxShingleSize to 4 output is:
please divide please divide this sentence divide this this sentence
I was expecting the output as follows with maxShingleSize=3 and
outputUnigrams=false :
please divide this divide this sentence
{quote}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
-
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
