[jira] Commented: (LUCENE-2331) Add NoOpMergePolicy
[ https://issues.apache.org/jira/browse/LUCENE-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848196#action_12848196 ] Michael McCandless commented on LUCENE-2331: OK, then I'll leave it. Patch looks good -- these are simple additions -- I'll commit shortly. Thanks Shai! > Add NoOpMergePolicy > --- > > Key: LUCENE-2331 > URL: https://issues.apache.org/jira/browse/LUCENE-2331 > Project: Lucene - Java > Issue Type: New Feature > Components: Index >Reporter: Shai Erera >Assignee: Michael McCandless > Fix For: 3.1 > > Attachments: LUCENE-2331.patch, LUCENE-2331.patch, LUCENE-2331.patch > > > I'd like to add a simple and useful MP implementation which does nothing > ! :). I've came across many places where either the following is documented > or implemented: "if you want to prevent merges, set mergeFactor to a high > enough value". I think a NoOpMergePolicy is just as good, and can REALLY > allow you disable merges (except for maybe set mergeFactor to Int.MAX_VAL). > As such, NoOpMergePolicy will be introduced as a singleton, and can be used > for convenience purposes only. Also, for Parallel Index it's important, > because I'd like the slices to never do any merges, unless ParallelWriter > decides so. So they should be set w/ that MP. > I have a patch ready. Waiting for LUCENE-2320 to go in, so that I don't need > to change it afterwards. > About the name - I like the name, but suggestions are welcome. I thought of a > NullMergePolicy, but I don't like 'Null' used for a NoOp. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Commented: (LUCENE-2331) Add NoOpMergePolicy
[ https://issues.apache.org/jira/browse/LUCENE-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848192#action_12848192 ] Shai Erera commented on LUCENE-2331: I think it's correct. The idea is to say that even w/ NMP, if you use NMS you ensure that no MS code is ever run (e.g. if you use NMP only, then CMS code [default] will always run but won't do anything). > Add NoOpMergePolicy > --- > > Key: LUCENE-2331 > URL: https://issues.apache.org/jira/browse/LUCENE-2331 > Project: Lucene - Java > Issue Type: New Feature > Components: Index >Reporter: Shai Erera >Assignee: Michael McCandless > Fix For: 3.1 > > Attachments: LUCENE-2331.patch, LUCENE-2331.patch, LUCENE-2331.patch > > > I'd like to add a simple and useful MP implementation which does nothing > ! :). I've came across many places where either the following is documented > or implemented: "if you want to prevent merges, set mergeFactor to a high > enough value". I think a NoOpMergePolicy is just as good, and can REALLY > allow you disable merges (except for maybe set mergeFactor to Int.MAX_VAL). > As such, NoOpMergePolicy will be introduced as a singleton, and can be used > for convenience purposes only. Also, for Parallel Index it's important, > because I'd like the slices to never do any merges, unless ParallelWriter > decides so. So they should be set w/ that MP. > I have a patch ready. Waiting for LUCENE-2320 to go in, so that I don't need > to change it afterwards. > About the name - I like the name, but suggestions are welcome. I thought of a > NullMergePolicy, but I don't like 'Null' used for a NoOp. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Commented: (LUCENE-2331) Add NoOpMergePolicy
[
https://issues.apache.org/jira/browse/LUCENE-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848189#action_12848189
]
Michael McCandless commented on LUCENE-2331:
In the jdocs for NoMergeScheduler you say this:
{noformat}
Note that you can achieve the same thing by using {...@link NoMergePolicy},
however with {...@link NoMergeScheduler}
you also ensure that no unnecessary code of any {...@link MergeScheduler}
implementation is ever executed.
{noformat}
Should that {...@link MergeScheduler} be {...@link MergePolicy} instead? I can
fix...
> Add NoOpMergePolicy
> ---
>
> Key: LUCENE-2331
> URL: https://issues.apache.org/jira/browse/LUCENE-2331
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Index
>Reporter: Shai Erera
>Assignee: Michael McCandless
> Fix For: 3.1
>
> Attachments: LUCENE-2331.patch, LUCENE-2331.patch, LUCENE-2331.patch
>
>
> I'd like to add a simple and useful MP implementation which does nothing
> ! :). I've came across many places where either the following is documented
> or implemented: "if you want to prevent merges, set mergeFactor to a high
> enough value". I think a NoOpMergePolicy is just as good, and can REALLY
> allow you disable merges (except for maybe set mergeFactor to Int.MAX_VAL).
> As such, NoOpMergePolicy will be introduced as a singleton, and can be used
> for convenience purposes only. Also, for Parallel Index it's important,
> because I'd like the slices to never do any merges, unless ParallelWriter
> decides so. So they should be set w/ that MP.
> I have a patch ready. Waiting for LUCENE-2320 to go in, so that I don't need
> to change it afterwards.
> About the name - I like the name, but suggestions are welcome. I thought of a
> NullMergePolicy, but I don't like 'Null' used for a NoOp.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
-
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Commented: (LUCENE-2331) Add NoOpMergePolicy
[ https://issues.apache.org/jira/browse/LUCENE-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848158#action_12848158 ] Michael McCandless commented on LUCENE-2331: bq. You ask because of the useCompound* methods? Yes, because these methods (unexpectedly -- not good) also affect whether newly flushed segments are CFS or not. I think just the two is OK? One can always make their own class if they really need diff't settings for the stores vs non-stores. > Add NoOpMergePolicy > --- > > Key: LUCENE-2331 > URL: https://issues.apache.org/jira/browse/LUCENE-2331 > Project: Lucene - Java > Issue Type: New Feature > Components: Index >Reporter: Shai Erera >Assignee: Michael McCandless > Fix For: 3.1 > > Attachments: LUCENE-2331.patch, LUCENE-2331.patch > > > I'd like to add a simple and useful MP implementation which does nothing > ! :). I've came across many places where either the following is documented > or implemented: "if you want to prevent merges, set mergeFactor to a high > enough value". I think a NoOpMergePolicy is just as good, and can REALLY > allow you disable merges (except for maybe set mergeFactor to Int.MAX_VAL). > As such, NoOpMergePolicy will be introduced as a singleton, and can be used > for convenience purposes only. Also, for Parallel Index it's important, > because I'd like the slices to never do any merges, unless ParallelWriter > decides so. So they should be set w/ that MP. > I have a patch ready. Waiting for LUCENE-2320 to go in, so that I don't need > to change it afterwards. > About the name - I like the name, but suggestions are welcome. I thought of a > NullMergePolicy, but I don't like 'Null' used for a NoOp. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Commented: (LUCENE-2331) Add NoOpMergePolicy
[ https://issues.apache.org/jira/browse/LUCENE-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848113#action_12848113 ] Shai Erera commented on LUCENE-2331: bq. do you think we should allow instantiation of NoMergePolicy, allowing you to control if it uses CFS or not? You ask because of the useCompound* methods? I wanted NMP to be a singleton really, and I don't think those two really matter? Meaning, if you are using it, I guess you don't really care if it uses a cmpnd file or not? But if you think it's important, I can create 3 singletons: NO_COMPOUND_FILES_AND_STORE, COMPOUND_FILES, COMPOUND_FILES_AND_STORE (I really hate the long names though). We can settle w/ just two - (NO)COMPOUND_FILES ... > Add NoOpMergePolicy > --- > > Key: LUCENE-2331 > URL: https://issues.apache.org/jira/browse/LUCENE-2331 > Project: Lucene - Java > Issue Type: New Feature > Components: Index >Reporter: Shai Erera >Assignee: Michael McCandless > Fix For: 3.1 > > Attachments: LUCENE-2331.patch, LUCENE-2331.patch > > > I'd like to add a simple and useful MP implementation which does nothing > ! :). I've came across many places where either the following is documented > or implemented: "if you want to prevent merges, set mergeFactor to a high > enough value". I think a NoOpMergePolicy is just as good, and can REALLY > allow you disable merges (except for maybe set mergeFactor to Int.MAX_VAL). > As such, NoOpMergePolicy will be introduced as a singleton, and can be used > for convenience purposes only. Also, for Parallel Index it's important, > because I'd like the slices to never do any merges, unless ParallelWriter > decides so. So they should be set w/ that MP. > I have a patch ready. Waiting for LUCENE-2320 to go in, so that I don't need > to change it afterwards. > About the name - I like the name, but suggestions are welcome. I thought of a > NullMergePolicy, but I don't like 'Null' used for a NoOp. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Commented: (LUCENE-2331) Add NoOpMergePolicy
[ https://issues.apache.org/jira/browse/LUCENE-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848080#action_12848080 ] Michael McCandless commented on LUCENE-2331: Patch looks good Shai! But, can you normalize the white space (2 space indent)? Also... do you think we should allow instantiation of NoMergePolicy, allowing you to control if it uses CFS or not? > Add NoOpMergePolicy > --- > > Key: LUCENE-2331 > URL: https://issues.apache.org/jira/browse/LUCENE-2331 > Project: Lucene - Java > Issue Type: New Feature > Components: Index >Reporter: Shai Erera >Assignee: Michael McCandless > Fix For: 3.1 > > Attachments: LUCENE-2331.patch > > > I'd like to add a simple and useful MP implementation which does nothing > ! :). I've came across many places where either the following is documented > or implemented: "if you want to prevent merges, set mergeFactor to a high > enough value". I think a NoOpMergePolicy is just as good, and can REALLY > allow you disable merges (except for maybe set mergeFactor to Int.MAX_VAL). > As such, NoOpMergePolicy will be introduced as a singleton, and can be used > for convenience purposes only. Also, for Parallel Index it's important, > because I'd like the slices to never do any merges, unless ParallelWriter > decides so. So they should be set w/ that MP. > I have a patch ready. Waiting for LUCENE-2320 to go in, so that I don't need > to change it afterwards. > About the name - I like the name, but suggestions are welcome. I thought of a > NullMergePolicy, but I don't like 'Null' used for a NoOp. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Commented: (LUCENE-2331) Add NoOpMergePolicy
[ https://issues.apache.org/jira/browse/LUCENE-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847086#action_12847086 ] Shai Erera commented on LUCENE-2331: In the process, I'll also add a NoMergeScheduler which will have empty implementations of MS. That's kind of redundant if one uses NoMP, however for symmetry it's nice to have it, as well as for not running any unnecessary code, like CMS and its threads, just to discover MP returned nothing. > Add NoOpMergePolicy > --- > > Key: LUCENE-2331 > URL: https://issues.apache.org/jira/browse/LUCENE-2331 > Project: Lucene - Java > Issue Type: New Feature > Components: Index >Reporter: Shai Erera > Fix For: 3.1 > > > I'd like to add a simple and useful MP implementation which does nothing > ! :). I've came across many places where either the following is documented > or implemented: "if you want to prevent merges, set mergeFactor to a high > enough value". I think a NoOpMergePolicy is just as good, and can REALLY > allow you disable merges (except for maybe set mergeFactor to Int.MAX_VAL). > As such, NoOpMergePolicy will be introduced as a singleton, and can be used > for convenience purposes only. Also, for Parallel Index it's important, > because I'd like the slices to never do any merges, unless ParallelWriter > decides so. So they should be set w/ that MP. > I have a patch ready. Waiting for LUCENE-2320 to go in, so that I don't need > to change it afterwards. > About the name - I like the name, but suggestions are welcome. I thought of a > NullMergePolicy, but I don't like 'Null' used for a NoOp. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Commented: (LUCENE-2331) Add NoOpMergePolicy
[ https://issues.apache.org/jira/browse/LUCENE-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847018#action_12847018 ] Michael McCandless commented on LUCENE-2331: +1 for NoMergePolicy > Add NoOpMergePolicy > --- > > Key: LUCENE-2331 > URL: https://issues.apache.org/jira/browse/LUCENE-2331 > Project: Lucene - Java > Issue Type: New Feature > Components: Index >Reporter: Shai Erera > Fix For: 3.1 > > > I'd like to add a simple and useful MP implementation which does nothing > ! :). I've came across many places where either the following is documented > or implemented: "if you want to prevent merges, set mergeFactor to a high > enough value". I think a NoOpMergePolicy is just as good, and can REALLY > allow you disable merges (except for maybe set mergeFactor to Int.MAX_VAL). > As such, NoOpMergePolicy will be introduced as a singleton, and can be used > for convenience purposes only. Also, for Parallel Index it's important, > because I'd like the slices to never do any merges, unless ParallelWriter > decides so. So they should be set w/ that MP. > I have a patch ready. Waiting for LUCENE-2320 to go in, so that I don't need > to change it afterwards. > About the name - I like the name, but suggestions are welcome. I thought of a > NullMergePolicy, but I don't like 'Null' used for a NoOp. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Commented: (LUCENE-2331) Add NoOpMergePolicy
[ https://issues.apache.org/jira/browse/LUCENE-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846998#action_12846998 ] Shai Erera commented on LUCENE-2331: I like NoMergesPolicy ... perhaps, like NoLockFactory, we can call it NoMergePolicy? so MP is preserved in the name (not that it's critical)? > Add NoOpMergePolicy > --- > > Key: LUCENE-2331 > URL: https://issues.apache.org/jira/browse/LUCENE-2331 > Project: Lucene - Java > Issue Type: New Feature > Components: Index >Reporter: Shai Erera > Fix For: 3.1 > > > I'd like to add a simple and useful MP implementation which does nothing > ! :). I've came across many places where either the following is documented > or implemented: "if you want to prevent merges, set mergeFactor to a high > enough value". I think a NoOpMergePolicy is just as good, and can REALLY > allow you disable merges (except for maybe set mergeFactor to Int.MAX_VAL). > As such, NoOpMergePolicy will be introduced as a singleton, and can be used > for convenience purposes only. Also, for Parallel Index it's important, > because I'd like the slices to never do any merges, unless ParallelWriter > decides so. So they should be set w/ that MP. > I have a patch ready. Waiting for LUCENE-2320 to go in, so that I don't need > to change it afterwards. > About the name - I like the name, but suggestions are welcome. I thought of a > NullMergePolicy, but I don't like 'Null' used for a NoOp. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Commented: (LUCENE-2331) Add NoOpMergePolicy
[ https://issues.apache.org/jira/browse/LUCENE-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846926#action_12846926 ] Earwin Burrfoot commented on LUCENE-2331: - NoMergesPolicy - that's exactly what it is, a policy of no merges > Add NoOpMergePolicy > --- > > Key: LUCENE-2331 > URL: https://issues.apache.org/jira/browse/LUCENE-2331 > Project: Lucene - Java > Issue Type: New Feature > Components: Index >Reporter: Shai Erera > Fix For: 3.1 > > > I'd like to add a simple and useful MP implementation which does nothing > ! :). I've came across many places where either the following is documented > or implemented: "if you want to prevent merges, set mergeFactor to a high > enough value". I think a NoOpMergePolicy is just as good, and can REALLY > allow you disable merges (except for maybe set mergeFactor to Int.MAX_VAL). > As such, NoOpMergePolicy will be introduced as a singleton, and can be used > for convenience purposes only. Also, for Parallel Index it's important, > because I'd like the slices to never do any merges, unless ParallelWriter > decides so. So they should be set w/ that MP. > I have a patch ready. Waiting for LUCENE-2320 to go in, so that I don't need > to change it afterwards. > About the name - I like the name, but suggestions are welcome. I thought of a > NullMergePolicy, but I don't like 'Null' used for a NoOp. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
