[jira] Commented: (LUCENE-2364) Add support for terms in BytesRef format to Term, TermQuery, TermRangeQuery & Co.
[ https://issues.apache.org/jira/browse/LUCENE-2364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855358#action_12855358 ] Uwe Schindler commented on LUCENE-2364: --- +1 Term is still used at a lot of places in internal code, but that can be changed easily. One of those places is MTQ :-) > Add support for terms in BytesRef format to Term, TermQuery, TermRangeQuery & > Co. > - > > Key: LUCENE-2364 > URL: https://issues.apache.org/jira/browse/LUCENE-2364 > Project: Lucene - Java > Issue Type: Improvement >Affects Versions: Flex Branch >Reporter: Uwe Schindler > Fix For: 3.1 > > > It would be good to directly allow BytesRefs in TermQuery and TermRangeQuery > (as both queries convert the strings to BytesRef internally). For > NumericRange support in Solr it will be needed to support numerics as ByteRef > in single-term queries. > When this will be added, don't forget to change TestNumericRangeQueryXX to > use the BytesRef ctor of TRQ. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Commented: (LUCENE-2364) Add support for terms in BytesRef format to Term, TermQuery, TermRangeQuery & Co.
[ https://issues.apache.org/jira/browse/LUCENE-2364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855343#action_12855343 ] Michael McCandless commented on LUCENE-2364: Maybe we should simply deprecate Term? It's used in very few places, now. And then require you pass in separate String field, BytesRef text (eg to TermQuery). > Add support for terms in BytesRef format to Term, TermQuery, TermRangeQuery & > Co. > - > > Key: LUCENE-2364 > URL: https://issues.apache.org/jira/browse/LUCENE-2364 > Project: Lucene - Java > Issue Type: Improvement >Affects Versions: Flex Branch >Reporter: Uwe Schindler > Fix For: 3.1 > > > It would be good to directly allow BytesRefs in TermQuery and TermRangeQuery > (as both queries convert the strings to BytesRef internally). For > NumericRange support in Solr it will be needed to support numerics as ByteRef > in single-term queries. > When this will be added, don't forget to change TestNumericRangeQueryXX to > use the BytesRef ctor of TRQ. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Commented: (LUCENE-2364) Add support for terms in BytesRef format to Term, TermQuery, TermRangeQuery & Co.
[ https://issues.apache.org/jira/browse/LUCENE-2364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854717#action_12854717 ] Michael McCandless commented on LUCENE-2364: Once we fix Term to take a BytesRef, we should remove the newly added IndexReader.docFreq(String field, BytesRef term), and just use the existing one that takes a Term. > Add support for terms in BytesRef format to Term, TermQuery, TermRangeQuery & > Co. > - > > Key: LUCENE-2364 > URL: https://issues.apache.org/jira/browse/LUCENE-2364 > Project: Lucene - Java > Issue Type: Improvement >Affects Versions: Flex Branch >Reporter: Uwe Schindler > Fix For: 3.1 > > > It would be good to directly allow BytesRefs in TermQuery and TermRangeQuery > (as both queries convert the strings to BytesRef internally). For > NumericRange support in Solr it will be needed to support numerics as ByteRef > in single-term queries. > When this will be added, don't forget to change TestNumericRangeQueryXX to > use the BytesRef ctor of TRQ. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Commented: (LUCENE-2364) Add support for terms in BytesRef format to Term, TermQuery, TermRangeQuery & Co.
[ https://issues.apache.org/jira/browse/LUCENE-2364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854575#action_12854575 ] Michael McCandless commented on LUCENE-2364: Also FieldCacheRangeFilter.newStringRange, but for this we need FieldCache to load as BytesRef (I'll open a separate issue). > Add support for terms in BytesRef format to Term, TermQuery, TermRangeQuery & > Co. > - > > Key: LUCENE-2364 > URL: https://issues.apache.org/jira/browse/LUCENE-2364 > Project: Lucene - Java > Issue Type: Improvement >Affects Versions: Flex Branch >Reporter: Uwe Schindler > Fix For: 3.1 > > > It would be good to directly allow BytesRefs in TermQuery and TermRangeQuery > (as both queries convert the strings to BytesRef internally). For > NumericRange support in Solr it will be needed to support numerics as ByteRef > in single-term queries. > When this will be added, don't forget to change TestNumericRangeQueryXX to > use the BytesRef ctor of TRQ. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Commented: (LUCENE-2364) Add support for terms in BytesRef format to Term, TermQuery, TermRangeQuery & Co.
[ https://issues.apache.org/jira/browse/LUCENE-2364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853336#action_12853336 ] Uwe Schindler commented on LUCENE-2364: --- This would also make MTQ's rewrite mode internal collectors better, as they convert BytesRef terms from the enums to String Terms, passing to TermQuery and inside TermScorer convert back. Whith real binary terms (numerics are not yet real binary, they are UTF-8 conform ascii bytes), this would break. > Add support for terms in BytesRef format to Term, TermQuery, TermRangeQuery & > Co. > - > > Key: LUCENE-2364 > URL: https://issues.apache.org/jira/browse/LUCENE-2364 > Project: Lucene - Java > Issue Type: Improvement >Affects Versions: Flex Branch >Reporter: Uwe Schindler > Fix For: Flex Branch > > > It would be good to directly allow BytesRefs in TermQuery and TermRangeQuery > (as both queries convert the strings to BytesRef internally). For > NumericRange support in Solr it will be needed to support numerics as ByteRef > in single-term queries. > When this will be added, don't forget to change TestNumericRangeQueryXX to > use the BytesRef ctor of TRQ. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
