[jira] Resolved: (LUCENE-1976) isCurrent() and getVersion() on an NRT reader are broken
[ https://issues.apache.org/jira/browse/LUCENE-1976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-1976. Resolution: Fixed OK fixed on 3.1. isCurrent() and getVersion() on an NRT reader are broken Key: LUCENE-1976 URL: https://issues.apache.org/jira/browse/LUCENE-1976 Project: Lucene - Java Issue Type: Bug Components: Index Affects Versions: 2.9 Reporter: Michael McCandless Assignee: Michael McCandless Priority: Minor Fix For: 3.1, 3.0, 2.9.1 Attachments: LUCENE-1976.patch Right now isCurrent() will always return true for an NRT reader and getVersion() will always return the version of the last commit. This is because the NRT reader holds the live segmentInfos. I think isCurrent() should return false when any further changes have occurred with the writer, else true. This is actually fairly easy to determine, since the writer tracks how many docs deletions are buffered in RAM and these counters only increase with each change. getVersion should return the version as of when the reader was created. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Resolved: (LUCENE-1976) isCurrent() and getVersion() on an NRT reader are broken
[ https://issues.apache.org/jira/browse/LUCENE-1976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-1976. Resolution: Fixed Fix Version/s: (was: 3.1) 3.0 2.9.1 isCurrent() and getVersion() on an NRT reader are broken Key: LUCENE-1976 URL: https://issues.apache.org/jira/browse/LUCENE-1976 Project: Lucene - Java Issue Type: Bug Components: Index Affects Versions: 2.9 Reporter: Michael McCandless Assignee: Michael McCandless Priority: Minor Fix For: 2.9.1, 3.0 Attachments: LUCENE-1976.patch Right now isCurrent() will always return true for an NRT reader and getVersion() will always return the version of the last commit. This is because the NRT reader holds the live segmentInfos. I think isCurrent() should return false when any further changes have occurred with the writer, else true. This is actually fairly easy to determine, since the writer tracks how many docs deletions are buffered in RAM and these counters only increase with each change. getVersion should return the version as of when the reader was created. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
