[jira] Updated: (LUCENE-1401) Deprecation of autoCommit in 2.4 leads to compile problems, when autoCommit should be false

2008-09-23 Thread Michael McCandless (JIRA)

 [ 
https://issues.apache.org/jira/browse/LUCENE-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael McCandless updated LUCENE-1401:
---

Affects Version/s: 2.9
Fix Version/s: 2.9
   2.4

 Deprecation of autoCommit in 2.4 leads to compile problems, when autoCommit 
 should be false
 ---

 Key: LUCENE-1401
 URL: https://issues.apache.org/jira/browse/LUCENE-1401
 Project: Lucene - Java
  Issue Type: Bug
  Components: Index
Affects Versions: 2.4, 2.9
Reporter: Uwe Schindler
Assignee: Michael McCandless
Priority: Trivial
 Fix For: 2.4, 2.9


 I am currently changing my code to be most compatible with 2.4. I switched on 
 deprecation warnings and got a warning about the autoCommit parameter in 
 IndexWriter constructors.
 My code *should* use autoCommit=false, so I want to use the new semantics. 
 The default of IndexWriter is still autoCommit=true. My problem now: How to 
 disable autoCommit whithout deprecation warnings?
 Maybe, the old constructors, that are deprecated should use 
 autoCommit=true. But there are new constructors with this 
 IndexWriter.MaxFieldLength mfl in it, that appear new in 2.4 but are 
 deprecated:
 IndexWriter(Directory d, boolean autoCommit, Analyzer a, boolean create, 
 IndexDeletionPolicy deletionPolicy, IndexWriter.MaxFieldLength mfl) 
   Deprecated. This will be removed in 3.0, when autoCommit will be 
 hardwired to false. Use 
 IndexWriter(Directory,Analyzer,boolean,IndexDeletionPolicy,MaxFieldLength) 
 instead, and call commit() when needed.
 What the hell is meant by this, a new constructor that is deprecated? And the 
 hint is wrong. If I use the other constructor in the warning, I get 
 autoCommit=true.
 There is something completely wrong.
 It should be clear, which constructors set autoCommit=true, which set it per 
 default to false (perhaps new ones), and the Deprecated text is wrong, if 
 autoCommit does not default to false.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (LUCENE-1401) Deprecation of autoCommit in 2.4 leads to compile problems, when autoCommit should be false

2008-09-23 Thread Michael McCandless (JIRA)

 [ 
https://issues.apache.org/jira/browse/LUCENE-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael McCandless updated LUCENE-1401:
---

Attachment: LUCENE-1401.patch

Attached patch that removes the new deprecated ctors, and sets autoCommit=false 
for the new ctors (that take MaxFieldLength).

The bulk of the patch is fixing all places where we were calling the new 
deprecated ctors.

 Deprecation of autoCommit in 2.4 leads to compile problems, when autoCommit 
 should be false
 ---

 Key: LUCENE-1401
 URL: https://issues.apache.org/jira/browse/LUCENE-1401
 Project: Lucene - Java
  Issue Type: Bug
  Components: Index
Affects Versions: 2.4, 2.9
Reporter: Uwe Schindler
Assignee: Michael McCandless
Priority: Trivial
 Fix For: 2.4, 2.9

 Attachments: LUCENE-1401.patch


 I am currently changing my code to be most compatible with 2.4. I switched on 
 deprecation warnings and got a warning about the autoCommit parameter in 
 IndexWriter constructors.
 My code *should* use autoCommit=false, so I want to use the new semantics. 
 The default of IndexWriter is still autoCommit=true. My problem now: How to 
 disable autoCommit whithout deprecation warnings?
 Maybe, the old constructors, that are deprecated should use 
 autoCommit=true. But there are new constructors with this 
 IndexWriter.MaxFieldLength mfl in it, that appear new in 2.4 but are 
 deprecated:
 IndexWriter(Directory d, boolean autoCommit, Analyzer a, boolean create, 
 IndexDeletionPolicy deletionPolicy, IndexWriter.MaxFieldLength mfl) 
   Deprecated. This will be removed in 3.0, when autoCommit will be 
 hardwired to false. Use 
 IndexWriter(Directory,Analyzer,boolean,IndexDeletionPolicy,MaxFieldLength) 
 instead, and call commit() when needed.
 What the hell is meant by this, a new constructor that is deprecated? And the 
 hint is wrong. If I use the other constructor in the warning, I get 
 autoCommit=true.
 There is something completely wrong.
 It should be clear, which constructors set autoCommit=true, which set it per 
 default to false (perhaps new ones), and the Deprecated text is wrong, if 
 autoCommit does not default to false.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]