[jira] Updated: (LUCENE-1449) IndexDeletionPolicy.delete behaves incorrectly when deleting latest generation
[ https://issues.apache.org/jira/browse/LUCENE-1449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-1449: --- Attachment: LUCENE-1449.patch OK I attached a new patch, this time including the simple fix, which is for IndexWriter to mark itself as having pending changes whenever the head commit point gets deleted by the deletion policy on init. I will commit shortly. > IndexDeletionPolicy.delete behaves incorrectly when deleting latest > generation > --- > > Key: LUCENE-1449 > URL: https://issues.apache.org/jira/browse/LUCENE-1449 > Project: Lucene - Java > Issue Type: Bug > Components: Index >Affects Versions: 2.9 >Reporter: Mark Harwood >Assignee: Michael McCandless >Priority: Minor > Attachments: LUCENE-1449.patch, LUCENE-1449.patch, > TestTransactionRollbackCapability.java, > TestTransactionRollbackCapability2.java > > > I have been looking to provide the ability to rollback committed transactions > and encountered some issues. > I appreciate IndexDeletionPolicy's main motivation is to handle cleaning away > OLD commit points but it does not explicitly state that it can or cannot be > used to clean NEW commit points. > If this is not supported then the documentation should ideally state this. If > the intention is to support this behaviour then read on ... > There seem to be 2 issues so far: > 1) The first attempt to call IndexCommit.delete on the latest commit point > fails to remove any contents. The subsequent call succeeds however > 2) Deleting the latest commit point fails to update the segments.gen file to > point to segments_N-1. New IndexReaders that are opened are then misdirected > to open segments_N which has been deleted > Junit test to follow... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (LUCENE-1449) IndexDeletionPolicy.delete behaves incorrectly when deleting latest generation
[ https://issues.apache.org/jira/browse/LUCENE-1449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-1449: --- Attachment: LUCENE-1449.patch Excellent! I modified your test -- cleaned up whitespace, removed the @author tag, and put back a modified failing test case from your original (to show the bug that we still need to fix). Next I'll work on fixing the bug so that test case passes. > IndexDeletionPolicy.delete behaves incorrectly when deleting latest > generation > --- > > Key: LUCENE-1449 > URL: https://issues.apache.org/jira/browse/LUCENE-1449 > Project: Lucene - Java > Issue Type: Bug > Components: Index >Affects Versions: 2.9 >Reporter: Mark Harwood >Assignee: Michael McCandless >Priority: Minor > Attachments: LUCENE-1449.patch, > TestTransactionRollbackCapability.java, > TestTransactionRollbackCapability2.java > > > I have been looking to provide the ability to rollback committed transactions > and encountered some issues. > I appreciate IndexDeletionPolicy's main motivation is to handle cleaning away > OLD commit points but it does not explicitly state that it can or cannot be > used to clean NEW commit points. > If this is not supported then the documentation should ideally state this. If > the intention is to support this behaviour then read on ... > There seem to be 2 issues so far: > 1) The first attempt to call IndexCommit.delete on the latest commit point > fails to remove any contents. The subsequent call succeeds however > 2) Deleting the latest commit point fails to update the segments.gen file to > point to segments_N-1. New IndexReaders that are opened are then misdirected > to open segments_N which has been deleted > Junit test to follow... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (LUCENE-1449) IndexDeletionPolicy.delete behaves incorrectly when deleting latest generation
[ https://issues.apache.org/jira/browse/LUCENE-1449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Harwood updated LUCENE-1449: - Attachment: TestTransactionRollbackCapability2.java Thanks for the pointers, Mike. This new test now passes having made a few changes. > IndexDeletionPolicy.delete behaves incorrectly when deleting latest > generation > --- > > Key: LUCENE-1449 > URL: https://issues.apache.org/jira/browse/LUCENE-1449 > Project: Lucene - Java > Issue Type: Bug > Components: Index >Affects Versions: 2.9 >Reporter: Mark Harwood >Assignee: Michael McCandless >Priority: Minor > Attachments: TestTransactionRollbackCapability.java, > TestTransactionRollbackCapability2.java > > > I have been looking to provide the ability to rollback committed transactions > and encountered some issues. > I appreciate IndexDeletionPolicy's main motivation is to handle cleaning away > OLD commit points but it does not explicitly state that it can or cannot be > used to clean NEW commit points. > If this is not supported then the documentation should ideally state this. If > the intention is to support this behaviour then read on ... > There seem to be 2 issues so far: > 1) The first attempt to call IndexCommit.delete on the latest commit point > fails to remove any contents. The subsequent call succeeds however > 2) Deleting the latest commit point fails to update the segments.gen file to > point to segments_N-1. New IndexReaders that are opened are then misdirected > to open segments_N which has been deleted > Junit test to follow... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (LUCENE-1449) IndexDeletionPolicy.delete behaves incorrectly when deleting latest generation
[ https://issues.apache.org/jira/browse/LUCENE-1449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Harwood updated LUCENE-1449: - Attachment: TestTransactionRollbackCapability.java Junit test > IndexDeletionPolicy.delete behaves incorrectly when deleting latest > generation > --- > > Key: LUCENE-1449 > URL: https://issues.apache.org/jira/browse/LUCENE-1449 > Project: Lucene - Java > Issue Type: Bug > Components: Index >Affects Versions: 2.9 >Reporter: Mark Harwood >Priority: Minor > Attachments: TestTransactionRollbackCapability.java > > > I have been looking to provide the ability to rollback committed transactions > and encountered some issues. > I appreciate IndexDeletionPolicy's main motivation is to handle cleaning away > OLD commit points but it does not explicitly state that it can or cannot be > used to clean NEW commit points. > If this is not supported then the documentation should ideally state this. If > the intention is to support this behaviour then read on ... > There seem to be 2 issues so far: > 1) The first attempt to call IndexCommit.delete on the latest commit point > fails to remove any contents. The subsequent call succeeds however > 2) Deleting the latest commit point fails to update the segments.gen file to > point to segments_N-1. New IndexReaders that are opened are then misdirected > to open segments_N which has been deleted > Junit test to follow... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
