[jira] Updated: (LUCENE-1695) Update the Highlighter to use the new TokenStream API
[ https://issues.apache.org/jira/browse/LUCENE-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated LUCENE-1695: Attachment: LUCENE-1695.patch To trunk Update the Highlighter to use the new TokenStream API - Key: LUCENE-1695 URL: https://issues.apache.org/jira/browse/LUCENE-1695 Project: Lucene - Java Issue Type: Improvement Components: contrib/highlighter Reporter: Mark Miller Assignee: Mark Miller Fix For: 2.9 Attachments: LUCENE-1695.patch, LUCENE-1695.patch, LUCENE-1695.patch, LUCENE-1695.patch, LUCENE-1695.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Updated: (LUCENE-1695) Update the Highlighter to use the new TokenStream API
[ https://issues.apache.org/jira/browse/LUCENE-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated LUCENE-1695: Attachment: LUCENE-1695.patch to trunk Update the Highlighter to use the new TokenStream API - Key: LUCENE-1695 URL: https://issues.apache.org/jira/browse/LUCENE-1695 Project: Lucene - Java Issue Type: Improvement Components: contrib/highlighter Reporter: Mark Miller Assignee: Mark Miller Fix For: 2.9 Attachments: LUCENE-1695.patch, LUCENE-1695.patch, LUCENE-1695.patch, LUCENE-1695.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Updated: (LUCENE-1695) Update the Highlighter to use the new TokenStream API
[ https://issues.apache.org/jira/browse/LUCENE-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated LUCENE-1695: Attachment: LUCENE-1695.patch Update the Highlighter to use the new TokenStream API - Key: LUCENE-1695 URL: https://issues.apache.org/jira/browse/LUCENE-1695 Project: Lucene - Java Issue Type: Improvement Components: contrib/highlighter Reporter: Mark Miller Assignee: Mark Miller Fix For: 2.9 Attachments: LUCENE-1695.patch, LUCENE-1695.patch, LUCENE-1695.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Updated: (LUCENE-1695) Update the Highlighter to use the new TokenStream API
[ https://issues.apache.org/jira/browse/LUCENE-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated LUCENE-1695: Attachment: LUCENE-1695.patch Pretty much done, all tests pass. It breaks back compat, but frankly, straddling doesn't seem worth the effort here. Or even very possible. You can't really give new methods to use for the deprecated ones, and deprecating by class would be a real nuisance as we would lose class names I'd rather keep. We have no back compat policy, and I think its worth just pushing this to the new API. I was also thinking about breaking back compat with changing the Highlighter to use the SpanScorer, so doing it all in one shot would be nice. The overall migration should be fairly simple once you understand the new TokenFilter API. I'll handle it for Solr. Still needs either its own changes file to explain or could go in the contrib common changes file. There is a change to the MemoryIndex to get around issues with the new/old API and CachingTokenFilters. Ill have to see how the new TokenFilter API improvements issue works out before doing a final patch for this. Update the Highlighter to use the new TokenStream API - Key: LUCENE-1695 URL: https://issues.apache.org/jira/browse/LUCENE-1695 Project: Lucene - Java Issue Type: Improvement Components: contrib/highlighter Reporter: Mark Miller Assignee: Mark Miller Fix For: 2.9 Attachments: LUCENE-1695.patch, LUCENE-1695.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
[jira] Updated: (LUCENE-1695) Update the Highlighter to use the new TokenStream API
[ https://issues.apache.org/jira/browse/LUCENE-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated LUCENE-1695: Attachment: LUCENE-1695.patch Rough, non backward compat patch. There is still an issue with testUnRewrittenQuery() - it passes in isolation, but not when run with the other tests: java.io.IOException: Stream closed at java.io.StringReader.ensureOpen(StringReader.java:56) at java.io.StringReader.read(StringReader.java:90) at org.apache.lucene.analysis.standard.StandardTokenizerImpl.zzRefill(StandardTokenizerImpl.java:451) at org.apache.lucene.analysis.standard.StandardTokenizerImpl.getNextToken(StandardTokenizerImpl.java:637) at org.apache.lucene.analysis.standard.StandardTokenizer.incrementToken(StandardTokenizer.java:153) at org.apache.lucene.analysis.standard.StandardFilter.incrementToken(StandardFilter.java:50) at org.apache.lucene.analysis.LowerCaseFilter.incrementToken(LowerCaseFilter.java:38) at org.apache.lucene.analysis.StopFilter.incrementToken(StopFilter.java:222) at org.apache.lucene.search.highlight.Highlighter.getBestTextFragments(Highlighter.java:242) Update the Highlighter to use the new TokenStream API - Key: LUCENE-1695 URL: https://issues.apache.org/jira/browse/LUCENE-1695 Project: Lucene - Java Issue Type: Improvement Components: contrib/highlighter Reporter: Mark Miller Assignee: Mark Miller Fix For: 2.9 Attachments: LUCENE-1695.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
