[JBoss-dev] [ jboss-Feature Requests-515842 ] J2EE Certification test
Feature Requests item #515842, was opened at 2002-02-11 02:52 You can respond by visiting: http://sourceforge.net/tracker/?func=detailatid=376688aid=515842group_id=22866 Category: None Group: None Status: Open Priority: 5 Submitted By: Nobody/Anonymous (nobody) Assigned to: Nobody/Anonymous (nobody) Summary: J2EE Certification test Initial Comment: Can we expect that Jboss will acquire Sun's J2EE 1.2/1.3 certification Brand (using the certification test) in a near future. I guess that doing so will convince the business community even better. having the 1.2/1.3 brand ensures that it would be possible to migrate existing J2EE apps from eg. WebSphere to Jboss. Regards, Gunther Strube -- You can respond by visiting: http://sourceforge.net/tracker/?func=detailatid=376688aid=515842group_id=22866 ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] RE: [ jboss-Patches-475080 ] Remove dead imports from jboss-all
I tried to do this around noon on Sunday and cvs head was not compiling... I didn't have too much time to look into it, so I'll give this another shot later on this week. -- Guillaume -Original Message- From: Guillaume Boissiere [mailto:[EMAIL PROTECTED]] Sent: Thursday, February 07, 2002 11:39 AM To: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Subject: RE: [ jboss-Patches-475080 ] Remove dead imports from jboss-all Hi Jason, Sounds good to me, it's one of those things, it never feels like it's a good time to do because it touches so much code. So let me do this: I'll run my script, test that it works well and does not break things and commit the changes to CVS HEAD this week-end unless someone complains. So if this is a bad time for anyone, time to speak up!! -- Guillaume -Original Message- From: nobody [mailto:[EMAIL PROTECTED]]On Behalf Of [EMAIL PROTECTED] Sent: Wednesday, February 06, 2002 7:56 PM To: [EMAIL PROTECTED] Subject: [ jboss-Patches-475080 ] Remove dead imports from jboss-all Patches item #475080, was opened at 2001-10-25 15:05 You can respond by visiting: http://sourceforge.net/tracker/?func=detailatid=376687aid=475080 group_id=22866 Category: JBossServer Group: v3.0 Rabbit Hole (unstable) Status: Open Resolution: None Priority: 5 Submitted By: Guillaume Boissiere (boissier) Assigned to: Nobody/Anonymous (nobody) Summary: Remove dead imports from jboss-all Initial Comment: Would you believe that there are 2065 lines of import x.y.z; where the class is imported but not used? I put together a script that parses through the source code (in jboss-all) and removes all those unnecessary import lines. The result: a performance improvement of almost 10% in the time it takes to compile the whole project... Here is the long patch attached that removes all these extra lines. Patch is lightly tested and after applying it, the project compiles just fine. Enjoy! -- Guillaume PS: I noticed a couple files have CR+CR+LF at the end of each line instead of the more standard CR+LF, CR or LF... I had trouble with those (ex: EJBAdaptorBean) so they are not included here. -- Comment By: Jason Dillon (user57) Date: 2002-02-06 16:55 Message: Logged In: YES user_id=15045 How about submitting the script which does this. Things have changed a bit since this was posted. I think it might be more work to apply the patch (and deal with the conflicts) than to just run the script again. If this is not an issue any more let me know so I can close this. ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] [ jboss-Feature Requests-515885 ] Tomcat 3.3a embedding
Feature Requests item #515885, was opened at 2002-02-11 05:10 You can respond by visiting: http://sourceforge.net/tracker/?func=detailatid=376688aid=515885group_id=22866 Category: None Group: None Status: Open Priority: 5 Submitted By: Nobody/Anonymous (nobody) Assigned to: Nobody/Anonymous (nobody) Summary: Tomcat 3.3a embedding Initial Comment: Tomcat 3.3a is the fastest Tomcat, so there is a need to use it within JBoss instead of Tomcat 3.2. Has a number of changes in configuration and .jar placement, etc., so it can't just replace Tomcat 3.2, and needs work to be done for embedding. IS there someone who did it already ? Is the work in progress ? If you know the steps to do it, please post -- You can respond by visiting: http://sourceforge.net/tracker/?func=detailatid=376688aid=515885group_id=22866 ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] CVS update: jbossmx/src/main/org/jboss/invocation/jrmp/server JRMPInvokerHA.java
Didn't someone mention something about new ObjectName was very very expensive call? Can you cache it? -dain Oleg Nitz wrote: User: olegnitz Date: 02/02/11 16:53:35 Modified:src/main/org/jboss/invocation/jrmp/server JRMPInvokerHA.java Log: The bean hashCode was calculated incorrectly: was String.hashCode(), should be (new ObjectName(String)).hashCode() Revision ChangesPath 1.10 +32 -19 jbossmx/src/main/org/jboss/invocation/jrmp/server/JRMPInvokerHA.java Index: JRMPInvokerHA.java === RCS file: /cvsroot/jboss/jbossmx/src/main/org/jboss/invocation/jrmp/server/JRMPInvokerHA.java,v retrieving revision 1.9 retrieving revision 1.10 diff -u -r1.9 -r1.10 --- JRMPInvokerHA.java 7 Feb 2002 08:56:34 - 1.9 +++ JRMPInvokerHA.java 12 Feb 2002 00:53:35 - 1.10 @@ -41,7 +41,7 @@ * * @author a href=mailto:[EMAIL PROTECTED]Bill Burke/a * -* @version $Revision: 1.9 $ +* @version $Revision: 1.10 $ */ public class JRMPInvokerHA @@ -99,7 +99,7 @@ state = STARTED; log.info(Started); } - + public void stop() { if (getState() != STARTED) @@ -125,49 +125,62 @@ public void destroy() { } - + public void registerBean(String beanName, HATarget target) throws Exception { + Integer hash = new Integer((new ObjectName(beanName)).hashCode()); log.info( BEAN NAME IS +beanName); - beanMap.put(new Integer(beanName.hashCode()), target); + if (beanMap.containsKey(hash)) { + // FIXME [oleg] In theory this is possible! + throw new IllegalStateException(Trying to register bean with the existing hashCode); + } + beanMap.put(hash, target); } - + public JRMPInvokerProxy createProxy(String beanName, LoadBalancePolicy policy) throws Exception { - HATarget target = (HATarget)beanMap.get(new Integer(beanName.hashCode())); + Integer hash = new Integer((new ObjectName(beanName)).hashCode()); + HATarget target = (HATarget)beanMap.get(hash); + if (target == null) { + throw new IllegalStateException(The bean hashCode not found); + } return new JRMPInvokerProxyHA(target.getReplicants(), policy); } - + public void unregisterBean(String beanName) throws Exception { - beanMap.remove(new Integer(beanName.hashCode())); + Integer hash = new Integer((new ObjectName(beanName)).hashCode()); + beanMap.remove(hash); } - + /** * Invoke a Remote interface method. */ public Object invoke(Invocation invocation) throws Exception - { - + { + ClassLoader oldCl = Thread.currentThread().getContextClassLoader(); - + try { - // Deserialize the transaction if it is there + // Deserialize the transaction if it is there invocation.setTransaction(importTPC(((MarshalledInvocation) invocation).getTransactionPropagationContext())); - + // Extract the ObjectName, the rest is still marshalled ObjectName mbean = (ObjectName) Registry.lookup((Integer) invocation.getContainer()); - + long clientViewId = ((Long)invocation.getValue(CLUSTER_VIEW_ID)).longValue(); - - + + // The cl on the thread should be set in another interceptor - Object rtn = server.invoke(mbean, , new Object[] {invocation}, new String[] {java.lang.Object}); + Object rtn = server.invoke(mbean, , new Object[] {invocation}, new String[] {java.lang.Object}); HARMIResponse rsp = new HARMIResponse(); - + HATarget target = (HATarget)beanMap.get((Integer) invocation.getContainer()); + if (target == null) { +throw new IllegalStateException(The bean hashCode not found); + } if (clientViewId != target.getCurrentViewId()) { rsp.newReplicants = new ArrayList(target.getReplicants()); ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] CVS update: jboss/src/main/org/jboss/system UnifiedClassLoader.java
The indents on these changes are all screwed up because tabs are being used instead of spaces. Check your editor settings. - Original Message - From: Jason Dillon [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Monday, February 11, 2002 2:58 PM Subject: [JBoss-dev] CVS update: jboss/src/main/org/jboss/system UnifiedClassLoader.java User: user57 Date: 02/02/11 14:58:49 Modified:src/main/org/jboss/system UnifiedClassLoader.java Log: o using logger to show exception, not printStackTrace() Revision ChangesPath 1.4 +36 -46 jboss/src/main/org/jboss/system/UnifiedClassLoader.java Index: UnifiedClassLoader.java === RCS file: /cvsroot/jboss/jboss/src/main/org/jboss/system/UnifiedClassLoader.java,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- UnifiedClassLoader.java 11 Feb 2002 22:44:34 - 1.3 +++ UnifiedClassLoader.java 11 Feb 2002 22:58:49 - 1.4 @@ -1,37 +1,37 @@ /* -* JBoss, the OpenSource J2EE webOS -* -* Distributable under LGPL license. -* See terms of license at gnu.org. -*/ + * JBoss, the OpenSource J2EE webOS + * + * Distributable under LGPL license. + * See terms of license at gnu.org. + */ + package org.jboss.system; import java.net.URL; import java.io.InputStream; - - /** -* The URLClassLoader is associated with a given URL. -* It can load jar and sar (or jsr). -* -* pThe ServiceLibraries keeps track of the UCL and asks everyone for -*resources and classes. -* -* @author a href=[EMAIL PROTECTED]Marc Fleury/a -* @author a href=[EMAIL PROTECTED]Christoph G. Jung/a -* @author a href=[EMAIL PROTECTED]Scott Stark/a -* @version $Revision: 1.3 $ -* -* pb20010830 marc fleury:/b -* ul -* liInitial import -* /ul -* pb20011009 cgj:/b -* ul -* lifixed default resolution behaviour -* /ul -*/ + * The URLClassLoader is associated with a given URL. + * It can load jar and sar (or jsr). + * + * pThe ServiceLibraries keeps track of the UCL and asks everyone for + *resources and classes. + * + * @author a href=[EMAIL PROTECTED]Marc Fleury/a + * @author a href=[EMAIL PROTECTED]Christoph G. Jung/a + * @author a href=[EMAIL PROTECTED]Scott Stark/a + * @version $Revision: 1.4 $ + * + * pb20010830 marc fleury:/b + * ul + * liInitial import + * /ul + * + * pb20011009 cgj:/b + * ul + * lifixed default resolution behaviour + * /ul + */ public class UnifiedClassLoader extends java.net.URLClassLoader implements UnifiedClassLoaderMBean @@ -75,27 +75,18 @@ } catch(Exception e) { - e.printStackTrace(); - log.warn(URL +url+ could not be opened); + // + // FIXME: Should not mask exceptionsd like this, if it is an error, then + //propagate it to caller tyo handle + // + log.warn(URL +url+ could not be opened, e); } } /** - * loadClass - * - * We intercept the load class to know exactly the dependencies - * of the underlying jar - */ - - - /* - USE THIS TO TRACE CLASS LOADING - if (name.endsWith(CHANGEME)) - { - log.debug(UCL LOAD +this.hashCode()+ in loadClass +name); - } - */ - +* We intercept the load class to know exactly the dependencies +* of the underlying jar +*/ public Class loadClass(String name, boolean resolve) throws ClassNotFoundException { @@ -104,14 +95,13 @@ public Class loadClassLocally (String name, boolean resolve) - throws ClassNotFoundException + throws ClassNotFoundException { return super.loadClass(name, resolve); } public URL getResource(String name) { - URL resource = super.getResource(name); if (resource == null) ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jboss/src/main/org/jboss/system UnifiedClassLoader.java
User: user57 Date: 02/02/11 18:38:39 Modified:src/main/org/jboss/system UnifiedClassLoader.java Log: o fix indentation Revision ChangesPath 1.5 +19 -17jboss/src/main/org/jboss/system/UnifiedClassLoader.java Index: UnifiedClassLoader.java === RCS file: /cvsroot/jboss/jboss/src/main/org/jboss/system/UnifiedClassLoader.java,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- UnifiedClassLoader.java 11 Feb 2002 22:58:49 - 1.4 +++ UnifiedClassLoader.java 12 Feb 2002 02:38:39 - 1.5 @@ -20,7 +20,7 @@ * @author a href=[EMAIL PROTECTED]Marc Fleury/a * @author a href=[EMAIL PROTECTED]Christoph G. Jung/a * @author a href=[EMAIL PROTECTED]Scott Stark/a - * @version $Revision: 1.4 $ + * @version $Revision: 1.5 $ * * pb20010830 marc fleury:/b * ul @@ -49,11 +49,11 @@ private static BootstrapLogger log = BootstrapLogger.getLogger(UnifiedClassLoader.class); /** - * One url per SCL - * - * @param String application - * @param ClassLoader parent - */ +* One url per SCL +* +* @param String application +* @param ClassLoader parent +*/ public UnifiedClassLoader(URL url) { super(new URL[] {url}); @@ -110,11 +110,11 @@ } /* - if (resource == null) - { - if( log.isTraceEnabled() ) - log.trace(Did not find the UCL resource +name); - } +if (resource == null) +{ +if( log.isTraceEnabled() ) +log.trace(Did not find the UCL resource +name); +} */ return resource; } @@ -149,17 +149,19 @@ return url.hashCode(); } - /** This is overriden to return null to avoid excessive and most likely -*useless RMI annotated codebases. Unfortunately this appears to be the -*only wat to do this at the moment(JDK1.3.1). + /** +* This is overriden to return null to avoid excessive and most likely +* useless RMI annotated codebases. Unfortunately this appears to be the +* only wat to do this at the moment(JDK1.3.1). */ public URL[] getURLs() { -return null; + return null; } - /** This method simply invokes the super.getURLs() method to access the -*list of URLs that make up the UnifiedClassLoader classpath. + /** +* This method simply invokes the super.getURLs() method to access the +* list of URLs that make up the UnifiedClassLoader classpath. */ public URL[] getClasspath() { ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jboss/src/main/org/jboss Main.java
User: user57 Date: 02/02/11 18:51:27 Modified:src/main/org/jboss Main.java Log: o handle jmx RuntimeErrorException Revision ChangesPath 1.67 +5 -1 jboss/src/main/org/jboss/Main.java Index: Main.java === RCS file: /cvsroot/jboss/jboss/src/main/org/jboss/Main.java,v retrieving revision 1.66 retrieving revision 1.67 diff -u -r1.66 -r1.67 --- Main.java 11 Feb 2002 23:01:36 - 1.66 +++ Main.java 12 Feb 2002 02:51:27 - 1.67 @@ -12,6 +12,7 @@ import javax.management.MBeanException; import javax.management.RuntimeMBeanException; +import javax.management.RuntimeErrorException; import org.jboss.system.MBeanClassLoader; import org.jboss.system.ServiceLibraries; @@ -28,7 +29,7 @@ * * @author a href=mailto:[EMAIL PROTECTED];Marc Fleury/a * @author a href=mailto:[EMAIL PROTECTED];Jason Dillon/a - * @version $Revision: 1.66 $ + * @version $Revision: 1.67 $ */ public class Main implements Runnable @@ -48,6 +49,9 @@ } catch (RuntimeMBeanException e) { e.getTargetException().printStackTrace(); + } + catch (RuntimeErrorException e) { + e.getTargetError().printStackTrace(); } catch (Exception e) { e.printStackTrace(); ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] Automated JBoss Testsuite Results
JBoss daily test results SUMMARY Number of tests run: 491 Successful tests: 479 Errors:8 Failures: 4 [time of test: 12 February 2002 2:53 GMT] [java.version: 1.3.0] [java.vendor: IBM Corporation] [java.vm.version: 1.3.0] [java.vm.name: Classic VM] [java.vm.info: J2RE 1.3.0 IBM build cx130-20010626 (JIT enabled: jitc)] [os.name: Linux] [os.arch: x86] [os.version: 2.4.9-12] See http://lubega.com for full details NOTE: If there are any errors shown above - this mail is only highlighting them - it is NOT indicating that they are being looked at by anyone. Remember - if a test becomes broken after your changes - fix it or fix the test! DETAILS OF ERRORS [details not shown -as this makes the mail too big to reach the sf mailing list] PS BEFORE you commit, run the test suite! Its really is easy, just use the ant target 'run-basic-testsuite' from the build directory. To just run the unit tests (they are quite quick): In the testsuite directory, ./build.sh tests-unit You can run a single test case using: ./build.sh -Dtest=[XXXTestCase] one-test The XXXTestCase is the classname of the junit class to run. So, to run the EJBSpecUnitTestCase use: ./build.sh -Dtest=EJBSpecUnitTestCase one-test To run all tests within a package, use ./build.sh -Dtest=[package] test The package is name of the directory under the org/jboss/test directory that contains the tests to run. So, to run the unit tests in the org.jboss.test.security package use: ./build.sh -Dtest=security test Thanks for all your effort - we really do love you! ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] What were those timings on 3.0?
The tomcat-test.ear is showing that the optimized container flag is being ignored and all intra-VM calls are going through the local invoker stack and should be optimized. However, the times I'm seeing are 10x slower than the optimized JBoss-2.4.4/Tomcat-4.0.1 times. JBoss-3.0.0/Tomcat-4.0.2: NonOptimized: 1.6 ms/call Optimized: 1.6 ms/call JBoss-2.4.4/Tomcat-4.0.1: NonOptimized: 0.782 ms/call Optimized: 0.156 ms/call Here is the call stack for the stateless session bean which shows the call going through the local invoker which does not use marshalling of the arguments: at org.jboss.test.tomcat.ejb.bean.StatelessSessionBean.getClassLoaders(Stateles sSessionBean.java:97) at org.jboss.test.tomcat.ejb.bean.StatelessSessionBean.getMessageAndTrace(State lessSessionBean.java:52) at java.lang.reflect.Method.invoke(Native Method) at org.jboss.ejb.StatelessSessionContainer$ContainerInterceptor.invoke(Stateles sSessionContainer.java:623) at org.jboss.ejb.plugins.StatelessSessionInstanceInterceptor.invoke(StatelessSe ssionInstanceInterceptor.java:77) at org.jboss.ejb.plugins.AbstractTxInterceptor.invokeNext(AbstractTxInterceptor .java:96) at org.jboss.ejb.plugins.TxInterceptorCMT.runWithTransactions(TxInterceptorCMT. java:158) at org.jboss.ejb.plugins.TxInterceptorCMT.invoke(TxInterceptorCMT.java:64) at org.jboss.ejb.plugins.SecurityInterceptor.invoke(SecurityInterceptor.java:12 7) at org.jboss.ejb.plugins.LogInterceptor.invoke(LogInterceptor.java:166) at org.jboss.ejb.StatelessSessionContainer.invoke(StatelessSessionContainer.jav a:289) at org.jboss.ejb.Container.invoke(Container.java:611) at com.sun.management.jmx.MBeanServerImpl.invoke(MBeanServerImpl.java:1555) at com.sun.management.jmx.MBeanServerImpl.invoke(MBeanServerImpl.java:1523) at org.jboss.invocation.local.LocalInvoker.invoke(LocalInvoker.java:114) at org.jboss.invocation.jrmp.interfaces.JRMPInvokerProxy.invoke(JRMPInvokerProx y.java:150) at org.jboss.proxy.ejb.GenericProxy.invoke(GenericProxy.java:182) at org.jboss.proxy.ejb.StatelessSessionProxy.invoke(StatelessSessionProxy.java: 111) at $Proxy16.getMessageAndTrace(Unknown Source) at org.jboss.test.tomcat.servlet.HelloEJB.testBean(HelloEJB.java:79) at org.jboss.test.tomcat.servlet.HelloEJB.doGet(HelloEJB.java:40) at javax.servlet.http.HttpServlet.service(HttpServlet.java:740) at javax.servlet.http.HttpServlet.service(HttpServlet.java:853) The simple perf test also shows much slower numbers. This test includes the RMI roundtrip overhead and 3.0 is 4x slower: JBoss-3.0.0 [PerfStressTestCase,DEBUG] +++ testTimings() [PerfStressTestCase,DEBUG] Found ProbeHome @ jndiName=Probe [PerfStressTestCase,DEBUG] Created Probe [PerfStressTestCase,DEBUG] Starting 1000 noop() invocations [PerfStressTestCase,DEBUG] 1000 noop() invocations = 4891 ms, 4 ms/noop [PerfStressTestCase,DEBUG] Starting 1000 ping(PING) invocations [PerfStressTestCase,DEBUG] 1000 ping() invocations = 4266 ms, 4 ms/noop [PerfStressTestCase,DEBUG] Starting 1000 echo(ECHO) invocations [PerfStressTestCase,DEBUG] 1000 echo() invocations = 4203 ms, 4 ms/noop JBoss-2.4.4 [junit] +++ testTimings() [junit] Found ProbeHome @ jndiName=Probe [junit] Created Probe [junit] Starting 1000 noop() invocations [junit] 1000 noop() invocations = 1953 ms, 1 ms/noop [junit] Starting 1000 ping(PING) invocations [junit] 1000 ping() invocations = 1937 ms, 1 ms/noop [junit] Starting 1000 echo(ECHO) invocations [junit] 1000 echo() invocations = 2141 ms, 2 ms/noop I'm not inclined to branch for the 3.0 release until I know why these numbers are so poor. Scott Stark Chief Technology Officer JBoss Group, LLC ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] XML snippets in mbean configuration
This is already supported in both 2.4.4 and 3.0. For example, this works with both versions: mbean code=org.jboss.web.catalina.EmbeddedCatalinaServiceSX name=jboss.web:service=EmbeddedCatalinaSX attribute name=Port8080/attribute attribute name=Config Connector className=org.apache.ajp.tomcat4.Ajp13Connector port=8009 minProcessors=5 maxProcessors=75 acceptCount=10 / /attribute /mbean Scott Stark Chief Technology Officer JBoss Group, LLC - Original Message - From: Jason Dillon [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Monday, February 11, 2002 4:00 PM Subject: [JBoss-dev] XML snippets in mbean configuration I have been playing with this idea in my head for a while, but the JMX details kept getting in the way... or rather my comprehension of how JMX fits in go in the way. The concept is to allow a richer configuration interface to our mbeans (and to other compatible mbeans) be letting them take xml snippets. Take the following imaginary example: mbean code=my.imaginary.Service name=imaginary.Service attribute name=XmlConfig configuration someDirective/ /configuration /attribute /mbean ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] XML snippets in mbean configuration
Sorry about that... jumped the gun on sending that email. --jason On Mon, 2002-02-11 at 19:09, Scott M Stark wrote: This is already supported in both 2.4.4 and 3.0. For example, this works with both versions: mbean code=org.jboss.web.catalina.EmbeddedCatalinaServiceSX name=jboss.web:service=EmbeddedCatalinaSX attribute name=Port8080/attribute attribute name=Config Connector className=org.apache.ajp.tomcat4.Ajp13Connector port=8009 minProcessors=5 maxProcessors=75 acceptCount=10 / /attribute /mbean Scott Stark Chief Technology Officer JBoss Group, LLC - Original Message - From: Jason Dillon [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Monday, February 11, 2002 4:00 PM Subject: [JBoss-dev] XML snippets in mbean configuration I have been playing with this idea in my head for a while, but the JMX details kept getting in the way... or rather my comprehension of how JMX fits in go in the way. The concept is to allow a richer configuration interface to our mbeans (and to other compatible mbeans) be letting them take xml snippets. Take the following imaginary example: mbean code=my.imaginary.Service name=imaginary.Service attribute name=XmlConfig configuration someDirective/ /configuration /attribute /mbean ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbosssx build.xml
User: user57 Date: 02/02/11 19:22:02 Modified:.build.xml Log: o Adding SafeObjectFactory, which simply makes ObjectNames and turns ant malformed exceptions into Errors. This is used to create ObjectName OBJECT_NAME fields, so we don't have to keep creating new ObjectNames all the time. o MainDeployer ServiceController use new ObjectName OBJECT_NAME o Updated refering classes to not wrap OBJECT_NAME with new ObjectName o Using MBeanProxy to talk to ServiceController (and MainDeployer in some areas). MBeanProxy is a central location to put in that pesky JMX exception handling + is tidies up the code base. Can evevntually optimize this to make it veru efficient too. o Putting org.jboss.util classes into lib/ext/jboss-util.jar and adding it to the bootlibraries, so that the core system components have access to these when loading (not just when running, aka after jboss-service.xml loads). * Need to clean up jboss-util, move deployable stuff out of it and such (they don't really belong there). o updated modules that needed util, to include jboss-util.jar in there external module config Revision ChangesPath 1.13 +2 -1 jbosssx/build.xml Index: build.xml === RCS file: /cvsroot/jboss/jbosssx/build.xml,v retrieving revision 1.12 retrieving revision 1.13 diff -u -r1.12 -r1.13 --- build.xml 9 Feb 2002 00:01:38 - 1.12 +++ build.xml 12 Feb 2002 03:22:02 - 1.13 @@ -12,7 +12,7 @@ !---- !-- == -- -!-- $Id: build.xml,v 1.12 2002/02/09 00:01:38 starksm Exp $ -- +!-- $Id: build.xml,v 1.13 2002/02/12 03:22:02 user57 Exp $ -- project default=main name=JBoss/Security @@ -166,6 +166,7 @@ property name=jboss.server.lib value=${jboss.server.root}/lib/ path id=jboss.server.classpath pathelement path=${jboss.server.lib}/jboss.jar/ + pathelement path=${jboss.server.lib}/jboss-util.jar/ pathelement path=${jboss.server.lib}/jboss-security.jar/ /path ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbossmx build.xml
User: user57 Date: 02/02/11 19:22:01 Modified:.build.xml Log: o Adding SafeObjectFactory, which simply makes ObjectNames and turns ant malformed exceptions into Errors. This is used to create ObjectName OBJECT_NAME fields, so we don't have to keep creating new ObjectNames all the time. o MainDeployer ServiceController use new ObjectName OBJECT_NAME o Updated refering classes to not wrap OBJECT_NAME with new ObjectName o Using MBeanProxy to talk to ServiceController (and MainDeployer in some areas). MBeanProxy is a central location to put in that pesky JMX exception handling + is tidies up the code base. Can evevntually optimize this to make it veru efficient too. o Putting org.jboss.util classes into lib/ext/jboss-util.jar and adding it to the bootlibraries, so that the core system components have access to these when loading (not just when running, aka after jboss-service.xml loads). * Need to clean up jboss-util, move deployable stuff out of it and such (they don't really belong there). o updated modules that needed util, to include jboss-util.jar in there external module config Revision ChangesPath 1.24 +2 -1 jbossmx/build.xml Index: build.xml === RCS file: /cvsroot/jboss/jbossmx/build.xml,v retrieving revision 1.23 retrieving revision 1.24 diff -u -r1.23 -r1.24 --- build.xml 9 Feb 2002 16:00:51 - 1.23 +++ build.xml 12 Feb 2002 03:22:01 - 1.24 @@ -12,7 +12,7 @@ !---- !-- == -- -!-- $Id: build.xml,v 1.23 2002/02/09 16:00:51 slaboure Exp $ -- +!-- $Id: build.xml,v 1.24 2002/02/12 03:22:01 user57 Exp $ -- project default=main name=JBoss/Cluster @@ -171,6 +171,7 @@ property name=jboss.server.lib value=${jboss.server.root}/lib/ path id=jboss.server.classpath pathelement path=${jboss.server.lib}/jboss.jar/ + pathelement path=${jboss.server.lib}/jboss-util.jar/ /path !-- The combined dependent module classpath -- ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbosscx/src/main/org/jboss/resource RARDeployer.java
User: user57 Date: 02/02/11 19:22:01 Modified:src/main/org/jboss/resource RARDeployer.java Log: o Adding SafeObjectFactory, which simply makes ObjectNames and turns ant malformed exceptions into Errors. This is used to create ObjectName OBJECT_NAME fields, so we don't have to keep creating new ObjectNames all the time. o MainDeployer ServiceController use new ObjectName OBJECT_NAME o Updated refering classes to not wrap OBJECT_NAME with new ObjectName o Using MBeanProxy to talk to ServiceController (and MainDeployer in some areas). MBeanProxy is a central location to put in that pesky JMX exception handling + is tidies up the code base. Can evevntually optimize this to make it veru efficient too. o Putting org.jboss.util classes into lib/ext/jboss-util.jar and adding it to the bootlibraries, so that the core system components have access to these when loading (not just when running, aka after jboss-service.xml loads). * Need to clean up jboss-util, move deployable stuff out of it and such (they don't really belong there). o updated modules that needed util, to include jboss-util.jar in there external module config Revision ChangesPath 1.19 +109 -115 jbosscx/src/main/org/jboss/resource/RARDeployer.java Index: RARDeployer.java === RCS file: /cvsroot/jboss/jbosscx/src/main/org/jboss/resource/RARDeployer.java,v retrieving revision 1.18 retrieving revision 1.19 diff -u -r1.18 -r1.19 --- RARDeployer.java 29 Jan 2002 21:12:22 - 1.18 +++ RARDeployer.java 12 Feb 2002 03:22:01 - 1.19 @@ -1,9 +1,9 @@ /* -* JBoss, the OpenSource J2EE webOS -* -* Distributable under LGPL license. -* See terms of license at gnu.org. -*/ + * JBoss, the OpenSource J2EE webOS + * + * Distributable under LGPL license. + * See terms of license at gnu.org. + */ package org.jboss.resource; @@ -26,8 +26,10 @@ import java.util.Map; import java.util.jar.JarEntry; import java.util.jar.JarFile; + import javax.management.Notification; import javax.management.ObjectName; + import org.jboss.deployment.DeploymentInfo; import org.jboss.deployment.DeploymentException; import org.jboss.logging.Logger; @@ -36,59 +38,64 @@ import org.jboss.system.ServiceMBeanSupport; import org.jboss.system.ServiceControllerMBean; import org.jboss.system.UnifiedClassLoader; +import org.jboss.util.MBeanProxy; + import org.w3c.dom.Document; import org.w3c.dom.Element; /** -* Service that deploys .rar files containing resource adapters. Deploying -* the RAR file is the first step in making the resource adapter available to -* application components; once it is deployed, one or more connection -* factories must be configured and bound into JNDI, a task performed by the -* codeConnectionFactoryLoader/code service. -* -* @author Toby Allsopp ([EMAIL PROTECTED]) -* @author a href=mailto:[EMAIL PROTECTED];David Jencks/a -* @version$Revision: 1.18 $ -* @seeorg.jboss.resource.ConnectionFactoryLoader p -* -* bRevisions:/b p -* -* b20010725 Toby Allsopp (patch from David Jencks)/b -* ul -*li Implemented codegetMetaData/code so that connection factories -*can be loaded after RAR deployment/li -* /ul -* b20011219 Marc Fleury/b -* ul -*li Make the deployer call create and start on the service it deploys/li -* /ul -* b20011227 Marc Fleury/b -* ul -*li Unification of deployers/li -* /ul -* -*/ + * Service that deploys .rar files containing resource adapters. Deploying + * the RAR file is the first step in making the resource adapter available to + * application components; once it is deployed, one or more connection + * factories must be configured and bound into JNDI, a task performed by the + * codeConnectionFactoryLoader/code service. + * + * @author Toby Allsopp ([EMAIL PROTECTED]) + * @author a href=mailto:[EMAIL PROTECTED];David Jencks/a + * @version$Revision: 1.19 $ + * @seeorg.jboss.resource.ConnectionFactoryLoader p + * + * bRevisions:/b p + * + * b20010725 Toby Allsopp (patch from David Jencks)/b + * ul + * li Implemented codegetMetaData/code so that connection factories + *can be loaded after RAR deployment/li + * /ul + * + * b20011219 Marc Fleury/b + * ul + * li Make the deployer call create and start on the service it deploys/li + * /ul + * + * b20011227 Marc Fleury/b + * ul + * li Unification of deployers/li + * /ul + */ public class RARDeployer -extends ServiceMBeanSupport -implements RARDeployerMBean + extends ServiceMBeanSupport + implements RARDeployerMBean { private static int nextNum =
[JBoss-dev] CVS update: contrib/varia build.xml
User: user57 Date: 02/02/11 19:22:01 Modified:variabuild.xml Log: o Adding SafeObjectFactory, which simply makes ObjectNames and turns ant malformed exceptions into Errors. This is used to create ObjectName OBJECT_NAME fields, so we don't have to keep creating new ObjectNames all the time. o MainDeployer ServiceController use new ObjectName OBJECT_NAME o Updated refering classes to not wrap OBJECT_NAME with new ObjectName o Using MBeanProxy to talk to ServiceController (and MainDeployer in some areas). MBeanProxy is a central location to put in that pesky JMX exception handling + is tidies up the code base. Can evevntually optimize this to make it veru efficient too. o Putting org.jboss.util classes into lib/ext/jboss-util.jar and adding it to the bootlibraries, so that the core system components have access to these when loading (not just when running, aka after jboss-service.xml loads). * Need to clean up jboss-util, move deployable stuff out of it and such (they don't really belong there). o updated modules that needed util, to include jboss-util.jar in there external module config Revision ChangesPath 1.15 +2 -1 contrib/varia/build.xml Index: build.xml === RCS file: /cvsroot/jboss/contrib/varia/build.xml,v retrieving revision 1.14 retrieving revision 1.15 diff -u -r1.14 -r1.15 --- build.xml 3 Feb 2002 20:16:25 - 1.14 +++ build.xml 12 Feb 2002 03:22:01 - 1.15 @@ -12,7 +12,7 @@ !---- !-- == -- -!-- $Id: build.xml,v 1.14 2002/02/03 20:16:25 azakkerman Exp $ -- +!-- $Id: build.xml,v 1.15 2002/02/12 03:22:01 user57 Exp $ -- project default=main name=JBoss Plugins/Varia @@ -212,6 +212,7 @@ property name=jboss.server.lib value=${jboss.server.root}/lib/ path id=jboss.server.classpath pathelement path=${jboss.server.lib}/jboss.jar/ + pathelement path=${jboss.server.lib}/jboss-util.jar/ /path !-- The combined dependent module classpath -- ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jboss build.xml
User: user57 Date: 02/02/11 19:22:02 Modified:.build.xml Log: o Adding SafeObjectFactory, which simply makes ObjectNames and turns ant malformed exceptions into Errors. This is used to create ObjectName OBJECT_NAME fields, so we don't have to keep creating new ObjectNames all the time. o MainDeployer ServiceController use new ObjectName OBJECT_NAME o Updated refering classes to not wrap OBJECT_NAME with new ObjectName o Using MBeanProxy to talk to ServiceController (and MainDeployer in some areas). MBeanProxy is a central location to put in that pesky JMX exception handling + is tidies up the code base. Can evevntually optimize this to make it veru efficient too. o Putting org.jboss.util classes into lib/ext/jboss-util.jar and adding it to the bootlibraries, so that the core system components have access to these when loading (not just when running, aka after jboss-service.xml loads). * Need to clean up jboss-util, move deployable stuff out of it and such (they don't really belong there). o updated modules that needed util, to include jboss-util.jar in there external module config Revision ChangesPath 1.54 +24 -24jboss/build.xml Index: build.xml === RCS file: /cvsroot/jboss/jboss/build.xml,v retrieving revision 1.53 retrieving revision 1.54 diff -u -r1.53 -r1.54 --- build.xml 4 Feb 2002 21:27:07 - 1.53 +++ build.xml 12 Feb 2002 03:22:02 - 1.54 @@ -12,7 +12,7 @@ !---- !-- == -- -!-- $Id: build.xml,v 1.53 2002/02/04 21:27:07 patriot1burke Exp $ -- +!-- $Id: build.xml,v 1.54 2002/02/12 03:22:02 user57 Exp $ -- project default=main name=JBoss/Server @@ -480,6 +480,9 @@ !-- Exclude command line utilities -- exclude name=org/jboss/*/ + +!-- Exclude utilities, they are now in jboss-util.jar -- +exclude name=org/jboss/util/*/ !-- Exclude JMX Connector stuff we will use the connector SAR for that -- exclude name=org/jboss/jmx/**/ @@ -501,6 +504,16 @@ /fileset /jar +!-- Build jboss-util.jar -- +jar jarfile=${build.lib}/jboss-util.jar + fileset dir=${build.classes} +include name=org/jboss/util/**/ + +!-- MBeanProxy needs this. This compiler stuff should be moved under util -- +include name=org/jboss/proxy/compiler/**/ + /fileset +/jar + !-- | Build jboss-boot.jar | @@ -511,16 +524,10 @@ fileset dir=${build.classes} include name=org/jboss/Version.class/ include name=org/jboss/system/BootstrapLogger.class/ -include name=org/jboss/system/UnifiedClassLoader.class/ -include name=org/jboss/system/UnifiedClassLoaderMBean.class/ -include name=org/jboss/system/MBeanClassLoader.class/ -include name=org/jboss/system/MBeanClassLoaderMBean.class/ -include name=org/jboss/system/ServiceLibraries.class/ -include name=org/jboss/system/ServiceLibrariesMBean.class/ -include name=org/jboss/system/Server.class/ -include name=org/jboss/system/Server**.class/ -include name=org/jboss/system/ServerMBean.class/ -include name=org/jboss/system/ServerConfig.class/ +include name=org/jboss/system/UnifiedClassLoader*.class/ +include name=org/jboss/system/MBeanClassLoader*.class/ +include name=org/jboss/system/ServiceLibraries*.class/ +include name=org/jboss/system/Server*.class/ include name=org/jboss/deployment/DeploymentException.class/ /fileset fileset dir=${build.resources} @@ -535,23 +542,16 @@ include name=org/jboss/system/Service.class/ include name=org/jboss/system/ServiceMBean.class/ include name=org/jboss/system/ServiceMBeanSupport.class/ -include name=org/jboss/system/ServiceController**.class/ -include name=org/jboss/system/ServiceCreator**.class/ +include name=org/jboss/system/ServiceController*.class/ +include name=org/jboss/system/ServiceCreator*.class/ include name=org/jboss/system/ServiceConfigurator.class/ -include name=org/jboss/system/ServiceControllerMBean.class/ +include name=org/jboss/system/ServiceContext.class/ include name=org/jboss/system/ConfigurationException.class/ include name=org/jboss/system/Info*/ -include name=org/jboss/system/ServiceContext.class/ -include name=org/jboss/deployment/MainDeployer.class/ -include name=org/jboss/deployment/MainDeployerMBean.class/ -
[JBoss-dev] CVS update: admin build.xml
User: user57 Date: 02/02/11 19:22:00 Modified:.build.xml Log: o Adding SafeObjectFactory, which simply makes ObjectNames and turns ant malformed exceptions into Errors. This is used to create ObjectName OBJECT_NAME fields, so we don't have to keep creating new ObjectNames all the time. o MainDeployer ServiceController use new ObjectName OBJECT_NAME o Updated refering classes to not wrap OBJECT_NAME with new ObjectName o Using MBeanProxy to talk to ServiceController (and MainDeployer in some areas). MBeanProxy is a central location to put in that pesky JMX exception handling + is tidies up the code base. Can evevntually optimize this to make it veru efficient too. o Putting org.jboss.util classes into lib/ext/jboss-util.jar and adding it to the bootlibraries, so that the core system components have access to these when loading (not just when running, aka after jboss-service.xml loads). * Need to clean up jboss-util, move deployable stuff out of it and such (they don't really belong there). o updated modules that needed util, to include jboss-util.jar in there external module config Revision ChangesPath 1.13 +2 -1 admin/build.xml Index: build.xml === RCS file: /cvsroot/jboss/admin/build.xml,v retrieving revision 1.12 retrieving revision 1.13 diff -u -r1.12 -r1.13 --- build.xml 15 Jan 2002 16:45:55 - 1.12 +++ build.xml 12 Feb 2002 03:22:00 - 1.13 @@ -12,7 +12,7 @@ !---- !-- == -- -!-- $Id: build.xml,v 1.12 2002/01/15 16:45:55 d_jencks Exp $ -- +!-- $Id: build.xml,v 1.13 2002/02/12 03:22:00 user57 Exp $ -- project default=main name=JBoss/Admin @@ -131,6 +131,7 @@ property name=jboss.server.lib value=${jboss.server.root}/lib/ path id=jboss.server.classpath pathelement path=${jboss.server.lib}/jboss.jar/ + pathelement path=${jboss.server.lib}/jboss-util.jar/ /path !-- The combined depedant module classpath -- ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: build/jboss build.xml
User: user57 Date: 02/02/11 19:22:01 Modified:jbossbuild.xml Log: o Adding SafeObjectFactory, which simply makes ObjectNames and turns ant malformed exceptions into Errors. This is used to create ObjectName OBJECT_NAME fields, so we don't have to keep creating new ObjectNames all the time. o MainDeployer ServiceController use new ObjectName OBJECT_NAME o Updated refering classes to not wrap OBJECT_NAME with new ObjectName o Using MBeanProxy to talk to ServiceController (and MainDeployer in some areas). MBeanProxy is a central location to put in that pesky JMX exception handling + is tidies up the code base. Can evevntually optimize this to make it veru efficient too. o Putting org.jboss.util classes into lib/ext/jboss-util.jar and adding it to the bootlibraries, so that the core system components have access to these when loading (not just when running, aka after jboss-service.xml loads). * Need to clean up jboss-util, move deployable stuff out of it and such (they don't really belong there). o updated modules that needed util, to include jboss-util.jar in there external module config Revision ChangesPath 1.69 +2 -1 build/jboss/build.xml Index: build.xml === RCS file: /cvsroot/jboss/build/jboss/build.xml,v retrieving revision 1.68 retrieving revision 1.69 diff -u -r1.68 -r1.69 --- build.xml 4 Feb 2002 21:25:59 - 1.68 +++ build.xml 12 Feb 2002 03:22:01 - 1.69 @@ -12,7 +12,7 @@ !---- !-- == -- -!-- $Id: build.xml,v 1.68 2002/02/04 21:25:59 patriot1burke Exp $ -- +!-- $Id: build.xml,v 1.69 2002/02/12 03:22:01 user57 Exp $ -- project default=main name=JBoss/Build @@ -431,6 +431,7 @@ copy todir=${install.lib.ext} filtering=no fileset dir=${_module.output}/lib include name=jboss.jar/ + include name=jboss-util.jar/ include name=jboss-spine.jar/ /fileset /copy ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbosscx build.xml
User: user57 Date: 02/02/11 19:22:01 Modified:.build.xml Log: o Adding SafeObjectFactory, which simply makes ObjectNames and turns ant malformed exceptions into Errors. This is used to create ObjectName OBJECT_NAME fields, so we don't have to keep creating new ObjectNames all the time. o MainDeployer ServiceController use new ObjectName OBJECT_NAME o Updated refering classes to not wrap OBJECT_NAME with new ObjectName o Using MBeanProxy to talk to ServiceController (and MainDeployer in some areas). MBeanProxy is a central location to put in that pesky JMX exception handling + is tidies up the code base. Can evevntually optimize this to make it veru efficient too. o Putting org.jboss.util classes into lib/ext/jboss-util.jar and adding it to the bootlibraries, so that the core system components have access to these when loading (not just when running, aka after jboss-service.xml loads). * Need to clean up jboss-util, move deployable stuff out of it and such (they don't really belong there). o updated modules that needed util, to include jboss-util.jar in there external module config Revision ChangesPath 1.19 +2 -1 jbosscx/build.xml Index: build.xml === RCS file: /cvsroot/jboss/jbosscx/build.xml,v retrieving revision 1.18 retrieving revision 1.19 diff -u -r1.18 -r1.19 --- build.xml 20 Jan 2002 15:05:18 - 1.18 +++ build.xml 12 Feb 2002 03:22:01 - 1.19 @@ -12,7 +12,7 @@ !---- !-- == -- -!-- $Id: build.xml,v 1.18 2002/01/20 15:05:18 mnf999 Exp $ -- +!-- $Id: build.xml,v 1.19 2002/02/12 03:22:01 user57 Exp $ -- project default=main name=JBoss/Connector @@ -131,6 +131,7 @@ property name=jboss.server.lib value=${jboss.server.root}/lib/ path id=jboss.server.classpath pathelement path=${jboss.server.lib}/jboss.jar/ + pathelement path=${jboss.server.lib}/jboss-util.jar/ /path !-- Pool -- ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jboss/src/main/org/jboss/deployment EARDeployer.java MainDeployer.java MainDeployerMBean.java SARDeployer.java
User: user57 Date: 02/02/11 19:22:02 Modified:src/main/org/jboss/deployment EARDeployer.java MainDeployer.java MainDeployerMBean.java SARDeployer.java Log: o Adding SafeObjectFactory, which simply makes ObjectNames and turns ant malformed exceptions into Errors. This is used to create ObjectName OBJECT_NAME fields, so we don't have to keep creating new ObjectNames all the time. o MainDeployer ServiceController use new ObjectName OBJECT_NAME o Updated refering classes to not wrap OBJECT_NAME with new ObjectName o Using MBeanProxy to talk to ServiceController (and MainDeployer in some areas). MBeanProxy is a central location to put in that pesky JMX exception handling + is tidies up the code base. Can evevntually optimize this to make it veru efficient too. o Putting org.jboss.util classes into lib/ext/jboss-util.jar and adding it to the bootlibraries, so that the core system components have access to these when loading (not just when running, aka after jboss-service.xml loads). * Need to clean up jboss-util, move deployable stuff out of it and such (they don't really belong there). o updated modules that needed util, to include jboss-util.jar in there external module config Revision ChangesPath 1.5 +3 -3 jboss/src/main/org/jboss/deployment/EARDeployer.java Index: EARDeployer.java === RCS file: /cvsroot/jboss/jboss/src/main/org/jboss/deployment/EARDeployer.java,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- EARDeployer.java 9 Feb 2002 16:09:17 - 1.4 +++ EARDeployer.java 12 Feb 2002 03:22:02 - 1.5 @@ -49,7 +49,7 @@ /** * * @author a href=mailto:[EMAIL PROTECTED];Marc Fleury/a -* @version $Revision: 1.4 $ +* @version $Revision: 1.5 $ */ public class EARDeployer extends ServiceMBeanSupport @@ -189,7 +189,7 @@ { // Register with the main deployer server.invoke( -new ObjectName(org.jboss.deployment.MainDeployerMBean.OBJECT_NAME), +org.jboss.deployment.MainDeployerMBean.OBJECT_NAME, addDeployer, new Object[] {this}, new String[] {org.jboss.deployment.DeployerMBean}); @@ -211,7 +211,7 @@ { // Register with the main deployer server.invoke( -new ObjectName(org.jboss.deployment.MainDeployerMBean.OBJECT_NAME), +org.jboss.deployment.MainDeployerMBean.OBJECT_NAME, removeDeployer, new Object[] {this}, new String[] {org.jboss.deployment.DeployerMBean}); 1.13 +138 -101 jboss/src/main/org/jboss/deployment/MainDeployer.java Index: MainDeployer.java === RCS file: /cvsroot/jboss/jboss/src/main/org/jboss/deployment/MainDeployer.java,v retrieving revision 1.12 retrieving revision 1.13 diff -u -r1.12 -r1.13 --- MainDeployer.java 10 Feb 2002 17:44:32 - 1.12 +++ MainDeployer.java 12 Feb 2002 03:22:02 - 1.13 @@ -37,49 +37,54 @@ import javax.management.MalformedObjectNameException; import org.jboss.system.ServiceMBeanSupport; + import org.jboss.util.DirectoryBuilder; +import org.jboss.util.MBeanProxy; + /** - * MainDeployer - * - * Takes a series of URL to watch, detects changes and calls the appropriate Deployers - * + * Takes a series of URL to watch, detects changes and calls the appropriate Deployers. + * * @author a href=mailto:[EMAIL PROTECTED];Marc Fleury/a - * @version $Revision: 1.12 $ + * @author a href=mailto:[EMAIL PROTECTED];Jason Dillon/a + * @version $Revision: 1.13 $ */ public class MainDeployer extends ServiceMBeanSupport implements MainDeployerMBean, Runnable { /** JMX Server **/ - MBeanServer server; + private MBeanServer server; /** Deployers **/ - Set deployers = new HashSet(); + private Set deployers = new HashSet(); /** Scanned Directories **/ - ArrayList directories = new ArrayList(); + private ArrayList directories = new ArrayList(); /** I always feel like somebody is watching me, contains DeploymentInfo **/ - Map deployments = new HashMap(); - ArrayList deploymentsList = new ArrayList(); + private Map deployments = new HashMap(); + private ArrayList deploymentsList = new ArrayList(); /** Thread running **/ - boolean running = false; + private boolean running = false; /** period of scanning **/ - int period = 5000; + private int period = 5000; /** an increment for tmp files **/ - int id = 0; + private int id = 0; /** Given a flat set
[JBoss-dev] CVS update: contrib/jetty build.xml
User: user57 Date: 02/02/11 19:22:01 Modified:jettybuild.xml Log: o Adding SafeObjectFactory, which simply makes ObjectNames and turns ant malformed exceptions into Errors. This is used to create ObjectName OBJECT_NAME fields, so we don't have to keep creating new ObjectNames all the time. o MainDeployer ServiceController use new ObjectName OBJECT_NAME o Updated refering classes to not wrap OBJECT_NAME with new ObjectName o Using MBeanProxy to talk to ServiceController (and MainDeployer in some areas). MBeanProxy is a central location to put in that pesky JMX exception handling + is tidies up the code base. Can evevntually optimize this to make it veru efficient too. o Putting org.jboss.util classes into lib/ext/jboss-util.jar and adding it to the bootlibraries, so that the core system components have access to these when loading (not just when running, aka after jboss-service.xml loads). * Need to clean up jboss-util, move deployable stuff out of it and such (they don't really belong there). o updated modules that needed util, to include jboss-util.jar in there external module config Revision ChangesPath 1.31 +1 -0 contrib/jetty/build.xml Index: build.xml === RCS file: /cvsroot/jboss/contrib/jetty/build.xml,v retrieving revision 1.30 retrieving revision 1.31 diff -u -r1.30 -r1.31 --- build.xml 10 Feb 2002 17:57:38 - 1.30 +++ build.xml 12 Feb 2002 03:22:01 - 1.31 @@ -171,6 +171,7 @@ property name=jboss.server.lib value=${jboss.server.root}/lib/ path id=jboss.server.classpath pathelement path=${jboss.server.lib}/jboss.jar/ + pathelement path=${jboss.server.lib}/jboss-util.jar/ /path !-- Cluster -- ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jboss/src/main/org/jboss/util SafeObjectNameFactory.java
User: user57 Date: 02/02/11 19:22:03 Added: src/main/org/jboss/util SafeObjectNameFactory.java Log: o Adding SafeObjectFactory, which simply makes ObjectNames and turns ant malformed exceptions into Errors. This is used to create ObjectName OBJECT_NAME fields, so we don't have to keep creating new ObjectNames all the time. o MainDeployer ServiceController use new ObjectName OBJECT_NAME o Updated refering classes to not wrap OBJECT_NAME with new ObjectName o Using MBeanProxy to talk to ServiceController (and MainDeployer in some areas). MBeanProxy is a central location to put in that pesky JMX exception handling + is tidies up the code base. Can evevntually optimize this to make it veru efficient too. o Putting org.jboss.util classes into lib/ext/jboss-util.jar and adding it to the bootlibraries, so that the core system components have access to these when loading (not just when running, aka after jboss-service.xml loads). * Need to clean up jboss-util, move deployable stuff out of it and such (they don't really belong there). o updated modules that needed util, to include jboss-util.jar in there external module config Revision ChangesPath 1.1 jboss/src/main/org/jboss/util/SafeObjectNameFactory.java Index: SafeObjectNameFactory.java === /* * JBoss, the OpenSource J2EE webOS * * Distributable under LGPL license. * See terms of license at gnu.org. */ package org.jboss.util; import java.util.Hashtable; import javax.management.MalformedObjectNameException; import javax.management.ObjectName; /** * A simple factory for creating safe object names. A safe object name * will not throw malforumed exceptions. Any such exceptions will * be translated into errors. * * @author a href=mailto:[EMAIL PROTECTED];Jason Dillon/a * @version $Revision: 1.1 $ */ public class SafeObjectNameFactory { public static ObjectName create(String name) { try { return new ObjectName(name); } catch (MalformedObjectNameException e) { throw new Error(Invalid ObjectName: + name + ; + e); } } public static ObjectName create(String domain, String key, String value) { try { return new ObjectName(domain, key, value); } catch (MalformedObjectNameException e) { throw new Error(Invalid ObjectName: + domain + , + key + , + value + ; + e); } } public static ObjectName create(String domain, Hashtable table) { try { return new ObjectName(domain, table); } catch (MalformedObjectNameException e) { throw new Error(Invalid ObjectName: + domain + , + table + ; + e); } } } ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb EJBDeployer.java
User: user57 Date: 02/02/11 19:22:03 Modified:src/main/org/jboss/ejb EJBDeployer.java Log: o Adding SafeObjectFactory, which simply makes ObjectNames and turns ant malformed exceptions into Errors. This is used to create ObjectName OBJECT_NAME fields, so we don't have to keep creating new ObjectNames all the time. o MainDeployer ServiceController use new ObjectName OBJECT_NAME o Updated refering classes to not wrap OBJECT_NAME with new ObjectName o Using MBeanProxy to talk to ServiceController (and MainDeployer in some areas). MBeanProxy is a central location to put in that pesky JMX exception handling + is tidies up the code base. Can evevntually optimize this to make it veru efficient too. o Putting org.jboss.util classes into lib/ext/jboss-util.jar and adding it to the bootlibraries, so that the core system components have access to these when loading (not just when running, aka after jboss-service.xml loads). * Need to clean up jboss-util, move deployable stuff out of it and such (they don't really belong there). o updated modules that needed util, to include jboss-util.jar in there external module config Revision ChangesPath 1.4 +3 -3 jboss/src/main/org/jboss/ejb/EJBDeployer.java Index: EJBDeployer.java === RCS file: /cvsroot/jboss/jboss/src/main/org/jboss/ejb/EJBDeployer.java,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- EJBDeployer.java 9 Feb 2002 16:09:21 - 1.3 +++ EJBDeployer.java 12 Feb 2002 03:22:02 - 1.4 @@ -74,7 +74,7 @@ * @author a href=mailto:[EMAIL PROTECTED];Peter Antman/a. * @author a href=mailto:[EMAIL PROTECTED];Scott Stark/a * @author a href=mailto:[EMAIL PROTECTED];Sacha Labourey/a -* @version $Revision: 1.3 $ +* @version $Revision: 1.4 $ */ public class EJBDeployer extends ServiceMBeanSupport @@ -163,7 +163,7 @@ { // Register with the main deployer server.invoke( -new ObjectName(org.jboss.deployment.MainDeployerMBean.OBJECT_NAME), +org.jboss.deployment.MainDeployerMBean.OBJECT_NAME, addDeployer, new Object[] {this}, new String[] {org.jboss.deployment.DeployerMBean}); @@ -188,7 +188,7 @@ { // Register with the main deployer server.invoke( -new ObjectName(org.jboss.deployment.MainDeployerMBean.OBJECT_NAME), +org.jboss.deployment.MainDeployerMBean.OBJECT_NAME, removeDeployer, new Object[] {this}, new String[] {org.jboss.deployment.DeployerMBean}); ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jboss/src/main/org/jboss/system Server.java ServiceController.java ServiceControllerMBean.java
User: user57 Date: 02/02/11 19:22:03 Modified:src/main/org/jboss/system Server.java ServiceController.java ServiceControllerMBean.java Log: o Adding SafeObjectFactory, which simply makes ObjectNames and turns ant malformed exceptions into Errors. This is used to create ObjectName OBJECT_NAME fields, so we don't have to keep creating new ObjectNames all the time. o MainDeployer ServiceController use new ObjectName OBJECT_NAME o Updated refering classes to not wrap OBJECT_NAME with new ObjectName o Using MBeanProxy to talk to ServiceController (and MainDeployer in some areas). MBeanProxy is a central location to put in that pesky JMX exception handling + is tidies up the code base. Can evevntually optimize this to make it veru efficient too. o Putting org.jboss.util classes into lib/ext/jboss-util.jar and adding it to the bootlibraries, so that the core system components have access to these when loading (not just when running, aka after jboss-service.xml loads). * Need to clean up jboss-util, move deployable stuff out of it and such (they don't really belong there). o updated modules that needed util, to include jboss-util.jar in there external module config Revision ChangesPath 1.12 +58 -48jboss/src/main/org/jboss/system/Server.java Index: Server.java === RCS file: /cvsroot/jboss/jboss/src/main/org/jboss/system/Server.java,v retrieving revision 1.11 retrieving revision 1.12 diff -u -r1.11 -r1.12 --- Server.java 11 Feb 2002 23:01:37 - 1.11 +++ Server.java 12 Feb 2002 03:22:03 - 1.12 @@ -32,14 +32,14 @@ * * @author a href=mailto:[EMAIL PROTECTED];Marc Fleury/a * @author a href=mailto:[EMAIL PROTECTED];Jason Dillon/a - * @version $Revision: 1.11 $ + * @version $Revision: 1.12 $ */ public class Server -implements ServerMBean + implements ServerMBean { /** Class logger */ private static final BootstrapLogger log = - BootstrapLogger.getLogger(Server.class); + BootstrapLogger.getLogger(Server.class); /** Container for version information. */ private final Version version = Version.getInstance(); @@ -71,11 +71,11 @@ this.config = config; if (debug) { - log.debug(Using config: + config); + log.debug(Using config: + config); } log.info(JBoss (MX MicroKernel) + - version + [ + version.getName() + ]); + version + [ + version.getName() + ]); // remeber when we we started started = new Date(); @@ -84,35 +84,35 @@ // Create the MBeanServer server = MBeanServerFactory.createMBeanServer(config.getDomain()); if (debug) { - log.debug(Created MBeanServer: + server); + log.debug(Created MBeanServer: + server); } String systemDomain = server.getDefaultDomain() + .system; if (debug) { - log.debug(Using system domain: + systemDomain); + log.debug(Using system domain: + systemDomain); } // Register server components server.registerMBean(this, - new ObjectName(systemDomain,service, Server)); + new ObjectName(systemDomain,service, Server)); server.registerMBean(config, - new ObjectName(systemDomain,service, ServerConfig)); + new ObjectName(systemDomain,service, ServerConfig)); // Initialize the MBean libraries repository server.registerMBean(ServiceLibraries.getLibraries(), - new ObjectName(systemDomain, service, ServiceLibraries)); + new ObjectName(systemDomain, service, ServiceLibraries)); // Initialize spine boot libraries initBootLibraries(); // Create MBeanClassLoader for the base system ObjectName loaderName = - new ObjectName(systemDomain, service, ServiceClassLoader); + new ObjectName(systemDomain, service, ServiceClassLoader); MBeanClassLoader mcl = new MBeanClassLoader(loaderName); server.registerMBean(mcl, loaderName); if (debug) { - log.debug(Registered service classloader: + loaderName); + log.debug(Registered service classloader: + loaderName); } // Set ServiceClassLoader as classloader for the construction of @@ -121,8 +121,8 @@ // Setup logging server.createMBean(org.jboss.logging.Log4jService, - new ObjectName(systemDomain, service, Logging), - loaderName); + new ObjectName(systemDomain, service, Logging), +
[JBoss-dev] Automated JBoss Testsuite Results
JBoss daily test results SUMMARY Number of tests run: 491 Successful tests: 480 Errors:8 Failures: 3 [time of test: 12 February 2002 3:22 GMT] [java.version: 1.3.1] [java.vendor: Blackdown Java-Linux Team] [java.vm.version: Blackdown-1.3.1-FCS] [java.vm.name: Java HotSpot(TM) Client VM] [java.vm.info: mixed mode] [os.name: Linux] [os.arch: i386] [os.version: 2.4.9-12] See http://lubega.com for full details NOTE: If there are any errors shown above - this mail is only highlighting them - it is NOT indicating that they are being looked at by anyone. Remember - if a test becomes broken after your changes - fix it or fix the test! DETAILS OF ERRORS [details not shown -as this makes the mail too big to reach the sf mailing list] PS BEFORE you commit, run the test suite! Its really is easy, just use the ant target 'run-basic-testsuite' from the build directory. To just run the unit tests (they are quite quick): In the testsuite directory, ./build.sh tests-unit You can run a single test case using: ./build.sh -Dtest=[XXXTestCase] one-test The XXXTestCase is the classname of the junit class to run. So, to run the EJBSpecUnitTestCase use: ./build.sh -Dtest=EJBSpecUnitTestCase one-test To run all tests within a package, use ./build.sh -Dtest=[package] test The package is name of the directory under the org/jboss/test directory that contains the tests to run. So, to run the unit tests in the org.jboss.test.security package use: ./build.sh -Dtest=security test Thanks for all your effort - we really do love you! ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] Deployer redesign (again) proposal
On 2002.02.11 18:46:32 -0500 Jason Dillon wrote: I was thinking this weekend, while I was having trouble sleeping (again), about our deployers and how there isn't a very usable admin interface to what is deployed and so on. More specifically, there is not a domain, which lists mbeans which relate to a given deployment. I was also thinking about some ways to reduce the dependency on files (or rather abstract that dependency into something external from the primary deployment components. I took a look at how easy it would be to add a simple facade over the current system to add a DeploymentController which would simply live in the MBeanServer and allow administration of that deployment. I think it can be done, but anything would be a hack given how things work at the moment. So I started thinking about changing the model so that we can achive the same results with out having to muck up things, and here is what I came up with. * * * Redesign deployment system to use Deployment (or DeploymentController) object instances to perform work for a single deployment. These objects are created by a factory, which lives and is configured from the client deployment API or DeploymentManager. A simple type - classname map can be used to object creation. This may not be so easy. I'm partial to the current system of asking deployers what they can do. Deployment objects are bound into JMX under jboss.deployments, and have methods to deploy, undeploy, remove. This provides a rich management interface to what is deployed and to easily redeploy. Retain existing DeployerMBean API and mapper for compatibility. This will allow clients to connect to the DeploymentManager API, use a deploy/undeploy method with a URL, which will then be translated and proxied into a call to the deployment bound in JMX. The DeploymentManager's job is to create Deployments for a given type of deployable content. As I mentioned before, this can be a simple JMX configurable map of type to deployment classname. Type will be initially discovered by the URL passed in, though we could eventually move to something more advanced using mime-types or something... eaither way once we have a 'type', we can get moving. The DM will also manage setting up the local file bits for now. Any other system level config will be passed into the Deployment during initialization. Once initialized and bound to JMX then it can be deployed/undeployed and so on. This introduces a new wrinkle in that a deployment could be bound, but not deployed or passive. This lets admins undeploy with out losing the interface to that deployment. Passive deployments can be removed when not needed any further. this happens now, you just can't see it. * * * To help the deployment system become more file independent, we need to move the 'auto deployer' functionality to an external component. Since deployer is overused in our environment, I suggest we rename this type of beast to a DeploymentScanner, since that is what is does, scans for deployment changes. DS is a simple interface which hooks up to the DM, via JMX. Its sole job is to detect new, removed, updated deployments and letting the DM know about them. Yes, I suggested this several months ago (autodeployer + universal deployer). Marc just implemented them together. Initially we will provide a LocalFileDeploymentScanner, which does what the AutoDeployer did (and MainDeployer does). Current maindeployer is happy to look at http* urls also. This is pluggable, so we can have any number of these running, once we figure out how to get auto deployment detecttion working over different protocols. What protocols are you thinking of? ftp??? * * * At the same time, we should clean up the usage of URL, Strings and Files. More specifically, use URL for everything over String (string was only really there for JMX administration, but since a URL can be constructed from a String I think this is a admin client coercion issue and we should not muck up our components with this garbage; btw i have written such a corecion system which can easily be integrated into a http adapter once we have one of those which isn't the RI). Also lets not use URL when we really mean local File. There are some places in the MainDeployer which take URLS, but those URLS must be files... so it would be better to have them take files instead. We should also not hard code any http specific bits. There are if proto is http or file all over the place, which I think we need to get rid of. Could be running over https, or some other protocol. We should not care. * * * All that said, I think this is a project best suited for a post 3.0 release. Since Scott is going to branch on tuesday for 3.0, then this should probably go into main, and be slated for a 3.1 release or something. I think that it will take about a week to get all of this squared
[JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb EJBDeployer.java
User: user57 Date: 02/02/11 19:33:01 Modified:src/main/org/jboss/ejb EJBDeployer.java Log: o specify target throwable when retrhowing DeploymentExceptions o Minor logging changes Revision ChangesPath 1.5 +34 -40jboss/src/main/org/jboss/ejb/EJBDeployer.java Index: EJBDeployer.java === RCS file: /cvsroot/jboss/jboss/src/main/org/jboss/ejb/EJBDeployer.java,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- EJBDeployer.java 12 Feb 2002 03:22:02 - 1.4 +++ EJBDeployer.java 12 Feb 2002 03:33:00 - 1.5 @@ -74,7 +74,7 @@ * @author a href=mailto:[EMAIL PROTECTED];Peter Antman/a. * @author a href=mailto:[EMAIL PROTECTED];Scott Stark/a * @author a href=mailto:[EMAIL PROTECTED];Sacha Labourey/a -* @version $Revision: 1.4 $ +* @version $Revision: 1.5 $ */ public class EJBDeployer extends ServiceMBeanSupport @@ -357,8 +357,10 @@ public synchronized void deploy(DeploymentInfo sdi) - throws DeploymentException + throws DeploymentException { + boolean debug = log.isDebugEnabled(); + try { // Create a file loader with which to load the files @@ -369,7 +371,9 @@ // Load XML sdi.metaData = efm.load(); } - catch (Exception e) {log.error(Problem loading metaData , e);} + catch (Exception e) { + log.error(Problem loading metaData , e); + } // Check validity NDC.push(Verifier ); @@ -380,10 +384,11 @@ if( verifyDeployments ) { BeanVerifier verifier = new BeanVerifier(); - verifier.addVerificationListener( new DeployListener ()); -if (log.isInfoEnabled()) - log.info( Verifying + sdi.url ); +if (debug) { + log.debug(Verifying + sdi.url); +} + verifier.verify( sdi.url, (ApplicationMetaData) sdi.metaData, sdi.ucl ); } } @@ -403,7 +408,7 @@ app.setURL( sdi.url ); - if (log.isDebugEnabled()) { + if (debug) { log.debug( Deploying: + sdi.url ); } @@ -412,8 +417,7 @@ { BeanMetaData bean = (BeanMetaData) beans.next(); -if (log.isInfoEnabled()) - log.info( Deploying + bean.getEjbName() ); +log.info( Deploying + bean.getEjbName() ); try { app.addContainer( createContainer( bean, sdi ) ); @@ -431,7 +435,7 @@ app.start(); // Done - if (log.isDebugEnabled()) { + if (debug) { log.debug( Deployed: + app.getName() ); } @@ -440,11 +444,11 @@ } catch( Exception e ) { - log.error(Could not deploy + sdi.url.toString(), e); + log.error(Could not deploy + sdi.url, e); app.stop(); //app.destroy(); - throw new DeploymentException( Could not deploy + sdi.url.toString(), e ); + throw new DeploymentException( Could not deploy + sdi.url, e ); } } @@ -456,12 +460,13 @@ * @throws DeploymentException */ public void undeploy(DeploymentInfo di) - throws DeploymentException + throws DeploymentException { undeploy(di.url); } + public void undeploy(URL url ) - throws DeploymentException + throws DeploymentException { // Get application from table Application app = (Application) deployments.get( url ); @@ -473,8 +478,7 @@ } // Undeploy application - if (log.isInfoEnabled()) - log.info( Undeploying: + url ); + log.info( Undeploying: + url ); app.stop(); //app.destroy(); @@ -502,8 +506,6 @@ // Remove deployment deployments.remove( url ); - - } /** @@ -736,7 +738,8 @@ } catch(Exception e) { -throw new DeploymentException(Failed to create SecurityProxy of type: + securityProxyClassName + , + conf.getContainerInvoker() + - + e); +throw new DeploymentException(Failed to create SecurityProxy of type: + + securityProxyClassName + , + conf.getContainerInvoker(), e); } } @@ -865,7 +868,7 @@ } catch( Exception e ) { - throw new DeploymentException( Missing or invalid Container Invoker (in jboss.xml or standardjboss.xml): + invoker+ -
[JBoss-dev] Is log4j MaxFileSize broken?
Before DR1 I was changing log4j.appender.Default.MaxFileSize in my log4j.properties file to 10MB so I could see all of my DB code. Now it seams that this value is always ignored as I can only get a log with 1700 lines. Is this value still used? Is this file still used? On another issue do we sill need the instantdb.properties file? thanks -dain ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] Is log4j MaxFileSize broken?
On another issue do we sill need the instantdb.properties file? Nope. --jason ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] Deployer redesign (again) proposal
Redesign deployment system to use Deployment (or DeploymentController) object instances to perform work for a single deployment. These objects are created by a factory, which lives and is configured from the client deployment API or DeploymentManager. A simple type - classname map can be used to object creation. This may not be so easy. I'm partial to the current system of asking deployers what they can do. I don't see that it is all that complex. Rather than having singleton deployers, which contain deployment logic (and may or may not create deployment state objects), I suggest using a simple factory to create a state/controller object that handle handle all of the work itself. It does not seem like there is all that much shared state required between deployements, that which I have seen are unique number generators and the like. I was also thinking of keeping the deployer concept around and making a deployment a stateful translating proxy to the correct deployer (filling in the details that the deployer needs todo its work), but I could not see why it would make sense to complicate things in that manner. What would the deployer do, which the deployment instance could not? The only thing that I could think of was track a list of deployments, but if the deployment is bound to JMX (and named properly), then this is handled by the mbean server already. It seems like the current deployers are a bit more complex than they really need to be. By changing the way we look at them we can make things much simpler, and gaining some more administrative control. Granted, we could make DeploymentInfo, but that seems like a bloated hack. So, MD creates a DI, which holds its basics, then the real deployer possibly creates its own state object. If we want to expose different management functionality per deployment, then we have to have two objects, rather than one. If Deployement is a simple interface, then the factory would lookup and create a concrete instance of one. This object would probably be a dynamic mbean, or could be a pojo and be wrapped by a model mbean, thus allowing it to expose in the same mnmgt interface more api. Deployment objects are bound into JMX under jboss.deployments, and have methods to deploy, undeploy, remove. This provides a rich management interface to what is deployed and to easily redeploy. Retain existing DeployerMBean API and mapper for compatibility. This will allow clients to connect to the DeploymentManager API, use a deploy/undeploy method with a URL, which will then be translated and proxied into a call to the deployment bound in JMX. The DeploymentManager's job is to create Deployments for a given type of deployable content. As I mentioned before, this can be a simple JMX configurable map of type to deployment classname. Type will be initially discovered by the URL passed in, though we could eventually move to something more advanced using mime-types or something... eaither way once we have a 'type', we can get moving. The DM will also manage setting up the local file bits for now. Any other system level config will be passed into the Deployment during initialization. Once initialized and bound to JMX then it can be deployed/undeployed and so on. This introduces a new wrinkle in that a deployment could be bound, but not deployed or passive. This lets admins undeploy with out losing the interface to that deployment. Passive deployments can be removed when not needed any further. this happens now, you just can't see it. I am not sure what you mean here... there is a lot in the above, which most certain does not exist. Perhaps you mean that the MD, proxies requests to the real deployer? I understand that, but take a look at what it would take for an admin to look at the html adapter and see what is deployed, the undeploy or redeploy one or more apps? You can't really do it... you need the exact url, used to make the deployment in the first place. I can certainly see exposing DI to solve this, but I think that is only a bandage. If a particular deployment needs some other factory-like presence then it may choose to proxy requests over to it, but the underlying call chain would still go through the Deployment. To help the deployment system become more file independent, we need to move the 'auto deployer' functionality to an external component. Since deployer is overused in our environment, I suggest we rename this type of beast to a DeploymentScanner, since that is what is does, scans for deployment changes. DS is a simple interface which hooks up to the DM, via JMX. Its sole job is to detect new, removed, updated deployments and letting the DM know about them. Yes, I suggested this several months ago (autodeployer + universal deployer). Marc just implemented them together. Right... well we should fix this. Initially we will provide a
Re: [JBoss-dev] Is log4j MaxFileSize broken?
can you remove it? Jason Dillon wrote: On another issue do we sill need the instantdb.properties file? Nope. --jason ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] Is log4j MaxFileSize broken?
I figgured it out. I'm an idiot. For some reason the log system only logs INFO messages except for org.jboss.system. -dain Dain Sundstrom wrote: Before DR1 I was changing log4j.appender.Default.MaxFileSize in my log4j.properties file to 10MB so I could see all of my DB code. Now it seams that this value is always ignored as I can only get a log with 1700 lines. Is this value still used? Is this file still used? On another issue do we sill need the instantdb.properties file? thanks -dain ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] Automated JBoss Testsuite Results
JBoss daily test results SUMMARY Number of tests run: 491 Successful tests: 480 Errors:8 Failures: 3 [time of test: 12 February 2002 4:18 GMT] [java.version: 1.3.1] [java.vendor: Blackdown Java-Linux Team] [java.vm.version: Blackdown-1.3.1-FCS] [java.vm.name: Classic VM] [java.vm.info: green threads, nojit] [os.name: Linux] [os.arch: i386] [os.version: 2.4.9-12] See http://lubega.com for full details NOTE: If there are any errors shown above - this mail is only highlighting them - it is NOT indicating that they are being looked at by anyone. Remember - if a test becomes broken after your changes - fix it or fix the test! DETAILS OF ERRORS [details not shown -as this makes the mail too big to reach the sf mailing list] PS BEFORE you commit, run the test suite! Its really is easy, just use the ant target 'run-basic-testsuite' from the build directory. To just run the unit tests (they are quite quick): In the testsuite directory, ./build.sh tests-unit You can run a single test case using: ./build.sh -Dtest=[XXXTestCase] one-test The XXXTestCase is the classname of the junit class to run. So, to run the EJBSpecUnitTestCase use: ./build.sh -Dtest=EJBSpecUnitTestCase one-test To run all tests within a package, use ./build.sh -Dtest=[package] test The package is name of the directory under the org/jboss/test directory that contains the tests to run. So, to run the unit tests in the org.jboss.test.security package use: ./build.sh -Dtest=security test Thanks for all your effort - we really do love you! ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: contrib/varia/src/etc/conf/default instantdb.properties
User: user57 Date: 02/02/11 20:27:11 Removed: varia/src/etc/conf/default instantdb.properties Log: o buh-bye ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] Is log4j MaxFileSize broken?
Sure. --jason On Mon, 2002-02-11 at 20:24, Dain Sundstrom wrote: can you remove it? Jason Dillon wrote: On another issue do we sill need the instantdb.properties file? Nope. --jason ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] BCEL org.jboss.proxy.compiler
Any thoughts on replacing our proxy compiler with the Byte Code Engineering Library, recently added to the list of Jakarta sub-projects? --jason ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] BCEL org.jboss.proxy.compiler
Good. That is basically the position that I have... well bad too, cause I don't have time todo it at the moment either, but I think it should be done eventually. Perhaps there is someone out there looking for a relatively easy todo task to help improve the quality of JBoss? --jason On Mon, 2002-02-11 at 20:54, Dain Sundstrom wrote: When I was at marc's place last week I suggested changing to BCEL, as it is actively maintained by the jakarta group, and it would be one less moving part for us. He liked the idea, but neither of us have the time right now to learn another tool. If you've got nothing better to work on go for it. -dain Jason Dillon wrote: Any thoughts on replacing our proxy compiler with the Byte Code Engineering Library, recently added to the list of Jakarta sub-projects? --jason ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jboss/src/main/org/jboss/system ServerConfig.java ServerConfigMBean.java
User: user57 Date: 02/02/11 21:05:48 Modified:src/main/org/jboss/system ServerConfig.java ServerConfigMBean.java Log: o exposing two more local file config properties: tempDir and stateDataDir (for tmp db). These appear to be the only other local file resources we have at the moment (both of which are currently generated from homeDir). Revision ChangesPath 1.3 +64 -14jboss/src/main/org/jboss/system/ServerConfig.java Index: ServerConfig.java === RCS file: /cvsroot/jboss/jboss/src/main/org/jboss/system/ServerConfig.java,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- ServerConfig.java 11 Feb 2002 23:01:37 - 1.2 +++ ServerConfig.java 12 Feb 2002 05:05:47 - 1.3 @@ -22,13 +22,19 @@ *Should use nested version when JDK 1.4 is standardized. * * @author a href=mailto:[EMAIL PROTECTED];Jason Dillon/a - * @version $Revision: 1.2 $ + * @version $Revision: 1.3 $ */ public class ServerConfig implements ServerConfigMBean { /** The local home directory for the server. */ private File homeDir; + + /** The directory for server temporay files. */ + private File tempDir; + + /** The directory for local state data files. */ + private File stateDataDir; /** The JMX domain for the base MBean server. */ private String domain = jboss; @@ -88,12 +94,23 @@ public String getDomain() { return domain; } + + public void setConfigName(final String name) { + if (name == null) + throw new IllegalArgumentException(name is null); + + configName = name; + } + public String getConfigName() { + return configName; + } + public void setHomeDir(final File dir) { if (dir == null) throw new IllegalArgumentException(dir is null); - - // check if this is really a directory ? + + // FIXME: check if this is really a directory homeDir = dir; } @@ -101,6 +118,50 @@ public File getHomeDir() { return homeDir; } + + public void setTempDir(final File dir) { + if (dir == null) + throw new IllegalArgumentException(dir is null); + + // FIXME: check if this is really a directory + // FIXME: check if this is writable + tempDir = dir; + } + + /** +* Get the directory where temporary files will be stored. +* +* @returnThe directory where the server stores temporary files. +*/ + public File getTempDir() { + if (tempDir == null) { + tempDir = new File(homeDir, tmp); + } + + return tempDir; + } + + public void setStateDataDir(final File dir) { + if (dir == null) + throw new IllegalArgumentException(dir is null); + + // FIXME: check if this is really a directory + // FIXME: check if this is writable + stateDataDir = dir; + } + + /** +* Get the directory where local state data will be stored. +* +* @returnThe directory where the server stores local state data. +*/ + public File getStateDataDir() { + if (stateDataDir == null) { + stateDataDir = new File(homeDir, db); + } + + return stateDataDir; + } public void setInstallURL(final URL url) { if (url == null) @@ -134,17 +195,6 @@ return libraryURL; } - public void setConfigName(final String name) { - if (name == null) - throw new IllegalArgumentException(name is null); - - configName = name; - } - - public String getConfigName() { - return configName; - } - public void setConfigURL(final URL url) { if (url == null) throw new IllegalArgumentException(url is null); 1.2 +58 -4 jboss/src/main/org/jboss/system/ServerConfigMBean.java Index: ServerConfigMBean.java === RCS file: /cvsroot/jboss/jboss/src/main/org/jboss/system/ServerConfigMBean.java,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- ServerConfigMBean.java11 Feb 2002 23:01:37 - 1.1 +++ ServerConfigMBean.java12 Feb 2002 05:05:47 - 1.2 @@ -14,24 +14,78 @@ * The JMX MBean interface for the ttServerConfig/tt component. * * @author a href=mailto:[EMAIL PROTECTED];Jason Dillon/a - * @version $Revision: 1.1 $ + * @version $Revision: 1.2 $ */ public interface ServerConfigMBean { + /** +* Get the JMX domain for which the system is bound under. +* +* @returnJMX domain name. +
Re: [JBoss-dev] BCEL org.jboss.proxy.compiler
When I was at marc's place last week I suggested changing to BCEL, as it is actively maintained by the jakarta group, and it would be one less moving part for us. He liked the idea, but neither of us have the time right now to learn another tool. If you've got nothing better to work on go for it. -dain Jason Dillon wrote: Any thoughts on replacing our proxy compiler with the Byte Code Engineering Library, recently added to the list of Jakarta sub-projects? --jason ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] Automated JBoss Testsuite Results
JBoss daily test results SUMMARY Number of tests run: 491 Successful tests: 471 Errors:10 Failures: 10 [time of test: 12 February 2002 5:9 GMT] [java.version: 1.3.1] [java.vendor: Sun Microsystems Inc.] [java.vm.version: 1.3.1-b24] [java.vm.name: Java HotSpot(TM) Server VM] [java.vm.info: mixed mode] [os.name: Linux] [os.arch: i386] [os.version: 2.4.9-12] See http://lubega.com for full details NOTE: If there are any errors shown above - this mail is only highlighting them - it is NOT indicating that they are being looked at by anyone. Remember - if a test becomes broken after your changes - fix it or fix the test! DETAILS OF ERRORS [details not shown -as this makes the mail too big to reach the sf mailing list] PS BEFORE you commit, run the test suite! Its really is easy, just use the ant target 'run-basic-testsuite' from the build directory. To just run the unit tests (they are quite quick): In the testsuite directory, ./build.sh tests-unit You can run a single test case using: ./build.sh -Dtest=[XXXTestCase] one-test The XXXTestCase is the classname of the junit class to run. So, to run the EJBSpecUnitTestCase use: ./build.sh -Dtest=EJBSpecUnitTestCase one-test To run all tests within a package, use ./build.sh -Dtest=[package] test The package is name of the directory under the org/jboss/test directory that contains the tests to run. So, to run the unit tests in the org.jboss.test.security package use: ./build.sh -Dtest=security test Thanks for all your effort - we really do love you! ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jboss/src/main/org/jboss/deployment MainDeployer.java MainDeployerMBean.java DeploymentInfo.java
User: d_jencks Date: 02/02/11 21:41:09 Modified:src/main/org/jboss/deployment MainDeployer.java MainDeployerMBean.java DeploymentInfo.java Log: cleanup of many deployment/undployment problems including bug 515537, deploy loops on failed deployment Revision ChangesPath 1.14 +299 -215 jboss/src/main/org/jboss/deployment/MainDeployer.java Index: MainDeployer.java === RCS file: /cvsroot/jboss/jboss/src/main/org/jboss/deployment/MainDeployer.java,v retrieving revision 1.13 retrieving revision 1.14 diff -u -r1.13 -r1.14 --- MainDeployer.java 12 Feb 2002 03:22:02 - 1.13 +++ MainDeployer.java 12 Feb 2002 05:41:09 - 1.14 @@ -7,65 +7,63 @@ package org.jboss.deployment; + + + + +import java.io.File; +import java.io.FileInputStream; +import java.io.FileOutputStream; +import java.io.FilenameFilter; +import java.io.IOException; +import java.io.InputStream; +import java.io.OutputStream; +import java.net.JarURLConnection; +import java.net.MalformedURLException; +import java.net.URL; import java.util.ArrayList; -import java.util.Set; +import java.util.Collection; import java.util.Enumeration; -import java.util.HashSet; -import java.util.Map; import java.util.HashMap; +import java.util.HashSet; import java.util.Iterator; +import java.util.List; +import java.util.Map; +import java.util.Set; import java.util.StringTokenizer; -import java.util.jar.JarFile; import java.util.jar.Attributes; import java.util.jar.JarEntry; +import java.util.jar.JarFile; import java.util.jar.Manifest; - -import java.net.JarURLConnection; -import java.net.URL; -import java.net.MalformedURLException; - -import java.io.InputStream; -import java.io.FileInputStream; -import java.io.FileOutputStream; -import java.io.OutputStream; -import java.io.File; -import java.io.FilenameFilter; -import java.io.IOException; - import javax.management.MBeanServer; -import javax.management.ObjectName; import javax.management.MalformedObjectNameException; - +import javax.management.ObjectName; import org.jboss.system.ServiceMBeanSupport; - import org.jboss.util.DirectoryBuilder; -import org.jboss.util.MBeanProxy; - /** - * Takes a series of URL to watch, detects changes and calls the appropriate Deployers. - * + * MainDeployer + * + * Takes a series of URL to watch, detects changes and calls the appropriate Deployers + * * @author a href=mailto:[EMAIL PROTECTED];Marc Fleury/a - * @author a href=mailto:[EMAIL PROTECTED];Jason Dillon/a - * @version $Revision: 1.13 $ + * @version $Revision: 1.14 $ */ public class MainDeployer extends ServiceMBeanSupport implements MainDeployerMBean, Runnable { - /** JMX Server **/ - private MBeanServer server; /** Deployers **/ - private Set deployers = new HashSet(); + private final Set deployers = new HashSet(); /** Scanned Directories **/ - private ArrayList directories = new ArrayList(); + private final ArrayList directories = new ArrayList(); /** I always feel like somebody is watching me, contains DeploymentInfo **/ - private Map deployments = new HashMap(); - private ArrayList deploymentsList = new ArrayList(); - + private final Map deployments = new HashMap(); + private final ArrayList deploymentsList = new ArrayList(); + /** Thread running **/ private boolean running = false; @@ -76,16 +74,20 @@ private int id = 0; /** Given a flat set of files, this is the order of deployment **/ - private String[] order = { sar, service.xml, rar, jar, war, ear, zip }; + private final String[] order = {sar, service.xml, rar, jar, war, ear, zip}; - public void setPeriod(int period) { + /** Get on period **/ + public void setPeriod(int period) + { this.period = period; } - public int getPeriod() { - return period; + public int getPeriod() + { + return period; } + /** * Directory get set logic, these are scanning directories * on the local filesystem @@ -106,16 +108,17 @@ // We are dealing with a relative path URL if (!( url.startsWith(file:) || url.startsWith(http:))) { - url = file: + System.getProperty(jboss.system.home) + / + url; + url = file:+System.getProperty(jboss.system.home)+File.separator+url; } - // Only one entry try { URL dir = new URL(url); - if (!directories.contains(dir)) { - directories.add(dir); - } + + if (!directories.contains(dir)) + { +directories.add(dir); +
[JBoss-dev] CVS update: jbosstest/src/main/org/jboss/test/jmx/deployer - New directory
User: d_jencks Date: 02/02/11 21:42:14 jbosstest/src/main/org/jboss/test/jmx/deployer - New directory ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbosstest/src/resources/jmx/deployer/META-INF - New directory
User: d_jencks Date: 02/02/11 21:49:46 jbosstest/src/resources/jmx/deployer/META-INF - New directory ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbosstest/src/main/org/jboss/test/jmx/deployer BrokenDeployer.java
User: d_jencks Date: 02/02/11 21:50:46 Added: src/main/org/jboss/test/jmx/deployer BrokenDeployer.java Log: BrokenDeployer exhibiting 7 ways a deployer may break. Useful in testing MainDeployer, although I don't know how to automate the tests Revision ChangesPath 1.1 jbosstest/src/main/org/jboss/test/jmx/deployer/BrokenDeployer.java Index: BrokenDeployer.java === /* * JBoss, the OpenSource J2EE webOS * * Distributable under LGPL license. * See terms of license at gnu.org. */ package org.jboss.test.jmx.deployer; import java.io.File; import java.net.URL; import javax.management.ObjectName; import org.jboss.deployment.DeploymentException; import org.jboss.deployment.DeploymentInfo; import org.jboss.system.ServiceMBeanSupport; /** * BrokenDeployer.java * This is a test of many possible problems with deployments. * .xaa DeploymentException in init * .xbb NPE in init * .xcc DeploymentException in deploy * .xdd NPE in deploy * .xee DeploymentException in undeploy * .xff NPE in undeploy * .xgg deployment with a non-existent watch. (caused looping in bug 515537) * * The build script creates a BrokenDeployer.sar, which should be deployed before any * of the test files as noted above are deployed. * * Created: Sun Feb 10 20:41:29 2002 * * @author a href=mailto:[EMAIL PROTECTED];David Jencks/a * @version * @jmx:mbean name=jboss.test:service=BrokenDeployer * @jmx:interface extends=org.jboss.deployment.DeployerMBean */ public class BrokenDeployer extends ServiceMBeanSupport implements BrokenDeployerMBean { public BrokenDeployer () { } public String getName() { return Broken Deployer; } protected void startService() throws Exception { try { // Register with the main deployer server.invoke( new ObjectName(org.jboss.deployment.MainDeployerMBean.OBJECT_NAME), addDeployer, new Object[] {this}, new String[] {org.jboss.deployment.DeployerMBean}); } catch (Exception e) {log.error(Could not register with MainDeployer, e);} log.info(BrokenDeployer started); } /** undeploys all deployments */ protected void stopService() { log.info(BrokenDeployer stopped); try { // Register with the main deployer server.invoke( new ObjectName(org.jboss.deployment.MainDeployerMBean.OBJECT_NAME), removeDeployer, new Object[] {this}, new String[] {org.jboss.deployment.DeployerMBean}); } catch (Exception e) {log.error(Could not register with MainDeployer, e);} } public boolean accepts(DeploymentInfo sdi) { log.info(asking about file: + sdi.url.toString()); String file = new File(sdi.url.getFile()).toString(); log.info(now asking about file: + file); return file.endsWith(xaa) || file.endsWith(xbb) || file.endsWith(xcc) || file.endsWith(xdd) || file.endsWith(xee) || file.endsWith(xff) || file.endsWith(xgg); } public void init(DeploymentInfo sdi) throws DeploymentException { String file = new File(sdi.url.getFile()).toString(); if (file.endsWith(xaa)) { throw new DeploymentException(DeploymentException in init); } // end of if () if (file.endsWith(xbb)) { throw new NullPointerException(NullPointerException in init); } // end of if () if (file.endsWith(xgg)) { try { sdi.watch = new URL(File:/nowhere.jar); } catch (Exception e) { log.error(could not create fake url); } // end of try-catch } // end of if () } public void deploy(DeploymentInfo sdi) throws DeploymentException { String file = new File(sdi.url.getFile()).toString(); if (file.endsWith(xcc)) { throw new DeploymentException(DeploymentException in deploy); } // end of if () if (file.endsWith(xdd)) { throw new NullPointerException(NullPointerException in deploy); } // end of if () } public void undeploy(DeploymentInfo sdi) throws DeploymentException { String file = new File(sdi.url.getFile()).toString(); if (file.endsWith(xee)) { throw new DeploymentException(DeploymentException in undeploy); } // end of if () if (file.endsWith(xff)) {
[JBoss-dev] CVS update: jbosstest build.xml
User: d_jencks Date: 02/02/11 21:50:46 Modified:.build.xml Log: BrokenDeployer exhibiting 7 ways a deployer may break. Useful in testing MainDeployer, although I don't know how to automate the tests Revision ChangesPath 1.61 +31 -2 jbosstest/build.xml Index: build.xml === RCS file: /cvsroot/jboss/jbosstest/build.xml,v retrieving revision 1.60 retrieving revision 1.61 diff -u -r1.60 -r1.61 --- build.xml 2 Feb 2002 03:16:21 - 1.60 +++ build.xml 12 Feb 2002 05:50:46 - 1.61 @@ -27,7 +27,7 @@ !--tests-jmxri-compliance still needs to run over jmxri.jar -- !--the aim of that test is to check our compliance suite. -- -!-- $Id: build.xml,v 1.60 2002/02/02 03:16:21 ejort Exp $ -- +!-- $Id: build.xml,v 1.61 2002/02/12 05:50:46 d_jencks Exp $ -- project default=main name=JBoss/Testsuite @@ -208,6 +208,7 @@ pathelement path=${jboss.server.lib}/jboss-client.jar/ pathelement path=${jboss.server.lib}/jmx-rmi-connector-client.jar/ pathelement path=${jboss.server.lib}/deploy.jar/ + pathelement path=${jboss.server.lib}/jboss-spine.jar/ /path !-- Messaging -- @@ -413,8 +414,26 @@ /target + target name=compile-mbean-sources depends=init +taskdef name=jmxdoclet classname=xdoclet.jmx.JMXDocletTask/ + +mkdir dir=${build.gen-src}/ +jmxdoclet sourcepath=${source.java} + destdir=${build.gen-src} + classpath=${xdoclet.task.classpath} + force=true + excludedtags=@version,@author + fileset dir=${source.java} +include name=org/jboss/test/jmx/deployer/*.java/ + /fileset + mbeaninterface/ +/jmxdoclet + + /target + + !-- Compile all class files -- - target name=compile-classes depends=compile-bean-sources + target name=compile-classes depends=compile-bean-sources, compile-mbean-sources mkdir dir=${build.classes}/ javac destdir=${build.classes} optimize=${javac.optimize} @@ -1024,6 +1043,16 @@ include name=org/jboss/test/jmx/nullinfo/**/ /fileset fileset dir=${build.resources}/jmx/nullinfo +include name=META-INF/jboss-service.xml/ + /fileset +/jar + +!--build sar containing broken deployer. I don't know how to use this in a unit test-- +jar jarfile=${build.lib}/brokendeployer.sar + fileset dir=${build.classes} +include name=org/jboss/test/jmx/deployer/**/ + /fileset + fileset dir=${build.resources}/jmx/deployer include name=META-INF/jboss-service.xml/ /fileset /jar ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbosstest/src/resources/jmx/deployer/META-INF jboss-service.xml
User: d_jencks Date: 02/02/11 21:50:47 Added: src/resources/jmx/deployer/META-INF jboss-service.xml Log: BrokenDeployer exhibiting 7 ways a deployer may break. Useful in testing MainDeployer, although I don't know how to automate the tests Revision ChangesPath 1.1 jbosstest/src/resources/jmx/deployer/META-INF/jboss-service.xml Index: jboss-service.xml === ?xml version=1.0 encoding=UTF-8? server mbean code=org.jboss.test.jmx.deployer.BrokenDeployer name=jboss.test:service=BrokenDeployer /mbean /server ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] [ jboss-Bugs-515537 ] Deployer loops on failed deployment
Bugs item #515537, was opened at 2002-02-10 08:18 You can respond by visiting: http://sourceforge.net/tracker/?func=detailatid=376685aid=515537group_id=22866 Category: JBossServer Group: v3.0 Rabbit Hole Status: Closed Resolution: Fixed Priority: 5 Submitted By: Georg Schmid (giorgio42) Assigned to: David Jencks (d_jencks) Summary: Deployer loops on failed deployment Initial Comment: Deployer loops on failed deployment Basic info: INFO JBoss (MX MicroKernel) 3.0.0DR1(200202092237) [RABBIT-HOLE] ... 11:40:24,734 INFO [Info] Java version: 1.3.1_02,Sun Microsystems Inc. 11:40:24,734 INFO [Info] Java VM: Java HotSpot(TM) Client VM 1.3.1_02-b02,Sun Microsystems Inc. 11:40:24,734 INFO [Info] OS-System: Windows 2000 5.0,x86 Bug: Failed deployment puts Deployer into endless loop. Although the deployment fails, the deployer puts it on the watch list and treats it as if the deployment succeeded: 2002-02-10 12:34:52,265 DEBUG [org.jboss.ejb.plugins.cmp.jdbc.JDBCStoreManager.Mainte nanceEB] jar:file:/I:/jboss/jboss- 3.0.0DR1/tmp/deploy/66.entity-beans.jar!/META- INF/jbosscmp-jdbc.xml found. Overriding defaults 2002-02-10 12:34:52,625 ERROR [org.jboss.ejb.EJBDeployer] Could not deploy file:/I:/jboss/jboss-3.0.0DR1/deploy/entity-beans.jar org.jboss.deployment.DeploymentException: Role: module- belongs-to-facility with multiplicity many using foreign-key mapping is not allowed to have key-fields at org.jboss.ejb.plugins.cmp.jdbc.metadata.JDBCRelationshi pRoleMetaData.loadKeyFields (JDBCRelationshipRoleMetaData.java:352) at org.jboss.ejb.plugins.cmp.jdbc.metadata.JDBCRelationshi pRoleMetaData.init (JDBCRelationshipRoleMetaData.java:157) at org.jboss.ejb.plugins.cmp.jdbc.metadata.JDBCRelationMet aData.init(JDBCRelationMetaData.java:308) at org.jboss.ejb.plugins.cmp.jdbc.metadata.JDBCApplication MetaData.init(JDBCApplicationMetaData.java:383) at org.jboss.ejb.plugins.cmp.jdbc.metadata.JDBCXmlFileLoad er.load(JDBCXmlFileLoader.java:75) at org.jboss.ejb.plugins.cmp.jdbc.JDBCStoreManager.loadJDB CEntityMetaData(JDBCStoreManager.java:503) at org.jboss.ejb.plugins.cmp.jdbc.JDBCStoreManager.create (JDBCStoreManager.java:277) at org.jboss.ejb.plugins.CMPPersistenceManager.create (CMPPersistenceManager.java:134) at org.jboss.ejb.EntityContainer.create (EntityContainer.java:342) at org.jboss.ejb.Application.start (Application.java:214) at org.jboss.ejb.EJBDeployer.deploy (EJBDeployer.java:431) at org.jboss.deployment.MainDeployer.deploy (MainDeployer.java:396) at org.jboss.deployment.MainDeployer.deploy (MainDeployer.java:362) at org.jboss.deployment.MainDeployer.scan (MainDeployer.java:243) at org.jboss.deployment.MainDeployer.run (MainDeployer.java:229) at java.lang.Thread.run(Unknown Source) 2002-02-10 12:34:52,937 DEBUG [org.jboss.deployment.MainDeployer] Watching new file: file:/I:/jboss/jboss-3.0.0DR1/deploy/entity-beans.jar 2002-02-10 12:34:52,937 WARN [org.jboss.deployment.MainDeployer] operation failed; ignoring java.lang.NullPointerException at org.jboss.ejb.plugins.cmp.jdbc.JDBCStoreManager.stop (JDBCStoreManager.java:346) at org.jboss.ejb.plugins.CMPPersistenceManager.stop (CMPPersistenceManager.java:180) at org.jboss.ejb.EntityContainer.stop (EntityContainer.java:408) at org.jboss.ejb.Application.stop (Application.java:240) at org.jboss.ejb.EJBDeployer.deploy (EJBDeployer.java:444) at org.jboss.deployment.MainDeployer.deploy (MainDeployer.java:396) at org.jboss.deployment.MainDeployer.deploy (MainDeployer.java:362) at org.jboss.deployment.MainDeployer.scan (MainDeployer.java:243) at org.jboss.deployment.MainDeployer.run (MainDeployer.java:229) at java.lang.Thread.run(Unknown Source) 2002-02-10 12:35:03,437 INFO [org.jboss.deployment.MainDeployer] Undeploying file:/I:/jboss/jboss-3.0.0DR1/deploy/entity-beans.jar 2002-02-10 12:35:03,437 ERROR [org.jboss.deployment.MainDeployer] Undeployment failed: file:/I:/jboss/jboss-3.0.0DR1/deploy/entity- beans.jar org.jboss.deployment.DeploymentException: URL not deployed at org.jboss.ejb.EJBDeployer.undeploy (EJBDeployer.java:472) at org.jboss.ejb.EJBDeployer.undeploy (EJBDeployer.java:461) at org.jboss.deployment.MainDeployer.undeploy (MainDeployer.java:315) at org.jboss.deployment.MainDeployer.scan (MainDeployer.java:258) at org.jboss.deployment.MainDeployer.run (MainDeployer.java:229) at java.lang.Thread.run(Unknown Source) 2002-02-10 12:35:08,562 INFO [org.jboss.deployment.MainDeployer] Undeploying file:/I:/jboss/jboss-3.0.0DR1/deploy/entity-beans.jar 2002-02-10 12:35:08,578 ERROR [org.jboss.deployment.MainDeployer] Undeployment failed: file:/I:/jboss/jboss-3.0.0DR1/deploy/entity- beans.jar org.jboss.deployment.DeploymentException: URL not deployed at
[JBoss-dev] CVS update: jboss/src/main/org/jboss/system ServiceMBeanSupport.java
User: user57 Date: 02/02/11 22:13:49 Modified:src/main/org/jboss/system ServiceMBeanSupport.java Log: o using short class name for Service.getName() default Revision ChangesPath 1.11 +47 -33jboss/src/main/org/jboss/system/ServiceMBeanSupport.java Index: ServiceMBeanSupport.java === RCS file: /cvsroot/jboss/jboss/src/main/org/jboss/system/ServiceMBeanSupport.java,v retrieving revision 1.10 retrieving revision 1.11 diff -u -r1.10 -r1.11 --- ServiceMBeanSupport.java 20 Jan 2002 15:21:29 - 1.10 +++ ServiceMBeanSupport.java 12 Feb 2002 06:13:49 - 1.11 @@ -1,9 +1,10 @@ /* -* JBoss, the OpenSource J2EE webOS -* -* Distributable under LGPL license. -* See terms of license at gnu.org. -*/ + * JBoss, the OpenSource J2EE webOS + * + * Distributable under LGPL license. + * See terms of license at gnu.org. + */ + package org.jboss.system; import java.util.Date; @@ -19,39 +20,45 @@ import org.apache.log4j.NDC; /** -* An abstract base class JBoss services can subclass to implement a -* service that conforms to the ServiceMBean interface. Subclasses must -* override {@link #getName} method and should override -* {@link #startService}, and {@link #stopService} as approriate. -* -* @see ServiceMBean -* -* @author a href=mailto:[EMAIL PROTECTED];Rickard Öberg/a -* @author a href=mailto:[EMAIL PROTECTED];Scott Stark/a -* @author a href=mailto:[EMAIL PROTECTED];Andreas Schaefer/a -* @version $Revision: 1.10 $ -* -* pbRevisions:/b -* -* pb20010619 scott.stark:/b -* ul -* li use the full service class name as the log4j log name -* /ul -* pb20011202 Andreas Schaefer:/b -* ul -* li Add the own MBean Service Name to be remembered in an attribute -* /ul -*/ + * An abstract base class JBoss services can subclass to implement a + * service that conforms to the ServiceMBean interface. Subclasses must + * override {@link #getName} method and should override + * {@link #startService}, and {@link #stopService} as approriate. + * + * @see ServiceMBean + * + * @author a href=mailto:[EMAIL PROTECTED];Rickard Öberg/a + * @author a href=mailto:[EMAIL PROTECTED];Scott Stark/a + * @author a href=mailto:[EMAIL PROTECTED];Andreas Schaefer/a + * @version $Revision: 1.11 $ + * + * pbRevisions:/b + * + * pb20010619 scott.stark:/b + * ul + *li use the full service class name as the log4j log name + * /ul + * + * pb20011202 Andreas Schaefer:/b + * ul + *li Add the own MBean Service Name to be remembered in an attribute + * /ul + */ public abstract class ServiceMBeanSupport -extends NotificationBroadcasterSupport -implements ServiceMBean, MBeanRegistration + extends NotificationBroadcasterSupport + implements ServiceMBean, MBeanRegistration { // Attributes protected int state; protected MBeanServer server; - /** Own Object Name this MBean is registered with, see {@link #preRegister preRegister()}. **/ + + /** +* Own Object Name this MBean is registered with, +* see {@link #preRegister preRegister()}. +*/ protected ObjectName mServiceName; + private int id = 0; protected Logger log; @@ -66,8 +73,15 @@ } // Public - - public abstract String getName(); + + /** +* Use the short class name as the default for the service name. +*/ + public String getName() { + String classname = this.getClass().getName(); + return classname.substring(classname.lastIndexOf(.) + 1, + classname.length()); + } public ObjectName getServiceName() { return mServiceName; ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] Is log4j MaxFileSize broken?
INFO is the default priority filter. The org.jboss.system package classes are using the BootstrapLogger as the interface into log4j so there must be an issue with seeing the priority filters installed after the BootstrapLogger is created. Its on my list of things to do before branching. Scott Stark Chief Technology Officer JBoss Group, LLC - Original Message - From: Dain Sundstrom [EMAIL PROTECTED] To: JBoss-dev [EMAIL PROTECTED] Sent: Monday, February 11, 2002 8:23 PM Subject: Re: [JBoss-dev] Is log4j MaxFileSize broken? I figgured it out. I'm an idiot. For some reason the log system only logs INFO messages except for org.jboss.system. -dain ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb/plugins/cmp/jdbc JDBCStartCommand.java
User: dsundstrom Date: 02/02/11 22:15:17 Modified:src/main/org/jboss/ejb/plugins/cmp/jdbc JDBCStartCommand.java Log: Removed wanker log.info protection code. Changed addForeignKeyConstraint to assure that the connection and statement are closed before the transaction is committed. This is required for XA connections. Revision ChangesPath 1.21 +41 -41 jboss/src/main/org/jboss/ejb/plugins/cmp/jdbc/JDBCStartCommand.java Index: JDBCStartCommand.java === RCS file: /cvsroot/jboss/jboss/src/main/org/jboss/ejb/plugins/cmp/jdbc/JDBCStartCommand.java,v retrieving revision 1.20 retrieving revision 1.21 diff -u -r1.20 -r1.21 --- JDBCStartCommand.java 9 Feb 2002 16:09:23 - 1.20 +++ JDBCStartCommand.java 12 Feb 2002 06:15:17 - 1.21 @@ -40,7 +40,7 @@ * @author a href=mailto:[EMAIL PROTECTED];Joe Shevland/a * @author a href=mailto:[EMAIL PROTECTED];Justin Forder/a * @author a href=mailto:[EMAIL PROTECTED];Michel de Groot/a - * @version $Revision: 1.20 $ + * @version $Revision: 1.21 $ */ public class JDBCStartCommand { @@ -128,12 +128,10 @@ String tableName, String sql) throws DeploymentException { - boolean infoEnabled = log.isInfoEnabled(); // does this table already exist if(tableExists(dataSource, tableName)) { - if (infoEnabled) -log.info(Table ' + tableName + ' already exists); + log.info(Table ' + tableName + ' already exists); return; } @@ -141,35 +139,31 @@ Statement statement = null; // since we use the pools, we have to do this within a transaction - try - { + try { manager.getContainer().getTransactionManager().begin (); + } catch (Exception e) { + throw new DeploymentException(Could not get transaction to create + + table in, e); } - catch (Exception e) - { - log.error(Could not get transaction to create table in, e); - throw new DeploymentException(Could not get transaction to create table in, e); - } // end of try-catch try { - // get the connection - con = dataSource.getConnection(); try { +// get the connection +con = dataSource.getConnection(); + // create the statement statement = con.createStatement(); - // execute sql +// execute sql log.debug(Executing SQL: + sql); statement.executeUpdate(sql); - } - finally - { + } finally { +// make sure to close the connection and statement before +// comitting the transaction or XA will break JDBCUtil.safeClose(statement); JDBCUtil.safeClose(con); - } // end of finally + } manager.getContainer().getTransactionManager().commit (); - } - catch(Exception e) - { + } catch(Exception e) { log.debug(Could not create table + tableName); try { manager.getContainer().getTransactionManager().rollback (); @@ -179,8 +173,7 @@ throw new DeploymentException(Error while creating table, e); } // success - if (infoEnabled) - log.info(Created table ' + tableName + ' successfully.); + log.info(Created table ' + tableName + ' successfully.); Set createdTables = (Set)manager.getApplicationData(CREATED_TABLES_KEY); createdTables.add(tableName); } @@ -296,7 +289,6 @@ relationshipRolename= + cmrField.getMetaData().getRelationshipRoleName()); } - } private void addForeignKeyConstraint( @@ -329,28 +321,36 @@ b}; String sql = fkConstraint.getFunctionSql(args); + // since we use the pools, we have to do this within a transaction + try { + manager.getContainer().getTransactionManager().begin (); + } catch (Exception e) { + throw new DeploymentException(Could not get transaction to create + + table in, e); + } + Connection con = null; Statement statement = null; try { - // since we use the pools, we have to do this within a transaction - manager.getContainer().getTransactionManager().begin(); - - // get the connection - con = dataSource.getConnection(); + try { +// get the connection +con = dataSource.getConnection(); - // create the statement - statement =
[JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb/plugins/cmp/jdbc JDBCType.java JDBCTypeComplex.java JDBCTypeComplexProperty.java JDBCTypeFactory.java JDBCTypeSimple.java SQLUtil.java
User: dsundstrom Date: 02/02/11 22:17:15 Modified:src/main/org/jboss/ejb/plugins/cmp/jdbc JDBCType.java JDBCTypeComplex.java JDBCTypeComplexProperty.java JDBCTypeFactory.java JDBCTypeSimple.java SQLUtil.java Log: Added optional not-null element to cmp-fields. Not null is on by by default for primitive types and primary key fields. Revision ChangesPath 1.4 +2 -1 jboss/src/main/org/jboss/ejb/plugins/cmp/jdbc/JDBCType.java Index: JDBCType.java === RCS file: /cvsroot/jboss/jboss/src/main/org/jboss/ejb/plugins/cmp/jdbc/JDBCType.java,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- JDBCType.java 1 Sep 2001 22:03:15 - 1.3 +++ JDBCType.java 12 Feb 2002 06:17:15 - 1.4 @@ -12,13 +12,14 @@ * mapping of java classes to multipul columns. * * @author a href=mailto:[EMAIL PROTECTED];Dain Sundstrom/a - * @version $Revision: 1.3 $ + * @version $Revision: 1.4 $ */ public interface JDBCType { public String[] getColumnNames(); public Class[] getJavaTypes(); public int[] getJDBCTypes(); public String[] getSQLTypes(); + public boolean[] getNotNull(); public Object getColumnValue(int index, Object value); public Object setColumnValue(int index, Object value, Object columnValue); 1.8 +11 -1 jboss/src/main/org/jboss/ejb/plugins/cmp/jdbc/JDBCTypeComplex.java Index: JDBCTypeComplex.java === RCS file: /cvsroot/jboss/jboss/src/main/org/jboss/ejb/plugins/cmp/jdbc/JDBCTypeComplex.java,v retrieving revision 1.7 retrieving revision 1.8 diff -u -r1.7 -r1.8 --- JDBCTypeComplex.java 15 Jan 2002 21:38:37 - 1.7 +++ JDBCTypeComplex.java 12 Feb 2002 06:17:15 - 1.8 @@ -24,7 +24,7 @@ * details on how this is done. * * @author a href=mailto:[EMAIL PROTECTED];Dain Sundstrom/a - * @version $Revision: 1.7 $ + * @version $Revision: 1.8 $ */ public class JDBCTypeComplex implements JDBCType { private JDBCTypeComplexProperty[] properties; @@ -32,6 +32,7 @@ private Class[] javaTypes; private int[] jdbcTypes; private String[] sqlTypes; + private boolean[] notNull; private Class fieldType; private HashMap propertiesByName = new HashMap(); @@ -62,6 +63,11 @@ sqlTypes[i] = properties[i].getSQLType(); } + notNull = new boolean[properties.length]; + for(int i=0; inotNull.length; i++) { + notNull[i] = properties[i].isNotNull(); + } + for(int i=0; iproperties.length; i++) { propertiesByName.put(properties[i].getPropertyName(), properties[i]); } @@ -82,6 +88,10 @@ public String[] getSQLTypes() { return sqlTypes; + } + + public boolean[] getNotNull() { + return notNull; } public JDBCTypeComplexProperty[] getProperties() { 1.7 +10 -2 jboss/src/main/org/jboss/ejb/plugins/cmp/jdbc/JDBCTypeComplexProperty.java Index: JDBCTypeComplexProperty.java === RCS file: /cvsroot/jboss/jboss/src/main/org/jboss/ejb/plugins/cmp/jdbc/JDBCTypeComplexProperty.java,v retrieving revision 1.6 retrieving revision 1.7 diff -u -r1.6 -r1.7 --- JDBCTypeComplexProperty.java 24 Nov 2001 22:31:09 - 1.6 +++ JDBCTypeComplexProperty.java 12 Feb 2002 06:17:15 - 1.7 @@ -20,7 +20,7 @@ * the Java Bean. * * @author a href=mailto:[EMAIL PROTECTED];Dain Sundstrom/a - * @version $Revision: 1.6 $ + * @version $Revision: 1.7 $ */ public class JDBCTypeComplexProperty { private final String propertyName; @@ -28,6 +28,7 @@ private final Class javaType; private final int jdbcType; private final String sqlType; + private final boolean notNull; private final Method[] getters; private final Method[] setters; @@ -46,6 +47,7 @@ this.javaType = javaType; this.jdbcType = jdbcType; this.sqlType = sqlType; + this.notNull = false; this.getters = getters; this.setters = setters; } @@ -54,13 +56,15 @@ JDBCTypeComplexProperty defaultProperty, String columnName, int jdbcType, - String sqlType) { + String sqlType, + boolean notNull) { this.propertyName = defaultProperty.propertyName; this.columnName = columnName; this.javaType = defaultProperty.javaType; this.jdbcType = jdbcType; this.sqlType = sqlType; + this.notNull = notNull;
[JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb/plugins/cmp/jdbc/metadata JDBCCMPFieldMetaData.java JDBCCMPFieldPropertyMetaData.java JDBCRelationshipRoleMetaData.java
User: dsundstrom Date: 02/02/11 22:17:16 Modified:src/main/org/jboss/ejb/plugins/cmp/jdbc/metadata JDBCCMPFieldMetaData.java JDBCCMPFieldPropertyMetaData.java JDBCRelationshipRoleMetaData.java Log: Added optional not-null element to cmp-fields. Not null is on by by default for primitive types and primary key fields. Revision ChangesPath 1.7 +30 -2 jboss/src/main/org/jboss/ejb/plugins/cmp/jdbc/metadata/JDBCCMPFieldMetaData.java Index: JDBCCMPFieldMetaData.java === RCS file: /cvsroot/jboss/jboss/src/main/org/jboss/ejb/plugins/cmp/jdbc/metadata/JDBCCMPFieldMetaData.java,v retrieving revision 1.6 retrieving revision 1.7 diff -u -r1.6 -r1.7 --- JDBCCMPFieldMetaData.java 12 Dec 2001 19:48:36 - 1.6 +++ JDBCCMPFieldMetaData.java 12 Feb 2002 06:17:16 - 1.7 @@ -28,7 +28,7 @@ * @author a href=[EMAIL PROTECTED]Sebastien Alborini/a * @author a href=mailto:[EMAIL PROTECTED];Dirk Zimmermann/a * @author a href=mailto:[EMAIL PROTECTED];Vincent Harcq/a - * @version $Revision: 1.6 $ + * @version $Revision: 1.7 $ */ public final class JDBCCMPFieldMetaData { /** @@ -79,6 +79,11 @@ private final boolean primaryKeyMember; /** +* Should null values not be allowed for this field. +*/ + private final boolean notNull; + + /** * The Field object in the primary key class for this * cmp field, or null if this field is the prim-key-field. */ @@ -153,6 +158,7 @@ primaryKeyMember = pkMember; primaryKeyField = pkField; } + notNull = fieldType.isPrimitive() || primaryKeyMember; } /** @@ -225,6 +231,13 @@ // field object of the primary key primaryKeyField = defaultValues.getPrimaryKeyField(); + // not-null + Element notNullElement = MetaData.getOptionalChild(element, not-null); + notNull = +fieldType.isPrimitive() || +primaryKeyMember || +(notNullElement != null); + // property overrides Iterator iterator = MetaData.getChildrenByTagName(element, property); while(iterator.hasNext()) { @@ -259,6 +272,7 @@ Element element, JDBCCMPFieldMetaData defaultValues, boolean primaryKeyMember, + boolean notNull, boolean readOnly, int readTimeOut) throws DeploymentException { @@ -300,6 +314,9 @@ // primary key member? this.primaryKeyMember = primaryKeyMember; + // not-null + this.notNull = notNull; + // field object of the primary key primaryKeyField = defaultValues.getPrimaryKeyField(); @@ -340,6 +357,7 @@ JDBCCMPFieldMetaData defaultValues, String columnName, boolean primaryKeyMember, + boolean notNull, boolean readOnly, int readTimeOut) { @@ -370,12 +388,14 @@ // field object of the primary key primaryKeyField = defaultValues.getPrimaryKeyField(); + // not-null + this.notNull = notNull; + // property overrides for(Iterator i=defaultValues.propertyOverrides.iterator(); i.hasNext();) { propertyOverrides.add(new JDBCCMPFieldPropertyMetaData( this, (JDBCCMPFieldPropertyMetaData)i.next())); } - } /** @@ -465,6 +485,14 @@ */ public boolean isPrimaryKeyMember() { return primaryKeyMember; + } + + /** +* Should this field allow null values? +* @return true if this field will not allow a null value. +*/ + public boolean isNotNull() { + return notNull; } /** 1.6 +59 -24 jboss/src/main/org/jboss/ejb/plugins/cmp/jdbc/metadata/JDBCCMPFieldPropertyMetaData.java Index: JDBCCMPFieldPropertyMetaData.java === RCS file: /cvsroot/jboss/jboss/src/main/org/jboss/ejb/plugins/cmp/jdbc/metadata/JDBCCMPFieldPropertyMetaData.java,v retrieving revision 1.5 retrieving revision 1.6 diff -u -r1.5 -r1.6 --- JDBCCMPFieldPropertyMetaData.java 26 Nov 2001 03:12:27 - 1.5 +++ JDBCCMPFieldPropertyMetaData.java 12 Feb 2002 06:17:16 - 1.6 @@ -15,7 +15,7 @@ * This immutable class contains information about the an overriden field property. * * @author a href=mailto:[EMAIL PROTECTED];Dain Sundstrom/a - * @version $Revision: 1.5 $ + * @version $Revision: 1.6 $ */ public final class JDBCCMPFieldPropertyMetaData { /** @@ -42,23 +42,33 @@ * the sql type, used for table creation. */ private final String sqlType; + + /**
[JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb/plugins/cmp/jdbc/bridge JDBCCMRFieldBridge.java
User: dsundstrom Date: 02/02/11 22:17:16 Modified:src/main/org/jboss/ejb/plugins/cmp/jdbc/bridge JDBCCMRFieldBridge.java Log: Added optional not-null element to cmp-fields. Not null is on by by default for primitive types and primary key fields. Revision ChangesPath 1.22 +12 -1 jboss/src/main/org/jboss/ejb/plugins/cmp/jdbc/bridge/JDBCCMRFieldBridge.java Index: JDBCCMRFieldBridge.java === RCS file: /cvsroot/jboss/jboss/src/main/org/jboss/ejb/plugins/cmp/jdbc/bridge/JDBCCMRFieldBridge.java,v retrieving revision 1.21 retrieving revision 1.22 diff -u -r1.21 -r1.22 --- JDBCCMRFieldBridge.java 1 Feb 2002 01:44:30 - 1.21 +++ JDBCCMRFieldBridge.java 12 Feb 2002 06:17:15 - 1.22 @@ -53,7 +53,7 @@ * One for each role that entity has. * * @author a href=mailto:[EMAIL PROTECTED];Dain Sundstrom/a - * @version $Revision: 1.21 $ + * @version $Revision: 1.22 $ */ public class JDBCCMRFieldBridge implements JDBCFieldBridge { // -- Invocation messages -- @@ -1104,12 +1104,14 @@ private final Class[] javaTypes; private final int[] jdbcTypes; private final String[] sqlTypes; + private final boolean[] notNull; private CMRJDBCType(List fields) { List columnNamesList = new ArrayList(); List javaTypesList = new ArrayList(); List jdbcTypesList = new ArrayList(); List sqlTypesList = new ArrayList(); + List notNullList = new ArrayList(); for(Iterator iter = fields.iterator(); iter.hasNext(); ) { JDBCCMPFieldBridge field = (JDBCCMPFieldBridge)iter.next(); @@ -1119,6 +1121,7 @@ javaTypesList.add(type.getJavaTypes()[i]); jdbcTypesList.add(new Integer(type.getJDBCTypes()[i])); sqlTypesList.add(type.getSQLTypes()[i]); + notNullList.add(new Boolean(type.getNotNull()[i])); } } columnNames = (String[])columnNamesList.toArray( @@ -1132,6 +1135,11 @@ for(int i=0; ijdbcTypes.length; i++) { jdbcTypes[i] = ((Integer)jdbcTypesList.get(i)).intValue(); } + + notNull = new boolean[notNullList.size()]; + for(int i=0; inotNull.length; i++) { +notNull[i] = ((Boolean)notNullList.get(i)).booleanValue(); + } } public String[] getColumnNames() { return columnNames; @@ -1144,6 +1152,9 @@ } public String[] getSQLTypes() { return sqlTypes; + } + public boolean[] getNotNull() { + return notNull; } public Object getColumnValue(int index, Object value) { throw new UnsupportedOperationException(); ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] [ jboss-Bugs-512760 ] Patch: Add NOT NULL for pk in createSQL
Bugs item #512760, was opened at 2002-02-04 06:08 You can respond by visiting: http://sourceforge.net/tracker/?func=detailatid=376685aid=512760group_id=22866 Category: JBossCMP Group: v3.0 Rabbit Hole Status: Closed Resolution: Fixed Priority: 5 Submitted By: Matt (mpetteys) Assigned to: Dain Sundstrom (dsundstrom) Summary: Patch: Add NOT NULL for pk in createSQL Initial Comment: When tables with are created with primary keys in CMP, currently no column modifiers are used to create the table. The following is sql that is used to create table1 which has a primary key of id.. CREATE TABLE table1 (id VARCHAR(255) BINARY, data2 BLOB, data2 BLOB, CONSTRAINT pk_table1 PRIMARY KEY (id)) The current version of MySQL blows up on this because the column id should not be null because it is primary key column. The attached patch checks the columns to see if they are a primary key column and adds the not null modifier if they are. CREATE TABLE table1 (id VARCHAR(255) BINARY NOT NULL, data2 BLOB, data2 BLOB, CONSTRAINT pk_table1 PRIMARY KEY (id)) I believe most db supports not null so this should work universally without having to worry about DB specific syntax and I don't think that EJBs allow null primary keys so that shouldn't be a problem. -- Comment By: Dain Sundstrom (dsundstrom) Date: 2002-02-11 22:36 Message: Logged In: YES user_id=251431 I added an optional not-null to cmp-field and property. This option is on by default for pk fields and for primitive type. I could not use the supplied patch because it assumed that a field mapps to only one column. -- Comment By: Dain Sundstrom (dsundstrom) Date: 2002-02-11 14:08 Message: Logged In: YES user_id=251431 I'm wrong. I looked it up in my SQL in a Nutshell book, and it is required in SQL 99 that all pk columns be not null, which should be implied. I'll apply this patch (or something simmilar). -- Comment By: David Jencks (d_jencks) Date: 2002-02-11 13:49 Message: Logged In: YES user_id=60525 Not to nitpick, however sql92 entry level requires that all pk fields be not null all the time. Unique index fields can optionally be not null or null. I think previous sql standards also required this, but required it to be stated explicitly. sql92 standard syntax implicitly appends the not null constraint to all pk fields. There are several dbs that have archaic syntax that require you to declare not null explicitly (firebird/interbase and mysql come to mind) however ANY relational database with any hopes of logical consistency needs to require all pk fields not null. I do not know if (but think) that some databases object if you explicitly say not null on pks, even though they are adding the constraint implicitly. -- Comment By: Dain Sundstrom (dsundstrom) Date: 2002-02-11 13:02 Message: Logged In: YES user_id=251431 This patch is being rejected because it only fixes a problem in the mysql database, and breaks most other databases. It is perfecly valid in most databases to have a null pk. This is even more important when you have a pk field which is composed of several columns. In that case is a user may want some of the columns to be null some of the time. You can add not null to your sql-type, if you want this for your application. I would like to support a nullable (TRUE or FALSE) element in cmp-fields and a pk-not-null flag for type-mappings, but this is not a high priority. If you would like to work on this patch, contact me. -- Comment By: Andrew Marki (apmliq) Date: 2002-02-05 12:20 Message: Logged In: YES user_id=240275 To handle pk constraints on relation tables, I added a flag so JDBCStartCommand.getRelationCreateTableSQL() can force not null on all fields in SQLUtil.getCreateTableColumnsClause(fields, all) { ... if (all || field.isPrimaryKeyMember()) ...} In getRelationCreateTableSQL(), boolean hasPKC = cmrField.getRelationMetadata ().hasPrimaryKeyConstraint(); and invoke SQLUtil.getCTCC(fields, hasPKC); getCTCC(fields) just calls getCTCC(fields, false); The equivalent of nullable would be nice. -- You can respond by visiting: http://sourceforge.net/tracker/?func=detailatid=376685aid=512760group_id=22866 ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] CVS update: jboss/src/main/org/jboss/deployment MainDeploye
Ouch... had MainDeployer opened and modified... CVS is really bad at doing merges ahhh. Should be OK though. Might want to verify that I did not just clobber your changes. --jason _ View thread online: http://main.jboss.org/thread.jsp?forum=66thread=8305 ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jboss/src/resources/org/jboss/metadata jbosscmp-jdbc_3_0.dtd
User: dsundstrom Date: 02/02/11 22:22:51 Modified:src/resources/org/jboss/metadata jbosscmp-jdbc_3_0.dtd Log: Added not-null to cmp-field and property. Revision ChangesPath 1.11 +8 -2 jboss/src/resources/org/jboss/metadata/jbosscmp-jdbc_3_0.dtd Index: jbosscmp-jdbc_3_0.dtd === RCS file: /cvsroot/jboss/jboss/src/resources/org/jboss/metadata/jbosscmp-jdbc_3_0.dtd,v retrieving revision 1.10 retrieving revision 1.11 diff -u -r1.10 -r1.11 --- jbosscmp-jdbc_3_0.dtd 3 Feb 2002 02:19:27 - 1.10 +++ jbosscmp-jdbc_3_0.dtd 12 Feb 2002 06:22:50 - 1.11 @@ -183,7 +183,7 @@ The cmp-field element contains the configuration of a cmp-field. -- !ELEMENT cmp-field (field-name, read-only?, time-out?, - column-name?, ((jdbc-type, sql-type) | (property+))? ) + column-name?, not-null?, ((jdbc-type, sql-type) | (property+))? ) !-- @@ -200,6 +200,12 @@ !-- +If present the field will not allow a field value. +-- +!ELEMENT not-null EMPTY + + +!-- This is the JDBC type that is used when setting parameters in a JDBC PreparedStatement or loading data from a JDBC ResultSet for this cmp-field. The valid types are defined in java.sql.Types. @@ -219,7 +225,7 @@ value class property of a cmp-field that is the type of a dependent value class. -- -!ELEMENT property (property-name, column-name?, +!ELEMENT property (property-name, column-name?, not-null?, (jdbc-type, sql-type)?) ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] JBossMX serialVersionUID
We need to make sure that our plastic impl of the javax.managment.* conforms to the same serialVersionUID's from SUN's version: RemoteException occurred in server thread; nested exception is: java.rmi.UnmarshalException: error unmarshalling arguments; nested exception is: java.io.InvalidClassException: javax.management.ObjectName; Local class not compatible: stream classdesc serialVersionUID=6619599865887366536 local class serialVersionUID=-5467795090068647408 I have not looked into the reason for this specific problem, but I wanted to warn the appropriate parties that this will eed to be fixed. --jason ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbosstest/src/main/org/jboss/test/jmx/deployer BrokenDeployer.java
User: user57 Date: 02/02/11 22:50:20 Modified:src/main/org/jboss/test/jmx/deployer BrokenDeployer.java Log: o MainDeployerMBean.OBJECT_NAME is an ObjectName, no need to wrap. Revision ChangesPath 1.2 +2 -2 jbosstest/src/main/org/jboss/test/jmx/deployer/BrokenDeployer.java Index: BrokenDeployer.java === RCS file: /cvsroot/jboss/jbosstest/src/main/org/jboss/test/jmx/deployer/BrokenDeployer.java,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- BrokenDeployer.java 12 Feb 2002 05:50:46 - 1.1 +++ BrokenDeployer.java 12 Feb 2002 06:50:19 - 1.2 @@ -55,7 +55,7 @@ { // Register with the main deployer server.invoke( -new ObjectName(org.jboss.deployment.MainDeployerMBean.OBJECT_NAME), +org.jboss.deployment.MainDeployerMBean.OBJECT_NAME, addDeployer, new Object[] {this}, new String[] {org.jboss.deployment.DeployerMBean}); @@ -77,7 +77,7 @@ { // Register with the main deployer server.invoke( -new ObjectName(org.jboss.deployment.MainDeployerMBean.OBJECT_NAME), +org.jboss.deployment.MainDeployerMBean.OBJECT_NAME, removeDeployer, new Object[] {this}, new String[] {org.jboss.deployment.DeployerMBean}); ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] java.util.Date in PostgreSQL DB
This is for anyone who knows Postgres out there, There is a patch at sf that suggest adding the following mapping: mapping java-typejava.util.Date/java-type jdbc-typeTIMESTAMP/jdbc-type sql-typeTIMESTAMP/sql-type /mapping There is currently no mapping for java.util.Date, but there is a mapping for java.sql.Date, which is: mapping java-typejava.sql.Date/java-type jdbc-typeDATE/jdbc-type sql-typeDATE/sql-type /mapping Which is best for the default? -dain ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jboss build.xml
User: user57 Date: 02/02/11 22:51:17 Modified:.build.xml Log: o testsuite pulls DeploymentException from jboss-spine, which is broken but I haven't the energy to fix right now, it will be duplicated in jboss-boot jboss-spine for now. Revision ChangesPath 1.55 +7 -1 jboss/build.xml Index: build.xml === RCS file: /cvsroot/jboss/jboss/build.xml,v retrieving revision 1.54 retrieving revision 1.55 diff -u -r1.54 -r1.55 --- build.xml 12 Feb 2002 03:22:02 - 1.54 +++ build.xml 12 Feb 2002 06:51:17 - 1.55 @@ -12,7 +12,7 @@ !---- !-- == -- -!-- $Id: build.xml,v 1.54 2002/02/12 03:22:02 user57 Exp $ -- +!-- $Id: build.xml,v 1.55 2002/02/12 06:51:17 user57 Exp $ -- project default=main name=JBoss/Server @@ -529,6 +529,9 @@ include name=org/jboss/system/ServiceLibraries*.class/ include name=org/jboss/system/Server*.class/ include name=org/jboss/deployment/DeploymentException.class/ + +!-- Included as a duplicate class to allow core components to use it. -- +include name=org/jboss/util/SafeObjectNameFactory.class/ /fileset fileset dir=${build.resources} include name=org/jboss/version.properties/ @@ -552,6 +555,9 @@ include name=org/jboss/deployment/SARDeployer*.class/ include name=org/jboss/deployment/DeploymentInfo.class/ include name=org/jboss/deployment/DeployerMBean*.class/ + +!-- Currently duplicated to allow the testsuite to run -- +include name=org/jboss/deployment/DeploymentException.class/ /fileset /jar ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jboss/src/main/org/jboss/deployment Deployment.java
User: d_jencks Date: 02/02/11 22:58:13 Removed: src/main/org/jboss/deployment Deployment.java Log: removed obsolete class ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jbosstest build.xml
User: d_jencks Date: 02/02/11 23:00:56 Modified:.build.xml Log: get DeploymentException from jboss-boot.jar Revision ChangesPath 1.62 +2 -1 jbosstest/build.xml Index: build.xml === RCS file: /cvsroot/jboss/jbosstest/build.xml,v retrieving revision 1.61 retrieving revision 1.62 diff -u -r1.61 -r1.62 --- build.xml 12 Feb 2002 05:50:46 - 1.61 +++ build.xml 12 Feb 2002 07:00:56 - 1.62 @@ -27,7 +27,7 @@ !--tests-jmxri-compliance still needs to run over jmxri.jar -- !--the aim of that test is to check our compliance suite. -- -!-- $Id: build.xml,v 1.61 2002/02/12 05:50:46 d_jencks Exp $ -- +!-- $Id: build.xml,v 1.62 2002/02/12 07:00:56 d_jencks Exp $ -- project default=main name=JBoss/Testsuite @@ -208,6 +208,7 @@ pathelement path=${jboss.server.lib}/jboss-client.jar/ pathelement path=${jboss.server.lib}/jmx-rmi-connector-client.jar/ pathelement path=${jboss.server.lib}/deploy.jar/ + pathelement path=${jboss.server.lib}/jboss-boot.jar/ pathelement path=${jboss.server.lib}/jboss-spine.jar/ /path ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] CVS update: jboss/src/main/org/jboss/deployment MainDeployer.java MainDeployerMBean.java SARDeployer.java
User: user57 Date: 02/02/11 22:59:23 Modified:src/main/org/jboss/deployment MainDeployer.java MainDeployerMBean.java SARDeployer.java Log: o MainDeployer SARDeployer use ServerConfig getHomeDir() + getTempDir() and work off of them instead of jboss.system.home property. Revision ChangesPath 1.15 +106 -111 jboss/src/main/org/jboss/deployment/MainDeployer.java Index: MainDeployer.java === RCS file: /cvsroot/jboss/jboss/src/main/org/jboss/deployment/MainDeployer.java,v retrieving revision 1.14 retrieving revision 1.15 diff -u -r1.14 -r1.15 --- MainDeployer.java 12 Feb 2002 05:41:09 - 1.14 +++ MainDeployer.java 12 Feb 2002 06:59:22 - 1.15 @@ -7,10 +7,6 @@ package org.jboss.deployment; - - - - import java.io.File; import java.io.FileInputStream; import java.io.FileOutputStream; @@ -39,7 +35,9 @@ import javax.management.MalformedObjectNameException; import javax.management.ObjectName; import org.jboss.system.ServiceMBeanSupport; -import org.jboss.util.DirectoryBuilder; +import org.jboss.system.ServerConfigMBean; + +import org.jboss.util.MBeanProxy; /** * MainDeployer @@ -47,13 +45,12 @@ * Takes a series of URL to watch, detects changes and calls the appropriate Deployers * * @author a href=mailto:[EMAIL PROTECTED];Marc Fleury/a - * @version $Revision: 1.14 $ + * @version $Revision: 1.15 $ */ public class MainDeployer extends ServiceMBeanSupport implements MainDeployerMBean, Runnable { - /** Deployers **/ private final Set deployers = new HashSet(); @@ -74,11 +71,15 @@ private int id = 0; /** Given a flat set of files, this is the order of deployment **/ - private final String[] order = {sar, service.xml, rar, jar, war, ear, zip}; - - /** Get on period **/ - public void setPeriod(int period) - { + private String[] order = { sar, service.xml, rar, jar, war, ear, zip }; + + /** The temporary directory for deployments. */ + private File tempDir; + + /** The system home directory (for dealing with relative file names). */ + private File homeDir; + + public void setPeriod(int period) { this.period = period; } @@ -92,7 +93,7 @@ * Directory get set logic, these are scanning directories * on the local filesystem */ - public void setDirectories(String urlList) + public void setDirectories(String urlList) throws MalformedURLException { StringTokenizer urls = new StringTokenizer(urlList, ,); @@ -103,60 +104,47 @@ } } - public void addDirectory(String url) + public void addDirectory(String url) throws MalformedURLException { // We are dealing with a relative path URL - if (!( url.startsWith(file:) || url.startsWith(http:))) - { - url = file:+System.getProperty(jboss.system.home)+File.separator+url; + if (!( url.startsWith(file:) || url.startsWith(http:))) { + addDirectory(new URL(homeDir.toURL(), url)); } - // Only one entry - try - { - URL dir = new URL(url); + else { + addDirectory(new URL(url)); + } + } + + public void addDirectory(URL url) { + if (!directories.contains(url)) { + directories.add(url); - if (!directories.contains(dir)) - { -directories.add(dir); + if (log.isDebugEnabled()) { +log.debug(Added directory scan +url); } } - catch (MalformedURLException bad) - { - log.warn(Failed to add directory scan + url); - return; - } - - if (log.isDebugEnabled()) - { - log.debug(Added directory scan +url); - } } - public void removeDirectory(String url) + public void removeDirectory(String url) throws MalformedURLException { // We are dealing with a relative path URL - if (!( url.startsWith(file:) || url.startsWith(http:))) - { - url = System.getProperty(jboss.system.home) + url; + if (!(url.startsWith(file:) || url.startsWith(http:))) { + removeDirectory(new URL(homeDir.toURL(), url)); } - - try - { - int index = directories.lastIndexOf(new URL(url)); - if (index != -1) - { -directories.remove(index); - } + else { + removeDirectory(new URL(url)); } - catch (MalformedURLException bad) - { - log.warn(Failed to remove directory scan + url); - return; - } - - if
[JBoss-dev] CVS update: jboss/src/main/org/jboss/system ServerConfigMBean.java ServiceControllerMBean.java
User: user57 Date: 02/02/11 22:59:23 Modified:src/main/org/jboss/system ServerConfigMBean.java ServiceControllerMBean.java Log: o MainDeployer SARDeployer use ServerConfig getHomeDir() + getTempDir() and work off of them instead of jboss.system.home property. Revision ChangesPath 1.3 +10 -1 jboss/src/main/org/jboss/system/ServerConfigMBean.java Index: ServerConfigMBean.java === RCS file: /cvsroot/jboss/jboss/src/main/org/jboss/system/ServerConfigMBean.java,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- ServerConfigMBean.java12 Feb 2002 05:05:47 - 1.2 +++ ServerConfigMBean.java12 Feb 2002 06:59:23 - 1.3 @@ -8,16 +8,25 @@ package org.jboss.system; import java.io.File; + import java.net.URL; +import javax.management.ObjectName; + +import org.jboss.util.SafeObjectNameFactory; + /** * The JMX MBean interface for the ttServerConfig/tt component. * * @author a href=mailto:[EMAIL PROTECTED];Jason Dillon/a - * @version $Revision: 1.2 $ + * @version $Revision: 1.3 $ */ public interface ServerConfigMBean { + /** The default object name. */ + ObjectName OBJECT_NAME = SafeObjectNameFactory.create(jboss.system, + service, + ServerConfig); /** * Get the JMX domain for which the system is bound under. * 1.9 +4 -4 jboss/src/main/org/jboss/system/ServiceControllerMBean.java Index: ServiceControllerMBean.java === RCS file: /cvsroot/jboss/jboss/src/main/org/jboss/system/ServiceControllerMBean.java,v retrieving revision 1.8 retrieving revision 1.9 diff -u -r1.8 -r1.9 --- ServiceControllerMBean.java 12 Feb 2002 03:22:03 - 1.8 +++ ServiceControllerMBean.java 12 Feb 2002 06:59:23 - 1.9 @@ -23,7 +23,7 @@ * @see Service * * @author a href=mailto:[EMAIL PROTECTED];Marc Fleury/a - * @version $Revision: 1.8 $ + * @version $Revision: 1.9 $ * * pb20010830 marc fleury:/b * ul @@ -39,9 +39,9 @@ public interface ServiceControllerMBean { /** The default object name. */ -ObjectName OBJECT_NAME = SafeObjectNameFactory.create(jboss.system, - service, - ServiceController); + ObjectName OBJECT_NAME = SafeObjectNameFactory.create(jboss.system, + service, + ServiceController); /** Install a service, create the MBean and configure it**/ ObjectName install(Element mbean) throws Exception; ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] CVS update: jboss/src/main/org/jboss/deployment MainDeploye
On 2002.02.12 01:29:32 -0500 Jason Dillon wrote: Ouch... had MainDeployer opened and modified... CVS is really bad at doing merges ahhh. Should be OK though. Might want to verify that I did not just clobber your changes. --jason Ouch is right. I wasn't too happy with your changes earlier either, having spent most of the day tracking down deployer bugs;-) your second set looks ok to me. Could you please follow the coding conventions, i.e. if (true) { } else { } rather than if (true) { } else { } ? I don't like this style much either, but it is the official jboss style. Thanks david jencks _ View thread online: http://main.jboss.org/thread.jsp?forum=66thread=8305 ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] CVS update: jboss/src/main/org/jboss/deploymentMainDeploye
On Mon, 2002-02-11 at 23:18, David Jencks wrote: On 2002.02.12 01:29:32 -0500 Jason Dillon wrote: Ouch... had MainDeployer opened and modified... CVS is really bad at doing merges ahhh. Should be OK though. Might want to verify that I did not just clobber your changes. --jason Ouch is right. I wasn't too happy with your changes earlier either, having spent most of the day tracking down deployer bugs;-) Sorry about that. Wish there was a better way to deal with this. I usually end up just dumping my changes and starting over. your second set looks ok to me. Could you please follow the coding conventions, i.e. if (true) { } else { } rather than if (true) { } else { } ? I don't like this style much either, but it is the official jboss style. Will try, but that swag hurts my eyes and my mouse wheel finger. --jason ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
[JBoss-dev] ConcurrentModificationException in MainDeployer.scanRemoved
The logic in MainDeployer.scanRemoved needs to be validated for concurrency as I am periodically seeing this exception when a test is undeployed: 23:58:59,062 ERROR [Default] java.util.ConcurrentModificationException 23:58:59,062 ERROR [Default]at java.util.AbstractList$Itr.checkForComodification(AbstractList.java:445) 23:58:59,062 INFO [MainDeployer] could not delete directory file:/D:/usr/local/ src/cvsroot/Main/jboss-all/build/output/jboss-3.0.0DR2/tmp/deploy/56.perf.ja r restart will delete it 23:58:59,062 ERROR [Default]at java.util.AbstractList$Itr.next(AbstractList.java:418) 23:58:59,062 ERROR [Default]at org.jboss.deployment.MainDeployer.scanRemoved(MainDeployer.java:594) 23:58:59,062 ERROR [Default]at org.jboss.deployment.MainDeployer.scan(MainDeployer.java:281) 23:58:59,062 ERROR [Default]at org.jboss.deployment.MainDeployer.run(MainDeployer.java:249) 23:58:59,078 ERROR [Default]at java.lang.Thread.run(Thread.java:484) 23:58:59,078 INFO [MainDeployer] Undeployed file:/D:/usr/local/src/cvsroot/Main/jboss-all/testsuite/output/lib/perf.jar Scott Stark Chief Technology Officer JBoss Group, LLC ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
RE: [JBoss-dev] Classloader changes. was: Status of ear deployment
you are right i will give greg read write marcf |-Original Message- |From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On Behalf Of Jules Gosnell |Sent: Thursday, February 07, 2002 3:55 PM |To: Greg Wilkins |Cc: marc fleury; Dave Smith; [EMAIL PROTECTED]; |[EMAIL PROTECTED]; Oleg Zenzin |Subject: Re: [JBoss-dev] Classloader changes. was: Status of ear |deployment | | |Someone your side should definitely have write perms - I away |fri-sat-sun-mon, so won't be able to do anything. | |Jules | | | | |Greg Wilkins wrote: | | I have made a change to Jetty (tag JBOSS_200202072130) that has a | setClassLoader method on HttpContext ( and thus WebApplicationContext). | | This will allow the JBoss UCL to be set during deployment and thus to | completely avoid the Jetty ContextLoader and any policy that it may | implement. | | The only down side of this, is that the getFileClassPath method will | also have to be specialized so that a classpath can be generated that | can be passed to javac for JSP compilation. | | I'm not sure who should be making these changes now? Jules or Oleg. | It may be worthwhile to also give Jan checking permission and then we | can also checkin jetty updates and JettyService patches. | | cheers | | -- | Greg Wilkins[EMAIL PROTECTED] GB Phone: +44-(0)7092063462 | Mort Bay Consulting Australia and UK.Mbl Phone: +61-(0)4 17786631 | http://www.mortbay.com AU Phone: +61-(0)2 98107029 | | ___ | Jboss-development mailing list | [EMAIL PROTECTED] | https://lists.sourceforge.net/lists/listinfo/jboss-development | | |_ |Do You Yahoo!? |Get your free @yahoo.com address at http://mail.yahoo.com ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
RE: [JBoss-dev] JBOSS @ JAVAONE TSHIRT CONTEST
it is classic but it is good, man, it is all really good, it is going to be tough, marcf |-Original Message- |From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On Behalf Of Jules Gosnell |Sent: Thursday, February 07, 2002 4:21 PM |Cc: 'marc fleury'; 'Jboss-Development@Lists. Sourceforge. Net' |Subject: Re: [JBoss-dev] JBOSS @ JAVAONE TSHIRT CONTEST | | |OK - I know it's corny, but we haven't had any Star Wars references: | |JBoss - May the Source be with you | | |Someone must be able to come up with a quote about coming over to the |resistance, vanquishing the dark side, etc. | | |Jules | | | | |_ |Do You Yahoo!? |Get your free @yahoo.com address at http://mail.yahoo.com ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
RE: [JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb CacheKey.java
remove the cache key altogether if you want marcf |-Original Message- |From: [EMAIL PROTECTED] |[mailto:[EMAIL PROTECTED]]On Behalf Of Scott |M Stark |Sent: Thursday, February 07, 2002 11:50 PM |To: [EMAIL PROTECTED] |Subject: [JBoss-dev] CVS update: jboss/src/main/org/jboss/ejb |CacheKey.java | | | User: starksm | Date: 02/02/07 23:49:40 | | Modified:src/main/org/jboss/ejb Tag: Branch_2_4 CacheKey.java | Log: | Fix problem with cast in equals | | Revision ChangesPath | No revision | | | No revision | | | 1.12.2.2 +157 -138 jboss/src/main/org/jboss/ejb/CacheKey.java | | Index: CacheKey.java | === | RCS file: /cvsroot/jboss/jboss/src/main/org/jboss/ejb/CacheKey.java,v | retrieving revision 1.12.2.1 | retrieving revision 1.12.2.2 | diff -u -r1.12.2.1 -r1.12.2.2 | --- CacheKey.java20 Nov 2001 09:42:48 - 1.12.2.1 | +++ CacheKey.java8 Feb 2002 07:49:40 - 1.12.2.2 | @@ -1,150 +1,169 @@ | /* | -* JBoss, the OpenSource EJB server | -* | -* Distributable under LGPL license. | -* See terms of license at gnu.org. | -*/ | + * JBoss, the OpenSource EJB server | + * | + * Distributable under LGPL license. | + * See terms of license at gnu.org. | + */ | package org.jboss.ejb; | | +import java.lang.reflect.Method; | import java.rmi.MarshalledObject; | | import org.apache.log4j.Category; | | /** | -* CacheKey | -* | -* CacheKey is an encapsulation of both the PrimaryKey and a |cache specific key | -* | -* This implementation is a safer implementation in the sense |that it doesn't rely | -* on the user supplied hashcode and equals. It is also fast |since the hashCode operation | -* is pre-calculated. | -* | -* @see org.jboss.ejb.plugins.NoPassivationInstanceCache.java | -* @see org.jboss.ejb.plugins.EntityInstanceCache | -* @see org.jboss.ejb.plugins.EntityProxy | -* @author a href=[EMAIL PROTECTED]Marc Fleury/a | -* @author a href=[EMAIL PROTECTED]Bill Burke/a | -* @author a href=[EMAIL PROTECTED]Scott Stark/a | -* @version $Revision: 1.12.2.1 $ | -*/ | + * CacheKey | + * | + * CacheKey is an encapsulation of both the PrimaryKey and a |cache specific key | + * | + * This implementation is a safer implementation in the sense |that it doesn't rely | + * on the user supplied hashcode and equals. It is also |fast since the hashCode operation | + * is pre-calculated. | + * | + * @see org.jboss.ejb.plugins.NoPassivationInstanceCache.java | + * @see org.jboss.ejb.plugins.EntityInstanceCache | + * @see org.jboss.ejb.plugins.EntityProxy | + * @author a href=[EMAIL PROTECTED]Marc Fleury/a | + * @author a href=[EMAIL PROTECTED]Bill Burke/a | + * @author a href=[EMAIL PROTECTED]Scott Stark/a | + * @version $Revision: 1.12.2.2 $ | + */ | public class CacheKey | -implements java.io.Externalizable | + implements java.io.Externalizable | { | -// Constants - | - | -// Attributes | - | -// The database primaryKey | -// This primaryKey is used by | -// | -// org.jboss.ejb.plugins.EntityInstanceCache.setKey() - to |set the EntityEnterpriseContext id | -// org.jboss.ejb.plugins.jrmp.interfaces.EntityProxy.invoke(): | -// - implementing Entity.toString() -- cacheKey.getId().toString() | -// - implementing Entity.hashCode() -- cacheKey.getId().hashCode() | -// - etc... | -// |org.jboss.ejb.plugins.local.BaseLocalContainerInvoker.EntityProxy.getId() | -// | -protected Object id; | -public Object getId() | -{ | -return id; | -} | - | -// The Marshalled Object representing the key | -protected MarshalledObject mo; | - | -// The Marshalled Object's hashcode | -protected int hashCode; | - | -// Static | - | -// Public | - | -public CacheKey() | -{ | -// For externalization only | -} | -public CacheKey(Object id) | -{ | -if (id == null) throw new Error(id may not be null); | - | -this.id = id; | -try | -{ | -// Equals rely on the MarshalledObject itself | -mo = new MarshalledObject(id); | -// Precompute the hashCode (speed) | -hashCode = mo.hashCode(); | -} | -catch (Exception e) | -{ | - Category log = Category.getInstance(getClass()); | - log.error(failed to initialize, id=+id, e); | -} | -} | - | -// Z implementation -- | - | -// Package protected - | - | -// Protected
RE: [JBoss-dev] CVS update: jbossmx/src/etc farm-service.xml
david the classpath should not be used unless you go http installations try to remove these dependencies. marcf |-Original Message- |From: [EMAIL PROTECTED] |[mailto:[EMAIL PROTECTED]]On Behalf Of David |Jencks |Sent: Saturday, February 09, 2002 8:38 PM |To: [EMAIL PROTECTED] |Subject: [JBoss-dev] CVS update: jbossmx/src/etc farm-service.xml | | | User: d_jencks | Date: 02/02/09 20:37:43 | | Modified:src/etc farm-service.xml | Log: | fixed classpath codebase, however this relies on a nonexistent |class so is broken | | Revision ChangesPath | 1.4 +3 -1 jbossmx/src/etc/farm-service.xml | | Index: farm-service.xml | === | RCS file: /cvsroot/jboss/jbossmx/src/etc/farm-service.xml,v | retrieving revision 1.3 | retrieving revision 1.4 | diff -u -r1.3 -r1.4 | --- farm-service.xml 13 Jan 2002 17:17:15 - 1.3 | +++ farm-service.xml 10 Feb 2002 04:37:43 - 1.4 | @@ -8,11 +8,13 @@ | | server | | - classpath archives=jbossha.jar/ | + classpath codebase=lib/ext archives=jbossha.jar/ | | + !--these depends tags no longer do anything | dependsjboss:service=Naming/depends | dependsjboss.system:service=ServiceDeployer/depends | dependsjboss:service=DefaultPartition/depends | + -- | | !-- | -- | !-- Cluster Partition: defines cluster | -- | | | | |___ |Jboss-development mailing list |[EMAIL PROTECTED] |https://lists.sourceforge.net/lists/listinfo/jboss-development ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
RE: [JBoss-dev] Package organization
yes clearly scott, marcf |-Original Message- |From: [EMAIL PROTECTED] |[mailto:[EMAIL PROTECTED]]On Behalf Of Scott |M Stark |Sent: Saturday, February 09, 2002 4:03 PM |To: [EMAIL PROTECTED] |Subject: Re: [JBoss-dev] Package organization | | |I'm not saying style is not important, but to me your arguments |have no objective basis that tell me how they ensure management |scalability, hence its YOUR style viewpoint. While I thank you |for sharing, I have no interest in renaming packages unless you |can demonstrate a benefit. | |- Original Message - |From: Jason Dillon [EMAIL PROTECTED] |To: Scott M Stark [EMAIL PROTECTED] |Cc: [EMAIL PROTECTED] |Sent: Saturday, February 09, 2002 7:29 AM |Subject: Re: [JBoss-dev] Package organization | | | You are right... what _was_ I thinking anyways?!? Style... pfff who | needs it! | | I am going to go stick my head is a bucket. | | Code is important. Code is Art. Art has style. Therefor code has | style and is important. | | Of course the first two points are completely subjective. One might | think that code is not important (such an individual is not well | informed to how the new world order works), or that code is not art, but | a complicated chore to be banged out quickly just to get the job done. | | Of course, I think that my previous mail has more basis in scalable | organization than artistic style... | | --jason | | | | | |___ |Jboss-development mailing list |[EMAIL PROTECTED] |https://lists.sourceforge.net/lists/listinfo/jboss-development ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
RE: [JBoss-dev] New Deployment Architecture Doesn't Ignore dotfiles?
yes but do fix that if you can adrian, thanks marcf |-Original Message- |From: [EMAIL PROTECTED] |[mailto:[EMAIL PROTECTED]]On Behalf Of |Adrian Brock |Sent: Friday, February 08, 2002 3:37 PM |To: [EMAIL PROTECTED] |Subject: Re: [JBoss-dev] New Deployment Architecture Doesn't Ignore |dotfiles? | | |The old AutoDeployer quietly ignored rubbish in deploy |(anything that didn't match a deployer's filter) | |Looks like MainDeployer is less forgiving :-) | |Regards, |Adrian | |_ |View thread online: http://main.jboss.org/thread.jsp?forum=66thread=8120 | |___ |Jboss-development mailing list |[EMAIL PROTECTED] |https://lists.sourceforge.net/lists/listinfo/jboss-development ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
RE: [JBoss-dev] JBOSS @ JAVAONE TSHIRT CONTEST
That is really funny marcf |-Original Message- |From: Hunter Hillegas [mailto:[EMAIL PROTECTED]] |Sent: Thursday, February 07, 2002 11:22 AM |To: marc fleury; JBoss Dev |Subject: Re: [JBoss-dev] JBOSS @ JAVAONE TSHIRT CONTEST | | |JBoss: All Your J2EE Are Belong To Us | | From: Colin Daly [EMAIL PROTECTED] | Date: Thu, 7 Feb 2002 18:13:26 +1100 | To: marc fleury [EMAIL PROTECTED], Jboss-Development@Lists. | Sourceforge. Net [EMAIL PROTECTED] | Subject: Re: [JBoss-dev] JBOSS @ JAVAONE TSHIRT CONTEST | | to plagiarize you marc | | JBoss: | we love you. ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
RE: [JBoss-dev] New Deployment Architecture Doesn't Ignore dotfiles?
yes, this is the way it would work right now, and no it would not be the intended behavior. methinks you can submit a patch to the maindeployer that uses the 'findDeployer' call in the scans so we can weed out bullshit entries like this one. marcf |-Original Message- |From: [EMAIL PROTECTED] |[mailto:[EMAIL PROTECTED]]On Behalf Of |Hunter Hillegas |Sent: Friday, February 08, 2002 3:04 PM |To: JBoss Dev |Subject: [JBoss-dev] New Deployment Architecture Doesn't Ignore |dotfiles? | | |Am I right that the new deployer doesn't ignore dotfiles (files starting |with a ., making them hidden in Unix)? | |My OS (MacOS X 10.1), writes some meta data in dotfiles when you |muck around |in the directories and I guess it wrote one in deploy... Now I get this: | |15:01:49,120 INFO [MainDeployer] Deploying: |file:/Users/hunter/Unix/Sources/jboss-all-dr1/build/output/jboss-3. |0.0DR1/de |ploy/.DS_Store |15:01:49,140 ERROR [MainDeployer] Couldn't deploy URL |file:/Users/hunter/Unix/Sources/jboss-all-dr1/build/output/jboss-3. |0.0DR1/de |ploy/.DS_Store |org.jboss.deployment.DeploymentException: error in opening zip file, Cause: |java.util.zip.ZipException: error in opening zip file |at |org.jboss.deployment.MainDeployer.deploySubPackages(MainDeployer.java:577) | | |Okay... So this is just cosmetic and no big deal, just not sure if this is |intended behavior or not. | |Hunter | | |___ |Jboss-development mailing list |[EMAIL PROTECTED] |https://lists.sourceforge.net/lists/listinfo/jboss-development ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development