[JBoss-dev] jbpm-hsqldb-testsuite Build Completed With Testsuite Errors

2006-04-12 Thread qa

View results here -> http://cruisecontrol.jboss.com/cc/buildresults/jbpm-hsqldb-testsuite?log=log20060413022736
TESTS FAILEDAnt Error Message: /home/cruisecontrol/work/scripts/build-jbpm-db-matrix.xml:77: The following error occurred while executing this line: /home/cruisecontrol/work/scripts/build-jbpm-db-matrix.xml:68: The following error occurred while executing this line: /home/cruisecontrol/work/scripts/build-common-targets.xml:11: Build Successful - Tests completed with errors or failures.Date of build: 04/13/2006 02:27:36Time to build: 15 minutes 45 seconds




    Unit Tests: (254)    Total Errors and Failures: (5)testSuspendorg.jbpm.graph.exe.SuspendAndResumeDbTesttestResumeorg.jbpm.graph.exe.SuspendAndResumeDbTesttestStoreNodeorg.jbpm.jcr.JcrNodeDbTesttestServiceRetrievalorg.jbpm.jcr.JcrServiceDbTest 
 Modifications since last build: (first 50 of 0)



[JBoss-dev] jboss-3.2-testsuite Build Completed With Testsuite Errors

2006-04-12 Thread qa

View results here -> http://cruisecontrol.jboss.com/cc/buildresults/jboss-3.2-testsuite?log=log20060413001502
TESTS FAILEDAnt Error Message: /services/cruisecontrol/work/scripts/build-jboss-common.xml:235: The following error occurred while executing this line: /services/cruisecontrol/work/scripts/build-common-targets.xml:26: Build Successful - Tests completed with errors or failures.Date of build: 04/13/2006 00:15:02Time to build: 49 minutes 59 secondsLast changed: 04/12/2006 10:00:45Last log entry: JBAS-1228 EJB-QL produces incorrect SQL




    Unit Tests: (1842)    Total Errors and Failures: (6)testFederatedorg.jboss.test.jbossnet.external.ExternalUnitTestCasetestFederatedorg.jboss.test.jbossnet.external.RedeployExternalUnitTestCasetestENCPerforg.jboss.test.naming.test.NamingStressTestCaseunknownorg.jboss.test.perf.test.PerfStressTestCaseunknownorg.jboss.test.perf.test.SecurePerfStressTestCasetestSecurityDomainorg.jboss.test.security.test.EJBSpecUnitTestCase 
 Modifications since last build: (first 50 of 19)1.10.2.55modifiedaloubyanskyserver/src/main/org/jboss/ejb/plugins/cmp/jdbc/JDBCEJBQLCompiler.javaJBAS-1228 EJB-QL produces incorrect SQL1.1.2.6modifieddimitristomcat/src/main/org/jboss/web/tomcat/tc5/WebCtxLoader.javaJBAS-3006, throw LifecycleException rather than NPE when restarted (WebCtxLoader is not reloadable)1.10.2.54modifiedaloubyanskyserver/src/main/org/jboss/ejb/plugins/cmp/jdbc/JDBCEJBQLCompiler.javaJBAS-1245 JDBCEJBQLCompiler: Invalid SQL for Left join read ahead1.1.2.7modifiedaloubyanskytestsuite/src/resources/cmp2/keygen/META-INF/ejb-jar.xmltest for [JBAS-1249]   Incorrect Handle implementation for CMP Entity beans1.1.4.2modifiedaloubyanskytestsuite/src/main/org/jboss/test/cmp2/keygen/ejb/UnknownPK.javatest for [JBAS-1249]   Incorrect Handle implementation for CMP Entity beans1.1.4.2modifiedaloubyanskytestsuite/src/main/org/jboss/test/cmp2/keygen/ejb/UnknownPKHome.javatest for [JBAS-1249]   Incorrect Handle implementation for CMP Entity beans1.1.2.8modifiedaloubyanskytestsuite/src/main/org/jboss/test/cmp2/keygen/test/KeyGenerationUnitTestCase.javatest for [JBAS-1249]   Incorrect Handle implementation for CMP Entity beans1.1.4.4modifiedaloubyanskyserver/src/main/org/jboss/proxy/ejb/handle/EntityHandleImpl.javaJBAS-1249   Incorrect Handle implementation for CMP Entity beans1.1.4.1deletedaloubyanskytestsuite/src/main/org/jboss/test/cmp2/keygen/ejb/UnknownPK.javafile UnknownPK.java was added on branch Branch_3_2 on 2006-04-11 13:24:15 +1.1.4.1deletedaloubyanskytestsuite/src/main/org/jboss/test/cmp2/keygen/ejb/UnknownPKHome.javafile UnknownPKHome.java was added on branch Branch_3_2 on 2006-04-11 13:24:15 +1.12.2.40modifiedaloubyanskyserver/src/main/org/jboss/ejb/plugins/cmp/jdbc/JDBCAbstractQueryCommand.java[JBAS-1296] EJB-QL CMR traversal returns wrong interface type1.15.4.9modifiedaloubyanskyserver/src/main/org/jboss/ejb/plugins/cmp/jdbc/JDBCCommandFactory.java[JBAS-1296] EJB-QL CMR traversal returns wrong interface type1.3.4.13modifiedaloubyanskyserver/src/main/org/jboss/ejb/plugins/cmp/jdbc/JDBCFindAllQuery.java[JBAS-1296] EJB-QL CMR traversal returns wrong interface type1.3.4.13modifiedaloubyanskyserver/src/main/org/jboss/ejb/plugins/cmp/jdbc/JDBCFindByQuery.java[JBAS-1296] EJB-QL CMR traversal returns wrong interface type1.7.4.14modifiedaloubyanskyserver/src/main/org/jboss/ejb/plugins/cmp/jdbc/JDBCQueryManager.java[JBAS-1296] EJB-QL CMR traversal returns wrong interface type1.5.2.10modifiedaloubyanskytestsuite/src/resources/cmp2/commerce/META-INF/ejb-jar.xmlcorrected abstract schema name in the finder1.12.2.39modifiedaloubyanskyserver/src/main/org/jboss/ejb/plugins/cmp/jdbc/JDBCAbstractQueryCommand.java[JBAS-1550] JDBCEJBQLCompiler generates a non valid query1.10.2.53modifiedaloubyanskyserver/src/main/org/jboss/ejb/plugins/cmp/jdbc/JDBCEJBQLCompiler.java[JBAS-1550] JDBCEJBQLCompiler generates a non valid query1.4.4.27modifiedaloubyanskyserver/src/main/org/jboss/ejb/plugins/cmp/jdbc/JDBCFindByPrimaryKeyQuery.java[JBAS-1550] JDBCEJBQLCompiler generates a non valid query



[JBoss-dev] Rolling back versions of thirdparty dependencies

2006-04-12 Thread Ruel Loehr








I’ve modified the repository so that md5 checksums are
created for the hosted artifacts.   The build get task used to retrieve
artifacts has been modified to base its up to date comparison on these hash
sums rather than the timestamp of the file. 

 

This will clear up the issues we were having with rolling
back versions. 

 

I’ll backport it once it proves stable. 

 

Ruel Loehr

JBoss QA

 

-

512-342-7840 ext 2011

Yahoo: ruelloehr

Skype: ruelloehr

AOL: dokoruel

 








[JBoss-dev] jboss-seam-testsuite Build Completed With Testsuite Errors

2006-04-12 Thread qa

View results here -> http://cruisecontrol.jboss.com/cc/buildresults/jboss-seam-testsuite?log=log20060412083414
TESTS FAILEDAnt Error Message: /services/cruisecontrol/work/scripts/build-jboss-seam-testsuite.xml:132: The following error occurred while executing this line: /services/cruisecontrol/work/scripts/build-common-targets.xml:11: Build Successful - Tests completed with errors or failures.Date of build: 04/12/2006 08:34:14Time to build: 3 minutes 6 secondsLast changed: 04/11/2006 17:46:34Last log entry: oops




    Unit Tests: (15)    Total Errors and Failures: (1)testValidationInterceptor.Core 
 Modifications since last build: (first 50 of 6)1.13modifiedgavinsrc/main/org/jboss/seam/interceptors/ValidationInterceptor.javaoops1.9modifiedgavinsrc/main/org/jboss/seam/core/FacesMessages.javaoops1.12modifiedgavinexamples/booking/src/org/jboss/seam/example/booking/ChangePasswordAction.javaminor improv1.11modifiedgavinexamples/booking/src/org/jboss/seam/example/booking/RegisterAction.javaminor improv1.12modifiedgavinsrc/main/org/jboss/seam/interceptors/ValidationInterceptor.javasupport component ids in FacesMessages1.8modifiedgavinsrc/main/org/jboss/seam/core/FacesMessages.javasupport component ids in FacesMessages



[JBoss-dev] jboss-remoting-testsuite-1.5 Build Completed With Testsuite Errors

2006-04-12 Thread qa

View results here -> http://cruisecontrol.jboss.com/cc/buildresults/jboss-remoting-testsuite-1.5?log=log20060412055315
TESTS FAILEDAnt Error Message: /services/cruisecontrol/work/scripts/build-jboss-remoting.xml:96: The following error occurred while executing this line: /services/cruisecontrol/work/scripts/build-common-targets.xml:11: Build Successful - Tests completed with errors or failures.Date of build: 04/12/2006 05:53:15Time to build: 108 minutes 18 secondsLast changed: 12/31/2005 20:37:24Last log entry: JBREM-272:Added tests for (clientPool != null) and (threadPool != null) in cleanup.




    Unit Tests: (350)    Total Errors and Failures: (23)testStartorg.jboss.test.remoting.callback.pull.memory.callbackstore.CallbackStoreCallbackTestCase(java_serialization)testStartorg.jboss.test.remoting.callback.pull.memory.callbackstore.CallbackStoreCallbackTestCase(jboss_serialization)testStartorg.jboss.test.remoting.transport.multiplex.BasicServerSocketTestCase(java_serialization)testStartorg.jboss.test.remoting.transport.multiplex.BasicServerSocketTestCase(jboss_serialization)testStartorg.jboss.test.remoting.versioning.transport.http.VersionHTTPInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.http.VersionHTTPInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.http.VersionHTTPInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.http.VersionHTTPInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.http.VersionHTTPInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.multiplex.VersionMultiplexInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.multiplex.VersionMultiplexInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.multiplex.VersionMultiplexInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.multiplex.VersionMultiplexInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.rmi.VersionRMIInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.rmi.VersionRMIInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.rmi.VersionRMIInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.rmi.VersionRMIInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.rmi.VersionRMIInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.socket.VersionSocketInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.socket.VersionSocketInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.socket.VersionSocketInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.socket.VersionSocketInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.socket.VersionSocketInvokerTestCase 
 Modifications since last build: (first 50 of 2359)1.3modifiedtelrodsrc/tests/org/jboss/test/remoting/transport/socket/timeout/TimeoutClientTest.javaJBREM-235 - added new lgpl headers.1.3modifiedtelrodsrc/tests/org/jboss/test/remoting/transport/socket/timeout/TimeoutServerTest.javaJBREM-235 - added new lgpl headers.1.2modifiedtelrodsrc/tests/org/jboss/test/remoting/transport/socket/timeout/TimeoutTestCase.javaJBREM-235 - added new lgpl headers.1.3modifiedtelrodsrc/tests/org/jboss/test/remoting/transport/web/ComplexObject.javaJBREM-235 - added new lgpl headers.1.4modifiedtelrodsrc/tests/org/jboss/test/remoting/transport/web/WebInvocationHandler.javaJBREM-235 - added new lgpl headers.1.6modifiedtelrodsrc/tests/org/jboss/test/remoting/transport/web/WebInvokerTestClient.javaJBREM-235 - added new lgpl headers.1.2modifiedtelrodsrc/tests/org/jboss/test/remoting/transporter/TestClient.javaJBREM-235 - added new lgpl headers.1.2modifiedtelrodsrc/tests/org/jboss/test/remoting/transporter/TestServer.javaJBREM-235 - added new lgpl headers.1.2modifiedtelrodsrc/tests/org/jboss/test/remoting/transporter/TestServerImpl.javaJBREM-235 - added new lgpl headers.1.2modifiedtelrodsrc/tests/org/jboss/test/remoting/transporter/TransporterTestCase.javaJBREM-235 - added new lgpl headers.1.5modifiedtelrodsrc/tests/org/jboss/test/remoting/transport/socket/ssl/custom/InvokerTestCase.javabranches:  1.5.4;JBREM-235 - added new lgpl headers.1.2modifiedtelrodsrc/tests/org/jboss/test/remoting/transport/socket/ssl/test/SSLSimpleClient.javaJBREM-235 - added new lgpl headers.1.3modifiedtelrodsrc/tests/org/jboss/test/remoting/transport/socket/ssl/test/SSLSimpleServer.javaJBREM-235 - added new lgpl headers.1.6modifiedtelrodsrc/tests/org/jboss/test/remoting/transport/socket/timeout/keepalive/TimeoutClientTest.javaJBREM-235 - added new lgpl headers.1.6modifiedtelrodsrc/tests/org/jboss/test/remoting/transport/socket/timeout/keepalive/TimeoutServerTest.javaJBREM-235 - added new lgpl headers.1.5modifiedtelrodsrc/tests/org/jboss/test/remoting/transport/web/WebInvokerTestClient.javaJBREM-253 - changed to use coyote connector by default instead

[JBoss-dev] jboss-remoting-testsuite-1.4 Build Completed With Testsuite Errors

2006-04-12 Thread qa

View results here -> http://cruisecontrol.jboss.com/cc/buildresults/jboss-remoting-testsuite-1.4?log=log20060412043356
TESTS FAILEDAnt Error Message: /services/cruisecontrol/work/scripts/build-jboss-remoting.xml:96: The following error occurred while executing this line: /services/cruisecontrol/work/scripts/build-common-targets.xml:11: Build Successful - Tests completed with errors or failures.Date of build: 04/12/2006 04:33:56Time to build: 44 minutes 35 secondsLast changed: 04/08/2006 00:16:05Last log entry: JBREM-367 - fixed bug where server socket factory would not get set via bean property for microcontainer because server invoker does not exist as reference till Connector's create() method is called.




    Unit Tests: (183)    Total Errors and Failures: (20)testStartorg.jboss.test.remoting.transport.multiplex.BasicServerSocketTestCase(java_serialization)testStartorg.jboss.test.remoting.versioning.transport.http.VersionHTTPInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.http.VersionHTTPInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.http.VersionHTTPInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.http.VersionHTTPInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.http.VersionHTTPInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.multiplex.VersionMultiplexInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.multiplex.VersionMultiplexInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.multiplex.VersionMultiplexInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.multiplex.VersionMultiplexInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.rmi.VersionRMIInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.rmi.VersionRMIInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.rmi.VersionRMIInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.rmi.VersionRMIInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.rmi.VersionRMIInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.socket.VersionSocketInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.socket.VersionSocketInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.socket.VersionSocketInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.socket.VersionSocketInvokerTestCasetestStartorg.jboss.test.remoting.versioning.transport.socket.VersionSocketInvokerTestCase 
 Modifications since last build: (first 50 of 108)1.6modifiedtelrodsrc/tests/org/jboss/test/remoting/transport/web/WebInvocationHandler.javaJBREM-365 - adding remoting user agent to header of http client invoker requests.1.7modifiedtelrodsrc/tests/org/jboss/test/remoting/transport/web/WebInvokerTestClient.javaJBREM-365 - adding remoting user agent to header of http client invoker requests.1.5modifiedtelrodsrc/tests/org/jboss/test/remoting/connection/ConnectionValidatorClient.javaJBREM-380 - changed connector validator to only notifiy once of connection being lost.1.5modifiedtelrodsrc/tests/org/jboss/test/remoting/lease/LeaseUnitTestCase.javaJBREM-408 - fixed bug for lease update changing lease window by mistake.1.3modifiedtelrodsrc/tests/org/jboss/test/remoting/locator/InvokerLocatorTestCase.javaJBREM-406 - allow for : in the locator uri path1.1addedtelrodsrc/tests/org/jboss/test/remoting/detection/multicast/MulticastDetectorTestCase.javaJBREM-405 - fix for NPE when calling stop() more than once on multicast detector.1.2modifiedrsigalsrc/tests/org/jboss/test/remoting/transport/multiplex/ssl/.keystore.keystore and .truststore need to be in test src directory so they can get copied to test output directory.1.2modifiedrsigalsrc/tests/org/jboss/test/remoting/transport/multiplex/ssl/.truststore.keystore and .truststore need to be in test src directory so they can get copied to test output directory.1.3modifiedtimfoxsrc/main/org/jboss/remoting/util/TimerUtil.javaFixes to Connection pinging and leasing1.4modifiedtelrodsrc/tests/org/jboss/test/remoting/connection/ConnectionValidationServer.javaJBREM-378 - fixed client connection ping so will properly indicate if server is dead and also not activate a new lease on the server side.1.4modifiedtelrodsrc/tests/org/jboss/test/remoting/connection/ConnectionValidatorClient.javaJBREM-378 - fixed client connection ping so will properly indicate if server is dead and also not activate a new lease on the server side.1.4modifiedtelrodsrc/tests/org/jboss/test/remoting/lease/LeaseUnitTestCase.javaJBREM-374 - updated to use singleton like approach to allow for only one timer thread for leasing.1.2modifiedtelrodsrc/main/org/jboss/remoting/util/TimerUtil.javaJBREM-374 - updated to use singleton like approach to allow for only one timer thread for leasing.1.3modifiedtelrodsrc/tests/org/jb

[JBoss-dev] jboss-cache-testsuite Build Completed With Testsuite Errors

2006-04-12 Thread qa

View results here -> http://cruisecontrol.jboss.com/cc/buildresults/jboss-cache-testsuite?log=log20060412035420
TESTS FAILEDAnt Error Message: /services/cruisecontrol/work/scripts/build-JBossCache.xml:86: The following error occurred while executing this line: /services/cruisecontrol/work/scripts/build-common-targets.xml:11: Build Successful - Tests completed with errors or failures.Date of build: 04/12/2006 03:54:20Time to build: 36 minutes 37 secondsLast changed: 04/11/2006 23:28:35Last log entry: Minor comments.




    Unit Tests: (1495)    Total Errors and Failures: (10)testCallRemoteMethodsMethodCallRemoteorg.jboss.cache.rpc.RpcTreeCacheFunctionalTesttestUpdateEvictionorg.jboss.cache.aop.eviction.AopLRUPolicyUpdateEvictionTesttestPutObjectGraphAndEvictorg.jboss.cache.aop.eviction.PojoEvictionTesttestLegacyPolicyConfigurationorg.jboss.cache.eviction.EvictionConfigurationTesttestEvictionorg.jboss.cache.eviction.ReplicatedAopLRUPolicyTesttestEvictionReplicationorg.jboss.cache.eviction.ReplicatedAopLRUPolicyTesttestPojoEvictionorg.jboss.cache.eviction.ReplicatedAopLRUPolicyTesttestBadRpcHandlerNonLocalorg.jboss.cache.rpc.RpcTreeCacheFunctionalTesttestAsyncCallNonLocalorg.jboss.cache.rpc.RpcTreeCacheFunctionalTesttestExcludeSelfNonLocalorg.jboss.cache.rpc.RpcTreeCacheFunctionalTest 
 Modifications since last build: (first 50 of 238)1.4modifiedbwangtests/functional/org/jboss/cache/aop/eviction/PojoEvictionTest.javaComment1.3modifiedbwangtests/functional/org/jboss/cache/aop/eviction/PojoEvictionTest.javaMore tests1.2modifiedbwangtests/functional/org/jboss/cache/aop/eviction/PojoEvictionTest.javaTest for pojo eviction.1.1addedbwangtests/functional/org/jboss/cache/aop/eviction/PojoEvictionTest.javaTest for pojo eviction.1.4modifiedgenmantests/functional/org/jboss/cache/eviction/ReplicatedLRUPolicyTest.javaClean up tests and diagnostics; setUseMarshalling was not set on all nodesfor test;  add help binary dump to TreeCacheMarshaller1.7modifiedgenmantests/functional/org/jboss/cache/rpc/RpcTreeCacheFunctionalTest.javaClean up tests and diagnostics; setUseMarshalling was not set on all nodesfor test;  add help binary dump to TreeCacheMarshaller1.1addedbwangtests/functional/org/jboss/cache/aop/eviction/AopLRUPolicyTest.javaMoved aop eviction to its own dir.1.1addedbwangtests/functional/org/jboss/cache/aop/eviction/AopLRUPolicyUpdateEvictionTest.javaMoved aop eviction to its own dir.1.8deletedbwangtests/functional/org/jboss/cache/eviction/AopLRUPolicyTest.javaMoved aop eviction to its own dir.1.3deletedbwangtests/functional/org/jboss/cache/eviction/AopLRUPolicyUpdateEvictionTest.javaMoved aop eviction to its own dir.1.6modifiedgenmantests/functional/org/jboss/cache/optimistic/ComparatorTest.javaJBCACHE-555 -Remove non-working code from WorkspaceNodeImpl.getParentClean up OptimisticNodeInterceptor1.22modifiedgenmantests/functional/org/jboss/cache/loader/CacheLoaderTestsBase.javaJBCACHE-555 -Remove non-working code from WorkspaceNodeImpl.getParentClean up OptimisticNodeInterceptor1.3modifiedbwangtests/functional/org/jboss/cache/aop/util/ObjectUtilAopTest.javaJBCACHE-490 Created PojoCache class1.7modifiedbwangtests/functional/org/jboss/cache/eviction/AopLRUPolicyTest.javaJBCACHE-490 Created PojoCache class1.2modifiedbwangtests/functional/org/jboss/cache/eviction/AopLRUPolicyUpdateEvictionTest.javaJBCACHE-490 Created PojoCache class1.7modifiedbwangtests/functional/org/jboss/cache/loader/CacheLoaderManagerTest.javaJBCACHE-490 Created PojoCache class1.2modifiedbwangtests/perf/org/jboss/cache/aop/LocalMapPerfAopTest.javaJBCACHE-490 Created PojoCache class1.2modifiedbwangtests/perf/org/jboss/cache/aop/LocalPerfAopTest.javaJBCACHE-490 Created PojoCache class1.2modifiedbwangtests/perf/org/jboss/cache/aop/ReplicatedAsyncMapPerfAopTest.javaJBCACHE-490 Created PojoCache class1.2modifiedbwangtests/perf/org/jboss/cache/aop/ReplicatedSyncMapContentionAopTest.javaJBCACHE-490 Created PojoCache class1.2modifiedbwangtests/perf/org/jboss/cache/aop/ReplicatedSyncMapPerfAopTest.javaJBCACHE-490 Created PojoCache class1.2modifiedbwangtests/perf/org/jboss/cache/aop/ReplicatedSyncPerfAopTest.javaJBCACHE-490 Created PojoCache class1.2modifiedbwangtests/perf/org/jboss/cache/aop/Server.javaJBCACHE-490 Created PojoCache class1.2modifiedbwangtests/perf/org/jboss/cache/aop/StudentMetrics.javaJBCACHE-490 Created PojoCache class1.9modifiedbwangtests/functional/org/jboss/cache/aop/collection/CollectionAopTest.javaJBCACHE-490 Created PojoCache class1.7modifiedbwangtests/functional/org/jboss/cache/aop/collection/ObjectGraphAopTest.javaJBCACHE-490 Created PojoCache class1.2modifiedbwangtests/functional/org/jboss/cache/aop/collection/ReplicatedSyncListTest.javaJBCACHE-490 Created PojoCache class1.3modifiedbwangtests/functional/org/jboss/cache/aop/collection/ReplicatedSyncMapTest.javaJBCACHE-490 Created PojoCache class1.3modifiedbwangtests/functional/o

Re: [JBoss-dev] synchronization on non-final fields warning

2006-04-12 Thread Adrian Brock
Correct, if it did this instead:

public class JaasSecurityManager
{ 
   private CachePolicy domainCache;

   private Subject updateCache(Principal principal)
   {
  synchronized( domainCache )
  {
 domainCache = new CachePolicy();
 // stuff
  }
   }
}

Another thread can enter the synchronized block
because it will synchronize on a different object.

I'm not sure it is even determinate which
object it will synchronize on under the old
(pre Java5) memory model?
And probably only determinate on Java5 if you do
private volatile CachePolicy domainCache;

On Tue, 2006-04-11 at 23:51 -0500, Scott M Stark wrote:
> I'm trying to understand the full implication of the intellij
> synchronization on non-final fields warning, which has this description:
> 
> This inspection reports instances of synchronized statements where the
> lock expression is a non-final field. Such statements are unlikely to
> have useful semantics, as different threads may be locking on different
> objects even when operating on the same object.
> 
> An example usage is the following where a multiple operations on the
> domainCache variable is done in a synchronized block so that the
> remove/insert are atomic:
> 
> public class JaasSecurityManager
> { 
>private CachePolicy domainCache;
> 
>private Subject updateCache(Principal principal)
>{
>   synchronized( domainCache )
>   {
>  if( domainCache.peek(principal) != null )
> domainCache.remove(principal);
>  domainCache.insert(principal, info);
>   }
>}
> }
> 
> In going over the current memory model docs:
> http://www.cs.umd.edu/~pugh/java/memoryModel/
> http://gee.cs.oswego.edu/dl/jmm/cookbook.html
> http://www.cs.umd.edu/~pugh/java/memoryModel/jsr133.pdf
> 
> The only context I can see where this warning applies is if the
> domainCache variable is being changed. In that case two threads may
> actually be synchronizing/working on different objects, but that is fine
> in this case as the atomic block of ops only applies to the domainCache
> object. If other state was being referenced I can see a problem, but not
> for the illustrated usage.
> 
> Am I missing something here?
> 
> 
> Scott Stark
> VP Architecture & Technology
> JBoss Inc.
>  
>  
> 
> 
> ---
> This SF.Net email is sponsored by xPML, a groundbreaking scripting language
> that extends applications into web and mobile media. Attend the live webcast
> and join the prime developer group breaking into this new coding territory!
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid0944&bid$1720&dat1642
> ___
> JBoss-Development mailing list
> JBoss-Development@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/jboss-development
-- 

Adrian Brock
Chief Scientist
JBoss Inc.




---
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
___
JBoss-Development mailing list
JBoss-Development@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jboss-development