Re: [JBoss-dev] OBJECT_NAME rules
Hi
I think to add everywhere a DomainName to the ObjectNames of the MBeans
is a great idea. But please keep in mind that some MBean overwrite the given
ObjectName to enforce a particulare name (see preRegister()) methods.
On the other side not all MBeans should be added to JBOSS-SYSTEM because
the domain name is used to segment the JMX namespace. JBOSS-SYSTEM is
the default domain name meaning that a client does not have to know the
default
domain name to search for these MBeans. But when you want to create a
special
segement where it is necessary for a client to know the name and a grouping
is
appropriate then I think it is better to use a separate Domain Name.
Have fun - Andy
- Original Message -
From: "Guillaume Boissiere" <[EMAIL PROTECTED]>
To: "Andreas Schaefer" <[EMAIL PROTECTED]>;
<[EMAIL PROTECTED]>
Sent: Friday, November 02, 2001 8:31 PM
Subject: RE: [JBoss-dev] OBJECT_NAME rules
> Andy,
>
> Thanks for your quick response! Here is an updated patch that makes
> the naming more in line with the spec, by adding JBOSS-SYSTEM where
> it is missing in the code.
> Should make it easier to use the full Object Name capabilities in
> the future.
> Comments welcome,
>
> -- Guillaume
>
>
> diff -urN
> jboss/src/main/org/jboss/configuration/ConfigurationServiceMBean.java
> gb-jboss/src/main/org/jboss/configuration/ConfigurationServiceMBean.java
> --- jboss/src/main/org/jboss/configuration/ConfigurationServiceMBean.java
> Fri Aug 3 13:15:42 2001
> +++
gb-jboss/src/main/org/jboss/configuration/ConfigurationServiceMBean.java
> Fri Nov 2 23:03:50 2001
> @@ -19,7 +19,7 @@
> public interface ConfigurationServiceMBean
> {
> /** The default object name. */
> -public static final String OBJECT_NAME = ":service=Configuration";
> +public static final String OBJECT_NAME =
> "JBOSS-SYSTEM:service=Configuration";
>
> /**
> * Get the attribute value auto-trim flag.
> diff -urN jboss/src/main/org/jboss/deployment/AutoDeployerMBean.java
> gb-jboss/src/main/org/jboss/deployment/AutoDeployerMBean.java
> --- jboss/src/main/org/jboss/deployment/AutoDeployerMBean.java Wed Aug 29
> 18:52:05 2001
> +++ gb-jboss/src/main/org/jboss/deployment/AutoDeployerMBean.java Fri Nov
2
> 21:39:32 2001
> @@ -22,7 +22,7 @@
> extends ServiceMBean
> {
> /** The default object name. */
> - String OBJECT_NAME = "EJB:service=AutoDeployer";
> + public static final String OBJECT_NAME = "EJB:service=AutoDeployer";
>
> /**
> * Set the list of urls to watch.
> diff -urN jboss/src/main/org/jboss/deployment/J2eeDeployer.java
> gb-jboss/src/main/org/jboss/deployment/J2eeDeployer.java
> --- jboss/src/main/org/jboss/deployment/J2eeDeployer.java Mon Oct 8
> 03:03:49 2001
> +++ gb-jboss/src/main/org/jboss/deployment/J2eeDeployer.java Fri Nov 2
> 23:06:23 2001
> @@ -81,11 +81,11 @@
> // Constants -
> public File DEPLOYMENT_DIR = null;//"/home/deployment"; // default?
> MUST BE ABSOLUTE PATH!!!
> public static String CONFIG = "deployment.cfg";
> -final public static String DEFAULT_NAME="Default";
> -final public static String
> DEFAULT_JAR_DEPLOYER_NAME="EJB:service=ContainerFactory";
> -final public static String
> DEFAULT_WAR_DEPLOYER_NAME=":service=EmbeddedTomcat";
> -final public static String
> DEFAULT_RAR_DEPLOYER_NAME=":service=RarDeployer";
> -final public static String
> DEFAULT_JAVA_DEPLOYER_NAME=":service=JavaDeployer";
> +public static final String DEFAULT_NAME="Default";
> +public static final String
> DEFAULT_JAR_DEPLOYER_NAME="EJB:service=ContainerFactory";
> +public static final String
> DEFAULT_WAR_DEPLOYER_NAME="EJB:service=EmbeddedTomcat";
> +public static final String
> DEFAULT_RAR_DEPLOYER_NAME="EJB:service=RarDeployer";
> +public static final String
> DEFAULT_JAVA_DEPLOYER_NAME="EJB:service=JavaDeployer";
>
> public static final int EASY = 0;
> public static final int RESTRICTIVE = 1;
> diff -urN jboss/src/main/org/jboss/ejb/ContainerFactoryMBean.java
> gb-jboss/src/main/org/jboss/ejb/ContainerFactoryMBean.java
> --- jboss/src/main/org/jboss/ejb/ContainerFactoryMBean.java Wed Aug 29
> 23:10:02 2001
> +++ gb-jboss/src/main/org/jboss/ejb/ContainerFactoryMBean.java Fri Nov 2
> 23:07:46 2001
> @@ -25,7 +25,7 @@
> extends ServiceMBean
> {
> /** The default object name. */
> - String OBJECT_NAME = ":service=ContainerFactory";
> + public static final String OBJECT_NAME =
> "JBOSS-S
RE: [JBoss-dev] OBJECT_NAME rules
@@ -28,7 +28,7 @@
*/
public class FileURLPatch implements FileURLPatchMBean, MBeanRegistration {
- public static final String OBJECT_NAME= ":service=FileURLPatch";
+ public static final String OBJECT_NAME=
"JBOSS-SYSTEM:service=FileURLPatch";
Category log= Category.getInstance(FileURLPatch.class);
private CustomURLStreamHandlerFactory customURLStreamHandlerFactory= new
CustomURLStreamHandlerFactory();
private boolean enabled= false;
diff -urN jboss/src/main/org/jboss/util/Info.java
gb-jboss/src/main/org/jboss/util/Info.java
--- jboss/src/main/org/jboss/util/Info.java Fri Aug 3 13:15:57 2001
+++ gb-jboss/src/main/org/jboss/util/Info.java Fri Nov 2 23:18:42 2001
@@ -28,7 +28,7 @@
{
// Constants -
- public static final String OBJECT_NAME= ":service=Info";
+ public static final String OBJECT_NAME= "JBOSS-SYSTEM:service=Info";
// Attributes
diff -urN jboss/src/main/org/jboss/web/WebServiceMBean.java
gb-jboss/src/main/org/jboss/web/WebServiceMBean.java
--- jboss/src/main/org/jboss/web/WebServiceMBean.java Thu Aug 30 00:13:42
2001
+++ gb-jboss/src/main/org/jboss/web/WebServiceMBean.javaFri Nov 2 23:19:07
2001
@@ -19,7 +19,7 @@
extends org.jboss.system.ServiceMBean
{
// Constants -
- public static final String OBJECT_NAME = ":service=Webserver";
+ public static final String OBJECT_NAME =
"JBOSS-SYSTEM:service=Webserver";
// Public
public URL addClassLoader(ClassLoader cl);
> -Original Message-
> From: Andreas Schaefer [mailto:[EMAIL PROTECTED]]
> Sent: Friday, November 02, 2001 10:36 PM
> To: Guillaume Boissiere; [EMAIL PROTECTED]
> Subject: Re: [JBoss-dev] OBJECT_NAME rules
>
>
> Hi
>
> Your are right but Object Names rules are:
> :[=],...
>
> Right now JBoss does not use the Object Name capabilities fully
> one part you can see this is in the J2eeDeployer and WebDeployer.
> There we could create the WebDeployer service like this:
> JBOSS-SYSTEM:service=deployer,type=web,vendor=jetty
>
> This would enable use to skip to specify the WebDeployer name
> in the J2eeDeployer but instead the J2eeDeployer could search
> for a service with:
> JBOSS-SYSTEM:service=deployer,typ=web
> and whatever vendor the web deployer service provides does
> not matter.
>
> The Object names with no Domain Name is the worst because in
> JMX-RI is a big bug not able to find this MBean even it does allow
> the MBean to be registered with its name.
>
> Have fun - Andy
___
Jboss-development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] OBJECT_NAME rules
Hi
Your are right but Object Names rules are:
:[=],...
Right now JBoss does not use the Object Name capabilities fully
one part you can see this is in the J2eeDeployer and WebDeployer.
There we could create the WebDeployer service like this:
JBOSS-SYSTEM:service=deployer,type=web,vendor=jetty
This would enable use to skip to specify the WebDeployer name
in the J2eeDeployer but instead the J2eeDeployer could search
for a service with:
JBOSS-SYSTEM:service=deployer,typ=web
and whatever vendor the web deployer service provides does
not matter.
The Object names with no Domain Name is the worst because in
JMX-RI is a big bug not able to find this MBean even it does allow
the MBean to be registered with its name.
Have fun - Andy
- Original Message -
From: "Guillaume Boissiere" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Friday, November 02, 2001 7:07 PM
Subject: [JBoss-dev] OBJECT_NAME rules
> Perusing through the code, I saw the following variations for the service
> names of MBeans in JBoss:
>
> - no prefix, i.e ":service=Mail"
> - EJB prefix, i.e "EJB:service="
> - JBOSS-SYSTEM prefix i.e "JBOSS-SYSTEM:service=Info"
> - J2EE prefix i.e "J2EE:service=J2eeDeployer"
>
> Are there any specific rules for the naming? If so, what are they?
>
> Also I noticed that a couple of the MBeans had the OBJECT_NAME variable
not
> declared as public static final. Simple patch below.
>
> -- Guillaume
>
>
>
> diff -urN jboss/src/main/org/jboss/deployment/AutoDeployerMBean.java
> gb-jboss/src/main/org/jboss/deployment/AutoDeployerMBean.java
> --- jboss/src/main/org/jboss/deployment/AutoDeployerMBean.java Wed Aug 29
> 18:52:05 2001
> +++ gb-jboss/src/main/org/jboss/deployment/AutoDeployerMBean.java Fri Nov
2
> 21:39:32 2001
> @@ -22,7 +22,7 @@
> extends ServiceMBean
> {
> /** The default object name. */
> - String OBJECT_NAME = "EJB:service=AutoDeployer";
> + public static final String OBJECT_NAME = "EJB:service=AutoDeployer";
>
> /**
> * Set the list of urls to watch.
> diff -urN jboss/src/main/org/jboss/ejb/ContainerFactoryMBean.java
> gb-jboss/src/main/org/jboss/ejb/ContainerFactoryMBean.java
> --- jboss/src/main/org/jboss/ejb/ContainerFactoryMBean.java Wed Aug 29
> 23:10:02 2001
> +++ gb-jboss/src/main/org/jboss/ejb/ContainerFactoryMBean.java Fri Nov 2
> 21:43:49 2001
> @@ -25,7 +25,7 @@
> extends ServiceMBean
> {
> /** The default object name. */
> - String OBJECT_NAME = ":service=ContainerFactory";
> + public static final String OBJECT_NAME = ":service=ContainerFactory";
>
> /**
> * Returns the applications deployed by the container factory
> diff -urN
jboss/src/main/org/jboss/jms/asf/ServerSessionPoolLoaderMBean.java
> gb-jboss/src/main/org/jboss/jms/asf/ServerSessionPoolLoaderMBean.java
> --- jboss/src/main/org/jboss/jms/asf/ServerSessionPoolLoaderMBean.java Wed
> Aug 29 23:10:54 2001
> +++ gb-jboss/src/main/org/jboss/jms/asf/ServerSessionPoolLoaderMBean.java
> Fri Nov 2 21:45:48 2001
> @@ -31,7 +31,7 @@
> extends ServiceMBean
> {
> /** The default MBean object name. */
> - String OBJECT_NAME = ":service=ServerSessionPoolMBean";
> + public static final String OBJECT_NAME =
> ":service=ServerSessionPoolLoader";
>
> /**
> * Set the pool name.
> diff -urN jboss/src/main/org/jboss/system/FarmAutoDeployerMBean.java
> gb-jboss/src/main/org/jboss/system/FarmAutoDeployerMBean.java
> --- jboss/src/main/org/jboss/system/FarmAutoDeployerMBean.java Sat Oct 20
> 00:24:23 2001
> +++ gb-jboss/src/main/org/jboss/system/FarmAutoDeployerMBean.java Fri Nov
2
> 21:47:42 2001
> @@ -22,7 +22,7 @@
> extends ServiceMBean
> {
> /** The default object name. */
> - String OBJECT_NAME = "EJB:service=AutoDeployer";
> + public static final String OBJECT_NAME = "EJB:service=AutoDeployer";
>
> /**
> * Set the list of urls to watch.
> diff -urN jboss/src/main/org/jboss/system/InfoMBean.java
> gb-jboss/src/main/org/jboss/system/InfoMBean.java
> --- jboss/src/main/org/jboss/system/InfoMBean.java Fri Sep 7 20:53:56
2001
> +++ gb-jboss/src/main/org/jboss/system/InfoMBean.java Fri Nov 2 21:49:25
> 2001
> @@ -17,7 +17,7 @@
> */
> public interface InfoMBean
> {
> - String OBJECT_NAME = "JBOSS-SYSTEM:service=Info";
> + public static final String OBJECT_NAME = "JBOSS-SYSTEM:service=Info";
>
> String listMemoryUsage();
> String listSystemInfo();
> diff -urN jboss/src/main/org/jboss/system/ServiceLibrariesMBean.java
> gb-jboss/src/main/org/jboss/system/ServiceLibrariesMBean.java
> --- jboss/src
[JBoss-dev] OBJECT_NAME rules
Perusing through the code, I saw the following variations for the service
names of MBeans in JBoss:
- no prefix, i.e ":service=Mail"
- EJB prefix, i.e "EJB:service="
- JBOSS-SYSTEM prefix i.e "JBOSS-SYSTEM:service=Info"
- J2EE prefix i.e "J2EE:service=J2eeDeployer"
Are there any specific rules for the naming? If so, what are they?
Also I noticed that a couple of the MBeans had the OBJECT_NAME variable not
declared as public static final. Simple patch below.
-- Guillaume
diff -urN jboss/src/main/org/jboss/deployment/AutoDeployerMBean.java
gb-jboss/src/main/org/jboss/deployment/AutoDeployerMBean.java
--- jboss/src/main/org/jboss/deployment/AutoDeployerMBean.java Wed Aug 29
18:52:05 2001
+++ gb-jboss/src/main/org/jboss/deployment/AutoDeployerMBean.java Fri Nov 2
21:39:32 2001
@@ -22,7 +22,7 @@
extends ServiceMBean
{
/** The default object name. */
- String OBJECT_NAME = "EJB:service=AutoDeployer";
+ public static final String OBJECT_NAME = "EJB:service=AutoDeployer";
/**
* Set the list of urls to watch.
diff -urN jboss/src/main/org/jboss/ejb/ContainerFactoryMBean.java
gb-jboss/src/main/org/jboss/ejb/ContainerFactoryMBean.java
--- jboss/src/main/org/jboss/ejb/ContainerFactoryMBean.java Wed Aug 29
23:10:02 2001
+++ gb-jboss/src/main/org/jboss/ejb/ContainerFactoryMBean.java Fri Nov 2
21:43:49 2001
@@ -25,7 +25,7 @@
extends ServiceMBean
{
/** The default object name. */
- String OBJECT_NAME = ":service=ContainerFactory";
+ public static final String OBJECT_NAME = ":service=ContainerFactory";
/**
* Returns the applications deployed by the container factory
diff -urN jboss/src/main/org/jboss/jms/asf/ServerSessionPoolLoaderMBean.java
gb-jboss/src/main/org/jboss/jms/asf/ServerSessionPoolLoaderMBean.java
--- jboss/src/main/org/jboss/jms/asf/ServerSessionPoolLoaderMBean.java Wed
Aug 29 23:10:54 2001
+++ gb-jboss/src/main/org/jboss/jms/asf/ServerSessionPoolLoaderMBean.java
Fri Nov 2 21:45:48 2001
@@ -31,7 +31,7 @@
extends ServiceMBean
{
/** The default MBean object name. */
- String OBJECT_NAME = ":service=ServerSessionPoolMBean";
+ public static final String OBJECT_NAME =
":service=ServerSessionPoolLoader";
/**
* Set the pool name.
diff -urN jboss/src/main/org/jboss/system/FarmAutoDeployerMBean.java
gb-jboss/src/main/org/jboss/system/FarmAutoDeployerMBean.java
--- jboss/src/main/org/jboss/system/FarmAutoDeployerMBean.java Sat Oct 20
00:24:23 2001
+++ gb-jboss/src/main/org/jboss/system/FarmAutoDeployerMBean.java Fri Nov 2
21:47:42 2001
@@ -22,7 +22,7 @@
extends ServiceMBean
{
/** The default object name. */
- String OBJECT_NAME = "EJB:service=AutoDeployer";
+ public static final String OBJECT_NAME = "EJB:service=AutoDeployer";
/**
* Set the list of urls to watch.
diff -urN jboss/src/main/org/jboss/system/InfoMBean.java
gb-jboss/src/main/org/jboss/system/InfoMBean.java
--- jboss/src/main/org/jboss/system/InfoMBean.java Fri Sep 7 20:53:56 2001
+++ gb-jboss/src/main/org/jboss/system/InfoMBean.java Fri Nov 2 21:49:25
2001
@@ -17,7 +17,7 @@
*/
public interface InfoMBean
{
- String OBJECT_NAME = "JBOSS-SYSTEM:service=Info";
+ public static final String OBJECT_NAME = "JBOSS-SYSTEM:service=Info";
String listMemoryUsage();
String listSystemInfo();
diff -urN jboss/src/main/org/jboss/system/ServiceLibrariesMBean.java
gb-jboss/src/main/org/jboss/system/ServiceLibrariesMBean.java
--- jboss/src/main/org/jboss/system/ServiceLibrariesMBean.java Fri Sep 7
20:53:57 2001
+++ gb-jboss/src/main/org/jboss/system/ServiceLibrariesMBean.java Fri Nov 2
21:49:26 2001
@@ -22,7 +22,7 @@
*/
public interface ServiceLibrariesMBean
{
- String OBJECT_NAME = "JBOSS-SYSTEM:service=Libraries";
+ public static final String OBJECT_NAME =
"JBOSS-SYSTEM:service=Libraries";
// The ServicesLibraries MBean should expose "soft" information like
// the dependencies graph
___
Jboss-development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development
