[JBoss-dev] RE: concurrent-testsuite Build Completed With Testsuite Errors

2006-03-18 Thread Scott M Stark 



The check on the two AccessControlContexts in 
ExecutorsTest.testPrivilegedThreadFactory is flawed because in order for the 
ACCs to be equal, they have to have the same protection domains. This is false 
because of how we have the unit test classes seperated from the core concurrent 
classes. The test ACC has an extra ProtectionDomain for the output/test-classes 
codebase. In general equality of ACCs is meaningless. What matters is whether 
they imply the same set of permissions. I'm going to comment out the ACC check 
for now with a todo on checking some "interesting" 
permissions.

val$thisacc: java.security.AccessControlContext = [EMAIL PROTECTED]}context: 
java.security.ProtectionDomain[] = 
[EMAIL PROTECTED][0] = [EMAIL PROTECTED]"ProtectionDomain 
(file:/C:/cvs/JBossHead/concurrent/output/test-classes/ no 
certificates)\n [EMAIL PROTECTED] 
no principals\n [EMAIL PROTECTED] 
(\n (java.lang.RuntimePermission stopThread)\n (java.lang.RuntimePermission 
exitVM)\n (java.net.SocketPermission localhost:1024- listen,resolve)\n 
(java.io.FilePermission \\C:\\cvs\\JBossHead\\concurrent\\output\\test-classes\\- 
read)\n (java.util.PropertyPermission java.version read)\n 
(java.util.PropertyPermission java.vm.name read)\n (java.util.PropertyPermission 
java.vm.vendor read)\n (java.util.PropertyPermission os.name read)\n 
(java.util.PropertyPermission java.vendor.url read)\n 
(java.util.PropertyPermission java.vm.specification.vendor read)\n 
(java.util.PropertyPermission java.specification.vendor read)\n 
(java.util.PropertyPermission os.version read)\n (java.util.PropertyPermission 
java.specification.name read)\n (java.util.PropertyPermission java.class.version 
read)\n (java.util.PropertyPermission file.separator read)\n 
(java.util.PropertyPermission java.vm.version read)\n 
(java.util.PropertyPermission os.arch read)\n (java.util.PropertyPermission 
java.vm.specification.name read)\n (java.util.PropertyPermission 
java.vm.specification.version read)\n (java.util.PropertyPermission 
java.specification.version read)\n (java.util.PropertyPermission java.vendor 
read)\n (java.util.PropertyPermission path.separator read)\n 
(java.util.PropertyPermission line.separator read)\n)\n\n"[1] = [EMAIL PROTECTED]"ProtectionDomain 
(file:/C:/cvs/JBossHead/concurrent/thirdparty/junit/lib/junit.jar no 
certificates)\n [EMAIL PROTECTED] 
no principals\n [EMAIL PROTECTED] 
(\n (java.lang.RuntimePermission stopThread)\n (java.lang.RuntimePermission 
exitVM)\n (java.net.SocketPermission localhost:1024- listen,resolve)\n 
(java.io.FilePermission \\C:\\cvs\\JBossHead\\concurrent\\thirdparty\\junit\\lib\\junit.jar 
read)\n (java.util.PropertyPermission java.version read)\n 
(java.util.PropertyPermission java.vm.name read)\n (java.util.PropertyPermission 
java.vm.vendor read)\n (java.util.PropertyPermission os.name read)\n 
(java.util.PropertyPermission java.vendor.url read)\n 
(java.util.PropertyPermission java.vm.specification.vendor read)\n 
(java.util.PropertyPermission java.specification.vendor read)\n 
(java.util.PropertyPermission os.version read)\n (java.util.PropertyPermission 
java.specification.name read)\n (java.util.PropertyPermission java.class.version 
read)\n (java.util.PropertyPermission file.separator read)\n 
(java.util.PropertyPermission java.vm.version read)\n 
(java.util.PropertyPermission os.arch read)\n (java.util.PropertyPermission 
java.vm.specification.name read)\n (java.util.PropertyPermission 
java.vm.specification.version read)\n (java.util.PropertyPermission 
java.specification.version read)\n (java.util.PropertyPermission java.vendor 
read)\n (java.util.PropertyPermission path.separator read)\n 
(java.util.PropertyPermission line.separator read)\n)\n\n"[2] = [EMAIL PROTECTED]"ProtectionDomain 
(file:/C:/Program%20Files/JetBrains/IntelliJ%20IDEA%205.0/lib/idea_rt.jar no 
certificates)\n [EMAIL PROTECTED] 
no principals\n [EMAIL PROTECTED] 
(\n (java.lang.RuntimePermission stopThread)\n (java.lang.RuntimePermission 
exitVM)\n (java.net.SocketPermission localhost:1024- listen,resolve)\n 
(java.io.FilePermission \\C:\\Program 
Files\\JetBrains\\IntelliJ IDEA 5.0\\lib\\idea_rt.jar read)\n 
(java.util.PropertyPermission java.version read)\n (java.util.PropertyPermission 
java.vm.name read)\n (java.util.PropertyPermission java.vm.vendor read)\n 
(java.util.PropertyPermission os.name read)\n (java.util.PropertyPermission 
java.vendor.url read)\n (java.util.PropertyPermission 
java.vm.specification.vendor read)\n (java.util.PropertyPermission 
java.specification.vendor read)\n (java.util.PropertyPermission os.version 
read)\n (java.util.PropertyPermission java.specification.name read)\n 
(java.util.PropertyPermission java.class.version read)\n 
(java.util.PropertyPermission file.separator read)\n 
(java.util.PropertyPermission java.vm.version read)\n 
(java.util.PropertyPermission os.arch read)\n (java.util.PropertyPermission 
java.vm.specification.name read)\n (java.util.PropertyPermission

[JBoss-dev] Re: concurrent-testsuite Build Completed With Testsuite Errors

2006-02-13 Thread Adrian Brock 
This test is failing because it makes an invalid assumption.

That is that a privileged block will run with exactly the instance
of the access control context you pass it.

This is not true because it can do things with the domain combiner
to create a new equivalent access control context.

Strangely, it only appears to fail when running it from junit
inside ant. If I run the test indivudually from eclipse, 
it doesn't go through domain combination?

Should I just disable the test. A better test would be to check
whether the scheduled operation can perform some 
expected privileged action (like retrieve a system property).

On Sun, 2006-02-12 at 19:15, [EMAIL PROTECTED] wrote:
 View results here -
 http://cruisecontrol.jboss.com/cc/buildresults/concurrent-testsuite?log=log20060212190745
 
 TESTS FAILED
 Ant Error
 Message: 
 /services/cruisecontrol/work/scripts/build-concurrent-testsuite.xml:73: The 
 following error occurred while executing this line: 
 /services/cruisecontrol/work/scripts/build-common-targets.xml:11: Build 
 Successful - Tests completed with errors or failures.
 Date of build: 02/12/2006 19:07:45
 Time to build: 7 minutes 27 seconds
 
   Unit Tests: (1707)  Total Errors and Failures: (1) 
 testPrivilegedThreadFactory
   .ExecutorsTest

 
  Modifications since last build:  (first 50 of 0) 
 
-- 
 
Adrian Brock
Chief Scientist
JBoss Inc.
 




---
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnkkid=103432bid=230486dat=121642
___
JBoss-Development mailing list
JBoss-Development@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jboss-development