[JBoss-user] [JBoss AOP] - Re: aopc: parallel compilation
There are only 9 pointcuts in total, of various complexity. There are method, constructor (both usual and caller-side) and field expressions. Of course, all 3K classes are inspected for pointcuts matching, but only a few of them (<10) actually match. So I think less than 100 classes are really changed. My patch adds "-threads" command line parameter (and ant task parameter as well), which allows to define number of threads to use. It defaults to 1 if not specified. In this case behaviour is almost the same as without the patch: Compiler runs one thread which instruments all classes, and waits for it's completion. Any exceptions generated by the thread are properly rethrown. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3933446#3933446 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3933446 --- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 ___ JBoss-user mailing list JBoss-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jboss-user
[JBoss-user] [JBoss AOP] - Re: aopc: parallel compilation
At compilation-time the main two factors are number of classes and number of pointcut expressions. The number of aspects is not relevant at this point. The "complexity" of pointcut expressions is important though, field() and constructor execution pointcuts have a higher overhead than method execution and construction pointcuts, since field and constructor execution needs to instrument all the callers to call the wrappers. Can the change be made pluggable, so that it runs if a system property is present? And if not present, it runs as before? View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3933431#3933431 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3933431 --- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 ___ JBoss-user mailing list JBoss-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jboss-user
[JBoss-user] [JBoss AOP] - Re: aopc: parallel compilation
I've uploaded one more patch. I was running patched version all day and observed only a couple of glitches which I couldn't reproduce again. So I think it basically works, but isn't production ready, someone must really review it. This time I made initial file scanning also parallel. As for your questions, I've added some debugging output, I think this numbers will answer you: anonymous wrote : | aopc-classes-only: | [echo] Instrumenting ../classes | [aopc] [aopc] Spawned scanner thread 1 | [aopc] Added 3190 classes in 23437ms | [aopc] [aopc] Spawned compiler thread 1 | [aopc] Compiled 3190 classes in 15245ms | [aopc] Build Successful: 39397 ms | | ... | | aopc-classes-only: | [echo] Instrumenting ../classes | [aopc] [aopc] Spawned scanner thread 1 | [aopc] [aopc] Spawned scanner thread 2 | [aopc] Added 3190 classes in 15966ms | [aopc] [aopc] Spawned compiler thread 1 | [aopc] [aopc] Spawned compiler thread 2 | [aopc] Compiled 3190 classes in 13772ms | [aopc] Build Successful: 30478 ms | There are a lot of classes but only a few aspects. Picture can probably change if number of aspects will increase. View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3933429#3933429 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3933429 --- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 ___ JBoss-user mailing list JBoss-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jboss-user
[JBoss-user] [JBoss AOP] - Re: aopc: parallel compilation
Many thanks, I will try to take a look, but not today :-) Out of curiosity, how many classes are you weaving? You mentioned 10-15 minutes for the weaving? How long does it take after this fix? View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3933366#3933366 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3933366 --- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 ___ JBoss-user mailing list JBoss-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jboss-user
[JBoss-user] [JBoss AOP] - Re: aopc: parallel compilation
Hi Kabir, I've attached another patch to the bugreport. Works for me this time, even with large amount of concurrent threads. Could you try to run JBossAOP tests suite against the patched version? View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3933203#3933203 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3933203 --- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 ___ JBoss-user mailing list JBoss-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jboss-user
[JBoss-user] [JBoss AOP] - Re: aopc: parallel compilation
OK, if you find it valuable I'll try to make it working when I'll have a bit of spare time :) View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3931340#3931340 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3931340 --- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 ___ JBoss-user mailing list JBoss-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jboss-user
[JBoss-user] [JBoss AOP] - Re: aopc: parallel compilation
Hi, I see you opened http://jira.jboss.com/jira/browse/JBAOP-215 ? Should this be closed s mentioned. If you get it to work on a lot of classes, by all means contribute it back. The main things slowing down compilation will be field and constructor interception since we need to find all classes calling the field. This can be speeded up by using a construction(POJO->new()) which just adds the magic at the end of the constructor rather than replacing all the callers. Also, you may want to look at using the jboss.aop.exclude and jboss.aop.include system properties http://docs.jboss.com/aop/1.3/aspect-framework/reference/en/html/running.html#d0e2923 By all means, if you find a way to make parallell compilation work we will be happy to accept your contribution :-) View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3931272#3931272 Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3931272 --- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 ___ JBoss-user mailing list JBoss-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jboss-user
