Re: CFV: New jdk8 Reviewer: Daniel Fuchs

[Paul Sandoz]

Vote: yes.

Paul.

Re: RFR: 8022746: List of spelling errors in API doc

[Alan Bateman]

On 23/10/2013 16:05, sergey malenkov wrote:



Could you please review the following huge fix:
fix:http://cr.openjdk.java.net/~malenkov/8022746.8.0/
bug:https://bugs.openjdk.java.net/browse/JDK-8022746

The second version of the fix is here:
http://cr.openjdk.java.net/~malenkov/8022746.8.1/ 


The word-diff for your convenience is here:
http://cr.openjdk.java.net/~malenkov/8022746.8.1/diff.html 

In src/share/sample/nio/chatserver/ClientReader.java then you've 
replaced "enqueing" with "inquiring". I assume you meant to change it to 
"enqueing".


-Alan

Re: RFR: 8026491: Typos in string literals

[sergey malenkov]

Hi Stuart,

I've attached a file with all typos which had been left after the fix.
There are no any occured in jdk/src.

Thanks,
SAM

On 31.10.2013 5:59, Stuart Marks wrote:

Perhaps Sergey can check.

I would have checked myself, but Sergey pushed his earlier fix to the 
AWT forest, and I don't think it's appeared in TL yet. I could have 
pulled over the AWT forest, but I have enough distractions as it stands.


Hm, maybe we need a new Friday Stats metric: the numbre of occurances 
of mispeled words.


s'marks


On 10/30/13 1:40 PM, Jonathan Gibbons wrote:

find/grep before and after?

-- Jon

On 10/30/2013 01:17 PM, Stuart Marks wrote:

The changes look good.

It looks like "occured" is the most common spelling error. I wonder 
how many
instances of this misspelling will remain in the codebase after your 
fixes.


s'marks

On 10/30/13 4:43 AM, sergey malenkov wrote:

Hello,

Could you please review the following fix:
fix:http://cr.openjdk.java.net/~malenkov/8026491.8.0/
bug:https://bugs.openjdk.java.net/browse/JDK-8026491

I've replaced all typos with correct words in all string literals.

This is a second part of the previous fix
(8022746: List of spelling errors in API doc).

Thanks,
SAM




# Thu Oct 31 13:19:39 RST 2013
# TYPO: accessable
bsd/doc/man/schemagen.1:If your java sources/classes reference other classes, 
they must be accessable on your system CLASSPATH environment variable, or they 
need to be given to the tool by using the \f2\-classpath\fP/\f2\-cp\fP options. 
Otherwise you will see errors when generating your schema.
linux/doc/man/schemagen.1:If your java sources/classes reference other classes, 
they must be accessable on your system CLASSPATH environment variable, or they 
need to be given to the tool by using the \f2\-classpath\fP/\f2\-cp\fP options. 
Otherwise you will see errors when generating your schema.
solaris/doc/sun/man/man1/schemagen.1:If your java sources/classes reference 
other classes, they must be accessable on your system CLASSPATH environment 
variable, or they need to be given to the tool by using the 
\f2\-classpath\fP/\f2\-cp\fP options. Otherwise you will see errors when 
generating your schema.
# TYPO: alnum
share/classes/java/util/regex/ASCII.java:static final int ALNUM   = 
(UPPER|LOWER|DIGIT);
share/classes/java/util/regex/ASCII.java:return isType(ch, ALNUM);
share/classes/java/util/regex/Pattern.java: * {@code \p{Alnum}}
share/classes/java/util/regex/Pattern.java: * A 
visible character: {@code [\p{Alnum}\p{Punct}]}
share/classes/java/util/regex/Pattern.java: * \p{Alnum}
share/classes/java/util/regex/Pattern.java:defCtype("Alnum", 
ASCII.ALNUM);  // Alphanumeric characters
share/classes/java/util/regex/UnicodeProp.java:ALNUM {
share/classes/java/util/regex/UnicodeProp.java:posix.put("ALNUM", 
"ALNUM");
share/classes/sun/text/normalizer/UCharacter.java: * - alnum: 
hasBinaryProperty(c, UProperty.POSIX_ALNUM)
share/classes/sun/util/locale/LocaleMatcher.java:String 
rangeForRegex = range.replaceAll("\\x2A", "p{Alnum}*");
# TYPO: anys
share/classes/sun/util/cldr/resources/21_0_1/common/main/ca.xml:
{0} anys
share/classes/sun/util/cldr/resources/21_0_1/common/main/ca.xml:
{0} anys
share/classes/sun/util/cldr/resources/21_0_1/common/main/ca.xml:
D'aquí a 0 anys
share/classes/sun/util/cldr/resources/21_0_1/common/main/ca.xml:
D'aquí a {0} anys
share/classes/sun/util/cldr/resources/21_0_1/common/main/ca.xml:
Fa 0 anys
share/classes/sun/util/cldr/resources/21_0_1/common/main/ca.xml:
Fa {0} anys
# TYPO: attibute
share/classes/sun/misc/ExtensionDependency.java: * @param extensionName key 
in the attibute list
# TYPO: attribut
share/classes/com/sun/java/swing/plaf/windows/resources/windows_sv.properties:FileChooser.fileAttrHeader.textAndMnemonic=Attribut
share/classes/com/sun/org/apache/xml/internal/security/resource/xmlsecurity_de.properties:signature.signaturePropertyHasNoTarget
 = Das Target Attribut der SignatureProperty muss gesetzt sein
share/classes/com/sun/swing/internal/plaf/metal/resources/metal_sv.properties:FileChooser.fileAttrHeader.textAndMnemonic=Attribut
share/classes/com/sun/swing/internal/plaf/synth/resources/synth_sv.properties:FileChooser.fileAttrHeader.textAndMnemonic=Attribut
share/classes/sun/applet/resources/MsgAppletViewer_de.java:
{"appletviewer.parse.warning.requiresname", "Warnung: F\u00FCr -Tag ist ein \"name\"-Attribut erforderlich."},
share/classes/sun/applet/resources/MsgAppletViewer_de.java:
{"appletviewer.parse.warning.applet.requirescode", "Warnung: F\u00FCr 
-Tag ist ein \"code\"-Attribut erforderlich."},
share/classes/sun/applet/resources/MsgAppletViewer_de.java:
{"appletviewer.parse.warning.applet.requiresheight", "Warnung: F\u00FCr 
-Tag ist ein \"height\"-Attribut erforderlich."},
share/cl

Result: New JDK 8 Reviewer: Bhavesh Patel

[Jonathan Gibbons]

Voting for Bhavesh Patel [1] is now closed.

Yes: 7
Veto: 0
Abstain: 0
Disqualified: 1 (not a Reviewer)

According to the Bylaws definition of Three-Vote Consensus, this is
sufficient to approve the nomination.

Jonathan Gibbons

[1] http://mail.openjdk.java.net/pipermail/jdk8-dev/2013-October/00.html

hg: jdk8/jdk8/hotspot: Added tag jdk8-b114 for changeset 7fd913010dbb

[christine . lu]

Changeset: ddc3758f68db
Author:cl
Date:  2013-10-31 12:36 -0700
URL:   http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/ddc3758f68db

Added tag jdk8-b114 for changeset 7fd913010dbb

! .hgtags

hg: jdk8/jdk8/jaxp: Added tag jdk8-b114 for changeset 1b1e12117fe2

[christine . lu]

Changeset: d3b6da1b3e25
Author:cl
Date:  2013-10-31 12:36 -0700
URL:   http://hg.openjdk.java.net/jdk8/jdk8/jaxp/rev/d3b6da1b3e25

Added tag jdk8-b114 for changeset 1b1e12117fe2

! .hgtags

hg: jdk8/jdk8/jaxws: Added tag jdk8-b114 for changeset 9ad289610fc6

[christine . lu]

Changeset: e126d8eca69b
Author:cl
Date:  2013-10-31 12:36 -0700
URL:   http://hg.openjdk.java.net/jdk8/jdk8/jaxws/rev/e126d8eca69b

Added tag jdk8-b114 for changeset 9ad289610fc6

! .hgtags

hg: jdk8/jdk8/jdk: Added tag jdk8-b114 for changeset f26a0c8071bd

[christine . lu]

Changeset: 62982664dc72
Author:cl
Date:  2013-10-31 12:36 -0700
URL:   http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/62982664dc72

Added tag jdk8-b114 for changeset f26a0c8071bd

! .hgtags

hg: jdk8/jdk8/nashorn: Added tag jdk8-b114 for changeset 79f7b79bf97b

[christine . lu]

Changeset: f109bb255b80
Author:cl
Date:  2013-10-31 12:36 -0700
URL:   http://hg.openjdk.java.net/jdk8/jdk8/nashorn/rev/f109bb255b80

Added tag jdk8-b114 for changeset 79f7b79bf97b

! .hgtags

hg: jdk8/jdk8/langtools: Added tag jdk8-b114 for changeset 850d2602ae98

[christine . lu]

Changeset: fea486d30d41
Author:cl
Date:  2013-10-31 12:36 -0700
URL:   http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/fea486d30d41

Added tag jdk8-b114 for changeset 850d2602ae98

! .hgtags

hg: jdk8/jdk8: Added tag jdk8-b114 for changeset 4f2011496393

[christine . lu]

Changeset: b65d48f6938a
Author:cl
Date:  2013-10-31 12:36 -0700
URL:   http://hg.openjdk.java.net/jdk8/jdk8/rev/b65d48f6938a

Added tag jdk8-b114 for changeset 4f2011496393

! .hgtags

hg: jdk8/jdk8/corba: Added tag jdk8-b114 for changeset 0bbccf77c23e

[christine . lu]

Changeset: d425685e0b74
Author:cl
Date:  2013-10-31 12:36 -0700
URL:   http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/d425685e0b74

Added tag jdk8-b114 for changeset 0bbccf77c23e

! .hgtags

[8]: revokeall.exe should be made executable on WXP/Cygwin

[Francis ANDRE]

Hi

the revokeall.exe is not executable on WXP/Cygwin which leads to the error

Z:/JDK/jdk8/jdk/test/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh: 
line 107: 
Z:/JDK/jdk8/jdk/test/sun/management/jmxremote/bootstrap/../../windows/revokeall.exe: 
Permission denied


Thus, I would suggest to add a chmod ug+x $REVOKEALL in 
GeneratePropertyPassword.sh

as

diff --git a/test/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh 
b/test/sun/manageme

nt/jmxremote/bootstrap/GeneratePropertyPassword.sh
--- a/test/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh
+++ b/test/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh
@@ -74,6 +74,7 @@
 echo "$REVOKEALL missing"
 exit 1
 fi
+chmod ug+x $REVOKEALL
 fi

Francis

Re: CFV: New jdk8 Reviewer: Daniel Fuchs

[Daniel D. Daugherty]

Vote: yes

Dan


On 10/30/13 11:44 AM, Alan Bateman wrote:


I hereby nominate Daniel Fuchs to jdk8 Reviewer.

Daniel is on his second tour of duty in Oracle's JDK team. Those on 
jmx-dev will remember Daniel from the early years of OpenJDK when he 
was contributing changes to JMX. He left for a while to work at 
another team in Sun before returning to Oracle's JDK team about a year 
ago to focus on the JDK libraries. Since his return he has worked on 
JEP 162 and specifically the upgrade of JAXP to 1.6. He has also been 
clocking up hazard pay on the Logging API where he has fixed several 
major issues and a slew of long standing bugs. Daniel is author to ~60 
changesets in the jdk8 forest, and is reviewer/co-reviewer on ~90 
other changes.


Votes are due by Nov 13, 2013, 09.00 PST.

Only current jdk8 Reviewers[1] are eligible to vote on this 
nomination. Votes must be cast in the open by replying to this mailing 
list.


For Three-Vote Consensus voting instructions, see [2].

-Alan.

[1] http://openjdk.java.net/census
[2] http://openjdk.java.net/projects/#reviewer-vote

Re: RFR: 8026491: Typos in string literals

[Bradford Wetmore]

Cool stuff!  I like your green/red diff tool.  Don't have to click 
through each individual webrev page.


Just one thing to confirm but you would know better: was there anything 
that impacts L10N?  I didn't see anything obvious.


Brad


On 10/31/2013 5:58 AM, sergey malenkov wrote:

Hi Stuart,

I've attached a file with all typos which had been left after the fix.
There are no any occured in jdk/src.

Thanks,
SAM

On 31.10.2013 5:59, Stuart Marks wrote:

Perhaps Sergey can check.

I would have checked myself, but Sergey pushed his earlier fix to the
AWT forest, and I don't think it's appeared in TL yet. I could have
pulled over the AWT forest, but I have enough distractions as it stands.

Hm, maybe we need a new Friday Stats metric: the numbre of occurances
of mispeled words.

s'marks


On 10/30/13 1:40 PM, Jonathan Gibbons wrote:

find/grep before and after?

-- Jon

On 10/30/2013 01:17 PM, Stuart Marks wrote:

The changes look good.

It looks like "occured" is the most common spelling error. I wonder
how many
instances of this misspelling will remain in the codebase after your
fixes.

s'marks

On 10/30/13 4:43 AM, sergey malenkov wrote:

Hello,

Could you please review the following fix:
fix:http://cr.openjdk.java.net/~malenkov/8026491.8.0/
bug:https://bugs.openjdk.java.net/browse/JDK-8026491

I've replaced all typos with correct words in all string literals.

This is a second part of the previous fix
(8022746: List of spelling errors in API doc).

Thanks,
SAM

Re: RFR: 8026491: Typos in string literals

[Weijun Wang]

On 10/31/2013 5:58 AM, sergey malenkov wrote:

Hi Stuart,

I've attached a file with all typos which had been left after the fix.
There are no any occured in jdk/src.


False alarm:

# TYPO: tthe
share/classes/sun/security/tools/policytool/PolicyTool.java:
"\tThe final principal class will be " +

Thanks
Max