Re: TCK : updates required

2005-07-26 Thread Andy Jefferson 
 I'll look at the Map cases next

Michelle,

Here's some initial comments on the map tests.
1. HashMapStringKeyCollections : Field HashMapOfString_SimpleInterface7 is a 
MapString,Interface with the value embedded, and no join table. I interpret 
that as needing to serialise the map into the main table, but unfortunately 
there's no column for it in the schema (even though the column name is 
defined)

2. HashMapStringValueCollections : Field HashMapOfBigDecimal_String53 is a 
MapBigDecimal,String with a join table, and the value is defined to use a 
column with name STRING. The schema for the join table 
HASHMAP_BIG_DECIMAL53_STR has no column called STRING - its called VALUEVAL 
in that case. Either the schema or the ORM need changing to match.


Now these general observations apply to the other map tests too, and to other 
fields in the same classes.


-- 
Andy
Java Persistent Objects - JPOX

Question about orm metadata for inheritance

2005-07-26 Thread Michael Watzek 

Hi Craig, Andy, Erik,

I'm testing a kind of inheritance mapping using strategy new-table 
where each table contains columns for all fields. Thus, a table of a 
subclass contains columns for the declared fields *and* for the fields 
of all superclasses, e.g. this is the orm metadata of classes 
Insurance and DentalInsurance:


orm
package name=org.apache.jdo.tck.pc.company
...
class name=Insurance table=insuranceplans
inheritance strategy=new-table/
field name=insid column=INSID primary-key=true/
field name=carrier column=CARRIER/
field name=employee column=EMPLOYEE
 foreign-key/
/field
/class

class name=DentalInsurance table=dentalinsurance
inheritance strategy=new-table
join column=INSID/
/inheritance
field name=insid column=INSID primary-key=true/
field name=carrier column=CARRIER/
field name=employee column=EMPLOYEE
 foreign-key/
/field
field name=lifetimeOrthoBenefit 
column=LIFETIME_ORTHO_BENEFIT/

/class
...
/package
/orm

The Completeness test throws an exception applying this mapping 
(org.jpox.metadata.InvalidMetaDataException: Class 
org.apache.jdo.tck.pc.company.DentalInsurance has field 
org.apache.jdo.tck.pc.company.DentalInsurance.carrier declared in 
MetaData, but this field doesnt exist in the class!).


My question: Is this a valid mapping, if fields of superclasses are 
repeated in the orm metadata of subclasses?


Regards,
Michael
--
---
Michael Watzek  [EMAIL PROTECTED] Engineering GmbH
mailto:[EMAIL PROTECTED]Buelowstr. 66
Tel.:  ++49/30/235 520 36   10783 Berlin - Germany
Fax.:  ++49/30/217 520 12   http://www.spree.de/
---

Re: Question about orm metadata for inheritance

2005-07-26 Thread erik 
Michael,

We dont support Insurance.insid (SuperclassName.fieldName).

On a related issue, we also dont support fetch plans/indexes declared with
SuperclassName.fieldName, fieldName#key, fieldName#value or fieldName#element.

Regards,

Erik Bengtson

Quoting Michael Watzek [EMAIL PROTECTED]:

 Hi Erik,

 I'm just curious. Can you explain in more detail which parts of the orm
 metadata JPOX does not support right now? Is it inheritance strategy
 new-table in conjunction with a join element, or the repitition of
 superclass fields in subclasses?

 Regards,
 Michael

  Michael,
 
  No it is not valid. The below is valid, I think.
 
  field name=Insurance.insid column=INSID primary-key=true/
  field name=Insurance.carrier column=CARRIER/
  field name=Insurance.employee column=EMPLOYEE
  foreign-key/
  /field
 
  JPOX does not support the above syntax, yet.
 
  Regards,
 
  Erik Bengtson
 
  Quoting Michael Watzek [EMAIL PROTECTED]:
 
 
 Hi Craig, Andy, Erik,
 
 I'm testing a kind of inheritance mapping using strategy new-table
 where each table contains columns for all fields. Thus, a table of a
 subclass contains columns for the declared fields *and* for the fields
 of all superclasses, e.g. this is the orm metadata of classes
 Insurance and DentalInsurance:
 
 orm
  package name=org.apache.jdo.tck.pc.company
  ...
  class name=Insurance table=insuranceplans
  inheritance strategy=new-table/
  field name=insid column=INSID primary-key=true/
  field name=carrier column=CARRIER/
  field name=employee column=EMPLOYEE
   foreign-key/
  /field
  /class
 
  class name=DentalInsurance table=dentalinsurance
  inheritance strategy=new-table
  join column=INSID/
  /inheritance
  field name=insid column=INSID primary-key=true/
  field name=carrier column=CARRIER/
  field name=employee column=EMPLOYEE
   foreign-key/
  /field
  field name=lifetimeOrthoBenefit
 column=LIFETIME_ORTHO_BENEFIT/
  /class
  ...
  /package
 /orm
 
 The Completeness test throws an exception applying this mapping
 (org.jpox.metadata.InvalidMetaDataException: Class
 org.apache.jdo.tck.pc.company.DentalInsurance has field
 org.apache.jdo.tck.pc.company.DentalInsurance.carrier declared in
 MetaData, but this field doesnt exist in the class!).
 
 My question: Is this a valid mapping, if fields of superclasses are
 repeated in the orm metadata of subclasses?
 
 Regards,
 Michael
 --
 ---
 Michael Watzek  [EMAIL PROTECTED] Engineering GmbH
 mailto:[EMAIL PROTECTED]Buelowstr. 66
 Tel.:  ++49/30/235 520 36   10783 Berlin - Germany
 Fax.:  ++49/30/217 520 12   http://www.spree.de/
 ---
 
 
 
 


 --
 ---
 Michael Watzek  [EMAIL PROTECTED] Engineering GmbH
 mailto:[EMAIL PROTECTED]Buelowstr. 66
 Tel.:  ++49/30/235 520 36   10783 Berlin - Germany
 Fax.:  ++49/30/217 520 12   http://www.spree.de/
 ---

Re: Patch for JIRA JDO-96

2005-07-26 Thread Michael Watzek 

Hi Craig,

I'll have to leave now and will check that tomorrow.

Do you mean the org/apache/jdo/tck/pc/singlefieldidentity/package.jdo 
under directory applicationidentity?


Regards,
Michael


Hi Michael,

Thanks for the patch.

Question: Why is the package.jdo file marked as executable in svn? 
Configuration error in your maven setup?


Craig

On Jul 26, 2005, at 6:04 AM, Michael Watzek wrote:


Hi Michelle,

please find the attached patch fixing JIRA JDO-96 (Error reading the 
JDO Meta-Data file 
org/apache/jdo/tck/pc/singlefieldidentity/package.jdo. Cause : {1}). 
The patch adds a package JDO file to package 
org.apache.jdo.tck.pc.singlefieldidentity for datastoreidentity. All 
classes listed in that file have attribute persistence-modifier set 
to non-persistent.


Regards,
Michael
--
---
Michael Watzek  [EMAIL PROTECTED] Engineering GmbH
mailto:[EMAIL PROTECTED]Buelowstr. 66
Tel.:  ++49/30/235 520 36   10783 Berlin - Germany
Fax.:  ++49/30/217 520 12   http://www.spree.de/
---
Index: 
test/jdo/datastoreidentity/org/apache/jdo/tck/pc/singlefieldidentity/package.jdo

===
--- 
test/jdo/datastoreidentity/org/apache/jdo/tck/pc/singlefieldidentity/package.jdo  
  (revision 0)
+++ 
test/jdo/datastoreidentity/org/apache/jdo/tck/pc/singlefieldidentity/package.jdo  
  (revision 0)

@@ -0,0 +1,20 @@
+?xml version=1.0 encoding=UTF-8?
+!DOCTYPE jdo PUBLIC -//Sun Microsystems, Inc.//DTD Java Data 
Objects Metadata 2.0//EN http://java.sun.com/dtd/jdo_2_0.dtd;

+
+jdo
+  package name=org.apache.jdo.tck.pc.singlefieldidentity
+class name=PCPointSingleFieldPrimitivebyte 
persistence-modifier=non-persistent/
+class name=PCPointSingleFieldByte 
persistence-modifier=non-persistent/
+class name=PCPointSingleFieldPrimitivechar 
persistence-modifier=non-persistent/
+class name=PCPointSingleFieldCharacter 
persistence-modifier=non-persistent/
+class name=PCPointSingleFieldPrimitiveint 
persistence-modifier=non-persistent/
+class name=PCPointSingleFieldInteger 
persistence-modifier=non-persistent/
+class name=PCPointSingleFieldPrimitivelong 
persistence-modifier=non-persistent/
+class name=PCPointSingleFieldLong 
persistence-modifier=non-persistent/
+class name=PCPointSingleFieldPrimitiveshort 
persistence-modifier=non-persistent/
+class name=PCPointSingleFieldShort 
persistence-modifier=non-persistent/
+class name=PCPointSingleFieldString 
persistence-modifier=non-persistent/
+class name=PCPointSingleFieldDate 
persistence-modifier=non-persistent/

+  /package
+/jdo
+

Property changes on: 
test/jdo/datastoreidentity/org/apache/jdo/tck/pc/singlefieldidentity/package.jdo

___
Name: svn:executable
   + *




Craig Russell

Architect, Sun Java Enterprise System http://java.sun.com/products/jdo

408 276-5638 mailto:[EMAIL PROTECTED]

P.S. A good JDO? O, Gasp!





--
---
Michael Watzek  [EMAIL PROTECTED] Engineering GmbH
mailto:[EMAIL PROTECTED]Buelowstr. 66
Tel.:  ++49/30/235 520 36   10783 Berlin - Germany
Fax.:  ++49/30/217 520 12   http://www.spree.de/
---

Re: Patch for JIRA JDO-96

2005-07-26 Thread Craig Russell 
Hi Michael,On Jul 26, 2005, at 8:50 AM, Michael Watzek wrote:Hi Craig,I'll have to leave now and will check that tomorrow.Do you mean the "org/apache/jdo/tck/pc/singlefieldidentity/package.jdo" under directory applicationidentity?I mean:Property changes on: test/jdo/datastoreidentity/org/apache/jdo/tck/pc/singlefieldidentity/package.jdo___Name: svn:executable   + *Why is it svn:executable?I noticed a number of such svn:executable but this is the first time I questioned it...Thanks,CraigRegards,Michael Hi Michael,Thanks for the patch.Question: Why is the package.jdo file marked as "executable" in svn? Configuration error in your maven setup?CraigOn Jul 26, 2005, at 6:04 AM, Michael Watzek wrote: Hi Michelle,please find the attached patch fixing JIRA JDO-96 (Error reading the JDO Meta-Data file "org/apache/jdo/tck/pc/singlefieldidentity/package.jdo". Cause : {1}). The patch adds a package JDO file to package "org.apache.jdo.tck.pc.singlefieldidentity" for datastoreidentity. All classes listed in that file have attribute "persistence-modifier" set to "non-persistent".Regards,Michael-- ---Michael Watzek                  [EMAIL PROTECTED] Engineering GmbHmailto:[EMAIL PROTECTED]        Buelowstr. 66Tel.:  ++49/30/235 520 36       10783 Berlin - GermanyFax.:  ++49/30/217 520 12       http://www.spree.de/---Index: test/jdo/datastoreidentity/org/apache/jdo/tck/pc/singlefieldidentity/package.jdo===--- test/jdo/datastoreidentity/org/apache/jdo/tck/pc/singlefieldidentity/package.jdo    (revision 0)+++ test/jdo/datastoreidentity/org/apache/jdo/tck/pc/singlefieldidentity/package.jdo    (revision 0)@@ -0,0 +1,20 @@+?xml version="1.0" encoding="UTF-8"?+!DOCTYPE jdo PUBLIC "-//Sun Microsystems, Inc.//DTD Java Data Objects Metadata 2.0//EN" "http://java.sun.com/dtd/jdo_2_0.dtd"++jdo+  package name="org.apache.jdo.tck.pc.singlefieldidentity"+    class name="PCPointSingleFieldPrimitivebyte" persistence-modifier="non-persistent"/+    class name="PCPointSingleFieldByte" persistence-modifier="non-persistent"/+    class name="PCPointSingleFieldPrimitivechar" persistence-modifier="non-persistent"/+    class name="PCPointSingleFieldCharacter" persistence-modifier="non-persistent"/+    class name="PCPointSingleFieldPrimitiveint" persistence-modifier="non-persistent"/+    class name="PCPointSingleFieldInteger" persistence-modifier="non-persistent"/+    class name="PCPointSingleFieldPrimitivelong" persistence-modifier="non-persistent"/+    class name="PCPointSingleFieldLong" persistence-modifier="non-persistent"/+    class name="PCPointSingleFieldPrimitiveshort" persistence-modifier="non-persistent"/+    class name="PCPointSingleFieldShort" persistence-modifier="non-persistent"/+    class name="PCPointSingleFieldString" persistence-modifier="non-persistent"/+    class name="PCPointSingleFieldDate" persistence-modifier="non-persistent"/+  /package+/jdo+Property changes on: test/jdo/datastoreidentity/org/apache/jdo/tck/pc/singlefieldidentity/package.jdo___Name: svn:executable   + * Craig RussellArchitect, Sun Java Enterprise System http://java.sun.com/products/jdo408 276-5638 mailto:[EMAIL PROTECTED]P.S. A good JDO? O, Gasp! -- ---Michael Watzek                  [EMAIL PROTECTED] Engineering GmbHmailto:[EMAIL PROTECTED]        Buelowstr. 66Tel.:  ++49/30/235 520 36       10783 Berlin - GermanyFax.:  ++49/30/217 520 12       http://www.spree.de/---  Craig Russell Architect, Sun Java Enterprise System http://java.sun.com/products/jdo 408 276-5638 mailto:[EMAIL PROTECTED] P.S. A good JDO? O, Gasp!  

smime.p7s
Description: S/MIME cryptographic signature

Re: TCK : updates required

2005-07-26 Thread Michelle Caisse 

Hi Andy,

I checked in all these fixes and then some.  I also added the 
serialized=true tag where needed (JDO-82).


-- Michelle

Andy Jefferson wrote:


I'll look at the Map cases next
   



Michelle,

Here's some initial comments on the map tests.
1. HashMapStringKeyCollections : Field HashMapOfString_SimpleInterface7 is a 
MapString,Interface with the value embedded, and no join table. I interpret 
that as needing to serialise the map into the main table, but unfortunately 
there's no column for it in the schema (even though the column name is 
defined)


2. HashMapStringValueCollections : Field HashMapOfBigDecimal_String53 is a 
MapBigDecimal,String with a join table, and the value is defined to use a 
column with name STRING. The schema for the join table 
HASHMAP_BIG_DECIMAL53_STR has no column called STRING - its called VALUEVAL 
in that case. Either the schema or the ORM need changing to match.



Now these general observations apply to the other map tests too, and to other 
fields in the same classes.

Re: JDO API compability with JDK 1.3 (issue)

2005-07-26 Thread Craig Russell 
Hi Erik,Thanks. The protocol is that the person who filed the JIRA issue (this is you) should mark it RESOLVED once they have verified that the patch has been checked in and it solves the issue.Thanks,CraigOn Jul 26, 2005, at 12:51 PM, [EMAIL PROTECTED] wrote:Hi Craig,Your last patch solved the issue. Let me know if I have to change the issuestatusRegards,Erik Bengtson  Craig Russell Architect, Sun Java Enterprise System http://java.sun.com/products/jdo 408 276-5638 mailto:[EMAIL PROTECTED] P.S. A good JDO? O, Gasp!  

smime.p7s
Description: S/MIME cryptographic signature