[jira] Updated: (JDO-375) Company model tables are not fully cleaned up
[ http://issues.apache.org/jira/browse/JDO-375?page=all ]
Andy Jefferson updated JDO-375:
---
Attachment: jpox-enhancer-SNAPSHOT.jar
jpox-SNAPSHOT.jar
Attached are jars built from JPOX CVS HEAD. I can confirm the fix works and
have run the complete TCK twice through with success. Good work!
> Company model tables are not fully cleaned up
> -
>
> Key: JDO-375
> URL: http://issues.apache.org/jira/browse/JDO-375
> Project: JDO
> Type: Bug
> Components: tck20
> Versions: JDO 2 rc1
> Reporter: Erik Bengtson
> Assignee: Erik Bengtson
> Fix For: JDO 2 final
> Attachments: JDO-375-2.patch, JDO-375-fknames.patch, JDO-375.patch,
> jpox-SNAPSHOT.jar, jpox-enhancer-SNAPSHOT.jar
>
> Tables from company model does not appear to be clean after run.
> I can't say if this is a JPOX or TCK issue, because I did not dig into the
> issue.
> On second run, exceptions are like
> > 1)
> > test(org.apache.jdo.tck.api.persistencemanager.extent.GetExtentWithInstancesMadePersistentViaReachability)javax.jdo.JDODataStoreException:
> > Insert request failed: INSERT INTO applicationidentity0.COMPANIES
> > ("NAME",FOUNDEDDATE,ADDRID,CITY,COUNTRY,"STATE",STREET,ZIPCODE,ID,DISCRIMINATOR)
> > VALUES (?,?,?,?,?,?,?,?,?,?)
> > at
> > org.jpox.store.rdbms.request.InsertRequest.execute(InsertRequest.java:393)
> > at
> > org.jpox.store.rdbms.table.ClassTable.insert(ClassTable.java:2171)
> > at org.jpox.store.StoreManager.insert(StoreManager.java:757)
> > at
> > org.jpox.state.StateManagerImpl.internalMakePersistent(StateManagerImpl.java:3456)
> > at
> > org.jpox.state.StateManagerImpl.makePersistent(StateManagerImpl.java:3429)
> > at
> > org.jpox.AbstractPersistenceManager.internalMakePersistent(AbstractPersistenceManager.java:1150)
> > at
> > org.jpox.AbstractPersistenceManager.makePersistent(AbstractPersistenceManager.java:1205)
> > at
> > org.apache.jdo.tck.api.persistencemanager.extent.GetExtentWithInstancesMadePersistentViaReachability.createObjects(GetExtentWithInstancesMadePersistentViaReachability.java:72)
> > at
> > org.apache.jdo.tck.api.persistencemanager.extent.GetExtentWithInstancesMadePersistentViaReachability.test(GetExtentWithInstancesMadePersistentViaReachability.java:63)
> > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > at
> > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> > at
> > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> > at org.apache.jdo.tck.JDO_Test.runBare(JDO_Test.java:237)
> > at
> > org.apache.jdo.tck.util.BatchTestRunner.doRun(BatchTestRunner.java:107)
> > at
> > org.apache.jdo.tck.util.BatchTestRunner.start(BatchTestRunner.java:147)
> > at
> > org.apache.jdo.tck.util.BatchTestRunner.main(BatchTestRunner.java:122)
> > NestedThrowablesStackTrace:
> > ERROR 23505: The statement was aborted because it would have caused a
> > duplicate
> > key value in a unique or primary key constraint or unique index identified
> > by
> > 'COMPS_PK' defined on 'COMPANIES'.
> > at
> > org.apache.derby.iapi.error.StandardException.newException(Unknown Source)
> > at
> > org.apache.derby.impl.sql.execute.IndexChanger.insertAndCheckDups(Unknown
> > Source)
> > at org.apache.derby.impl.sql.execute.IndexChanger.doInsert(Unknown
> > Source)
> > at org.apache.derby.impl.sql.execute.IndexChanger.insert(Unknown
> > Source)
> > at org.apache.derby.impl.sql.execute.IndexSetChanger.insert(Unknown
> > Source)
> > at
> > org.apache.derby.impl.sql.execute.RowChangerImpl.insertRow(Unknown Source)
> > at
> > org.apache.derby.impl.sql.execute.InsertResultSet.normalInsertCore(Unknown
> > Source)
> > at org.apache.derby.impl.sql.execute.InsertResultSet.open(Unknown
> > Source)
> > at
> > org.apache.derby.impl.sql.GenericPreparedStatement.execute(Unknown Source)
> > at
> > org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(Unknown Source)
> > at
> > org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeStatement(Unknown
> > Source)
> > at
> > org.apache.derby.impl.jdbc.EmbedPreparedStatement.execute(Unknown Source)
> > at
> > com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.execute(NewProxyPreparedStatement.java:911)
> > at
> > org.jpox.store.rdbms.ParamLoggingPreparedStatement.execute(ParamLoggingPreparedStatement.java:212)
> > at
> > org.jpox.store.rdbms.request.Request.executeUpdate(Request.java:88)
> > at
> > org.jpox.store.rdbms.request.InsertRequest.execute(InsertRequest.java:267)
> > at
> > org.jpox.store.rdbms.table.ClassTable.insert(ClassTable.java:2171)
> > at org.jpox.store.StoreManager.insert(
Re: [jira] Commented: (JDO-375) Company model tables are not fully cleaned up
Craig,
Yes, I applied the patch. It was very helpfull.
Quoting Craig L Russell <[EMAIL PROTECTED]>:
> Hi Erik,
>
> By the way, are you using the patched .sql scripts with the named fk
> constraints or the checked-in scripts?
>
> Thanks,
>
> Craig
>
> On Apr 30, 2006, at 5:36 PM, Erik Bengtson wrote:
>
> > Hi,
> >
> > JPOX HEAD pass all tests and correctly clean database.
> >
> > Cheers
> >
> > Quoting "Michael Bouschen (JIRA)" <[EMAIL PROTECTED]>:
> >
> >> [
> >> http://issues.apache.org/jira/browse/JDO-375?
> >> page=comments#action_12377192 ]
> >>
> >> Michael Bouschen commented on JDO-375:
> >> --
> >>
> >> The fknames patch looks good!
> >>
> >>> Company model tables are not fully cleaned up
> >>> -
> >>>
> >>> Key: JDO-375
> >>> URL: http://issues.apache.org/jira/browse/JDO-375
> >>> Project: JDO
> >>> Type: Bug
> >>
> >>> Components: tck20
> >>> Versions: JDO 2 rc1
> >>> Reporter: Erik Bengtson
> >>> Assignee: Erik Bengtson
> >>> Fix For: JDO 2 final
> >>> Attachments: JDO-375-2.patch, JDO-375-fknames.patch, JDO-375.patch
> >>>
> >>> Tables from company model does not appear to be clean after run.
> >>> I can't say if this is a JPOX or TCK issue, because I did not dig
> >>> into the
> >> issue.
> >>> On second run, exceptions are like
> 1)
>
> >>
> > test
> > (org.apache.jdo.tck.api.persistencemanager.extent.GetExtentWithInstanc
> > esMadePersistentViaReachability)javax.jdo.JDODataStoreException:
> Insert request failed: INSERT INTO applicationidentity0.COMPANIES
>
> >>
> > ("NAME",FOUNDEDDATE,ADDRID,CITY,COUNTRY,"STATE",STREET,ZIPCODE,ID,DISC
> > RIMINATOR)
> VALUES (?,?,?,?,?,?,?,?,?,?)
> at
> >> org.jpox.store.rdbms.request.InsertRequest.execute
> >> (InsertRequest.java:393)
> at
> >> org.jpox.store.rdbms.table.ClassTable.insert(ClassTable.java:2171)
> at org.jpox.store.StoreManager.insert(StoreManager.java:
> 757)
> at
>
> >>
> > org.jpox.state.StateManagerImpl.internalMakePersistent
> > (StateManagerImpl.java:3456)
> at
> >> org.jpox.state.StateManagerImpl.makePersistent
> >> (StateManagerImpl.java:3429)
> at
>
> >>
> > org.jpox.AbstractPersistenceManager.internalMakePersistent
> > (AbstractPersistenceManager.java:1150)
> at
>
> >>
> > org.jpox.AbstractPersistenceManager.makePersistent
> > (AbstractPersistenceManager.java:1205)
> at
>
> >>
> > org.apache.jdo.tck.api.persistencemanager.extent.GetExtentWithInstance
> > sMadePersistentViaReachability.createObjects
> > (GetExtentWithInstancesMadePersistentViaReachability.java:72)
> at
>
> >>
> > org.apache.jdo.tck.api.persistencemanager.extent.GetExtentWithInstance
> > sMadePersistentViaReachability.test
> > (GetExtentWithInstancesMadePersistentViaReachability.java:63)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
>
> >> sun.reflect.NativeMethodAccessorImpl.invoke
> >> (NativeMethodAccessorImpl.java:39)
> at
>
> >>
> > sun.reflect.DelegatingMethodAccessorImpl.invoke
> > (DelegatingMethodAccessorImpl.java:25)
> at org.apache.jdo.tck.JDO_Test.runBare(JDO_Test.java:237)
> at
> >> org.apache.jdo.tck.util.BatchTestRunner.doRun(BatchTestRunner.java:
> >> 107)
> at
> >> org.apache.jdo.tck.util.BatchTestRunner.start(BatchTestRunner.java:
> >> 147)
> at
> >> org.apache.jdo.tck.util.BatchTestRunner.main(BatchTestRunner.java:
> >> 122)
> NestedThrowablesStackTrace:
> ERROR 23505: The statement was aborted because it would have
> caused a
> >> duplicate
> key value in a unique or primary key constraint or unique index
> >> identified by
> 'COMPS_PK' defined on 'COMPANIES'.
> at
> >> org.apache.derby.iapi.error.StandardException.newException(Unknown
> >> Source)
> at
> >> org.apache.derby.impl.sql.execute.IndexChanger.insertAndCheckDups
> >> (Unknown
> Source)
> at
> >> org.apache.derby.impl.sql.execute.IndexChanger.doInsert(Unknown
> >> Source)
> at org.apache.derby.impl.sql.execute.IndexChanger.insert
> (Unknown
> >> Source)
> at
> >> org.apache.derby.impl.sql.execute.IndexSetChanger.insert(Unknown
> >> Source)
> at
> >> org.apache.derby.impl.sql.execute.RowChangerImpl.insertRow(Unknown
> >> Source)
> at
> >> org.apache.derby.impl.sql.execute.InsertResultSet.normalInsertCore
> >> (Unknown
> Source)
> at org.apache.derby.impl.sql.execute.InsertResultSet.open
> (Unknown
> >> Source)
> at
> >> org.apache.derby.impl.sql.GenericPreparedStatement.execute(Unknown
> >> Source)
> at
> >> org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(Unknown
> >> Sourc
[jira] Resolved: (JDO-327) JPOX fails to create new instance of PC class via pm.newInstance(PCInterface)
[ http://issues.apache.org/jira/browse/JDO-327?page=all ]
Craig Russell resolved JDO-327:
---
Resolution: Fixed
With the latest JPOX HEAD this issue is resolved.
> JPOX fails to create new instance of PC class via pm.newInstance(PCInterface)
> -
>
> Key: JDO-327
> URL: http://issues.apache.org/jira/browse/JDO-327
> Project: JDO
> Type: Bug
> Components: tck20
> Versions: JDO 2 rc1
> Reporter: Craig Russell
> Assignee: Erik Bengtson
> Fix For: JDO 2 final
> Attachments: jpox-1.1.0.jar, jpox-enhancer-1.1.0.jar
>
> This is a new test for persistent interfaces. JPOX fails while obtaining
> metadata for the persistent interface IAddress.
> IAddress newAddress() {
> return (IAddress)pm.newInstance(IAddress.class);
> }
> maven -o -Djdo.tck.cfglist=companyPMInterface.conf runtck.jdori
> [java] RUN CompletenessTest.test ERROR
> [java] Description: Completeness test with standard mapping, basic
> testdata with all relationships and embedded objects.
> [java] Time: 009
> [java] There was 1 error:
> [java] 1)
> test(org.apache.jdo.tck.mapping.CompletenessTest)org.springframework.beans.factory.BeanCreationException:
> Error creating bean with name 'root' defined in class path resource
> [org/apache/jdo/tck/pc/company/companyAllRelationships.xml]: Can't resolve
> reference to bean 'company1' while setting property 'constructor argument
> with index 0[0]'; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating bean
> with name 'company1' defined in class path resource
> [org/apache/jdo/tck/pc/company/companyAllRelationships.xml]: Can't resolve
> reference to bean 'addr1' while setting property 'constructor argument with
> index 3'; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating bean
> with name 'addr1' defined in class path resource
> [org/apache/jdo/tck/pc/company/companyAllRelationships.xml]: Instantiation of
> bean failed; nested exception is
> org.springframework.beans.factory.BeanDefinitionStoreException: Factory
> method [public org.apache.jdo.tck.pc.company.IAddress
> org.apache.jdo.tck.pc.company.CompanyFactoryAbstractImpl.newAddress(long,java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.String)]
> threw exception; nested exception is javax.jdo.JDOException: Cannot read the
> JDO Meta-Data file " java.lang.ClassCastException:
> org.jpox.metadata.EmbeddedMetaData"
> [java] org.springframework.beans.factory.BeanCreationException: Error
> creating bean with name 'company1' defined in class path resource
> [org/apache/jdo/tck/pc/company/companyAllRelationships.xml]: Can't resolve
> reference to bean 'addr1' while setting property 'constructor argument with
> index 3'; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating bean
> with name 'addr1' defined in class path resource
> [org/apache/jdo/tck/pc/company/companyAllRelationships.xml]: Instantiation of
> bean failed; nested exception is
> org.springframework.beans.factory.BeanDefinitionStoreException: Factory
> method [public org.apache.jdo.tck.pc.company.IAddress
> org.apache.jdo.tck.pc.company.CompanyFactoryAbstractImpl.newAddress(long,java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.String)]
> threw exception; nested exception is javax.jdo.JDOException: Cannot read the
> JDO Meta-Data file " java.lang.ClassCastException:
> org.jpox.metadata.EmbeddedMetaData"
> [java] org.springframework.beans.factory.BeanCreationException: Error
> creating bean with name 'addr1' defined in class path resource
> [org/apache/jdo/tck/pc/company/companyAllRelationships.xml]: Instantiation of
> bean failed; nested exception is
> org.springframework.beans.factory.BeanDefinitionStoreException: Factory
> method [public org.apache.jdo.tck.pc.company.IAddress
> org.apache.jdo.tck.pc.company.CompanyFactoryAbstractImpl.newAddress(long,java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.String)]
> threw exception; nested exception is javax.jdo.JDOException: Cannot read the
> JDO Meta-Data file " java.lang.ClassCastException:
> org.jpox.metadata.EmbeddedMetaData"
> [java] org.springframework.beans.factory.BeanDefinitionStoreException:
> Factory method [public org.apache.jdo.tck.pc.company.IAddress
> org.apache.jdo.tck.pc.company.CompanyFactoryAbstractImpl.newAddress(long,java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.String)]
> threw exception; nested exception is javax.jdo.JDOException: Cannot read the
> JDO Meta-Data file " java.lang.ClassCastException:
> org.jpox.metadata.EmbeddedMetaData"
> [java] javax.jdo.JDOException: Cannot read the JDO Meta-Data file " stream> java.lang.ClassCastExc
[jira] Resolved: (JDO-375) Company model tables are not fully cleaned up
[ http://issues.apache.org/jira/browse/JDO-375?page=all ]
Michael Bouschen resolved JDO-375:
--
Resolution: Fixed
I checked in Craig's fknames patch (see revison 398624).
With the latest JPOX version the cleanup issue is resolved.
> Company model tables are not fully cleaned up
> -
>
> Key: JDO-375
> URL: http://issues.apache.org/jira/browse/JDO-375
> Project: JDO
> Type: Bug
> Components: tck20
> Versions: JDO 2 rc1
> Reporter: Erik Bengtson
> Assignee: Erik Bengtson
> Fix For: JDO 2 final
> Attachments: JDO-375-2.patch, JDO-375-fknames.patch, JDO-375.patch,
> jpox-SNAPSHOT.jar, jpox-enhancer-SNAPSHOT.jar
>
> Tables from company model does not appear to be clean after run.
> I can't say if this is a JPOX or TCK issue, because I did not dig into the
> issue.
> On second run, exceptions are like
> > 1)
> > test(org.apache.jdo.tck.api.persistencemanager.extent.GetExtentWithInstancesMadePersistentViaReachability)javax.jdo.JDODataStoreException:
> > Insert request failed: INSERT INTO applicationidentity0.COMPANIES
> > ("NAME",FOUNDEDDATE,ADDRID,CITY,COUNTRY,"STATE",STREET,ZIPCODE,ID,DISCRIMINATOR)
> > VALUES (?,?,?,?,?,?,?,?,?,?)
> > at
> > org.jpox.store.rdbms.request.InsertRequest.execute(InsertRequest.java:393)
> > at
> > org.jpox.store.rdbms.table.ClassTable.insert(ClassTable.java:2171)
> > at org.jpox.store.StoreManager.insert(StoreManager.java:757)
> > at
> > org.jpox.state.StateManagerImpl.internalMakePersistent(StateManagerImpl.java:3456)
> > at
> > org.jpox.state.StateManagerImpl.makePersistent(StateManagerImpl.java:3429)
> > at
> > org.jpox.AbstractPersistenceManager.internalMakePersistent(AbstractPersistenceManager.java:1150)
> > at
> > org.jpox.AbstractPersistenceManager.makePersistent(AbstractPersistenceManager.java:1205)
> > at
> > org.apache.jdo.tck.api.persistencemanager.extent.GetExtentWithInstancesMadePersistentViaReachability.createObjects(GetExtentWithInstancesMadePersistentViaReachability.java:72)
> > at
> > org.apache.jdo.tck.api.persistencemanager.extent.GetExtentWithInstancesMadePersistentViaReachability.test(GetExtentWithInstancesMadePersistentViaReachability.java:63)
> > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > at
> > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> > at
> > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> > at org.apache.jdo.tck.JDO_Test.runBare(JDO_Test.java:237)
> > at
> > org.apache.jdo.tck.util.BatchTestRunner.doRun(BatchTestRunner.java:107)
> > at
> > org.apache.jdo.tck.util.BatchTestRunner.start(BatchTestRunner.java:147)
> > at
> > org.apache.jdo.tck.util.BatchTestRunner.main(BatchTestRunner.java:122)
> > NestedThrowablesStackTrace:
> > ERROR 23505: The statement was aborted because it would have caused a
> > duplicate
> > key value in a unique or primary key constraint or unique index identified
> > by
> > 'COMPS_PK' defined on 'COMPANIES'.
> > at
> > org.apache.derby.iapi.error.StandardException.newException(Unknown Source)
> > at
> > org.apache.derby.impl.sql.execute.IndexChanger.insertAndCheckDups(Unknown
> > Source)
> > at org.apache.derby.impl.sql.execute.IndexChanger.doInsert(Unknown
> > Source)
> > at org.apache.derby.impl.sql.execute.IndexChanger.insert(Unknown
> > Source)
> > at org.apache.derby.impl.sql.execute.IndexSetChanger.insert(Unknown
> > Source)
> > at
> > org.apache.derby.impl.sql.execute.RowChangerImpl.insertRow(Unknown Source)
> > at
> > org.apache.derby.impl.sql.execute.InsertResultSet.normalInsertCore(Unknown
> > Source)
> > at org.apache.derby.impl.sql.execute.InsertResultSet.open(Unknown
> > Source)
> > at
> > org.apache.derby.impl.sql.GenericPreparedStatement.execute(Unknown Source)
> > at
> > org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(Unknown Source)
> > at
> > org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeStatement(Unknown
> > Source)
> > at
> > org.apache.derby.impl.jdbc.EmbedPreparedStatement.execute(Unknown Source)
> > at
> > com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.execute(NewProxyPreparedStatement.java:911)
> > at
> > org.jpox.store.rdbms.ParamLoggingPreparedStatement.execute(ParamLoggingPreparedStatement.java:212)
> > at
> > org.jpox.store.rdbms.request.Request.executeUpdate(Request.java:88)
> > at
> > org.jpox.store.rdbms.request.InsertRequest.execute(InsertRequest.java:267)
> > at
> > org.jpox.store.rdbms.table.ClassTable.insert(ClassTable.java:2171)
> > at org.jpox.store.StoreManager.insert(StoreManager.java:757)
> > at
> > org.jpox.state.StateManage
[jira] Updated: (JDO-377) Company model factory improvements to test persistent interfaces
[ http://issues.apache.org/jira/browse/JDO-377?page=all ] Michael Bouschen updated JDO-377: - Attachment: JDO-377-mbo.patch Attached you find a new patch JDO-377-mbo.patch fixing a bug in the LifecycleCompletetness class and adding three new configurations one for each CompanyFactory implementation. There is one configuration failing when running with the latest JPOX version (I'm using the jars attached to JDO-375): lifecyclecompletenessPMInterface.conf with applicationidentity. Method verifyOids checks that the target class of a SingleFieldIdentity oid is the class passed to the pm.newInstance call (see last paragraph of 12.6.6. on page 116 of the spec). In this configuration pm.newInstance is called with a PC interface, but the target class is the implementing class that was generatd by JPOX. > Company model factory improvements to test persistent interfaces > > > Key: JDO-377 > URL: http://issues.apache.org/jira/browse/JDO-377 > Project: JDO > Type: Improvement > Components: tck20 > Versions: JDO 2 rc1 > Reporter: Craig Russell > Priority: Minor > Fix For: JDO 2 final > Attachments: JDO-377-mbo.patch, JDO-377.patch, LifecycleCompleteness.java, > lifecyclecompleteness.conf > > Please review this patch. > In order to test persistent interfaces better, a method was added to the > CompanyFactory interface to allow the test program to get the persistent > instances. > List getAllInstances(); > To implement this new API, changes were made to the factory implementation > classes to keep track of instances as they were created. > Additionally, only classes (or interfaces) actually instantiated were put > into the tearDown class array. So Person.class and Employee.class were > removed from the array. > Finally, a bug was fixed in CompanyFactoryPMClass where the interface > IMedicalInsurance.class was incorrectly added to the tearDown class array. > A new test class was used for testing. This class might be added to the TCK > if suitable. > And a new configuration was used for testing. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (JDO-375) Company model tables are not fully cleaned up
[
http://issues.apache.org/jira/browse/JDO-375?page=comments#action_12377237 ]
Michael Bouschen commented on JDO-375:
--
Added fknames patch to the 2.0 branch (see revision 398629).
> Company model tables are not fully cleaned up
> -
>
> Key: JDO-375
> URL: http://issues.apache.org/jira/browse/JDO-375
> Project: JDO
> Type: Bug
> Components: tck20
> Versions: JDO 2 rc1
> Reporter: Erik Bengtson
> Assignee: Erik Bengtson
> Fix For: JDO 2 final
> Attachments: JDO-375-2.patch, JDO-375-fknames.patch, JDO-375.patch,
> jpox-SNAPSHOT.jar, jpox-enhancer-SNAPSHOT.jar
>
> Tables from company model does not appear to be clean after run.
> I can't say if this is a JPOX or TCK issue, because I did not dig into the
> issue.
> On second run, exceptions are like
> > 1)
> > test(org.apache.jdo.tck.api.persistencemanager.extent.GetExtentWithInstancesMadePersistentViaReachability)javax.jdo.JDODataStoreException:
> > Insert request failed: INSERT INTO applicationidentity0.COMPANIES
> > ("NAME",FOUNDEDDATE,ADDRID,CITY,COUNTRY,"STATE",STREET,ZIPCODE,ID,DISCRIMINATOR)
> > VALUES (?,?,?,?,?,?,?,?,?,?)
> > at
> > org.jpox.store.rdbms.request.InsertRequest.execute(InsertRequest.java:393)
> > at
> > org.jpox.store.rdbms.table.ClassTable.insert(ClassTable.java:2171)
> > at org.jpox.store.StoreManager.insert(StoreManager.java:757)
> > at
> > org.jpox.state.StateManagerImpl.internalMakePersistent(StateManagerImpl.java:3456)
> > at
> > org.jpox.state.StateManagerImpl.makePersistent(StateManagerImpl.java:3429)
> > at
> > org.jpox.AbstractPersistenceManager.internalMakePersistent(AbstractPersistenceManager.java:1150)
> > at
> > org.jpox.AbstractPersistenceManager.makePersistent(AbstractPersistenceManager.java:1205)
> > at
> > org.apache.jdo.tck.api.persistencemanager.extent.GetExtentWithInstancesMadePersistentViaReachability.createObjects(GetExtentWithInstancesMadePersistentViaReachability.java:72)
> > at
> > org.apache.jdo.tck.api.persistencemanager.extent.GetExtentWithInstancesMadePersistentViaReachability.test(GetExtentWithInstancesMadePersistentViaReachability.java:63)
> > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > at
> > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> > at
> > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> > at org.apache.jdo.tck.JDO_Test.runBare(JDO_Test.java:237)
> > at
> > org.apache.jdo.tck.util.BatchTestRunner.doRun(BatchTestRunner.java:107)
> > at
> > org.apache.jdo.tck.util.BatchTestRunner.start(BatchTestRunner.java:147)
> > at
> > org.apache.jdo.tck.util.BatchTestRunner.main(BatchTestRunner.java:122)
> > NestedThrowablesStackTrace:
> > ERROR 23505: The statement was aborted because it would have caused a
> > duplicate
> > key value in a unique or primary key constraint or unique index identified
> > by
> > 'COMPS_PK' defined on 'COMPANIES'.
> > at
> > org.apache.derby.iapi.error.StandardException.newException(Unknown Source)
> > at
> > org.apache.derby.impl.sql.execute.IndexChanger.insertAndCheckDups(Unknown
> > Source)
> > at org.apache.derby.impl.sql.execute.IndexChanger.doInsert(Unknown
> > Source)
> > at org.apache.derby.impl.sql.execute.IndexChanger.insert(Unknown
> > Source)
> > at org.apache.derby.impl.sql.execute.IndexSetChanger.insert(Unknown
> > Source)
> > at
> > org.apache.derby.impl.sql.execute.RowChangerImpl.insertRow(Unknown Source)
> > at
> > org.apache.derby.impl.sql.execute.InsertResultSet.normalInsertCore(Unknown
> > Source)
> > at org.apache.derby.impl.sql.execute.InsertResultSet.open(Unknown
> > Source)
> > at
> > org.apache.derby.impl.sql.GenericPreparedStatement.execute(Unknown Source)
> > at
> > org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(Unknown Source)
> > at
> > org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeStatement(Unknown
> > Source)
> > at
> > org.apache.derby.impl.jdbc.EmbedPreparedStatement.execute(Unknown Source)
> > at
> > com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.execute(NewProxyPreparedStatement.java:911)
> > at
> > org.jpox.store.rdbms.ParamLoggingPreparedStatement.execute(ParamLoggingPreparedStatement.java:212)
> > at
> > org.jpox.store.rdbms.request.Request.executeUpdate(Request.java:88)
> > at
> > org.jpox.store.rdbms.request.InsertRequest.execute(InsertRequest.java:267)
> > at
> > org.jpox.store.rdbms.table.ClassTable.insert(ClassTable.java:2171)
> > at org.jpox.store.StoreManager.insert(StoreManager.java:757)
> > at
> > org.jpox.state.StateManagerImpl.internalMakePersistent(StateManagerImpl.java:3456
Re: [jira] Updated: (JDO-375) Company model tables are not fully cleaned up
Hi,
thanks for the files. I could successfully run the tck twice with the
attached jars.
Good job!
Regards Michael
> [ http://issues.apache.org/jira/browse/JDO-375?page=all ]
>
> Andy Jefferson updated JDO-375:
> ---
>
> Attachment: jpox-enhancer-SNAPSHOT.jar
> jpox-SNAPSHOT.jar
>
> Attached are jars built from JPOX CVS HEAD. I can confirm the fix works and
> have run the complete TCK twice through with success. Good work!
>
>> Company model tables are not fully cleaned up
>> -
>>
>> Key: JDO-375
>> URL: http://issues.apache.org/jira/browse/JDO-375
>> Project: JDO
>> Type: Bug
>
>> Components: tck20
>> Versions: JDO 2 rc1
>> Reporter: Erik Bengtson
>> Assignee: Erik Bengtson
>> Fix For: JDO 2 final
>> Attachments: JDO-375-2.patch, JDO-375-fknames.patch, JDO-375.patch,
>> jpox-SNAPSHOT.jar, jpox-enhancer-SNAPSHOT.jar
>>
>> Tables from company model does not appear to be clean after run.
>> I can't say if this is a JPOX or TCK issue, because I did not dig into the
>> issue.
>> On second run, exceptions are like
>>> 1)
>>> test(org.apache.jdo.tck.api.persistencemanager.extent.GetExtentWithInstancesMadePersistentViaReachability)javax.jdo.JDODataStoreException:
>>> Insert request failed: INSERT INTO applicationidentity0.COMPANIES
>>> ("NAME",FOUNDEDDATE,ADDRID,CITY,COUNTRY,"STATE",STREET,ZIPCODE,ID,DISCRIMINATOR)
>>> VALUES (?,?,?,?,?,?,?,?,?,?)
>>> at
>>> org.jpox.store.rdbms.request.InsertRequest.execute(InsertRequest.java:393)
>>> at
>>> org.jpox.store.rdbms.table.ClassTable.insert(ClassTable.java:2171)
>>> at org.jpox.store.StoreManager.insert(StoreManager.java:757)
>>> at
>>> org.jpox.state.StateManagerImpl.internalMakePersistent(StateManagerImpl.java:3456)
>>> at
>>> org.jpox.state.StateManagerImpl.makePersistent(StateManagerImpl.java:3429)
>>> at
>>> org.jpox.AbstractPersistenceManager.internalMakePersistent(AbstractPersistenceManager.java:1150)
>>> at
>>> org.jpox.AbstractPersistenceManager.makePersistent(AbstractPersistenceManager.java:1205)
>>> at
>>> org.apache.jdo.tck.api.persistencemanager.extent.GetExtentWithInstancesMadePersistentViaReachability.createObjects(GetExtentWithInstancesMadePersistentViaReachability.java:72)
>>> at
>>> org.apache.jdo.tck.api.persistencemanager.extent.GetExtentWithInstancesMadePersistentViaReachability.test(GetExtentWithInstancesMadePersistentViaReachability.java:63)
>>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>>> at
>>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>>> at
>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>>> at org.apache.jdo.tck.JDO_Test.runBare(JDO_Test.java:237)
>>> at
>>> org.apache.jdo.tck.util.BatchTestRunner.doRun(BatchTestRunner.java:107)
>>> at
>>> org.apache.jdo.tck.util.BatchTestRunner.start(BatchTestRunner.java:147)
>>> at
>>> org.apache.jdo.tck.util.BatchTestRunner.main(BatchTestRunner.java:122)
>>> NestedThrowablesStackTrace:
>>> ERROR 23505: The statement was aborted because it would have caused a
>>> duplicate
>>> key value in a unique or primary key constraint or unique index identified
>>> by
>>> 'COMPS_PK' defined on 'COMPANIES'.
>>> at
>>> org.apache.derby.iapi.error.StandardException.newException(Unknown Source)
>>> at
>>> org.apache.derby.impl.sql.execute.IndexChanger.insertAndCheckDups(Unknown
>>> Source)
>>> at org.apache.derby.impl.sql.execute.IndexChanger.doInsert(Unknown
>>> Source)
>>> at org.apache.derby.impl.sql.execute.IndexChanger.insert(Unknown
>>> Source)
>>> at org.apache.derby.impl.sql.execute.IndexSetChanger.insert(Unknown
>>> Source)
>>> at
>>> org.apache.derby.impl.sql.execute.RowChangerImpl.insertRow(Unknown Source)
>>> at
>>> org.apache.derby.impl.sql.execute.InsertResultSet.normalInsertCore(Unknown
>>> Source)
>>> at org.apache.derby.impl.sql.execute.InsertResultSet.open(Unknown
>>> Source)
>>> at
>>> org.apache.derby.impl.sql.GenericPreparedStatement.execute(Unknown Source)
>>> at
>>> org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(Unknown Source)
>>> at
>>> org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeStatement(Unknown
>>> Source)
>>> at
>>> org.apache.derby.impl.jdbc.EmbedPreparedStatement.execute(Unknown Source)
>>> at
>>> com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.execute(NewProxyPreparedStatement.java:911)
>>> at
>>> org.jpox.store.rdbms.ParamLoggingPreparedStatement.execute(ParamLoggingPreparedStatement.java:212)
>>> at
>>> org.jpox.store.rdbms.request.Request.executeUpdate(Request.java:88)
>>> at
>>> org.jpox.store.rdbms.request.InsertRequest.execute
[jira] Updated: (JDO-377) Company model factory improvements to test persistent interfaces
[ http://issues.apache.org/jira/browse/JDO-377?page=all ] Craig Russell updated JDO-377: -- Fix Version: JDO 2 maintenance release 1 (was: JDO 2 final) Thanks for continuing to improve the test. I think that the new test is valuable but needs a bit more work to make sure the comments are clean and the structure is correct. In particular, the list of allInstances only includes instances that have a managed extent (excludes Address). This inappropriately ties the factory to the usage in the configurations (e.g. another configuration might have the Address require an extent, or might instantiate a Person). The LifecycleCompleteness has an awkward name and there is only one JUnit-visible test method with several sub-tests. The sub-test pattern is useful but we need to rationalize the naming convention for sub-tests. This was done to avoid setup and teardown of the persistent instances but the ramification is that the individual tests cannot be excluded if there is some issue. Perhaps we can modify the exclude list to include not only class name but test name as well. So I think we should continue to work on this after the release of JDO 2. > Company model factory improvements to test persistent interfaces > > > Key: JDO-377 > URL: http://issues.apache.org/jira/browse/JDO-377 > Project: JDO > Type: Improvement > Components: tck20 > Versions: JDO 2 rc1 > Reporter: Craig Russell > Priority: Minor > Fix For: JDO 2 maintenance release 1 > Attachments: JDO-377-mbo.patch, JDO-377.patch, LifecycleCompleteness.java, > lifecyclecompleteness.conf > > Please review this patch. > In order to test persistent interfaces better, a method was added to the > CompanyFactory interface to allow the test program to get the persistent > instances. > List getAllInstances(); > To implement this new API, changes were made to the factory implementation > classes to keep track of instances as they were created. > Additionally, only classes (or interfaces) actually instantiated were put > into the tearDown class array. So Person.class and Employee.class were > removed from the array. > Finally, a bug was fixed in CompanyFactoryPMClass where the interface > IMedicalInsurance.class was incorrectly added to the tearDown class array. > A new test class was used for testing. This class might be added to the TCK > if suitable. > And a new configuration was used for testing. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (JDO-377) Company model factory improvements to test persistent interfaces
[ http://issues.apache.org/jira/browse/JDO-377?page=comments#action_12377267 ] Erik Bengtson commented on JDO-377: --- if you dont plan to commit it for JDO 2, we, JPOX, will give lower priority to the issue. We can work on it for the maintenance release 1 > Company model factory improvements to test persistent interfaces > > > Key: JDO-377 > URL: http://issues.apache.org/jira/browse/JDO-377 > Project: JDO > Type: Improvement > Components: tck20 > Versions: JDO 2 rc1 > Reporter: Craig Russell > Priority: Minor > Fix For: JDO 2 maintenance release 1 > Attachments: JDO-377-mbo.patch, JDO-377.patch, LifecycleCompleteness.java, > lifecyclecompleteness.conf > > Please review this patch. > In order to test persistent interfaces better, a method was added to the > CompanyFactory interface to allow the test program to get the persistent > instances. > List getAllInstances(); > To implement this new API, changes were made to the factory implementation > classes to keep track of instances as they were created. > Additionally, only classes (or interfaces) actually instantiated were put > into the tearDown class array. So Person.class and Employee.class were > removed from the array. > Finally, a bug was fixed in CompanyFactoryPMClass where the interface > IMedicalInsurance.class was incorrectly added to the tearDown class array. > A new test class was used for testing. This class might be added to the TCK > if suitable. > And a new configuration was used for testing. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[VOTE] Release Apache JDO 2.0 TCK
Javadogs,This vote is to release the Apache JDO 2.0 TCK, along with the two projects that it depends on: core20 and enhancer20. [+1] Release tck20, core20, and enhancer20 [0] Don't care[-1] Don't release tck20, core20, and enhancer20 because:The TCK can be tested from the staging area, http://people.apache.org/~clr/dist. The source distribution of tck20 can be found in the db/jdo directory. The maven jdo jars can be found in the java-repository directory. The JPOX reference implementation can be downloaded for testing against this tck at /jira/secure/attachment/12326093/jpox-SNAPSHOT.jar and/jira/secure/attachment/12326092/jpox-enhancer-SNAPSHOT.jarPlease test and vote.Craig Craig Russell Architect, Sun Java Enterprise System http://java.sun.com/products/jdo 408 276-5638 mailto:[EMAIL PROTECTED] P.S. A good JDO? O, Gasp! smime.p7s Description: S/MIME cryptographic signature
[jira] Commented: (JDO-377) Company model factory improvements to test persistent interfaces
[ http://issues.apache.org/jira/browse/JDO-377?page=comments#action_12377300 ] Craig Russell commented on JDO-377: --- I won't commit this for the final JDO 2.0 tck release. I'm sure JPOX have their hands full making the official 1.1.0 release. > Company model factory improvements to test persistent interfaces > > > Key: JDO-377 > URL: http://issues.apache.org/jira/browse/JDO-377 > Project: JDO > Type: Improvement > Components: tck20 > Versions: JDO 2 rc1 > Reporter: Craig Russell > Priority: Minor > Fix For: JDO 2 maintenance release 1 > Attachments: JDO-377-mbo.patch, JDO-377.patch, LifecycleCompleteness.java, > lifecyclecompleteness.conf > > Please review this patch. > In order to test persistent interfaces better, a method was added to the > CompanyFactory interface to allow the test program to get the persistent > instances. > List getAllInstances(); > To implement this new API, changes were made to the factory implementation > classes to keep track of instances as they were created. > Additionally, only classes (or interfaces) actually instantiated were put > into the tearDown class array. So Person.class and Employee.class were > removed from the array. > Finally, a bug was fixed in CompanyFactoryPMClass where the interface > IMedicalInsurance.class was incorrectly added to the tearDown class array. > A new test class was used for testing. This class might be added to the TCK > if suitable. > And a new configuration was used for testing. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [VOTE] Release Apache JDO 2.0 TCK
Sorry, forgot to mention this vote will be open for three days, ending on Thursday May 4.CraigOn May 1, 2006, at 4:57 PM, Craig L Russell wrote:Javadogs,This vote is to release the Apache JDO 2.0 TCK, along with the two projects that it depends on: core20 and enhancer20. [+1] Release tck20, core20, and enhancer20 [0] Don't care[-1] Don't release tck20, core20, and enhancer20 because:The TCK can be tested from the staging area, http://people.apache.org/~clr/dist. The source distribution of tck20 can be found in the db/jdo directory. The maven jdo jars can be found in the java-repository directory. The JPOX reference implementation can be downloaded for testing against this tck at /jira/secure/attachment/12326093/jpox-SNAPSHOT.jar and/jira/secure/attachment/12326092/jpox-enhancer-SNAPSHOT.jarPlease test and vote.CraigCraig RussellArchitect, Sun Java Enterprise System http://java.sun.com/products/jdo408 276-5638 mailto:[EMAIL PROTECTED]P.S. A good JDO? O, Gasp! Craig Russell Architect, Sun Java Enterprise System http://java.sun.com/products/jdo 408 276-5638 mailto:[EMAIL PROTECTED] P.S. A good JDO? O, Gasp! smime.p7s Description: S/MIME cryptographic signature
Release of JPOX 1.1
Hi Craig, Do you have any particular requirements for the release of JPOX 1.1 as RI that we need to be aware of when releasing ? With respect to CVS tags of the code, I propose tagging the release as JDO_2_RI as well as RELEASE_1_1_0 (our usual release tag) We will be releasing the usual bundles for 1.1.0 :- 1. Binaries : jpox-1.1.0.jar, jpox-enhancer-1.1.0.jar, jpox-1.1.0.rar 2. Source : jpox-1.1.0-src.tar.gz, jpoz-1.1.0-src.zip, jpox-enhancer-1.1.0-src.tar.gz, jpox-enhancer-1.1.0-src.zip 3. Docs : jpox-docs-1.1.0.tar.gz, jpox-docs-1.1.0.zip In addition there are (already) 1.1.0 versions of all Plugins (DBCP, C3P0, etc) that are usable with the RI. Anything else ? -- Andy
