Re: svn commit: r1488078 - /db/jdo/trunk/tck/src/java/org/apache/jdo/tck/api/persistencemanager/GetProperties.java
Thanks for testing. Craig On May 31, 2013, at 8:22 PM, Michelle Caisse wrote: > All tests pass for me. -- Michelle > > On 5/30/2013 6:44 PM, c...@apache.org wrote: >> Author: clr >> Date: Fri May 31 01:44:02 2013 >> New Revision: 1488078 >> >> URL: http://svn.apache.org/r1488078 >> Log: >> Add mixed case tests to getProperties tests >> >> Modified: >> >> db/jdo/trunk/tck/src/java/org/apache/jdo/tck/api/persistencemanager/GetProperties.java >> >> Modified: >> db/jdo/trunk/tck/src/java/org/apache/jdo/tck/api/persistencemanager/GetProperties.java >> URL: >> http://svn.apache.org/viewvc/db/jdo/trunk/tck/src/java/org/apache/jdo/tck/api/persistencemanager/GetProperties.java?rev=1488078&r1=1488077&r2=1488078&view=diff >> == >> --- >> db/jdo/trunk/tck/src/java/org/apache/jdo/tck/api/persistencemanager/GetProperties.java >> (original) >> +++ >> db/jdo/trunk/tck/src/java/org/apache/jdo/tck/api/persistencemanager/GetProperties.java >> Fri May 31 01:44:02 2013 >> @@ -178,6 +178,18 @@ public class GetProperties extends JDO_T >> public void set(PersistenceManager pm, Object value) >> {pm.setMultithreaded((Boolean) value);} >> }; >> +private TestProperty testLowerCaseMultithreaded = >> +new AbstractAPITestProperty(PROPERTY_MULTITHREADED, true, >> false) { >> +public Object get(PersistenceManager pm) {return >> pm.getMultithreaded();} >> +public void set(PersistenceManager pm, Object value) >> {pm.setProperty("javax.jdo.option.multithreaded", (Boolean) value);} >> +}; >> + >> +private TestProperty testUpperCaseMultithreaded = >> +new AbstractAPITestProperty(PROPERTY_MULTITHREADED, true, false) { >> +public Object get(PersistenceManager pm) {return pm.getMultithreaded();} >> +public void set(PersistenceManager pm, Object value) >> {pm.setProperty("javax.jdo.option.MULTITHREADED", (Boolean) value);} >> +}; >> + >> private TestProperty testDetachAllOnCommit = >> new AbstractAPITestProperty(PROPERTY_DETACH_ALL_ON_COMMIT, >> true, false) { >> public Object get(PersistenceManager pm) {return >> pm.getDetachAllOnCommit();} >> @@ -242,7 +254,8 @@ public class GetProperties extends JDO_T >> testRequiredProperties.add(testIgnoreCache); >> testRequiredProperties.add(testRestoreValues); >> -testOptionalProperties.put(PROPERTY_MULTITHREADED, >> setOf(testMultithreaded)); >> +testOptionalProperties.put(PROPERTY_MULTITHREADED, >> setOf(testMultithreaded, testLowerCaseMultithreaded, >> +testUpperCaseMultithreaded)); >> testOptionalProperties.put(OPTION_DATASTORE_TIMEOUT, >> setOf(testDatastoreReadTimeoutMillis, >> testDatastoreWriteTimeoutMillis)); >> testOptionalProperties.put(PROPERTY_OPTIMISTIC, >> setOf(testOptimistic)); >> >> >> > Craig L Russell Architect, Oracle http://db.apache.org/jdo 408 276-5638 mailto:craig.russ...@oracle.com P.S. A good JDO? O, Gasp!
Re: svn commit: r1488078 - /db/jdo/trunk/tck/src/java/org/apache/jdo/tck/api/persistencemanager/GetProperties.java
All tests pass for me. -- Michelle On 5/30/2013 6:44 PM, c...@apache.org wrote: Author: clr Date: Fri May 31 01:44:02 2013 New Revision: 1488078 URL: http://svn.apache.org/r1488078 Log: Add mixed case tests to getProperties tests Modified: db/jdo/trunk/tck/src/java/org/apache/jdo/tck/api/persistencemanager/GetProperties.java Modified: db/jdo/trunk/tck/src/java/org/apache/jdo/tck/api/persistencemanager/GetProperties.java URL: http://svn.apache.org/viewvc/db/jdo/trunk/tck/src/java/org/apache/jdo/tck/api/persistencemanager/GetProperties.java?rev=1488078&r1=1488077&r2=1488078&view=diff == --- db/jdo/trunk/tck/src/java/org/apache/jdo/tck/api/persistencemanager/GetProperties.java (original) +++ db/jdo/trunk/tck/src/java/org/apache/jdo/tck/api/persistencemanager/GetProperties.java Fri May 31 01:44:02 2013 @@ -178,6 +178,18 @@ public class GetProperties extends JDO_T public void set(PersistenceManager pm, Object value) {pm.setMultithreaded((Boolean) value);} }; +private TestProperty testLowerCaseMultithreaded = +new AbstractAPITestProperty(PROPERTY_MULTITHREADED, true, false) { +public Object get(PersistenceManager pm) {return pm.getMultithreaded();} +public void set(PersistenceManager pm, Object value) {pm.setProperty("javax.jdo.option.multithreaded", (Boolean) value);} +}; + +private TestProperty testUpperCaseMultithreaded = +new AbstractAPITestProperty(PROPERTY_MULTITHREADED, true, false) { +public Object get(PersistenceManager pm) {return pm.getMultithreaded();} +public void set(PersistenceManager pm, Object value) {pm.setProperty("javax.jdo.option.MULTITHREADED", (Boolean) value);} +}; + private TestProperty testDetachAllOnCommit = new AbstractAPITestProperty(PROPERTY_DETACH_ALL_ON_COMMIT, true, false) { public Object get(PersistenceManager pm) {return pm.getDetachAllOnCommit();} @@ -242,7 +254,8 @@ public class GetProperties extends JDO_T testRequiredProperties.add(testIgnoreCache); testRequiredProperties.add(testRestoreValues); -testOptionalProperties.put(PROPERTY_MULTITHREADED, setOf(testMultithreaded)); +testOptionalProperties.put(PROPERTY_MULTITHREADED, setOf(testMultithreaded, testLowerCaseMultithreaded, +testUpperCaseMultithreaded)); testOptionalProperties.put(OPTION_DATASTORE_TIMEOUT, setOf(testDatastoreReadTimeoutMillis, testDatastoreWriteTimeoutMillis)); testOptionalProperties.put(PROPERTY_OPTIMISTIC, setOf(testOptimistic));
Minutes: JDO TCK Conference Call Friday May 31, 9 am Pacific Daylight Time
Attendees: Michelle Caisse, Michael Bouschen, Craig Russell Agenda: 1. Fixed TCK query test failure: possible time zone issue in SupportedDateMethods? https://issues.apache.org/jira/browse/JDO-720 Seems like the issue is resolved. AI Michael resolve the JIRA. 2. News on JDO-678 "Ability to set properties on PersistenceManager" https://issues.apache.org/jira/browse/JDO-678 Should enumerate the properties that are supported and refer to the javax.jdo.Constants that defines them. AI Craig: put a table into an Appendix enumerating the properties and an indication of whether the property is an option or a property or both. AI Michelle: add an empty Appendix K to put the table into and update the book to include it. 3. Other issues Michelle start the process of building a release candidate for 3.1. Action Items from weeks past: [May 10 2013] AI Everyone take a look Apache ISIS and maybe subscribe to ISIS mail lists. [May 10 2013] AI Matthew take a deeper look into the way how JPA defines entity graphs (centralized vs. distributed across the metadata in JDO) [Aug 24 2012] AI Craig update the JIRAs JDO-689 JDO-690 and JDO-692 about JDOHelper methods. In process. [Aug 17 2012] AI Craig comment on JIRA JDO-589 Autocommit or nontransactional action [Sep 23 2011] AI Michael document when changing dependencies (to DataNucleus) it's necessary to rebuild the exectck project before running tck. -- Craig L Russell Architect, Oracle http://db.apache.org/jdo 408 276-5638 mailto:craig.russ...@oracle.com P.S. A good JDO? O, Gasp!
[jira] [Assigned] (JDO-720) Possible time zone issue in SupportedDateMethods
[ https://issues.apache.org/jira/browse/JDO-720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen reassigned JDO-720: Assignee: Michael Bouschen > Possible time zone issue in SupportedDateMethods > > > Key: JDO-720 > URL: https://issues.apache.org/jira/browse/JDO-720 > Project: JDO > Issue Type: Bug > Components: tck >Affects Versions: JDO 3 update 1 (3.0.1) >Reporter: Michael Bouschen >Assignee: Michael Bouschen > Fix For: JDO 3 maintenance release 1 (3.1) > > Attachments: JDO-720.patch > > > The TCK query test SupportedDateMethods fails when running a Date.getDate > query: the query result is empty where it should include an employee > instacne. > Please note, the failure occurs when running the test in California and > Arizona, but not in Europe. > Looks like the problem is in the company model reader creating a date in the > America/New_York time zone that is actually yesterday in other time zones, so > the tests fail. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (JDO-720) Possible time zone issue in SupportedDateMethods
[ https://issues.apache.org/jira/browse/JDO-720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bouschen resolved JDO-720. -- Resolution: Fixed > Possible time zone issue in SupportedDateMethods > > > Key: JDO-720 > URL: https://issues.apache.org/jira/browse/JDO-720 > Project: JDO > Issue Type: Bug > Components: tck >Affects Versions: JDO 3 update 1 (3.0.1) >Reporter: Michael Bouschen >Assignee: Michael Bouschen > Fix For: JDO 3 maintenance release 1 (3.1) > > Attachments: JDO-720.patch > > > The TCK query test SupportedDateMethods fails when running a Date.getDate > query: the query result is empty where it should include an employee > instacne. > Please note, the failure occurs when running the test in California and > Arizona, but not in Europe. > Looks like the problem is in the company model reader creating a date in the > America/New_York time zone that is actually yesterday in other time zones, so > the tests fail. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira