[GitHub] [db-jdo] sonarcloud[bot] commented on pull request #72: JDO-823: Remove unused local variable
sonarcloud[bot] commented on PR #72: URL: https://github.com/apache/db-jdo/pull/72#issuecomment-1490859079 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=db-jdo=72) [](https://sonarcloud.io/project/issues?id=db-jdo=72=false=BUG) [](https://sonarcloud.io/project/issues?id=db-jdo=72=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=db-jdo=72=false=BUG) [](https://sonarcloud.io/project/issues?id=db-jdo=72=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=db-jdo=72=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo=72=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=db-jdo=72=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=db-jdo=72=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo=72=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=db-jdo=72=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=db-jdo=72=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=db-jdo=72=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=db-jdo=72) No Coverage information [](https://sonarcloud.io/component_measures?id=db-jdo=72=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=db-jdo=72=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [db-jdo] sonarcloud[bot] commented on pull request #72: JDO-823: Remove unused local variable
sonarcloud[bot] commented on PR #72: URL: https://github.com/apache/db-jdo/pull/72#issuecomment-1490850995 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=db-jdo=72) [](https://sonarcloud.io/project/issues?id=db-jdo=72=false=BUG) [](https://sonarcloud.io/project/issues?id=db-jdo=72=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=db-jdo=72=false=BUG) [](https://sonarcloud.io/project/issues?id=db-jdo=72=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=db-jdo=72=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo=72=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=db-jdo=72=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=db-jdo=72=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo=72=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=db-jdo=72=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=db-jdo=72=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=db-jdo=72=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=db-jdo=72) No Coverage information [](https://sonarcloud.io/component_measures?id=db-jdo=72=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=db-jdo=72=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [db-jdo] tzaeschke opened a new pull request, #72: JDO-823: Remove unused local variable
tzaeschke opened a new pull request, #72: URL: https://github.com/apache/db-jdo/pull/72 Remove unused local variables. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Minutes: JDO TCK Conference Call Thursday March 30 1100 PDT 2000 CEST
Attendees: Michael Bouschen, Tilmann Zäschke, Tobias Bouschen, Craig Russell Next meeting: Thursday April 6 1100 PDT 2000 CET Agenda: 1. JIRA JDO-819 "Code quality analysis" https://issues.apache.org/jira/browse/JDO-819 JIRA JDO-823 "Fix sonarcloud issues of type Code Smells" https://issues.apache.org/jira/browse/JDO-823 Sonarcloud link: https://sonarcloud.io/summary/overall?id=db-jdo * Loops should not contain more than a single "break" or "continue" statement: https://sonarcloud.io/project/issues?resolved=false=java%3AS135=CODE_SMELL=db-jdo RunTCK: Still need a volunteer to look at the very complex method. * Type parameter names should comply with naming convention: https://sonarcloud.io/project/issues?resolved=false=java%3AS119=CODE_SMELL=db-jdo Resolve: make the parameter S; update javadoc if necessary. AI Michael * Unused local variables should be removed: https://sonarcloud.io/project/issues?resolved=false=java%3AS1481=CODE_SMELL=db-jdo Utilities.createReaderThread has unused variables count and outputBytesRead AI Tilmann try removing the unused variables * Cognitive Complexity of methods should not be too high: https://sonarcloud.io/project/issues?resolved=false=java%3AS3776=CRITICAL=CODE_SMELL=db-jdo * Raw types should not be used: https://sonarcloud.io/project/issues?resolved=false=java%3AS3740=MAJOR=db-jdo 2. JIRA JDO-709 "Standardize field/property converters" https://issues.apache.org/jira/browse/JDO-709 3. JIRA JDO-822: "Verify compatibility with JDK 20" https://issues.apache.org/jira/browse/JDO-822 4. JIRA JDO-812 "Move to JDK 11 as the lowest supported version" https://issues.apache.org/jira/browse/JDO-812 5. Other issues Action Items from weeks past: [Mar 23 2023] AI Craig: In exectck PropertyUtils look at the method names and parameter names and javadoc for string2Set and string2List See other email. Proposed change: Collection to List and change implementations to remove loop. [Mar 16 2023] AI Tobias JDOException.inPrintStackTrace is modified during the execution of the method: look into it. [Nov 23 2022] AI Tilmann follow up with Andy/DataNucleus for his advice on JDO-709. [Oct 20 2022] AI Craig update the JIRA JDO-709 to request a test case using annotations and results of the test. [Dec 09 2021] AI Craig: Try to contact all current/former participants in JDO development and see if and how they want to be recognized on the JDO and DB web sites.https://db.apache.org/whoweare.html [Oct 07 2021] AI Craig send a private message to all JSR-243 Expert Group members asking if they wish to continue. [Mar 25 2021] AI Craig: investigate "merging" papajdo and apache.clr accounts [Oct 17 2014] AI Matthew any updates for "Modify specification to address NoSQL datastores" https://issues.apache.org/jira/browse/JDO-651 Craig L Russell c...@apache.org
Proposal for code smell Use ... "Collections.addAll" or "System.arraycopy" instead.
Two methods with different names but identical implementation:
public static void string2Set(String names, Collection list)
public static void string2List(String names, List list)
The behavior only depends on the actual type of the "list" parameter.
Proposal: change implementations of both methods from iterating over the split
list of the argument to use the addAll of the second parameter
Both methods are used in the TCK:
clr% grep -R "string2Set" .
./exectck/src/main/java/org/apache/jdo/exectck/RunTCK.java:
PropertyUtils.string2Set(dblist, dbs);
./exectck/src/main/java/org/apache/jdo/exectck/RunTCK.java:
PropertyUtils.string2Set(identitytypes, idtypes);
./exectck/src/main/java/org/apache/jdo/exectck/InstallSchema.java:
PropertyUtils.string2Set(cfgList, cfgs);
./exectck/src/main/java/org/apache/jdo/exectck/InstallSchema.java:
PropertyUtils.string2Set(cfgList, cfgs);
./exectck/src/main/java/org/apache/jdo/exectck/InstallSchema.java:
PropertyUtils.string2Set(dblist, dbs);
./exectck/src/main/java/org/apache/jdo/exectck/InstallSchema.java:
PropertyUtils.string2Set(identitytypes, idtypes);
./exectck/src/main/java/org/apache/jdo/exectck/PropertyUtils.java: public
static void string2Set(String names, Collection list) {
./exectck/src/main/java/org/apache/jdo/exectck/Enhance.java:
PropertyUtils.string2Set(identitytypes, idtypes);
clr% grep -R "string2List" .
./exectck/src/main/java/org/apache/jdo/exectck/RunTCK.java:
PropertyUtils.string2List(cfgList, (List) cfgs);
./exectck/src/main/java/org/apache/jdo/exectck/RunTCK.java:
PropertyUtils.string2List(cfgList, (List) cfgs);
./exectck/src/main/java/org/apache/jdo/exectck/PropertyUtils.java: public
static void string2List(String names, List list) {
Craig L Russell
c...@apache.org
