Re: [PR] Move log files + cleanup (db-jdo)

2023-11-25 Thread via GitHub


clr-apache commented on PR #88:
URL: https://github.com/apache/db-jdo/pull/88#issuecomment-1826458130

   I agree. Ok to merge to main.
   
   Craig
   
   > On Nov 25, 2023, at 14:16, Michael Bouschen ***@***.***> wrote:
   > 
   > 
   > The changes look good, ship it.
   > 
   > —
   > Reply to this email directly, view it on GitHub 
, or 
unsubscribe 
.
   > You are receiving this because you are subscribed to this thread.
   > 
   
   Craig L Russell
   ***@***.***
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Move log files + cleanup (db-jdo)

2023-11-25 Thread via GitHub


mboapache commented on PR #88:
URL: https://github.com/apache/db-jdo/pull/88#issuecomment-1826431269

   The changes look good, ship it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GH] (db-jdo): Workflow run "Build JDO & Run TCK" is working again!

2023-11-25 Thread GitBox


The GitHub Actions job "Build JDO & Run TCK" on db-jdo.git has succeeded.
Run started by GitHub user tzaeschke (triggered by tzaeschke).

Head commit for run:
db9533897cf6cf48495ee890017c1c11d1eaed39 / Tilmann 
Update RunTCK.java

Report URL: https://github.com/apache/db-jdo/actions/runs/6990697058

With regards,
GitHub Actions via GitBox



Re: [PR] Move log files + cleanup (db-jdo)

2023-11-25 Thread via GitHub


sonarcloud[bot] commented on PR #88:
URL: https://github.com/apache/db-jdo/pull/88#issuecomment-1826392651

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=db-jdo=88)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=db-jdo=88=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo=88=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=db-jdo=88=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=db-jdo=88=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo=88=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo=88=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=db-jdo=88=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=db-jdo=88=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo=88=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=db-jdo=88=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo=88=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=db-jdo=88=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=db-jdo=88)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=db-jdo=88=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=db-jdo=88=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GH] (db-jdo): Workflow run "Build JDO & Run TCK" failed!

2023-11-25 Thread GitBox


The GitHub Actions job "Build JDO & Run TCK" on db-jdo.git has failed.
Run started by GitHub user tzaeschke (triggered by tzaeschke).

Head commit for run:
c1f223c333a578bb0bf8db9c87bc38c04dcb6b29 / Tilmann 
Move log files + cleanup

Report URL: https://github.com/apache/db-jdo/actions/runs/6990659964

With regards,
GitHub Actions via GitBox



Re: [PR] Move log files + cleanup (db-jdo)

2023-11-25 Thread via GitHub


sonarcloud[bot] commented on PR #88:
URL: https://github.com/apache/db-jdo/pull/88#issuecomment-1826392197

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=db-jdo=88)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=db-jdo=88=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo=88=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=db-jdo=88=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=db-jdo=88=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo=88=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo=88=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=db-jdo=88=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=db-jdo=88=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo=88=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=db-jdo=88=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo=88=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=db-jdo=88=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=db-jdo=88)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=db-jdo=88=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=db-jdo=88=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Move log files + cleanup (db-jdo)

2023-11-25 Thread via GitHub


tzaeschke opened a new pull request, #88:
URL: https://github.com/apache/db-jdo/pull/88

   This PR moves log files instead of copying them, see 
https://issues.apache.org/jira/browse/JDO-834.
   
   It also contains some minor cleanup:
   - Added `command.add("execute");` in `RunTck` to JUnit test execution. This 
prevents output of deprecation notice.
   - Fixed some javadoc comments
   - Removed debug print statements from `Point` class.
 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: Minutes: JDO TCK meeting Tuesday November 21 1100 PST 2000 CET

2023-11-25 Thread Tilmann Zäschke

Great, that works perfectly! :-)

On 21/11/2023 22:22, Michael Bouschen wrote:

Hi,


...

3. JDO-830: "tck: Migrate JUnit tests to version 5" 
https://issues.apache.org/jira/browse/JDO-830

PR #85 https://github.com/apache/db-jdo/pull/85

Still some issues with ConsoleLauncher writing to log files...
Good to merge. If still (color) issues with Console, another JIRA can 
be filed.


I found a way to disable the color in the junit result. The 
ConsoleLauncher has an option --disable-ansi-colors that does the job.


I checked in a change that makes use of option --disable-ansi-colors 
into the main branch. Please give it a try.


Regards Michael


Merged.

...