Re: [PR] Bump commons-io:commons-io from 2.11.0 to 2.14.0 in /parent-pom (db-jdo)

[via GitHub]

mboapache merged PR #95:
URL: https://github.com/apache/db-jdo/pull/95


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JDO-835 Fixed concurrency issue when running ResultClassRequirementsMap query… (db-jdo)

[via GitHub]

tzaeschke merged PR #94:
URL: https://github.com/apache/db-jdo/pull/94


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JDO-835 Fixed concurrency issue when running ResultClassRequirementsMap query… (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #94:
URL: https://github.com/apache/db-jdo/pull/94#issuecomment-2271980203

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=94) **Quality 
Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=94&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=94&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=94&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=94&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=94&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=94)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JDO-840: Fix changes links on JDO news site (db-jdo-site)

[via GitHub]

mboapache merged PR #52:
URL: https://github.com/apache/db-jdo-site/pull/52


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JDO-840: Fix changes links on JDO news site (db-jdo-site)

[via GitHub]

tzaeschke commented on PR #52:
URL: https://github.com/apache/db-jdo-site/pull/52#issuecomment-2059669167

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] JDO-840: Fix changes links on JDO news site (db-jdo-site)

[via GitHub]

mboapache opened a new pull request, #52:
URL: https://github.com/apache/db-jdo-site/pull/52

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Update downloads.adoc (db-jdo-site)

[via GitHub]

clr-apache merged PR #51:
URL: https://github.com/apache/db-jdo-site/pull/51


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] Update downloads.adoc (db-jdo-site)

[via GitHub]

clr-apache opened a new pull request, #51:
URL: https://github.com/apache/db-jdo-site/pull/51

   Remove obsolete JDO releases:
   3.1 uses sha1 which is not considered safe
   3.0.1 TCK and API do not have any sha so are not considered safe


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Update GitHub actions (db-jdo-site)

[via GitHub]

tobous merged PR #50:
URL: https://github.com/apache/db-jdo-site/pull/50


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Update GitHub actions (db-jdo-site)

[via GitHub]

tzaeschke commented on PR #50:
URL: https://github.com/apache/db-jdo-site/pull/50#issuecomment-1967872713

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Update GitHub Action versions (db-jdo)

[via GitHub]

tobous merged PR #93:
URL: https://github.com/apache/db-jdo/pull/93


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] Update GitHub actions (db-jdo-site)

[via GitHub]

tobous opened a new pull request, #50:
URL: https://github.com/apache/db-jdo-site/pull/50

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Update GitHub Action versions (db-jdo)

[via GitHub]

tzaeschke commented on PR #93:
URL: https://github.com/apache/db-jdo/pull/93#issuecomment-1967487150

   LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Update GitHub Action versions (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #93:
URL: https://github.com/apache/db-jdo/pull/93#issuecomment-1967484286

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=93) **Quality 
Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=93&resolved=false&inNewCodePeriod=true)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=93&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Coverage  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Duplication  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=93)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] Update GitHub Action versions (db-jdo)

[via GitHub]

tobous opened a new pull request, #93:
URL: https://github.com/apache/db-jdo/pull/93

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Clarify javadoc of Query.cancel() and cancelAll() (db-jdo)

[via GitHub]

tzaeschke merged PR #92:
URL: https://github.com/apache/db-jdo/pull/92


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Clarify javadoc of Query.cancel() and cancelAll() (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #92:
URL: https://github.com/apache/db-jdo/pull/92#issuecomment-1962993556

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=92) **Quality 
Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=92&resolved=false&inNewCodePeriod=true)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=92&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Coverage  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=92&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=92)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GH] Clarify javadoc of Query.cancel() and cancelAll() (db-jdo)

[via GitHub]

clr-apache commented on code in PR #92:
URL: https://github.com/apache/db-jdo/pull/92#discussion_r1501720431


##
api/src/main/java/javax/jdo/Query.java:
##
@@ -759,18 +759,19 @@ void addSubquery(
   Integer getDatastoreWriteTimeoutMillis();
 
   /**
-   * Method to cancel any executing queries. If the underlying datastore 
doesn't support
-   * cancellation of queries this will throw JDOUnsupportedOptionException. If 
the cancellation
-   * fails (e.g in the underlying datastore) then this will throw a 
JDOException.
+   * Method to cancel all executions of this query instance. If the underlying 
datastore doesn't
+   * support cancellation of queries this will throw 
JDOUnsupportedOptionException. If the
+   * cancellation fails (e.g in the underlying datastore) then this will throw 
a JDOException.
*
* @since 3.0
*/
   void cancelAll();
 
   /**
-   * Method to cancel an executing query in the specified thread. If the 
underlying datastore
-   * doesn't support cancellation of queries this will throw 
JDOUnsupportedOptionException. If the
-   * cancellation fails (e.g in the underlying datastore) then this will throw 
a JDOException.
+   * Method to cancel any executions of this query instance that run in the 
specified thread. If the
+   * underlying datastore doesn't support cancellation of queries this will 
throw
+   * JDOUnsupportedOptionException. If the cancellation fails (e.g in the 
underlying datastore) then
+   * this will throw a JDOException.
*
* @param thread The thread to cancel

Review Comment:
   Perhaps "Method to cancel an execution of this query in the parameter 
thread."



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GH] Clarify javadoc of Query.cancel() and cancelAll() (db-jdo)

[via GitHub]

ezoerner commented on code in PR #92:
URL: https://github.com/apache/db-jdo/pull/92#discussion_r1501694210


##
api/src/main/java/javax/jdo/Query.java:
##
@@ -759,18 +759,19 @@ void addSubquery(
   Integer getDatastoreWriteTimeoutMillis();
 
   /**
-   * Method to cancel any executing queries. If the underlying datastore 
doesn't support
-   * cancellation of queries this will throw JDOUnsupportedOptionException. If 
the cancellation
-   * fails (e.g in the underlying datastore) then this will throw a 
JDOException.
+   * Method to cancel all executions of this query instance. If the underlying 
datastore doesn't
+   * support cancellation of queries this will throw 
JDOUnsupportedOptionException. If the
+   * cancellation fails (e.g in the underlying datastore) then this will throw 
a JDOException.
*
* @since 3.0
*/
   void cancelAll();
 
   /**
-   * Method to cancel an executing query in the specified thread. If the 
underlying datastore
-   * doesn't support cancellation of queries this will throw 
JDOUnsupportedOptionException. If the
-   * cancellation fails (e.g in the underlying datastore) then this will throw 
a JDOException.
+   * Method to cancel any executions of this query instance that run in the 
specified thread. If the
+   * underlying datastore doesn't support cancellation of queries this will 
throw
+   * JDOUnsupportedOptionException. If the cancellation fails (e.g in the 
underlying datastore) then
+   * this will throw a JDOException.
*
* @param thread The thread to cancel

Review Comment:
   (because otherwise it can be read as possibly canceling other query 
instances, which the reference implementation does not do)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GH] Clarify javadoc of Query.cancel() and cancelAll() (db-jdo)

[via GitHub]

ezoerner commented on code in PR #92:
URL: https://github.com/apache/db-jdo/pull/92#discussion_r1501693614


##
api/src/main/java/javax/jdo/Query.java:
##
@@ -759,18 +759,19 @@ void addSubquery(
   Integer getDatastoreWriteTimeoutMillis();
 
   /**
-   * Method to cancel any executing queries. If the underlying datastore 
doesn't support
-   * cancellation of queries this will throw JDOUnsupportedOptionException. If 
the cancellation
-   * fails (e.g in the underlying datastore) then this will throw a 
JDOException.
+   * Method to cancel all executions of this query instance. If the underlying 
datastore doesn't
+   * support cancellation of queries this will throw 
JDOUnsupportedOptionException. If the
+   * cancellation fails (e.g in the underlying datastore) then this will throw 
a JDOException.
*
* @since 3.0
*/
   void cancelAll();
 
   /**
-   * Method to cancel an executing query in the specified thread. If the 
underlying datastore
-   * doesn't support cancellation of queries this will throw 
JDOUnsupportedOptionException. If the
-   * cancellation fails (e.g in the underlying datastore) then this will throw 
a JDOException.
+   * Method to cancel any executions of this query instance that run in the 
specified thread. If the
+   * underlying datastore doesn't support cancellation of queries this will 
throw
+   * JDOUnsupportedOptionException. If the cancellation fails (e.g in the 
underlying datastore) then
+   * this will throw a JDOException.
*
* @param thread The thread to cancel

Review Comment:
   Even so I think it would still be more clear to say “of this query instance” 
instead of “any executing queries”



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GH] Clarify javadoc of Query.cancel() and cancelAll() (db-jdo)

[via GitHub]

ezoerner commented on code in PR #92:
URL: https://github.com/apache/db-jdo/pull/92#discussion_r1501694210


##
api/src/main/java/javax/jdo/Query.java:
##
@@ -759,18 +759,19 @@ void addSubquery(
   Integer getDatastoreWriteTimeoutMillis();
 
   /**
-   * Method to cancel any executing queries. If the underlying datastore 
doesn't support
-   * cancellation of queries this will throw JDOUnsupportedOptionException. If 
the cancellation
-   * fails (e.g in the underlying datastore) then this will throw a 
JDOException.
+   * Method to cancel all executions of this query instance. If the underlying 
datastore doesn't
+   * support cancellation of queries this will throw 
JDOUnsupportedOptionException. If the
+   * cancellation fails (e.g in the underlying datastore) then this will throw 
a JDOException.
*
* @since 3.0
*/
   void cancelAll();
 
   /**
-   * Method to cancel an executing query in the specified thread. If the 
underlying datastore
-   * doesn't support cancellation of queries this will throw 
JDOUnsupportedOptionException. If the
-   * cancellation fails (e.g in the underlying datastore) then this will throw 
a JDOException.
+   * Method to cancel any executions of this query instance that run in the 
specified thread. If the
+   * underlying datastore doesn't support cancellation of queries this will 
throw
+   * JDOUnsupportedOptionException. If the cancellation fails (e.g in the 
underlying datastore) then
+   * this will throw a JDOException.
*
* @param thread The thread to cancel

Review Comment:
   (because otherwise it can be read as possibly canceling some other query 
instance if running on the specified thread)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GH] Clarify javadoc of Query.cancel() and cancelAll() (db-jdo)

[via GitHub]

ezoerner commented on code in PR #92:
URL: https://github.com/apache/db-jdo/pull/92#discussion_r1501693614


##
api/src/main/java/javax/jdo/Query.java:
##
@@ -759,18 +759,19 @@ void addSubquery(
   Integer getDatastoreWriteTimeoutMillis();
 
   /**
-   * Method to cancel any executing queries. If the underlying datastore 
doesn't support
-   * cancellation of queries this will throw JDOUnsupportedOptionException. If 
the cancellation
-   * fails (e.g in the underlying datastore) then this will throw a 
JDOException.
+   * Method to cancel all executions of this query instance. If the underlying 
datastore doesn't
+   * support cancellation of queries this will throw 
JDOUnsupportedOptionException. If the
+   * cancellation fails (e.g in the underlying datastore) then this will throw 
a JDOException.
*
* @since 3.0
*/
   void cancelAll();
 
   /**
-   * Method to cancel an executing query in the specified thread. If the 
underlying datastore
-   * doesn't support cancellation of queries this will throw 
JDOUnsupportedOptionException. If the
-   * cancellation fails (e.g in the underlying datastore) then this will throw 
a JDOException.
+   * Method to cancel any executions of this query instance that run in the 
specified thread. If the
+   * underlying datastore doesn't support cancellation of queries this will 
throw
+   * JDOUnsupportedOptionException. If the cancellation fails (e.g in the 
underlying datastore) then
+   * this will throw a JDOException.
*
* @param thread The thread to cancel

Review Comment:
   Even so I think it would still be more clear to say “of this query instance” 
instead of “an executing query”



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GH] Clarify javadoc of Query.cancel() and cancelAll() (db-jdo)

[via GitHub]

ezoerner commented on code in PR #92:
URL: https://github.com/apache/db-jdo/pull/92#discussion_r1501693614


##
api/src/main/java/javax/jdo/Query.java:
##
@@ -759,18 +759,19 @@ void addSubquery(
   Integer getDatastoreWriteTimeoutMillis();
 
   /**
-   * Method to cancel any executing queries. If the underlying datastore 
doesn't support
-   * cancellation of queries this will throw JDOUnsupportedOptionException. If 
the cancellation
-   * fails (e.g in the underlying datastore) then this will throw a 
JDOException.
+   * Method to cancel all executions of this query instance. If the underlying 
datastore doesn't
+   * support cancellation of queries this will throw 
JDOUnsupportedOptionException. If the
+   * cancellation fails (e.g in the underlying datastore) then this will throw 
a JDOException.
*
* @since 3.0
*/
   void cancelAll();
 
   /**
-   * Method to cancel an executing query in the specified thread. If the 
underlying datastore
-   * doesn't support cancellation of queries this will throw 
JDOUnsupportedOptionException. If the
-   * cancellation fails (e.g in the underlying datastore) then this will throw 
a JDOException.
+   * Method to cancel any executions of this query instance that run in the 
specified thread. If the
+   * underlying datastore doesn't support cancellation of queries this will 
throw
+   * JDOUnsupportedOptionException. If the cancellation fails (e.g in the 
underlying datastore) then
+   * this will throw a JDOException.
*
* @param thread The thread to cancel

Review Comment:
   Even so I think it would still be more clear to say “of this query instance” 
instead of “any query”



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GH] Clarify javadoc of Query.cancel() and cancelAll() (db-jdo)

[via GitHub]

clr-apache commented on code in PR #92:
URL: https://github.com/apache/db-jdo/pull/92#discussion_r1501692446


##
api/src/main/java/javax/jdo/Query.java:
##
@@ -759,18 +759,19 @@ void addSubquery(
   Integer getDatastoreWriteTimeoutMillis();
 
   /**
-   * Method to cancel any executing queries. If the underlying datastore 
doesn't support
-   * cancellation of queries this will throw JDOUnsupportedOptionException. If 
the cancellation
-   * fails (e.g in the underlying datastore) then this will throw a 
JDOException.
+   * Method to cancel all executions of this query instance. If the underlying 
datastore doesn't
+   * support cancellation of queries this will throw 
JDOUnsupportedOptionException. If the
+   * cancellation fails (e.g in the underlying datastore) then this will throw 
a JDOException.
*
* @since 3.0
*/
   void cancelAll();
 
   /**
-   * Method to cancel an executing query in the specified thread. If the 
underlying datastore
-   * doesn't support cancellation of queries this will throw 
JDOUnsupportedOptionException. If the
-   * cancellation fails (e.g in the underlying datastore) then this will throw 
a JDOException.
+   * Method to cancel any executions of this query instance that run in the 
specified thread. If the
+   * underlying datastore doesn't support cancellation of queries this will 
throw
+   * JDOUnsupportedOptionException. If the cancellation fails (e.g in the 
underlying datastore) then
+   * this will throw a JDOException.
*
* @param thread The thread to cancel

Review Comment:
   I believe that there is no way for a single thread to have multiple 
simultaneous executions of a query. So there is no reason to change the text of 
the javadoc for cancelAll. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JDO-831: tck: improve tck query tests for performance (db-jdo)

[via GitHub]

mboapache merged PR #90:
URL: https://github.com/apache/db-jdo/pull/90


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Remove unpacked 2.0 API to avoid XSS on the hosted website (db-jdo-site)

[via GitHub]

tobous merged PR #49:
URL: https://github.com/apache/db-jdo-site/pull/49


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Remove unpacked 2.0 API to avoid XSS on the hosted website (db-jdo-site)

[via GitHub]

tobous commented on PR #49:
URL: https://github.com/apache/db-jdo-site/pull/49#issuecomment-1954948109

   Removed the Zip as well by accident.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] Remove unpacked 2.0 API to avoid XSS on the hosted website (db-jdo-site)

[via GitHub]

tobous opened a new pull request, #49:
URL: https://github.com/apache/db-jdo-site/pull/49

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Clarify javadoc of Query.cancel() and cancelAll() (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #92:
URL: https://github.com/apache/db-jdo/pull/92#issuecomment-1954917032

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=92) **Quality 
Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=92&resolved=false&inNewCodePeriod=true)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=92&resolved=false&inNewCodePeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Coverage  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=92&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=92)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Disable external entity processing (db-jdo)

[via GitHub]

tzaeschke merged PR #91:
URL: https://github.com/apache/db-jdo/pull/91


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump org.springframework:spring-beans from 5.3.19 to 5.3.20 in /parent-pom (db-jdo)

[via GitHub]

mboapache merged PR #89:
URL: https://github.com/apache/db-jdo/pull/89


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump org.springframework:spring-beans from 5.3.19 to 5.3.20 in /parent-pom (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #89:
URL: https://github.com/apache/db-jdo/pull/89#issuecomment-1924659279

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=89) **Quality 
Gate passed**  
   Kudos, no new issues were introduced!
   
   [0 New 
issues](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=89&resolved=false&inNewCodePeriod=true)
  
   [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=89&resolved=false&inNewCodePeriod=true)
  
   No data about Coverage  
   [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=89&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=89)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] Bump org.springframework:spring-beans from 5.3.19 to 5.3.20 in /parent-pom (db-jdo)

[via GitHub]

dependabot[bot] opened a new pull request, #89:
URL: https://github.com/apache/db-jdo/pull/89

   Bumps 
[org.springframework:spring-beans](https://github.com/spring-projects/spring-framework)
 from 5.3.19 to 5.3.20.
   
   Release notes
   Sourced from https://github.com/spring-projects/spring-framework/releases";>org.springframework:spring-beans's
 releases.
   
   v5.3.20
   :star: New Features
   
   Refine CachedIntrospectionResults property introspection https://redirect.github.com/spring-projects/spring-framework/issues/28445";>#28445
   Improve tests and Javadoc on binding to a property of type 
javax.servlet.Part https://redirect.github.com/spring-projects/spring-framework/pull/27830";>#27830
   WritableResource doesn't have parity with Resource in 
@Value etc. [SPR-10656] https://redirect.github.com/spring-projects/spring-framework/issues/15284";>#15284
   
   :lady_beetle: Bug Fixes
   
   Ignore invalid STOMP frame https://redirect.github.com/spring-projects/spring-framework/issues/28443";>#28443
   @ModelAttribute name attribute is not supported in WebFlux 
https://redirect.github.com/spring-projects/spring-framework/issues/28423";>#28423
   Fix BindingResult error when ModelAttribute has custom name in WebFlux 
https://redirect.github.com/spring-projects/spring-framework/pull/28422";>#28422
   Request body deserialization failures are not captured by exception 
handlers in WebFlux https://redirect.github.com/spring-projects/spring-framework/issues/28155";>#28155
   
   :notebook_with_decorative_cover: Documentation
   
   Remove Log4J initialization from package-info.java in spring-web https://redirect.github.com/spring-projects/spring-framework/pull/28420";>#28420
   Remove Log4J configurer from package-info.java in spring-core https://redirect.github.com/spring-projects/spring-framework/pull/28411";>#28411
   Fix github issue reference in RequestMappingHandlerMapping https://redirect.github.com/spring-projects/spring-framework/pull/28372";>#28372
   Add Javadoc since tags for GraphQL constants https://redirect.github.com/spring-projects/spring-framework/pull/28369";>#28369
   Fix method reference in Kotlin documentation  https://redirect.github.com/spring-projects/spring-framework/pull/28340";>#28340
   
   :hammer: Dependency Upgrades
   
   Upgrade to ASM 9.3 https://redirect.github.com/spring-projects/spring-framework/issues/28390";>#28390
   Upgrade to Reactor 2020.0.19 https://redirect.github.com/spring-projects/spring-framework/issues/28437";>#28437
   
   :heart: Contributors
   We'd like to thank all the contributors who worked on this release!
   
   https://github.com/izeye";>@​izeye
   https://github.com/koenpunt";>@​koenpunt
   https://github.com/missingdays";>@​missingdays
   https://github.com/zhangmingqi09";>@​zhangmingqi09
   https://github.com/binchoo";>@​binchoo
   https://github.com/gorisanson";>@​gorisanson
   https://github.com/jprinet";>@​jprinet
   https://github.com/nealshan";>@​nealshan
   https://github.com/bougar";>@​bougar
   
   
   
   
   Commits
   
   https://github.com/spring-projects/spring-framework/commit/e0f56e7d80a4e1248198e40be99157dbd8f594af";>e0f56e7
 Release v5.3.20
   https://github.com/spring-projects/spring-framework/commit/83186b689f11f5e6efe7ccc08fdeb92f66fcd583";>83186b6
 Refine CachedIntrospectionResults property introspection
   https://github.com/spring-projects/spring-framework/commit/dc2947c52df18d5e99cad03383f7d6ba13d031fd";>dc2947c
 Ignore invalid connect frame
   https://github.com/spring-projects/spring-framework/commit/e4ec376075b617c70edcaa409540698f588f4af9";>e4ec376
 Disabling Undertow server in CoroutinesIntegrationTests
   https://github.com/spring-projects/spring-framework/commit/c81e11d537f396b9bf56bea30354ded2204861b8";>c81e11d
 Polishing
   https://github.com/spring-projects/spring-framework/commit/de6180b093a61ad852f537d49203740fc04207ed";>de6180b
 Upgrade to Reactor 2020.0.19
   https://github.com/spring-projects/spring-framework/commit/1c10cdd1e87f133c082771587a730bbf2255a920";>1c10cdd
 Update copyright dates
   https://github.com/spring-projects/spring-framework/commit/941b92cbede8536e384d766091d625c89f1980d0";>941b92c
 Make inner classes static when feasible
   https://github.com/spring-projects/spring-framework/commit/e26d8839b3823fb664e9762e10c94c5989c8bc44";>e26d883
 Stop referring to features as Java 6/7 features where unnecessary
   https://github.com/spring-projects/spring-framework/commit/a1c73803980835bdafd95929098ea943c5a355dc";>a1c7380
 Add test for value attribute in https://github.com/ModelAttribute";>@​ModelAttribute in 
WebFlux
   Additional commits viewable in https://github.com/spring-projects/spring-framework/compare/v5.3.19...v5.3.20";>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.springframework:spring-beans&package-manager=maven&previous-version=5.3.19&new-version=5.3.20)](https://docs

Re: [PR] Move log files + cleanup (db-jdo)

[via GitHub]

tzaeschke merged PR #88:
URL: https://github.com/apache/db-jdo/pull/88


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Move log files + cleanup (db-jdo)

[via GitHub]

clr-apache commented on PR #88:
URL: https://github.com/apache/db-jdo/pull/88#issuecomment-1826458130

   I agree. Ok to merge to main.
   
   Craig
   
   > On Nov 25, 2023, at 14:16, Michael Bouschen ***@***.***> wrote:
   > 
   > 
   > The changes look good, ship it.
   > 
   > —
   > Reply to this email directly, view it on GitHub 
, or 
unsubscribe 
.
   > You are receiving this because you are subscribed to this thread.
   > 
   
   Craig L Russell
   ***@***.***
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Move log files + cleanup (db-jdo)

[via GitHub]

mboapache commented on PR #88:
URL: https://github.com/apache/db-jdo/pull/88#issuecomment-1826431269

   The changes look good, ship it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Move log files + cleanup (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #88:
URL: https://github.com/apache/db-jdo/pull/88#issuecomment-1826392651

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=88)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=88&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=88&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=88&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=88&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=88&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=88&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=88&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=88&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=88&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=88&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=88&resolved=false&types=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=88&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=88)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=88&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=88&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Move log files + cleanup (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #88:
URL: https://github.com/apache/db-jdo/pull/88#issuecomment-1826392197

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=88)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=88&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=88&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=88&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=88&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=88&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=88&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=88&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=88&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=88&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=88&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=88&resolved=false&types=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=88&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=88)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=88&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=88&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] Move log files + cleanup (db-jdo)

[via GitHub]

tzaeschke opened a new pull request, #88:
URL: https://github.com/apache/db-jdo/pull/88

   This PR moves log files instead of copying them, see 
https://issues.apache.org/jira/browse/JDO-834.
   
   It also contains some minor cleanup:
   - Added `command.add("execute");` in `RunTck` to JUnit test execution. This 
prevents output of deprecation notice.
   - Fixed some javadoc comments
   - Removed debug print statements from `Point` class.
 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)

[via GitHub]

mboapache merged PR #85:
URL: https://github.com/apache/db-jdo/pull/85


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump org.apache.derby:derby from 10.14.2.0 to 10.17.1.0 in /parent-pom (db-jdo)

[via GitHub]

tobous closed pull request #87: Bump org.apache.derby:derby from 10.14.2.0 to 
10.17.1.0 in /parent-pom
URL: https://github.com/apache/db-jdo/pull/87


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump org.apache.derby:derby from 10.14.2.0 to 10.17.1.0 in /parent-pom (db-jdo)

[via GitHub]

dependabot[bot] commented on PR #87:
URL: https://github.com/apache/db-jdo/pull/87#issuecomment-1821560502

   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Export TCK logs in GitHub Action (db-jdo)

[via GitHub]

tobous merged PR #86:
URL: https://github.com/apache/db-jdo/pull/86


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #85:
URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1821514067

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=85)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=85&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=85&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=85&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=CODE_SMELL)
 [14 Code 
Smells](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=85)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=85&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=85&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump org.apache.derby:derby from 10.14.2.0 to 10.17.1.0 in /parent-pom (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #87:
URL: https://github.com/apache/db-jdo/pull/87#issuecomment-1819971811

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=87)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=87&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=87&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=87&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=87&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=87&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=87&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=87&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=87&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=87&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=87&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=87&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=87&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=87)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=87&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=87&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] Bump org.apache.derby:derby from 10.14.2.0 to 10.17.1.0 in /parent-pom (db-jdo)

[via GitHub]

dependabot[bot] opened a new pull request, #87:
URL: https://github.com/apache/db-jdo/pull/87

   Bumps org.apache.derby:derby from 10.14.2.0 to 10.17.1.0.
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.derby:derby&package-manager=maven&previous-version=10.14.2.0&new-version=10.17.1.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot show  ignore conditions` will show all of 
the ignore conditions of the specified dependency
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   You can disable automated security fix PRs for this repo from the [Security 
Alerts page](https://github.com/apache/db-jdo/network/alerts).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Export TCK logs in GitHub Action (db-jdo)

[via GitHub]

tobous commented on PR #86:
URL: https://github.com/apache/db-jdo/pull/86#issuecomment-1819915617

   So that you get an idea of what the exported logs for a failed build would 
look like, I created a separate PR on my fork that I rigged to always fail for 
JDK 8 and 17: https://github.com/tobous/db-jdo/pull/4
   
   These are the results of the build: 
https://github.com/tobous/db-jdo/actions/runs/6936510666
   At the bottom is the list of build artifacts, containing separat zips for 
the logs for the JDK 8 and JDK 17 build.
   
   Please have a look at the files to ensure that all necessary log files are 
included. The current setup includes all files in `tck/target/logs/`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Export TCK logs in GitHub Action (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #86:
URL: https://github.com/apache/db-jdo/pull/86#issuecomment-1819882125

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=86)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=86&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=86&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=86&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=86&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=86&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=86&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=86&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=86&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=86&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=86&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=86&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=86&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=86)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=86&metric=duplicated_lines_density&view=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] Export TCK logs in GitHub Action (db-jdo)

[via GitHub]

tobous opened a new pull request, #86:
URL: https://github.com/apache/db-jdo/pull/86

   Exports the logs of the different matrix builds as separate artifacts in 
case the corresponding build fails.
   
   Adjusts the matrix build to keep running if one of the builds fails.
   
   Adjusts the maven build command to suppress the download progress indicators.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)

[via GitHub]

mboapache commented on PR #85:
URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1817966299

   I found the problem of issues 2. and 3. from above: now the datanucleus 
output is store in the -jdori.txt file and the logger output of the TCK test 
classes go into the -tck.txt files. Fix is checked in into branch JDO-830.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #85:
URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1817963484

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=85)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=85&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=85&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=85&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=CODE_SMELL)
 [14 Code 
Smells](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=85)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=85&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=85&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #85:
URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1817586768

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=85)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=85&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=85&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=85&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=CODE_SMELL)
 [14 Code 
Smells](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=85)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=85&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=85&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)

[via GitHub]

mboapache commented on PR #85:
URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1817585647

   1. About the test log output: this is what I have mentioned before, you 
should print the output using more -R or less -R. 
   If we do not like this output, then we need to find a JUnit launcher class 
other than org.junit.platform.console.ConsoleLauncher.
   2. The -jdori.txt files should include the datanucleus output. I have to 
check why this is not copied over.
   3. The logger output should go into the -txt.txt files. I need to check why 
this does not work.
   4. We have to discuss which Output from System.err we are talking about: 
output from RunTCK versus output from the test class. 
   5. This empty line causes the value jdo.tck.classes being empty, so there is 
no TCK test class specified. There was a bug in RunTCK in method getTestClasses 
when checking whether there is a test class specified.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GH] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)

[via GitHub]

mboapache commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1398242075


##
tck/src/main/java/org/apache/jdo/tck/util/ResultSummary.java:
##
@@ -36,9 +37,14 @@ public class ResultSummary implements Serializable {
   /** The name of the file to store a serialized instance of this class. */
   private static final String FILE_NAME_OF_RESULT_SUMMARY = 
"ResultSummary.ser";
 
+  private static final DecimalFormat THREE_DIGITS_FORMATTER = new 
DecimalFormat("000");

Review Comment:
   The two constants are leftovers. I remove them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GH] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)

[via GitHub]

mboapache commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1398241937


##
tck/src/main/java/org/apache/jdo/tck/api/jdohelper/IsDetached.java:
##
@@ -35,29 +36,23 @@ public class IsDetached extends DetachTest {
   private static final String ASSERTION_FAILED =
   "Assertion A8.5.6-1 JDOHelper.isDetached(Object) failed: ";
 
-  /**

Review Comment:
   I do not think so that someone wants to call the main method. 
   To run a TCK test you have to use the RunTCK plugin, in oder to get 
everything initialized that is requied by the TCK test classes. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GH] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)

[via GitHub]

mboapache commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1398237350


##
tck/src/main/java/org/apache/jdo/tck/api/jdohelper/IsDetached.java:
##
@@ -35,29 +36,23 @@ public class IsDetached extends DetachTest {
   private static final String ASSERTION_FAILED =
   "Assertion A8.5.6-1 JDOHelper.isDetached(Object) failed: ";
 
-  /**
-   * The main is called when the class is directly executed from 
the command line.
-   *
-   * @param args The arguments passed to the program.
-   */
-  public static void main(String[] args) {
-BatchTestRunner.run(IsDetached.class);
-  }
-
+  @Test
   public void testNullTransientAndUndetachableIsDetachedFalse() {
 pm = getPM();
 pm.currentTransaction().begin();
 
-assertFalse(ASSERTION_FAILED + "null object is detached", 
JDOHelper.isDetached(null));
-assertFalse(
-ASSERTION_FAILED + "transient object is detached", 
JDOHelper.isDetached(new Cart("bob")));
-assertFalse(
-ASSERTION_FAILED + "object of class marked not detachabled is 
detached",
-JDOHelper.isDetached(new Undetachable()));
+Assertions.assertFalse(

Review Comment:
   For me this is a preferred style. 
   Good catch, i will check for static imports of static methods.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GH] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)

[via GitHub]

mboapache commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1398237350


##
tck/src/main/java/org/apache/jdo/tck/api/jdohelper/IsDetached.java:
##
@@ -35,29 +36,23 @@ public class IsDetached extends DetachTest {
   private static final String ASSERTION_FAILED =
   "Assertion A8.5.6-1 JDOHelper.isDetached(Object) failed: ";
 
-  /**
-   * The main is called when the class is directly executed from 
the command line.
-   *
-   * @param args The arguments passed to the program.
-   */
-  public static void main(String[] args) {
-BatchTestRunner.run(IsDetached.class);
-  }
-
+  @Test
   public void testNullTransientAndUndetachableIsDetachedFalse() {
 pm = getPM();
 pm.currentTransaction().begin();
 
-assertFalse(ASSERTION_FAILED + "null object is detached", 
JDOHelper.isDetached(null));
-assertFalse(
-ASSERTION_FAILED + "transient object is detached", 
JDOHelper.isDetached(new Cart("bob")));
-assertFalse(
-ASSERTION_FAILED + "object of class marked not detachabled is 
detached",
-JDOHelper.isDetached(new Undetachable()));
+Assertions.assertFalse(

Review Comment:
   For me this is a preferred style. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)

[via GitHub]

tzaeschke commented on PR #85:
URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1817496798

   A failed test looks like this: 
[app-relationshipAllRelationships-junit.txt](https://github.com/apache/db-jdo/files/13400258/app-relationshipAllRelationships-junit.txt)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)

[via GitHub]

tzaeschke commented on PR #85:
URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1817493730

   For me the test log output is scrambled. For example the file 
`app-company1-1Relationships-junit.txt` looks like this:
   
   ```
   .
   '-- JUnit Jupiter [OK]
     '-- CompletenessTest [OK]
   '-- test() [OK]
   
   Test run finished after 1170 ms
   [ 2 containers found  ]
   [ 0 containers skipped]
   [ 2 containers started]
   [ 0 containers aborted]
   [ 2 containers successful ]
   [ 0 containers failed ]
   [ 1 tests found   ]
   [ 0 tests skipped ]
   [ 1 tests started ]
   [ 0 tests aborted ]
   [ 1 tests successful  ]
   [ 0 tests failed  ]
   
   
   WARNING: Delegated to the 'execute' command.
This behaviour has been deprecated and will be removed in a future 
release.
Please use the 'execute' command directly.
   ```
   
   It's not obvious to me why this happens, the code looks unsuspicious, any 
suggestions?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GH] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)

[via GitHub]

tzaeschke commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1398193849


##
tck/src/main/java/org/apache/jdo/tck/api/jdohelper/IsDetached.java:
##
@@ -35,29 +36,23 @@ public class IsDetached extends DetachTest {
   private static final String ASSERTION_FAILED =
   "Assertion A8.5.6-1 JDOHelper.isDetached(Object) failed: ";
 
-  /**
-   * The main is called when the class is directly executed from 
the command line.
-   *
-   * @param args The arguments passed to the program.
-   */
-  public static void main(String[] args) {
-BatchTestRunner.run(IsDetached.class);
-  }
-
+  @Test
   public void testNullTransientAndUndetachableIsDetachedFalse() {
 pm = getPM();
 pm.currentTransaction().begin();
 
-assertFalse(ASSERTION_FAILED + "null object is detached", 
JDOHelper.isDetached(null));
-assertFalse(
-ASSERTION_FAILED + "transient object is detached", 
JDOHelper.isDetached(new Cart("bob")));
-assertFalse(
-ASSERTION_FAILED + "object of class marked not detachabled is 
detached",
-JDOHelper.isDetached(new Undetachable()));
+Assertions.assertFalse(

Review Comment:
   Using `Assertions.` instead of static import, is that a preferred style or 
pragmatic/convenience (which also would be totally reasonable considering the 
amount of changes)?



##
tck/src/main/java/org/apache/jdo/tck/util/ResultSummary.java:
##
@@ -36,9 +37,14 @@ public class ResultSummary implements Serializable {
   /** The name of the file to store a serialized instance of this class. */
   private static final String FILE_NAME_OF_RESULT_SUMMARY = 
"ResultSummary.ser";
 
+  private static final DecimalFormat THREE_DIGITS_FORMATTER = new 
DecimalFormat("000");

Review Comment:
   What are these for? They don't appear to be used...?



##
tck/src/main/java/org/apache/jdo/tck/util/SystemCfgSummary.java:
##
@@ -78,7 +88,7 @@ static String getSystemInfo() {
* @param path the path
* @param message the message
*/
-  static void saveSystemInfo(String path, String message) {
+  private void saveSystemInfo(String path, String message) {

Review Comment:
   I think this could remain 'static'.



##
tck/src/main/java/org/apache/jdo/tck/util/SystemCfgSummary.java:
##
@@ -31,7 +31,9 @@ public class SystemCfgSummary {
   /** The name of the system configuration summary file. */
   private static final String SYSCFG_FILE_NAME = "system_config.txt";
 
-  private static String newLine;
+  private static String NL = System.getProperty("line.separator");

Review Comment:
   Make 'final'?



##
tck/src/main/java/org/apache/jdo/tck/util/ResultSummary.java:
##
@@ -135,23 +139,48 @@ private static ResultSummary load(String directory) {
*
* @param result the result object
*/
-  private void increment(TestResult result) {
+  private void increment(TestExecutionSummary result) {
+// total numbers
 this.nrOfTotalConfigurations++;
-this.totalTestCount += result.runCount();
-if (!result.wasSuccessful()) {
+this.totalTestCount += result.getTestsFoundCount();
+if (result.getTestsFailedCount() > 0) {
   this.nrOfFailedConfigurations++;
-  this.totalFailureCount += result.failureCount();
-  this.totalErrorCount += result.errorCount();
+  this.totalFailureCount += result.getTestsFailedCount();
 }
   }
 
+  private void appendTestResult(
+  String directory, String idtype, String config, TestExecutionSummary 
result) {
+String resultFileName = directory + File.separator + RESULT_FILE_NAME;
+String header = "Running tests for " + config + " with " + idtype + ":" + 
NEWLINE + "  ";
+StringBuilder builder = new StringBuilder(header);
+builder.append(getTestResult(result));
+appendTCKResultMessage(resultFileName, builder.toString());
+  }
+
+  private String getTestResult(TestExecutionSummary summary) {
+StringBuilder builder = new StringBuilder();
+builder.append(summary.getTestsFailedCount() == 0 ? "OK " : "** ");
+builder.append("Tests found: ").append(summary.getTestsFoundCount());
+builder.append(", started: ").append(summary.getTestsStartedCount());
+builder.append(", succeeded: ").append(summary.getTestsSucceededCount());
+builder.append(", failed: ").append(summary.getTestsFailedCount());
+builder.append(", skipped: ").append(summary.getTestsSkippedCount());
+builder.append(", aborted: ").append(summary.getTestsAbortedCount());
+builder
+.append(", time: ")
+.append(((double) (summary.getTimeFinished() - 
summary.getTimeStarted()) / 1000.0))

Review Comment:
   I think the cast to `double` is unnecessary.



##
tck/src/main/java/org/apache/jdo/tck/api/jdohelper/IsDetached.java:
##
@@ -35,29 +36,23 @@ public class IsDetached extends DetachTest {
   private static final String ASSERTION_FAILED =
   "Assertion A8.5.6-1 JDOHelper.isDetached(Object

Re: [PR] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #85:
URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1804648411

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=85)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=85&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=85&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=85&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=CODE_SMELL)
 [11 Code 
Smells](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=85)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=85&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=85&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GH] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)

[via GitHub]

mboapache commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1387254461


##
exectck/src/main/java/org/apache/jdo/exectck/RunTCK.java:
##
@@ -528,13 +693,14 @@ public void execute() throws MojoExecutionException, 
MojoFailureException {
   + File.separator;
   String[] metadataExtensions = {"jdo", "jdoquery", "orm", "xml", 
"properties"};
   String fromFileName = null;
+  File toFile = null;
   String pkgName = null;
   int startIdx = -1;
   // iterator over list of abs name of metadata files in src
   Iterator fi = FileUtils.iterateFiles(new File(fromDirName), 
metadataExtensions, true);
   while (fi.hasNext()) {
 try {
-  fromFile = fi.next();
+  File fromFile = fi.next();

Review Comment:
   - I agree the try clause should only contain the FileUtil.copy
   - The files should be copied, because the enhanced directory should be kept 
in case you want to run the next tck run without enhacement.
   - I agree to declare the variables in place.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GH] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)

[via GitHub]

mboapache commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1387252360


##
exectck/src/main/java/org/apache/jdo/exectck/RunTCK.java:
##
@@ -263,231 +396,261 @@ public void execute() throws MojoExecutionException, 
MojoFailureException {
 } catch (IOException ex) {
   Logger.getLogger(RunTCK.class.getName()).log(Level.SEVERE, null, ex);
 }
+  }
 
-// Get ClassLoader URLs to build classpath below
-URL[] cpURLs = ((URLClassLoader) 
Thread.currentThread().getContextClassLoader()).getURLs();
-ArrayList urlList = new ArrayList<>(Arrays.asList(cpURLs));
-
-// Get contents of pmf properties file to build new file below
-String pmfPropsReadFileName = confDirectory + File.separator + 
pmfProperties;
-String defaultPropsContents = "";
+  /**
+   * Get classpath string: add new entries to URLS from loader
+   *
+   * @param urlList ClassLoader URLs
+   * @param enhancedDir
+   * @return
+   */
+  private String getClasspathString(List urlList, File enhancedDir) {
+String cpString;
+ArrayList cpList = new ArrayList<>();
+cpList.addAll(urlList);
 try {
-  defaultPropsContents = Utilities.readFile(pmfPropsReadFileName);
-} catch (IOException ex) {
+  URL url1 = enhancedDir.toURI().toURL();
+  URL url2 =
+  new File(buildDirectory + File.separator + CLASSES_DIR_NAME + 
File.separator)
+  .toURI()
+  .toURL();
+  if (runtckVerbose) {
+System.out.println("url2 is " + url2.toString());
+  }
+  cpList.add(url1);
+  cpList.add(url2);
+  String[] jars = {"jar"};
+  Iterator fi = FileUtils.iterateFiles(new File(extLibsDirectory), 
jars, true);
+  while (fi.hasNext()) {
+cpList.add(fi.next().toURI().toURL());
+  }
+  for (String dependency : 
this.dependencyClasspath.split(File.pathSeparator)) {
+cpList.add(new File(dependency).toURI().toURL());
+  }
+} catch (MalformedURLException ex) {
+  ex.printStackTrace();
   Logger.getLogger(RunTCK.class.getName()).log(Level.SEVERE, null, ex);
 }
+cpString = Utilities.urls2ClasspathString(cpList);
+if (runtckVerbose) {
+  System.out.println("\nClasspath is " + cpString);
+}
+return cpString;
+  }
 
-// Reset logfile content (may not be empty if previous run crashed)
-resetFileContent(implLogFile);
-resetFileContent(TCK_LOG_FILE);
-
-int failureCount = 0;
-for (String db : dbs) {
-  System.setProperty("jdo.tck.database", db);
-  alreadyran = false;
-
-  for (String idtype : idtypes) {
-List idPropsString = new ArrayList<>();
-idPropsString.addAll(propsString);
-idPropsString.add("-Djdo.tck.identitytype=" + idtype);
-String enhancedDirName =
-buildDirectory
-+ File.separator
-+ "enhanced"
-+ File.separator
-+ impl
-+ File.separator
-+ idtype
-+ File.separator;
-File enhancedDir = new File(enhancedDirName);
-if (!(enhancedDir.exists())) {
-  throw new MojoExecutionException(
-  "Could not find enhanced directory "
-  + enhancedDirName
-  + ". Execute Enhance goal before RunTCK.");
-}
-
-// Set classpath string: add new entries to URLS from loader
-ArrayList cpList = new ArrayList<>();
-cpList.addAll(urlList);
-try {
-  URL url1 = enhancedDir.toURI().toURL();
-  URL url2 =
-  new File(buildDirectory + File.separator + CLASSES_DIR_NAME + 
File.separator)
-  .toURI()
-  .toURL();
-  if (runtckVerbose) {
-System.out.println("url2 is " + url2.toString());
-  }
-  cpList.add(url1);
-  cpList.add(url2);
-  String[] jars = {"jar"};
-  Iterator fi = FileUtils.iterateFiles(new 
File(extLibsDirectory), jars, true);
-  while (fi.hasNext()) {
-cpList.add(fi.next().toURI().toURL());
-  }
-  for (String dependency : 
this.dependencyClasspath.split(File.pathSeparator)) {
-cpList.add(new File(dependency).toURI().toURL());
-  }
-} catch (MalformedURLException ex) {
-  ex.printStackTrace();
-  Logger.getLogger(RunTCK.class.getName()).log(Level.SEVERE, null, ex);
-}
-cpString = Utilities.urls2ClasspathString(cpList);
-if (runtckVerbose) {
-  System.out.println("\nClasspath is " + cpString);
-}
-
-for (String cfg : cfgs) {
-  List cfgPropsString = new ArrayList<>();
-  cfgPropsString.addAll(idPropsString);
-  // Parse conf file and set properties String
-  props = PropertyUtils.getProperties(confDirectory + File.separator + 
cfg);
-  cfgPropsString.add(
-  "-Djdo.tck.testdata="

[GH] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)

[via GitHub]

mboapache commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1387172217


##
exectck/src/main/java/org/apache/jdo/exectck/RunTCK.java:
##
@@ -263,231 +396,261 @@ public void execute() throws MojoExecutionException, 
MojoFailureException {
 } catch (IOException ex) {
   Logger.getLogger(RunTCK.class.getName()).log(Level.SEVERE, null, ex);
 }
+  }
 
-// Get ClassLoader URLs to build classpath below
-URL[] cpURLs = ((URLClassLoader) 
Thread.currentThread().getContextClassLoader()).getURLs();
-ArrayList urlList = new ArrayList<>(Arrays.asList(cpURLs));
-
-// Get contents of pmf properties file to build new file below
-String pmfPropsReadFileName = confDirectory + File.separator + 
pmfProperties;
-String defaultPropsContents = "";
+  /**
+   * Get classpath string: add new entries to URLS from loader
+   *
+   * @param urlList ClassLoader URLs
+   * @param enhancedDir
+   * @return
+   */
+  private String getClasspathString(List urlList, File enhancedDir) {
+String cpString;
+ArrayList cpList = new ArrayList<>();
+cpList.addAll(urlList);
 try {
-  defaultPropsContents = Utilities.readFile(pmfPropsReadFileName);
-} catch (IOException ex) {
+  URL url1 = enhancedDir.toURI().toURL();
+  URL url2 =
+  new File(buildDirectory + File.separator + CLASSES_DIR_NAME + 
File.separator)
+  .toURI()
+  .toURL();
+  if (runtckVerbose) {
+System.out.println("url2 is " + url2.toString());
+  }
+  cpList.add(url1);
+  cpList.add(url2);
+  String[] jars = {"jar"};
+  Iterator fi = FileUtils.iterateFiles(new File(extLibsDirectory), 
jars, true);
+  while (fi.hasNext()) {
+cpList.add(fi.next().toURI().toURL());
+  }
+  for (String dependency : 
this.dependencyClasspath.split(File.pathSeparator)) {
+cpList.add(new File(dependency).toURI().toURL());
+  }
+} catch (MalformedURLException ex) {
+  ex.printStackTrace();
   Logger.getLogger(RunTCK.class.getName()).log(Level.SEVERE, null, ex);
 }
+cpString = Utilities.urls2ClasspathString(cpList);
+if (runtckVerbose) {
+  System.out.println("\nClasspath is " + cpString);
+}
+return cpString;
+  }
 
-// Reset logfile content (may not be empty if previous run crashed)
-resetFileContent(implLogFile);
-resetFileContent(TCK_LOG_FILE);
-
-int failureCount = 0;
-for (String db : dbs) {
-  System.setProperty("jdo.tck.database", db);
-  alreadyran = false;
-
-  for (String idtype : idtypes) {
-List idPropsString = new ArrayList<>();
-idPropsString.addAll(propsString);
-idPropsString.add("-Djdo.tck.identitytype=" + idtype);
-String enhancedDirName =
-buildDirectory
-+ File.separator
-+ "enhanced"
-+ File.separator
-+ impl
-+ File.separator
-+ idtype
-+ File.separator;
-File enhancedDir = new File(enhancedDirName);
-if (!(enhancedDir.exists())) {
-  throw new MojoExecutionException(
-  "Could not find enhanced directory "
-  + enhancedDirName
-  + ". Execute Enhance goal before RunTCK.");
-}
-
-// Set classpath string: add new entries to URLS from loader
-ArrayList cpList = new ArrayList<>();
-cpList.addAll(urlList);
-try {
-  URL url1 = enhancedDir.toURI().toURL();
-  URL url2 =
-  new File(buildDirectory + File.separator + CLASSES_DIR_NAME + 
File.separator)
-  .toURI()
-  .toURL();
-  if (runtckVerbose) {
-System.out.println("url2 is " + url2.toString());
-  }
-  cpList.add(url1);
-  cpList.add(url2);
-  String[] jars = {"jar"};
-  Iterator fi = FileUtils.iterateFiles(new 
File(extLibsDirectory), jars, true);
-  while (fi.hasNext()) {
-cpList.add(fi.next().toURI().toURL());
-  }
-  for (String dependency : 
this.dependencyClasspath.split(File.pathSeparator)) {
-cpList.add(new File(dependency).toURI().toURL());
-  }
-} catch (MalformedURLException ex) {
-  ex.printStackTrace();
-  Logger.getLogger(RunTCK.class.getName()).log(Level.SEVERE, null, ex);
-}
-cpString = Utilities.urls2ClasspathString(cpList);
-if (runtckVerbose) {
-  System.out.println("\nClasspath is " + cpString);
-}
-
-for (String cfg : cfgs) {
-  List cfgPropsString = new ArrayList<>();
-  cfgPropsString.addAll(idPropsString);
-  // Parse conf file and set properties String
-  props = PropertyUtils.getProperties(confDirectory + File.separator + 
cfg);
-  cfgPropsString.add(
-  "-Djdo.tck.testdata="

[GH] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)

[via GitHub]

mboapache commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1387168344


##
exectck/src/main/java/org/apache/jdo/exectck/RunTCK.java:
##
@@ -140,37 +141,178 @@ private String getTrimmedPropertyValue(Properties props, 
String key) {
 return value == null ? "" : value.trim();
   }
 
+  private static String fileToString(String fileName) {
+try {
+  byte[] encoded = Files.readAllBytes(Paths.get(fileName));
+  return new String(encoded);
+} catch (IOException ex) {
+  return "Problems reading " + fileName + ": " + ex.getMessage();
+}
+  }
+
+  /** */
   @Override
-  public void execute() throws MojoExecutionException, MojoFailureException {
+  public void execute() throws MojoExecutionException {
 if (!doRunTCK) {
   System.out.println("Skipping RunTCK goal!");
   return;
 }
 
-Properties props = null;
 boolean alreadyran = false;
-String runonce = "false";
-List propsString = new ArrayList<>();
-List command;
+boolean runonce = false;
 String cpString = null;
-InvocationResult result;
-File fromFile = null;
-File toFile = null;
 
+List propsString = initTCKRun();
+String excludeFile = confDirectory + File.separator + exclude;
+propsString.add(
+"-Djdo.tck.exclude="
++ 
getTrimmedPropertyValue(PropertyUtils.getProperties(excludeFile), 
"jdo.tck.exclude"));
+
+// Create configuration log directory
+String thisLogDir = logsDirectory + File.separator + Utilities.now();
+String cfgDirName = thisLogDir + File.separator + "configuration";
+File cfgDir = new File(cfgDirName);
+if (!(cfgDir.exists()) && !(cfgDir.mkdirs())) {
+  throw new MojoExecutionException("Failed to create directory " + 
cfgDirName);
+}
+propsString.add("-Djdo.tck.log.directory=" + thisLogDir);
+
+copyConfigurationFiles();
+
+// Get ClassLoader URLs to build classpath below
+List urlList =
+new ArrayList<>(
+Arrays.asList(
+((URLClassLoader) 
Thread.currentThread().getContextClassLoader()).getURLs()));
+
+// Get contents of pmf properties file to build new file below
+String pmfPropsReadFileName = confDirectory + File.separator + 
pmfProperties;
+String defaultPropsContents = "";
+try {
+  defaultPropsContents = Utilities.readFile(pmfPropsReadFileName);
+} catch (IOException ex) {
+  Logger.getLogger(RunTCK.class.getName()).log(Level.SEVERE, null, ex);
+}
+
+// Reset logfile content (may not be empty if previous run crashed)
+resetFileContent(implLogFile);
+resetFileContent(TCK_LOG_FILE);
+
+int failureCount = 0;
+for (String db : dbs) {
+  System.setProperty("jdo.tck.database", db);
+  alreadyran = false;

Review Comment:
   I renamed it to alreadyRan



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GH] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)

[via GitHub]

tzaeschke commented on code in PR #85:
URL: https://github.com/apache/db-jdo/pull/85#discussion_r1383891081


##
exectck/src/main/java/org/apache/jdo/exectck/RunTCK.java:
##
@@ -140,37 +141,178 @@ private String getTrimmedPropertyValue(Properties props, 
String key) {
 return value == null ? "" : value.trim();
   }
 
+  private static String fileToString(String fileName) {
+try {
+  byte[] encoded = Files.readAllBytes(Paths.get(fileName));
+  return new String(encoded);
+} catch (IOException ex) {
+  return "Problems reading " + fileName + ": " + ex.getMessage();
+}
+  }
+
+  /** */
   @Override
-  public void execute() throws MojoExecutionException, MojoFailureException {
+  public void execute() throws MojoExecutionException {
 if (!doRunTCK) {
   System.out.println("Skipping RunTCK goal!");
   return;
 }
 
-Properties props = null;
 boolean alreadyran = false;
-String runonce = "false";
-List propsString = new ArrayList<>();
-List command;
+boolean runonce = false;
 String cpString = null;
-InvocationResult result;
-File fromFile = null;
-File toFile = null;
 
+List propsString = initTCKRun();
+String excludeFile = confDirectory + File.separator + exclude;
+propsString.add(
+"-Djdo.tck.exclude="
++ 
getTrimmedPropertyValue(PropertyUtils.getProperties(excludeFile), 
"jdo.tck.exclude"));
+
+// Create configuration log directory
+String thisLogDir = logsDirectory + File.separator + Utilities.now();

Review Comment:
   Why `this`?



##
exectck/src/main/java/org/apache/jdo/exectck/RunTCK.java:
##
@@ -116,17 +117,17 @@ public class RunTCK extends AbstractTCKMojo {
 
   /** Class used to run a batch of tests. */
   @Parameter(
-  property = "jdo.tck.testrunnerclass",
-  defaultValue = "org.apache.jdo.tck.util.BatchTestRunner",
+  property = "jdo.tck.testrunner.class",
+  defaultValue = "org.junit.platform.console.ConsoleLauncher",
   required = true)
   private String testRunnerClass;
 
-  /** Class used to output test result and configuration information. */
-  @Parameter(
-  property = "jdo.tck.resultprinterclass",
-  defaultValue = "org.apache.jdo.tck.util.BatchResultPrinter",
-  required = true)
-  private String resultPrinterClass;
+  /**
+   * output details mode for test run. Use one of: none, summary, flat, tree, 
verbose, testfeed. If

Review Comment:
   Is this sentence complete? Maybe change to "Output mode for test run ..."



##
exectck/src/main/java/org/apache/jdo/exectck/RunTCK.java:
##
@@ -140,37 +141,178 @@ private String getTrimmedPropertyValue(Properties props, 
String key) {
 return value == null ? "" : value.trim();
   }
 
+  private static String fileToString(String fileName) {
+try {
+  byte[] encoded = Files.readAllBytes(Paths.get(fileName));
+  return new String(encoded);
+} catch (IOException ex) {
+  return "Problems reading " + fileName + ": " + ex.getMessage();
+}
+  }
+
+  /** */
   @Override
-  public void execute() throws MojoExecutionException, MojoFailureException {
+  public void execute() throws MojoExecutionException {
 if (!doRunTCK) {
   System.out.println("Skipping RunTCK goal!");
   return;
 }
 
-Properties props = null;
 boolean alreadyran = false;
-String runonce = "false";
-List propsString = new ArrayList<>();
-List command;
+boolean runonce = false;
 String cpString = null;
-InvocationResult result;
-File fromFile = null;
-File toFile = null;
 
+List propsString = initTCKRun();
+String excludeFile = confDirectory + File.separator + exclude;
+propsString.add(
+"-Djdo.tck.exclude="
++ 
getTrimmedPropertyValue(PropertyUtils.getProperties(excludeFile), 
"jdo.tck.exclude"));
+
+// Create configuration log directory
+String thisLogDir = logsDirectory + File.separator + Utilities.now();
+String cfgDirName = thisLogDir + File.separator + "configuration";
+File cfgDir = new File(cfgDirName);
+if (!(cfgDir.exists()) && !(cfgDir.mkdirs())) {
+  throw new MojoExecutionException("Failed to create directory " + 
cfgDirName);
+}
+propsString.add("-Djdo.tck.log.directory=" + thisLogDir);
+
+copyConfigurationFiles();
+
+// Get ClassLoader URLs to build classpath below
+List urlList =
+new ArrayList<>(
+Arrays.asList(
+((URLClassLoader) 
Thread.currentThread().getContextClassLoader()).getURLs()));
+
+// Get contents of pmf properties file to build new file below
+String pmfPropsReadFileName = confDirectory + File.separator + 
pmfProperties;
+String defaultPropsContents = "";
+try {
+  defaultPropsContents = Utilities.readFile(pmfPropsReadFileName);
+} catch (IOException ex) {
+  Logger.getLogger(RunTCK.class.getName()).log(Level.SEVERE, null, ex);
+}
+
+  

Re: [PR] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #85:
URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1794402762

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=85)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=85&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=85&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=85&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=CODE_SMELL)
 [10 Code 
Smells](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=85)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=85&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=85&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)

[via GitHub]

mboapache opened a new pull request, #85:
URL: https://github.com/apache/db-jdo/pull/85

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JDO-822 - Add JDK 21 to matrix build (db-jdo)

[via GitHub]

tobous merged PR #84:
URL: https://github.com/apache/db-jdo/pull/84


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JDO-822 - Add JDK 21 to matrix build (db-jdo)

[via GitHub]

clr-apache commented on PR #84:
URL: https://github.com/apache/db-jdo/pull/84#issuecomment-1778204772

   Looks good.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JDO-822 - Add JDK 21 to matrix build (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #84:
URL: https://github.com/apache/db-jdo/pull/84#issuecomment-1777490176

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=84)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=84&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=84&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=84&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=84&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=84&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=84&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=84&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=84&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=84&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=84&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=84&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=84&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=84)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=84&metric=duplicated_lines_density&view=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] JDO-822 - Add JDK 21 to matrix build (db-jdo)

[via GitHub]

tobous opened a new pull request, #84:
URL: https://github.com/apache/db-jdo/pull/84

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Clean up Enhancer.execute() (db-jdo)

[via GitHub]

tzaeschke merged PR #83:
URL: https://github.com/apache/db-jdo/pull/83


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Clean up Enhancer.execute() (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #83:
URL: https://github.com/apache/db-jdo/pull/83#issuecomment-167685

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=83)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=83&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=83&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=83&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=83)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=83&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=83&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Clean up Enhancer.execute() (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #83:
URL: https://github.com/apache/db-jdo/pull/83#issuecomment-1644423598

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=83)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=83&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=83&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=83&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=CODE_SMELL)
 [2 Code 
Smells](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=83)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=83&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=83&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Clean up Enhancer.execute() (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #83:
URL: https://github.com/apache/db-jdo/pull/83#issuecomment-1637037832

   SonarCloud Quality Gate failed.    [![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate 
failed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=83)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=83&resolved=false&types=SECURITY_HOTSPOT)
 
[![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png
 
'E')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=83&resolved=false&types=SECURITY_HOTSPOT)
 [1 Security 
Hotspot](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=83&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=83)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=83&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=83&metric=new_duplicated_lines_density&view=list)
   
   
   
   
![idea](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png
 'idea') Catch issues before they fail your Quality Gate with our IDE extension 
![sonarlint](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png
 'sonarlint') 
[SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Clean up Enhancer.execute() (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #83:
URL: https://github.com/apache/db-jdo/pull/83#issuecomment-1637032727

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=83)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=83&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=83&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=83&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=CODE_SMELL)
 [3 Code 
Smells](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=83)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=83&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=83&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JDO-832: Remove RunTCK option jdo.tck.skipJndi (db-jdo)

[via GitHub]

mboapache merged PR #82:
URL: https://github.com/apache/db-jdo/pull/82


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Clean up Enhancer.execute() (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #83:
URL: https://github.com/apache/db-jdo/pull/83#issuecomment-1628806607

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=83)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=83&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=83&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=83&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=CODE_SMELL)
 [7 Code 
Smells](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=83)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=83&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=83&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Clean up Enhancer.execute() (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #83:
URL: https://github.com/apache/db-jdo/pull/83#issuecomment-1628800957

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=83)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=83&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=83&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=83&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=CODE_SMELL)
 [7 Code 
Smells](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=83&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=83)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=83&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=83&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] Clean up Enhancer.execute() (db-jdo)

[via GitHub]

tzaeschke opened a new pull request, #83:
URL: https://github.com/apache/db-jdo/pull/83

   As part of https://issues.apache.org/jira/browse/JDO-823, this PR attempt to 
clean up code issues in the `Enhancer`.
   Specifically:
   - [x] Reduce code complexity of `execute()`. Done.
   - [ ] ~~Fix problem with `ClassLoader` not being treated as resource in the 
try-catch block.~~
   - [ ] Analyze problem with `classes` only ever being used for `"testdata"`. 
Is this intentional? Why does it work at all?
   
   The ClassLoader problem reported by SonarCloud is considered a false 
positive: 
   1) While the class loader is created inside the try-catch block, it is also 
assigned, i.e. it leaves the scope. It should definitely **not** be closed in 
this try-catch block under any circumstances.
   2) Introducing an "outer" try-catch block to close it would also be wrong, 
the class loader will be closed automatically when the current thread ends. I 
don't think it is even possible to close (or detatch) the class loader before 
the thread ends.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JDO-832: Remove RunTCK option jdo.tck.skipJndi (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #82:
URL: https://github.com/apache/db-jdo/pull/82#issuecomment-1627466461

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=82)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=82&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=82&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=82&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=82&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=82&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=82&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=82&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=82&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=82&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=82&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=82&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=82&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=82)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=82&metric=duplicated_lines_density&view=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] JDO-832: Remove RunTCK option jdo.tck.skipJndi (db-jdo)

[via GitHub]

mboapache opened a new pull request, #82:
URL: https://github.com/apache/db-jdo/pull/82

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JDO-827 Simplify JNDI (db-jdo)

[via GitHub]

tzaeschke merged PR #81:
URL: https://github.com/apache/db-jdo/pull/81


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JDO-827 Simplify JNDI (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #81:
URL: https://github.com/apache/db-jdo/pull/81#issuecomment-1624146331

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=81)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=81&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=81&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=81&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=81)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=81&metric=duplicated_lines_density&view=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JDO-829: api: Migrate JUnit tests to version 5 (db-jdo)

[via GitHub]

mboapache merged PR #80:
URL: https://github.com/apache/db-jdo/pull/80


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JDO-827 Simplify JNDI (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #81:
URL: https://github.com/apache/db-jdo/pull/81#issuecomment-1614490566

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=81)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=81&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=81&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=81&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=81)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=81&metric=duplicated_lines_density&view=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JDO-827 Simplify JNDI (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #81:
URL: https://github.com/apache/db-jdo/pull/81#issuecomment-1614404589

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=81)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=81&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=81&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=81&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=81)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=81&metric=duplicated_lines_density&view=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JDO-829: api: Migrate JUnit tests to version 5 (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #80:
URL: https://github.com/apache/db-jdo/pull/80#issuecomment-1613683840

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=80)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=80&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=80&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=80&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=80&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=80&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=80&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=80&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=80&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=80&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=80&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=80&resolved=false&types=CODE_SMELL)
 [3 Code 
Smells](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=80&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=80)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=80&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=80&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GH] JDO-829: api: Migrate JUnit tests to version 5 (db-jdo)

[via GitHub]

tzaeschke commented on code in PR #80:
URL: https://github.com/apache/db-jdo/pull/80#discussion_r1247017440


##
api/src/test/java/javax/jdo/PMFMapMapTest.java:
##
@@ -40,18 +41,14 @@ public class PMFMapMapTest extends AbstractJDOConfigTest {
   private static final String PMF_SERVICE_CLASS = "javax.jdo.stub.StubPMF";
   private static final String PROPERTIES_FILE = "propsfile.props";
 
-  public static void main(String args[]) {
-BatchTestRunner.run(PMFMapMapTest.class);
-  }
-
   /**
* {@inheritDoc}
*
* @return {@inheritDoc}
*/
-  public static TestSuite suite() {
+  /*public static TestSuite suite() {

Review Comment:
   Remove commented out code?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JDO-829: api: Migrate JUnit tests to version 5 (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #80:
URL: https://github.com/apache/db-jdo/pull/80#issuecomment-1613674570

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=80)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=80&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=80&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=80&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=80&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=80&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=80&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=80&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=80&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=80&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=80&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=80&resolved=false&types=CODE_SMELL)
 [3 Code 
Smells](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=80&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=80)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=80&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=80&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JDO-827 Simplify JNDI (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #81:
URL: https://github.com/apache/db-jdo/pull/81#issuecomment-1613470334

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=81)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=81&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=81&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=81&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=81)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=81&metric=duplicated_lines_density&view=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JDO-827 Simplify JNDI (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #81:
URL: https://github.com/apache/db-jdo/pull/81#issuecomment-1613262742

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=81)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=81&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=81&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=81&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=81)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=81&metric=duplicated_lines_density&view=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JDO-827 Simplify JNDI (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #81:
URL: https://github.com/apache/db-jdo/pull/81#issuecomment-1613254212

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=81)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=81&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=81&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=81&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=81)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=81&metric=duplicated_lines_density&view=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JDO-827 Simplify JNDI (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #81:
URL: https://github.com/apache/db-jdo/pull/81#issuecomment-1613252562

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=81)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=81&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=81&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=81&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=81&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=81)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=81&metric=duplicated_lines_density&view=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JDO-829: api: Migrate JUnit tests to version 5 (db-jdo)

[via GitHub]

sonarcloud[bot] commented on PR #80:
URL: https://github.com/apache/db-jdo/pull/80#issuecomment-1611870703

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=80)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=80&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=80&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=80&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=80&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=80&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=80&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=80&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=80&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=80&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=80&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=80&resolved=false&types=CODE_SMELL)
 [3 Code 
Smells](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=80&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=80)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=80&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=80&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] JDO-829: api: Migrate JUnit tests to version 5 (db-jdo)

[via GitHub]

mboapache opened a new pull request, #80:
URL: https://github.com/apache/db-jdo/pull/80

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Update GitHub action versions & replace deprecated commands (db-jdo-site)

[via GitHub]

tobous merged PR #48:
URL: https://github.com/apache/db-jdo-site/pull/48


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Update GitHub action versions (db-jdo)

[via GitHub]

tobous merged PR #79:
URL: https://github.com/apache/db-jdo/pull/79


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [db-jdo-site] tobous merged pull request #47: JDO-828 - Add setup for subjects for automated GitHub emails

[via GitHub]

tobous merged PR #47:
URL: https://github.com/apache/db-jdo-site/pull/47


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org