[jira] [Commented] (JDO-702) Support for specification of embedded inherited objects
[ https://issues.apache.org/jira/browse/JDO-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485065#comment-13485065 ] Craig L Russell commented on JDO-702: - A bit more descriptive for Chapter 18: The optional discriminator attribute specifies the column to be used as the discriminator for the embedded object. This column would be used in case the type of the embedded object has subclasses. And in 15.4: Mapping embedded objects supports inheritance . In this case, the discriminator attribute would specify the discriminator strategy. svn 1402590 > Support for specification of embedded inherited objects > --- > > Key: JDO-702 > URL: https://issues.apache.org/jira/browse/JDO-702 > Project: JDO > Issue Type: New Feature > Components: api, specification, tck >Affects Versions: JDO 3 (3.0) >Reporter: Andy Jefferson >Assignee: Craig L Russell > Fix For: JDO 3 maintenance release 1 (3.1) > > Attachments: JDO-702.patch, JDO-702-test.patch > > > While JDO2+ allows specification of embedded objects stored with primary > objects, it doesn't have any specific way of specifying the embedded object > as being inherited and how you would persist it. In particular there is no > way to define a discriminator (column) for the embedded object. If we have an > example from the JDO spec, and if we have a subclass of Address as also > persistable, then we need to specify the discriminator for "primaryAddress" > field. > > ... > > > > > > > > > > > > So the XSD/DTD need updates to allow under , the > JDO Metadata API needs to allow this also, and the @Embedded annotation needs > a "discriminator" attribute adding. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JDO-702) Support for specification of embedded inherited objects
[ https://issues.apache.org/jira/browse/JDO-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485016#comment-13485016 ] Craig L Russell commented on JDO-702: - The specification update for this feature is brief. Chapter 18 under Embedded. Anything else needed? "The optional discriminator attribute specifies the column to be used as the discriminator for the embedded object. " > Support for specification of embedded inherited objects > --- > > Key: JDO-702 > URL: https://issues.apache.org/jira/browse/JDO-702 > Project: JDO > Issue Type: New Feature > Components: api, specification, tck >Affects Versions: JDO 3 (3.0) >Reporter: Andy Jefferson >Assignee: Craig L Russell > Fix For: JDO 3 maintenance release 1 (3.1) > > Attachments: JDO-702.patch, JDO-702-test.patch > > > While JDO2+ allows specification of embedded objects stored with primary > objects, it doesn't have any specific way of specifying the embedded object > as being inherited and how you would persist it. In particular there is no > way to define a discriminator (column) for the embedded object. If we have an > example from the JDO spec, and if we have a subclass of Address as also > persistable, then we need to specify the discriminator for "primaryAddress" > field. > > ... > > > > > > > > > > > > So the XSD/DTD need updates to allow under , the > JDO Metadata API needs to allow this also, and the @Embedded annotation needs > a "discriminator" attribute adding. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JDO-702) Support for specification of embedded inherited objects
[ https://issues.apache.org/jira/browse/JDO-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195981#comment-13195981 ] Andy Jefferson commented on JDO-702: Patch for tests now applied to SVN trunk. > Support for specification of embedded inherited objects > --- > > Key: JDO-702 > URL: https://issues.apache.org/jira/browse/JDO-702 > Project: JDO > Issue Type: New Feature > Components: api, specification, tck >Reporter: Andy Jefferson >Assignee: Craig L Russell > Attachments: JDO-702-test.patch, JDO-702.patch > > > While JDO2+ allows specification of embedded objects stored with primary > objects, it doesn't have any specific way of specifying the embedded object > as being inherited and how you would persist it. In particular there is no > way to define a discriminator (column) for the embedded object. If we have an > example from the JDO spec, and if we have a subclass of Address as also > persistable, then we need to specify the discriminator for "primaryAddress" > field. > > ... > > > > > > > > > > > > So the XSD/DTD need updates to allow under , the > JDO Metadata API needs to allow this also, and the @Embedded annotation needs > a "discriminator" attribute adding. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JDO-702) Support for specification of embedded inherited objects
[ https://issues.apache.org/jira/browse/JDO-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187063#comment-13187063 ] Andy Jefferson commented on JDO-702: Original patch to update EmbeddedMetaData, @Embedded and DTD/XSD is now applied to SVN trunk as revision r1232104 > Support for specification of embedded inherited objects > --- > > Key: JDO-702 > URL: https://issues.apache.org/jira/browse/JDO-702 > Project: JDO > Issue Type: New Feature > Components: api, specification, tck >Reporter: Andy Jefferson > Attachments: JDO-702-test.patch, JDO-702.patch > > > While JDO2+ allows specification of embedded objects stored with primary > objects, it doesn't have any specific way of specifying the embedded object > as being inherited and how you would persist it. In particular there is no > way to define a discriminator (column) for the embedded object. If we have an > example from the JDO spec, and if we have a subclass of Address as also > persistable, then we need to specify the discriminator for "primaryAddress" > field. > > ... > > > > > > > > > > > > So the XSD/DTD need updates to allow under , the > JDO Metadata API needs to allow this also, and the @Embedded annotation needs > a "discriminator" attribute adding. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JDO-702) Support for specification of embedded inherited objects
[ https://issues.apache.org/jira/browse/JDO-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185696#comment-13185696 ] Craig L Russell commented on JDO-702: - Not clear that we need to update the company model. A stand alone model for just this feature would work for me. The advantage of the company model is that there is a lot of infrastructure already written. And changing the Address classes/interfaces probably isn't best because the most common case for Address is embedded without subclasses. So probably another model is needed anyway. Or create another package outside the company model but use the company infrastructure (e.g. the completeness test). You also want to make sure that the query features (cast, relationships from embedded subtypes, projections of embedded types) work properly. > Support for specification of embedded inherited objects > --- > > Key: JDO-702 > URL: https://issues.apache.org/jira/browse/JDO-702 > Project: JDO > Issue Type: New Feature > Components: api, specification, tck >Reporter: Andy Jefferson > Attachments: JDO-702.patch > > > While JDO2+ allows specification of embedded objects stored with primary > objects, it doesn't have any specific way of specifying the embedded object > as being inherited and how you would persist it. In particular there is no > way to define a discriminator (column) for the embedded object. If we have an > example from the JDO spec, and if we have a subclass of Address as also > persistable, then we need to specify the discriminator for "primaryAddress" > field. > > ... > > > > > > > > > > > > So the XSD/DTD need updates to allow under , the > JDO Metadata API needs to allow this also, and the @Embedded annotation needs > a "discriminator" attribute adding. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JDO-702) Support for specification of embedded inherited objects
[ https://issues.apache.org/jira/browse/JDO-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181973#comment-13181973 ] Andy Jefferson commented on JDO-702: Sure, but what form does this testcase take? I was thinking of a simple subclass of Address, however a change to the company model seems to imply creating duplicated interfaces and implementations across various packages ... not just company, but also companyAnnotatedFC, companyAnnotated JPA, companyAnnotatedPC, companyAnnotatedPI etc. All I want is a subclass and a way of instantiating it (e.g CompanyFactory.newXXXAddress), without having to dup it many times. What is the minimum that this company model will accept ? > Support for specification of embedded inherited objects > --- > > Key: JDO-702 > URL: https://issues.apache.org/jira/browse/JDO-702 > Project: JDO > Issue Type: New Feature > Components: api, specification, tck >Reporter: Andy Jefferson > Attachments: JDO-702.patch > > > While JDO2+ allows specification of embedded objects stored with primary > objects, it doesn't have any specific way of specifying the embedded object > as being inherited and how you would persist it. In particular there is no > way to define a discriminator (column) for the embedded object. If we have an > example from the JDO spec, and if we have a subclass of Address as also > persistable, then we need to specify the discriminator for "primaryAddress" > field. > > ... > > > > > > > > > > > > So the XSD/DTD need updates to allow under , the > JDO Metadata API needs to allow this also, and the @Embedded annotation needs > a "discriminator" attribute adding. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JDO-702) Support for specification of embedded inherited objects
[ https://issues.apache.org/jira/browse/JDO-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181445#comment-13181445 ] Craig L Russell commented on JDO-702: - So all we need is a tck test case? I'll take care of the specification update. > Support for specification of embedded inherited objects > --- > > Key: JDO-702 > URL: https://issues.apache.org/jira/browse/JDO-702 > Project: JDO > Issue Type: New Feature > Components: api, specification, tck >Reporter: Andy Jefferson > Attachments: JDO-702.patch > > > While JDO2+ allows specification of embedded objects stored with primary > objects, it doesn't have any specific way of specifying the embedded object > as being inherited and how you would persist it. In particular there is no > way to define a discriminator (column) for the embedded object. If we have an > example from the JDO spec, and if we have a subclass of Address as also > persistable, then we need to specify the discriminator for "primaryAddress" > field. > > ... > > > > > > > > > > > > So the XSD/DTD need updates to allow under , the > JDO Metadata API needs to allow this also, and the @Embedded annotation needs > a "discriminator" attribute adding. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JDO-702) Support for specification of embedded inherited objects
[ https://issues.apache.org/jira/browse/JDO-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161734#comment-13161734 ] Craig L Russell commented on JDO-702: - Sounds good. > Support for specification of embedded inherited objects > --- > > Key: JDO-702 > URL: https://issues.apache.org/jira/browse/JDO-702 > Project: JDO > Issue Type: New Feature > Components: api, specification, tck >Reporter: Andy Jefferson > Attachments: JDO-702.patch > > > While JDO2+ allows specification of embedded objects stored with primary > objects, it doesn't have any specific way of specifying the embedded object > as being inherited and how you would persist it. In particular there is no > way to define a discriminator (column) for the embedded object. If we have an > example from the JDO spec, and if we have a subclass of Address as also > persistable, then we need to specify the discriminator for "primaryAddress" > field. > > ... > > > > > > > > > > > > So the XSD/DTD need updates to allow under , the > JDO Metadata API needs to allow this also, and the @Embedded annotation needs > a "discriminator" attribute adding. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
