[jira] [Commented] (JDO-707) Refactor JDO parent & child poms
[
https://issues.apache.org/jira/browse/JDO-707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273414#comment-13273414
]
Craig L Russell commented on JDO-707:
-
I think the version numbers should be hard coded, and not be substituted via
${project.version}. This is the advice I was given by the maven experts. The
version is required for defining the version in the pom, but not required for
declaring the dependencies.
Specifically, in tck/pom.xml, 3.1-SNAPSHOT should not be
removed. In the element and element, the version number
should either be removed (allow the parent pom to define the version number) or
should be retained.
In exectck/pom.xml, 1.0-SNAPSHOT should not be removed. The
changes @@ -69,6 +67,11 @@ and @@ -89,10 +92,6 @@ are unnecessary.
In api/pom.xml, 3.1-SNAPSHOT should not be removed.
> Refactor JDO parent & child poms
>
>
> Key: JDO-707
> URL: https://issues.apache.org/jira/browse/JDO-707
> Project: JDO
> Issue Type: Improvement
> Components: api, tck
>Affects Versions: JDO 3 maintenance release 1 (3.1)
>Reporter: Matthew T. Adams
>Assignee: Matthew T. Adams
> Labels: parent, pom
> Fix For: JDO 3 maintenance release 1 (3.1)
>
> Attachments: JDO-707-1.patch
>
>
> Create a parent-pom module, make modules api, exectck & tck inherit from it,
> then create a simple multimodule root pom which can be used to build all
> projects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JDO-707) Refactor JDO parent & child poms
[ https://issues.apache.org/jira/browse/JDO-707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226265#comment-13226265 ] Matthew T. Adams commented on JDO-707: -- The improvement comes when we release the 3.1 artifacts to Maven Central. When I released 3.0.1, I had to manually copy information from the parent pom into the JDO API pom. In 3.1, when we release, we should release not only artifact jdo-api, but also parent-pom. Then, there will not have to be any manual copying from the parent pom into the jdo-api pom. > Refactor JDO parent & child poms > > > Key: JDO-707 > URL: https://issues.apache.org/jira/browse/JDO-707 > Project: JDO > Issue Type: Improvement > Components: api, tck >Affects Versions: JDO 3 maintenance release 1 (3.1) >Reporter: Matthew T. Adams >Assignee: Matthew T. Adams > Labels: parent, pom > Fix For: JDO 3 maintenance release 1 (3.1) > > Attachments: JDO-707-1.patch > > > Create a parent-pom module, make modules api, exectck & tck inherit from it, > then create a simple multimodule root pom which can be used to build all > projects. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JDO-707) Refactor JDO parent & child poms
[ https://issues.apache.org/jira/browse/JDO-707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226253#comment-13226253 ] Michelle Caisse commented on JDO-707: - Wondering what the benefit is of this change over the existing setup? > Refactor JDO parent & child poms > > > Key: JDO-707 > URL: https://issues.apache.org/jira/browse/JDO-707 > Project: JDO > Issue Type: Improvement > Components: api, tck >Affects Versions: JDO 3 maintenance release 1 (3.1) >Reporter: Matthew T. Adams >Assignee: Matthew T. Adams > Labels: parent, pom > Fix For: JDO 3 maintenance release 1 (3.1) > > Attachments: JDO-707-1.patch > > > Create a parent-pom module, make modules api, exectck & tck inherit from it, > then create a simple multimodule root pom which can be used to build all > projects. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
