[jira] [Commented] (JDO-728) extension element for @Index, @ForeignKey, @Unique, @PrimaryKey annotations are needed.
[
https://issues.apache.org/jira/browse/JDO-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14030794#comment-14030794
]
Craig L Russell commented on JDO-728:
-
Updated the specification with 1602464.
extension element for @Index, @ForeignKey, @Unique, @PrimaryKey annotations
are needed.
---
Key: JDO-728
URL: https://issues.apache.org/jira/browse/JDO-728
Project: JDO
Issue Type: Improvement
Components: api, specification, tck
Affects Versions: JDO 3 update 1 (3.0.1)
Reporter: Baris ERGUN
Assignee: Craig L Russell
Priority: Minor
Fix For: JDO 3.1
Attachments: JDO-728.patch, TestExtensions.patch
JDO XSD for XML MetaData supports extension tag. But @Index does not have
such elements. Ie I cannot specify @Index(members = {sample},
extension=..). Hope this will be included in new releases. The extension
is used by ORM Frameworks in order to specify Index access method such HASH,
GIST etc ... (these are postgresql specific)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (JDO-728) extension element for @Index, @ForeignKey, @Unique, @PrimaryKey annotations are needed.
[
https://issues.apache.org/jira/browse/JDO-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14029782#comment-14029782
]
Michael Bouschen commented on JDO-728:
--
The changes look good. I propose to accept all the changes.
extension element for @Index, @ForeignKey, @Unique, @PrimaryKey annotations
are needed.
---
Key: JDO-728
URL: https://issues.apache.org/jira/browse/JDO-728
Project: JDO
Issue Type: Improvement
Components: api, specification, tck
Affects Versions: JDO 3 update 1 (3.0.1)
Reporter: Baris ERGUN
Assignee: Craig L Russell
Priority: Minor
Fix For: JDO 3.1
Attachments: JDO-728.patch, TestExtensions.patch
JDO XSD for XML MetaData supports extension tag. But @Index does not have
such elements. Ie I cannot specify @Index(members = {sample},
extension=..). Hope this will be included in new releases. The extension
is used by ORM Frameworks in order to specify Index access method such HASH,
GIST etc ... (these are postgresql specific)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (JDO-728) extension element for @Index, @ForeignKey, @Unique, @PrimaryKey annotations are needed.
[
https://issues.apache.org/jira/browse/JDO-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020012#comment-14020012
]
Craig L Russell commented on JDO-728:
-
I checked in the changes to the specification Chapter 19. Changes can be
reviewed using edit changes.
extension element for @Index, @ForeignKey, @Unique, @PrimaryKey annotations
are needed.
---
Key: JDO-728
URL: https://issues.apache.org/jira/browse/JDO-728
Project: JDO
Issue Type: Improvement
Components: api, specification, tck
Affects Versions: JDO 3 update 1 (3.0.1)
Reporter: Baris ERGUN
Assignee: Craig L Russell
Priority: Minor
Fix For: JDO 3.1
Attachments: JDO-728.patch, TestExtensions.patch
JDO XSD for XML MetaData supports extension tag. But @Index does not have
such elements. Ie I cannot specify @Index(members = {sample},
extension=..). Hope this will be included in new releases. The extension
is used by ORM Frameworks in order to specify Index access method such HASH,
GIST etc ... (these are postgresql specific)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (JDO-728) extension element for @Index, @ForeignKey, @Unique, @PrimaryKey annotations are needed.
[
https://issues.apache.org/jira/browse/JDO-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13916559#comment-13916559
]
Michael Bouschen commented on JDO-728:
--
The patch TestExtensions.patch looks good. I propose to remove the table name
in @Persistent(table=LINES). The name does not add any value, but might be
confusing.
A 'mvn clean install' succeeded with the patch.
extension element for @Index, @ForeignKey, @Unique, @PrimaryKey annotations
are needed.
---
Key: JDO-728
URL: https://issues.apache.org/jira/browse/JDO-728
Project: JDO
Issue Type: Improvement
Components: api, specification, tck
Affects Versions: JDO 3 update 1 (3.0.1)
Reporter: Baris ERGUN
Priority: Minor
Fix For: JDO 3 maintenance release 1 (3.1)
Attachments: JDO-728.patch, TestExtensions.patch
JDO XSD for XML MetaData supports extension tag. But @Index does not have
such elements. Ie I cannot specify @Index(members = {sample},
extension=..). Hope this will be included in new releases. The extension
is used by ORM Frameworks in order to specify Index access method such HASH,
GIST etc ... (these are postgresql specific)
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (JDO-728) extension element for @Index, @ForeignKey, @Unique, @PrimaryKey annotations are needed.
[
https://issues.apache.org/jira/browse/JDO-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13901651#comment-13901651
]
Craig L Russell commented on JDO-728:
-
To test that the annotation is properly defined, we just need to add a test
class with the annotations including the extension elements in the jdo-api
test/java/javax/jdo/annotations directory.
When compiling the jdo-api project if the class compiles the annotation is
correct.
Obviously, there cannot be a test for semantics.
extension element for @Index, @ForeignKey, @Unique, @PrimaryKey annotations
are needed.
---
Key: JDO-728
URL: https://issues.apache.org/jira/browse/JDO-728
Project: JDO
Issue Type: Improvement
Components: api, specification, tck
Affects Versions: JDO 3 update 1 (3.0.1)
Reporter: Baris ERGUN
Priority: Minor
Fix For: JDO 3 maintenance release 1 (3.1)
Attachments: JDO-728.patch
JDO XSD for XML MetaData supports extension tag. But @Index does not have
such elements. Ie I cannot specify @Index(members = {sample},
extension=..). Hope this will be included in new releases. The extension
is used by ORM Frameworks in order to specify Index access method such HASH,
GIST etc ... (these are postgresql specific)
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (JDO-728) extension element for @Index, @ForeignKey, @Unique, @PrimaryKey annotations are needed.
[
https://issues.apache.org/jira/browse/JDO-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874958#comment-13874958
]
Craig L Russell commented on JDO-728:
-
Don't we need a test case for this?
extension element for @Index, @ForeignKey, @Unique, @PrimaryKey annotations
are needed.
---
Key: JDO-728
URL: https://issues.apache.org/jira/browse/JDO-728
Project: JDO
Issue Type: Improvement
Components: api, specification, tck
Affects Versions: JDO 3 update 1 (3.0.1)
Reporter: Baris ERGUN
Priority: Minor
Attachments: JDO-728.patch
JDO XSD for XML MetaData supports extension tag. But @Index does not have
such elements. Ie I cannot specify @Index(members = {sample},
extension=..). Hope this will be included in new releases. The extension
is used by ORM Frameworks in order to specify Index access method such HASH,
GIST etc ... (these are postgresql specific)
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (JDO-728) extension element for @Index, @ForeignKey, @Unique, @PrimaryKey annotations are needed.
[
https://issues.apache.org/jira/browse/JDO-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875047#comment-13875047
]
Andy Jefferson commented on JDO-728:
How are you going to test something that is a vendor extension? Only thing I
can see is testing that the metadata API returns the extension specified, but
then that just tests processing of the annotations, not of the actual extension.
extension element for @Index, @ForeignKey, @Unique, @PrimaryKey annotations
are needed.
---
Key: JDO-728
URL: https://issues.apache.org/jira/browse/JDO-728
Project: JDO
Issue Type: Improvement
Components: api, specification, tck
Affects Versions: JDO 3 update 1 (3.0.1)
Reporter: Baris ERGUN
Priority: Minor
Attachments: JDO-728.patch
JDO XSD for XML MetaData supports extension tag. But @Index does not have
such elements. Ie I cannot specify @Index(members = {sample},
extension=..). Hope this will be included in new releases. The extension
is used by ORM Frameworks in order to specify Index access method such HASH,
GIST etc ... (these are postgresql specific)
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (JDO-728) extension element for @Index, @ForeignKey, @Unique, @PrimaryKey annotations are needed.
[
https://issues.apache.org/jira/browse/JDO-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875112#comment-13875112
]
Craig L Russell commented on JDO-728:
-
@Andy: Right. I was thinking of the extension in the xsd but this is the API.
extension element for @Index, @ForeignKey, @Unique, @PrimaryKey annotations
are needed.
---
Key: JDO-728
URL: https://issues.apache.org/jira/browse/JDO-728
Project: JDO
Issue Type: Improvement
Components: api, specification, tck
Affects Versions: JDO 3 update 1 (3.0.1)
Reporter: Baris ERGUN
Priority: Minor
Attachments: JDO-728.patch
JDO XSD for XML MetaData supports extension tag. But @Index does not have
such elements. Ie I cannot specify @Index(members = {sample},
extension=..). Hope this will be included in new releases. The extension
is used by ORM Frameworks in order to specify Index access method such HASH,
GIST etc ... (these are postgresql specific)
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (JDO-728) extension element for @Index, @ForeignKey, @Unique, @PrimaryKey annotations are needed.
[
https://issues.apache.org/jira/browse/JDO-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13870748#comment-13870748
]
Andy Jefferson commented on JDO-728:
Patch checked in
extension element for @Index, @ForeignKey, @Unique, @PrimaryKey annotations
are needed.
---
Key: JDO-728
URL: https://issues.apache.org/jira/browse/JDO-728
Project: JDO
Issue Type: Improvement
Components: api
Affects Versions: JDO 3 update 1 (3.0.1)
Reporter: Baris ERGUN
Priority: Minor
Attachments: JDO-728.patch
JDO XSD for XML MetaData supports extension tag. But @Index does not have
such elements. Ie I cannot specify @Index(members = {sample},
extension=..). Hope this will be included in new releases. The extension
is used by ORM Frameworks in order to specify Index access method such HASH,
GIST etc ... (these are postgresql specific)
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
