[jira] [Commented] (JDO-745) Support bitwise operations in JDOQL
[ https://issues.apache.org/jira/browse/JDO-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205270#comment-16205270 ] Michael Bouschen commented on JDO-745: -- Checked in the patch (see revision 1812229). > Support bitwise operations in JDOQL > --- > > Key: JDO-745 > URL: https://issues.apache.org/jira/browse/JDO-745 > Project: JDO > Issue Type: New Feature > Components: specification, tck >Reporter: Andy Jefferson >Assignee: Michael Bouschen > Fix For: JDO 3.2 > > Attachments: JDO-745-patch3.txt, JDO-745.patch > > > The tests BooleanLogicalAND.testNegative, BooleanLogicalOR.testNegative don't > test use of a boolean logical AND/OR. They actually test for an integer being > used with the "&" and "|" operators. Sadly this means that any implementation > that attempts to provide a vendor extension of support for bitwise AND/OR > (for those RDBMS that support it) cannot pass the TCK. > Perhaps add an "optional feature" for the vendor to support bitwise > operations, and then don't run that test if so. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (JDO-745) Support bitwise operations in JDOQL
[ https://issues.apache.org/jira/browse/JDO-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192288#comment-16192288 ] Craig L Russell commented on JDO-745: - The expected results for bitwise and and or seem wrong. "4 <= id && id >= 7" should be ? "4 <= id && id <= 7" I'd also suggest that the query predicate (byteNotNull & 4) returns a bunch of bits that should be compared via equality and not order, so: "(byteNotNull & 4) != 0" > Support bitwise operations in JDOQL > --- > > Key: JDO-745 > URL: https://issues.apache.org/jira/browse/JDO-745 > Project: JDO > Issue Type: New Feature > Components: specification, tck >Reporter: Andy Jefferson >Assignee: Michael Bouschen > Fix For: JDO 3.2 > > Attachments: JDO-745.patch, JDO-745-patch2.txt > > > The tests BooleanLogicalAND.testNegative, BooleanLogicalOR.testNegative don't > test use of a boolean logical AND/OR. They actually test for an integer being > used with the "&" and "|" operators. Sadly this means that any implementation > that attempts to provide a vendor extension of support for bitwise AND/OR > (for those RDBMS that support it) cannot pass the TCK. > Perhaps add an "optional feature" for the vendor to support bitwise > operations, and then don't run that test if so. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (JDO-745) Support bitwise operations in JDOQL
[ https://issues.apache.org/jira/browse/JDO-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187457#comment-16187457 ] Andy Jefferson commented on JDO-745: Does Apache Derby now support some bitwise operators? because it certainly never used to (hence DataNucleus not supporting it). If it still does not then is the test of value when the TCK only runs with Derby? See https://stackoverflow.com/questions/11101333/bitwise-operator-in-apache-derby Regarding having the TCK runnable on other RDBMS, I'd welcome that, but the significant blocker on that is that the "exectck" was written explicitly to use this Derby "ijs" seemingly, rather than using JDBC, like the code in https://github.com/datanucleus/datanucleus-rdbms/blob/master/src/main/java/org/datanucleus/store/rdbms/RDBMSStoreManager.java#L4349 > Support bitwise operations in JDOQL > --- > > Key: JDO-745 > URL: https://issues.apache.org/jira/browse/JDO-745 > Project: JDO > Issue Type: New Feature > Components: specification, tck >Reporter: Andy Jefferson >Assignee: Michael Bouschen > Fix For: JDO 3.2 > > Attachments: JDO-745.patch, JDO-745-patch2.txt > > > The tests BooleanLogicalAND.testNegative, BooleanLogicalOR.testNegative don't > test use of a boolean logical AND/OR. They actually test for an integer being > used with the "&" and "|" operators. Sadly this means that any implementation > that attempts to provide a vendor extension of support for bitwise AND/OR > (for those RDBMS that support it) cannot pass the TCK. > Perhaps add an "optional feature" for the vendor to support bitwise > operations, and then don't run that test if so. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (JDO-745) Support bitwise operations in JDOQL
[ https://issues.apache.org/jira/browse/JDO-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157389#comment-16157389 ] Michael Bouschen commented on JDO-745: -- Checked in the patch JDO-745.patch: fix negative tests to make use of string fields ( see committed revision 1807630). > Support bitwise operations in JDOQL > --- > > Key: JDO-745 > URL: https://issues.apache.org/jira/browse/JDO-745 > Project: JDO > Issue Type: New Feature > Components: specification, tck >Reporter: Andy Jefferson >Assignee: Michael Bouschen > Fix For: JDO 3.2 > > Attachments: JDO-745.patch > > > The tests BooleanLogicalAND.testNegative, BooleanLogicalOR.testNegative don't > test use of a boolean logical AND/OR. They actually test for an integer being > used with the "&" and "|" operators. Sadly this means that any implementation > that attempts to provide a vendor extension of support for bitwise AND/OR > (for those RDBMS that support it) cannot pass the TCK. > Perhaps add an "optional feature" for the vendor to support bitwise > operations, and then don't run that test if so. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (JDO-745) Support bitwise operations in JDOQL
[ https://issues.apache.org/jira/browse/JDO-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14662974#comment-14662974 ] Andy Jefferson commented on JDO-745: SVN now has javax.jdo.query.JDOQL.BitwiseOperations added to Constants, so can be used if the tests are going to be updated. While doing that I see that there is javax.jdo.option.UnconstrainedQueryVariables The JDO implementation supports JDOQL queries that contain a variable without a contains clause to constrain the variable. Surely, to be consistent with naming, this should be (renamed to) javax.jdo.query.JDOQL.UnconstraintedQueryVariables ?? Support bitwise operations in JDOQL --- Key: JDO-745 URL: https://issues.apache.org/jira/browse/JDO-745 Project: JDO Issue Type: New Feature Components: tck Reporter: Andy Jefferson Fix For: JDO 3.2 Attachments: JDO-745.patch The tests BooleanLogicalAND.testNegative, BooleanLogicalOR.testNegative don't test use of a boolean logical AND/OR. They actually test for an integer being used with the and | operators. Sadly this means that any implementation that attempts to provide a vendor extension of support for bitwise AND/OR (for those RDBMS that support it) cannot pass the TCK. Perhaps add an optional feature for the vendor to support bitwise operations, and then don't run that test if so. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JDO-745) Support bitwise operations in JDOQL
[ https://issues.apache.org/jira/browse/JDO-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14663077#comment-14663077 ] Andy Jefferson commented on JDO-745: javax.jdo.option.UnconstrainedQueryVariables is now renamed in Constants.java and also in the spec Ch11. Added javax.jdo.query.JDOQL.bitwiseOperations to spec Ch11 while in there. Still needs some text in Query chapter. Support bitwise operations in JDOQL --- Key: JDO-745 URL: https://issues.apache.org/jira/browse/JDO-745 Project: JDO Issue Type: New Feature Components: tck Reporter: Andy Jefferson Fix For: JDO 3.2 Attachments: JDO-745.patch The tests BooleanLogicalAND.testNegative, BooleanLogicalOR.testNegative don't test use of a boolean logical AND/OR. They actually test for an integer being used with the and | operators. Sadly this means that any implementation that attempts to provide a vendor extension of support for bitwise AND/OR (for those RDBMS that support it) cannot pass the TCK. Perhaps add an optional feature for the vendor to support bitwise operations, and then don't run that test if so. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
