Big patch

2011-09-27 Thread Matthew Adams
Hi all,

Attached is a patch to trunk for JDO-693  JDO-688.

It also fixes the failing tests in PMFMapMapTest.  I refactored the
JDOConfigTestClassLoader to be simpler.  Don't remember what I was
thinking way back when I wrote it, but it's way simpler now.

I'd thought about creating a roll-up task in JIRA to house this patch
and links to the aforementioned issues and a new issue that I'd enter
for the failing PMFMapMapTest methods.  Some of these changes
(JDO-693?) could be merged into the 3.0 branch as well.

Please review  comment.

-matthew

-- 
@matthewadams12
mailto:matt...@matthewadams.me
skype:matthewadams12
yahoo:matthewadams
aol:matthewadams12
google-talk:matthewadam...@gmail.com
msn:matt...@matthewadams.me
http://matthewadams.me
http://www.linkedin.com/in/matthewadams


Re: Big patch

2011-09-27 Thread Craig L Russell

Hi Matthew,

I'm afraid only the subscribers to jdo-experts got the attachment.

Can you please attach it to one of the JIRA issues?

Thanks,

Craig

On Sep 27, 2011, at 10:32 AM, Matthew Adams wrote:


Hi all,

Attached is a patch to trunk for JDO-693  JDO-688.

It also fixes the failing tests in PMFMapMapTest.  I refactored the
JDOConfigTestClassLoader to be simpler.  Don't remember what I was
thinking way back when I wrote it, but it's way simpler now.

I'd thought about creating a roll-up task in JIRA to house this patch
and links to the aforementioned issues and a new issue that I'd enter
for the failing PMFMapMapTest methods.  Some of these changes
(JDO-693?) could be merged into the 3.0 branch as well.

Please review  comment.

-matthew

--
@matthewadams12
mailto:matt...@matthewadams.me
skype:matthewadams12
yahoo:matthewadams
aol:matthewadams12
google-talk:matthewadam...@gmail.com
msn:matt...@matthewadams.me
http://matthewadams.me
http://www.linkedin.com/in/matthewadams


Craig L Russell
Architect, Oracle
http://db.apache.org/jdo
408 276-5638 mailto:craig.russ...@oracle.com
P.S. A good JDO? O, Gasp!



Re: Big patch

2011-09-27 Thread Matthew Adams
Done.  See JDO-695.

On Tue, Sep 27, 2011 at 12:51 PM, Craig L Russell
craig.russ...@oracle.com wrote:
 Hi Matthew,

 I'm afraid only the subscribers to jdo-experts got the attachment.

 Can you please attach it to one of the JIRA issues?

 Thanks,

 Craig

 On Sep 27, 2011, at 10:32 AM, Matthew Adams wrote:

 Hi all,

 Attached is a patch to trunk for JDO-693  JDO-688.

 It also fixes the failing tests in PMFMapMapTest.  I refactored the
 JDOConfigTestClassLoader to be simpler.  Don't remember what I was
 thinking way back when I wrote it, but it's way simpler now.

 I'd thought about creating a roll-up task in JIRA to house this patch
 and links to the aforementioned issues and a new issue that I'd enter
 for the failing PMFMapMapTest methods.  Some of these changes
 (JDO-693?) could be merged into the 3.0 branch as well.

 Please review  comment.

 -matthew

 --
 @matthewadams12
 mailto:matt...@matthewadams.me
 skype:matthewadams12
 yahoo:matthewadams
 aol:matthewadams12
 google-talk:matthewadam...@gmail.com
 msn:matt...@matthewadams.me
 http://matthewadams.me
 http://www.linkedin.com/in/matthewadams

 Craig L Russell
 Architect, Oracle
 http://db.apache.org/jdo
 408 276-5638 mailto:craig.russ...@oracle.com
 P.S. A good JDO? O, Gasp!





-- 
@matthewadams12
mailto:matt...@matthewadams.me
skype:matthewadams12
yahoo:matthewadams
aol:matthewadams12
google-talk:matthewadam...@gmail.com
msn:matt...@matthewadams.me
http://matthewadams.me
http://www.linkedin.com/in/matthewadams