Re: [PR] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)
sonarcloud[bot] commented on PR #85: URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1794402762 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=85) [](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=85&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=85&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=85&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=85) No Coverage information [](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=85&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=85&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)
sonarcloud[bot] commented on PR #85: URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1804648411 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=85) [](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=85&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=85&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=85&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=CODE_SMELL) [11 Code Smells](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=85) No Coverage information [](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=85&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=85&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)
tzaeschke commented on PR #85: URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1817493730 For me the test log output is scrambled. For example the file `app-company1-1Relationships-junit.txt` looks like this: ``` [36m.[0m [36m'--[0m [36mJUnit Jupiter[0m [32m[OK][0m [36m '--[0m [36mCompletenessTest[0m [32m[OK][0m [36m'--[0m [34mtest()[0m [32m[OK][0m Test run finished after 1170 ms [ 2 containers found ] [ 0 containers skipped] [ 2 containers started] [ 0 containers aborted] [ 2 containers successful ] [ 0 containers failed ] [ 1 tests found ] [ 0 tests skipped ] [ 1 tests started ] [ 0 tests aborted ] [ 1 tests successful ] [ 0 tests failed ] [33m[1mWARNING:[21m[39m[0m Delegated to the 'execute' command. This behaviour has been deprecated and will be removed in a future release. Please use the 'execute' command directly. ``` It's not obvious to me why this happens, the code looks unsuspicious, any suggestions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)
tzaeschke commented on PR #85: URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1817496798 A failed test looks like this: [app-relationshipAllRelationships-junit.txt](https://github.com/apache/db-jdo/files/13400258/app-relationshipAllRelationships-junit.txt) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)
mboapache commented on PR #85: URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1817585647 1. About the test log output: this is what I have mentioned before, you should print the output using more -R or less -R. If we do not like this output, then we need to find a JUnit launcher class other than org.junit.platform.console.ConsoleLauncher. 2. The -jdori.txt files should include the datanucleus output. I have to check why this is not copied over. 3. The logger output should go into the -txt.txt files. I need to check why this does not work. 4. We have to discuss which Output from System.err we are talking about: output from RunTCK versus output from the test class. 5. This empty line causes the value jdo.tck.classes being empty, so there is no TCK test class specified. There was a bug in RunTCK in method getTestClasses when checking whether there is a test class specified. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)
sonarcloud[bot] commented on PR #85: URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1817586768 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=85) [](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=85&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=85&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=85&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=CODE_SMELL) [14 Code Smells](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=85) No Coverage information [](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=85&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=85&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)
sonarcloud[bot] commented on PR #85: URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1817963484 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=85) [](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=85&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=85&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=85&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=CODE_SMELL) [14 Code Smells](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=85) No Coverage information [](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=85&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=85&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)
mboapache commented on PR #85: URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1817966299 I found the problem of issues 2. and 3. from above: now the datanucleus output is store in the -jdori.txt file and the logger output of the TCK test classes go into the -tck.txt files. Fix is checked in into branch JDO-830. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)
sonarcloud[bot] commented on PR #85: URL: https://github.com/apache/db-jdo/pull/85#issuecomment-1821514067 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=db-jdo&pullRequest=85) [](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=85&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=85&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=db-jdo&pullRequest=85&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=CODE_SMELL) [14 Code Smells](https://sonarcloud.io/project/issues?id=db-jdo&pullRequest=85&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=85) No Coverage information [](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=85&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=db-jdo&pullRequest=85&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] JDO-830: Migrate JUnit tests in tck to version 5 (db-jdo)
mboapache merged PR #85: URL: https://github.com/apache/db-jdo/pull/85 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
