Branch: refs/heads/master
Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin
Commit: 1b56ae3719b38ddd5a7545c0321c567107847965
https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/1b56ae3719b38ddd5a7545c0321c567107847965
Author: Pavel Roskin <plros...@gmail.com>
Date: 2019-11-28 (Thu, 28 Nov 2019)
Changed paths:
M
src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClient.java
Log Message:
-----------
StashApiClient: Don't ever return null from entityAsString()
EntityUtils.toString() can return null under some obscure circumstances.
>From our point of view, it's the same as an empty response, as long as no
exception is thrown. JSON parser would consider both as invalid JSON, but
it's safer not to deal with null.
Use Util.fix to convert null to an empty string.
Mark getRequest() and postRequest() as @Nonnull, they return the result
of entityAsString().
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/a1a7f3-1b56ae%40github.com.
