Re: Granularity of pipeline steps

2017-07-24 Thread 'Björn Pedersen' via Jenkins Developers
Hi,

It looks like a lot of the problems are linked to:
https://issues.jenkins-ci.org/browse/JENKINS-28119,Link to log of failed 
step
https://issues.jenkins-ci.org/browse/JENKINS-38381, Optimize log handling 
in Pipeline and Durable Task
https://issues.jenkins-ci.org/browse/JENKINS-26522, Annotated block/stage 
status

Björn

Am Montag, 24. Juli 2017 22:55:53 UTC+2 schrieb Ullrich Hafner:
>
> I’m currently implementing a better pipeline support for the static 
> analysis plug-ins (see [1]). 
> From the documentation of Step it is not clear to me, when to implement a 
> Step or when to use a method on a returned object. So basically, is a 
> procedural or object oriented approach desired? 
>
> E.g, in a freestyle project the warnings publisher does the following 
> things (among others): 
> 1) parse files for warnings 
> 2) copy files to build folder for future reference 
> 3) compute difference (new, old, fixed warnings) with regard to a 
> reference build 
> 4) blame authors of warnings 
> 5) publish warnings as persistent Action 
>
> So my question is: is everything a step? Or should e.g. step 1 (parse 
> warnings) return an object that has some methods, e.g. to copy the files 
> (2) to the build folder? 
>
> When I implement everything as Step then the list of available steps will 
> grow very fast (name clashes will be also very probable) 
>
> Are there some recommendations or is this decision up to the plugin 
> author? 
>
> [1] https://wiki.jenkins.io/display/JENKINS/Static+Analysis+in+Pipelines 
>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/08472d05-1b2f-4d85-ae9c-2b949c3f131e%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Granularity of pipeline steps

2017-07-24 Thread Ullrich Hafner
I’m currently implementing a better pipeline support for the static analysis 
plug-ins (see [1]).
>From the documentation of Step it is not clear to me, when to implement a Step 
>or when to use a method on a returned object. So basically, is a procedural or 
>object oriented approach desired?

E.g, in a freestyle project the warnings publisher does the following things 
(among others):
1) parse files for warnings
2) copy files to build folder for future reference
3) compute difference (new, old, fixed warnings) with regard to a reference 
build
4) blame authors of warnings
5) publish warnings as persistent Action

So my question is: is everything a step? Or should e.g. step 1 (parse warnings) 
return an object that has some methods, e.g. to copy the files (2) to the build 
folder?

When I implement everything as Step then the list of available steps will grow 
very fast (name clashes will be also very probable)

Are there some recommendations or is this decision up to the plugin author?

[1] https://wiki.jenkins.io/display/JENKINS/Static+Analysis+in+Pipelines


-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/9E4A672A-2BE5-4352-AFF2-0298751EA7CE%40gmail.com.
For more options, visit https://groups.google.com/d/optout.


signature.asc
Description: Message signed with OpenPGP


Re: gradle-jpi-plugin dependency resolution patch

2017-07-24 Thread Ryan Campbell
It would be awesome to merge this so that we can get better pipeline
support for the gradle-plugin!

On Mon, Jul 17, 2017 at 1:28 PM  wrote:

> Hello Jenkins devs,
>
> About 3 weeks ago I spoke with Daniel Spilker about the gradle-jpi-plugin
>  not picking up
> transitive dependencies. He submitted this PR
>  which seems to
> fix the issue.
>
> Partial pipeline support
>  for the
> gradle-plugin is currently blocked for review/merge while waiting for this
> patch to be released. Writing this to ping Daniel and ask for help getting
> a merge of his gradle-jpi-plugin patch.
>
> Thanks all,
> - Alex Johnson (github: alexbrjo)
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/ee349e5d-7a37-4c76-932c-08a60fca4882%40googlegroups.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANHK%3DJ2xMJcnm4pp%2BizYOWH%3D2hVy%3DcwSn99mao81tK0uETj%2BuA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Adopt a plugin] S3Plugin

2017-07-24 Thread Jimilian
I'm alive! :)

So, feel free to contact me via mail or PRs :)
I totally agree that S3 Plugin needs much more love (at least from 
testability perspective), but nevertheless any good PRs are welcome!

p.s. There are tons of plugins that are looking for good hands as well, 
i.e. xUnit Plugin.

Br, Alex

On Monday, 24 July 2017 19:02:26 UTC+2, Gergely Brautigam wrote:
>
> Thanks very much Oleg! 

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/4aab2e97-ed9c-4078-8bbb-7283262bbcd7%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Adopt a plugin] S3Plugin

2017-07-24 Thread Gergely Brautigam
Thanks very much Oleg! 

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/bda1d09b-5aee-4830-af10-81ddfec3f690%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Adopt a plugin] - vsphere-cloud

2017-07-24 Thread Oleg Nenashev
Hi Peter and Eric,

Who does want to be a default assignee?
Unfortunately I can set only a single person (but you can setup JIRA
notification rules even if you are not the maintainer).

BR, Oleg


2017-07-24 17:17 GMT+03:00 Jason Swager :

> Yes please, can you change the default assignee too.
>
>
> On Monday, July 24, 2017 at 5:08:58 AM UTC-7, Oleg Nenashev wrote:
>>
>> Hi all,
>>
>> Commit access is granted, thanks for your work on this plugin!
>> Please let me know if you want to change the default assignee in JIRA as
>> well.
>>
>> BR, Oleg
>>
>>
>> суббота, 22 июля 2017 г., 3:48:23 UTC+3 пользователь Jason Swager написал:
>>>
>>> Hello,
>>>
>>> I am the current owner of the vsphere-cloud plugin.  And I very much
>>> approve and endorse this request; please approve it  My github id is
>>> "jswager", my Jenkins ID is "jswager1"
>>>
>>> I've been looking for new owners to adopt this plugin due to my own lack
>>> of time and resources to dedicate to this project.  Peter and Eric have
>>> graciously volunteered to adopt it.
>>>
>>> Thank you,
>>> Jason
>>>
>>> On Friday, July 21, 2017 at 8:53:58 AM UTC-7, Peter Darton wrote:

 Hi folks,

 The vsphere-cloud plugin has a number of outstanding PRs, some of them
 from early this year.
 The only plugin owner with commit access (Jason) no longer has the
 time/resources to continue working on the plugin (or access to the
 resources required to test it) and is on record saying that he would like
 someone else to take over (https://groups.google.com/d/m
 sg/jenkinsci-dev/gowLQQXBUec/CgGZ-hQvBQAJ).
 I was discussing a takeover with the other plugin maintainer (Eric, who
 does not have commit access at present) when Jason said he was trying to
 hand over commit-access to us (https://github.com/jenkinsci/
 vsphere-cloud-plugin/pull/76#issuecomment-313497218) ... but as
 there's no sign of further activity on that front it would appear that this
 process has stalled.
 I would like to get that process (re?)started so we can get this sorted.

 I understand (from https://wiki.jenkins.io/displa
 y/JENKINS/Adopt+a+Plugin) that you need github and
 jenkins-infrastructure IDs to grant people commit access...
  - My github ID is "pjdarton", and my Jenkins-infrastructure ID is also
 "pjdarton".
  - Eric's github ID is "elordahl" and I believe that his
 Jenkins-infrastructure ID is the same (https://issues.jenkins-ci.org
 /secure/ViewProfile.jspa?name=elordahl).

 Please can you grant us both commit-access to the vsphere-cloud plugin?

 We could then work on clearing the backlog of PRs...

 Regards,

   Peter

 --
> You received this message because you are subscribed to a topic in the
> Google Groups "Jenkins Developers" group.
> To unsubscribe from this topic, visit https://groups.google.com/d/
> topic/jenkinsci-dev/bvO_YOsYhR0/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/
> msgid/jenkinsci-dev/fb0181e6-e53f-4679-a8e9-3f8e3c09f8b5%
> 40googlegroups.com
> 
> .
>
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLCp%3DCLuRYO7b05qvKV5bw2aQhstmHHxtepmUutBkTw%2Big%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Adopt a plugin] - vsphere-cloud

2017-07-24 Thread Jason Swager
Yes please, can you change the default assignee too.  

On Monday, July 24, 2017 at 5:08:58 AM UTC-7, Oleg Nenashev wrote:
>
> Hi all,
>
> Commit access is granted, thanks for your work on this plugin!
> Please let me know if you want to change the default assignee in JIRA as 
> well.
>
> BR, Oleg
>
>
> суббота, 22 июля 2017 г., 3:48:23 UTC+3 пользователь Jason Swager написал:
>>
>> Hello,
>>
>> I am the current owner of the vsphere-cloud plugin.  And I very much 
>> approve and endorse this request; please approve it  My github id is 
>> "jswager", my Jenkins ID is "jswager1"
>>
>> I've been looking for new owners to adopt this plugin due to my own lack 
>> of time and resources to dedicate to this project.  Peter and Eric have 
>> graciously volunteered to adopt it.
>>
>> Thank you,
>> Jason
>>
>> On Friday, July 21, 2017 at 8:53:58 AM UTC-7, Peter Darton wrote:
>>>
>>> Hi folks,
>>>
>>> The vsphere-cloud plugin has a number of outstanding PRs, some of them 
>>> from early this year.
>>> The only plugin owner with commit access (Jason) no longer has the 
>>> time/resources to continue working on the plugin (or access to the 
>>> resources required to test it) and is on record saying that he would like 
>>> someone else to take over (
>>> https://groups.google.com/d/msg/jenkinsci-dev/gowLQQXBUec/CgGZ-hQvBQAJ).
>>> I was discussing a takeover with the other plugin maintainer (Eric, who 
>>> does not have commit access at present) when Jason said he was trying to 
>>> hand over commit-access to us (
>>> https://github.com/jenkinsci/vsphere-cloud-plugin/pull/76#issuecomment-313497218)
>>>  
>>> ... but as there's no sign of further activity on that front it would 
>>> appear that this process has stalled.
>>> I would like to get that process (re?)started so we can get this sorted.
>>>
>>> I understand (from 
>>> https://wiki.jenkins.io/display/JENKINS/Adopt+a+Plugin) that you need 
>>> github and jenkins-infrastructure IDs to grant people commit access...
>>>  - My github ID is "pjdarton", and my Jenkins-infrastructure ID is also 
>>> "pjdarton".
>>>  - Eric's github ID is "elordahl" and I believe that his 
>>> Jenkins-infrastructure ID is the same (
>>> https://issues.jenkins-ci.org/secure/ViewProfile.jspa?name=elordahl).
>>>
>>> Please can you grant us both commit-access to the vsphere-cloud plugin?
>>>
>>> We could then work on clearing the backlog of PRs...
>>>
>>> Regards,
>>>
>>>   Peter
>>>
>>>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/fb0181e6-e53f-4679-a8e9-3f8e3c09f8b5%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Customize node creation from within a pipeline definition

2017-07-24 Thread Jonathan Ballet
Hi,

I'm looking how possible it would be to allow the customization of a new 
Jenkins worker based on the definition of a node within a Jenkinsfile file.

Considering a node provisioner which is able to create new nodes from 
Docker images for example, I would like to be able to do something similar 
to this:

node("my-node-provisioner", docker_image="internal/jenkins-worker:v12", 
memory_limit="4GB") {
// my steps here
}

That would allow the developers to customize the context in which their job 
is running in, within the available node provisioner possibilities, while 
keeping all the versioning on how the job needs to be executed within the 
Jenkinsfile of the project.

Some more context about what I'd like to do: I'm using the Nomad plugin to 
schedule our Jenkins jobs in the pool of machines we are managing via the 
Nomad scheduler. Nodes ("slave templates" in the Nomad plugin terminology) 
can be configured from Jenkins main configuration screen, but it's not that 
convenient. See my RFC here for even more details: 
https://github.com/jenkinsci/nomad-plugin/issues/20

It's my first time digging inside Jenkins extensions and I don't really 
know where I should start to look for. Any pointers would be appreciated! 
I'm especially interested to know if it's something which has been done 
before, and if it's desirable or not.

Thanks!

 Jonathan

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/3bfab27d-79ab-427b-b67b-ad69a6830001%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Request to join the Jenkins Security Team

2017-07-24 Thread Stephen Connolly
More the merrier IMHO, I am +1 on you joining

On 24 July 2017 at 06:04, 'Bruno P. Kinoshita' via Jenkins Developers <
jenkinsci-dev@googlegroups.com> wrote:

> Hi Oleg,
>
> I had seen the security advisory, and in the Wiki and GitHub I can see
> some progress made to fix some of the 5 issues.
>
> But I think the maintainer is the only one with access to read and comment
> in the SECURITY-XXX tickets.
>
> At least that's what I recall from when I worked on an SECURITY issue. My
> intention was to check the progress of tickets, see if there was a patch
> somewhere to be tested, or a discussion going on. And then try to help
> scriptler and any other plugin I use/used or that is a dependency in one of
> the plugins I use.
>
> But I can wait till the maintainer has made further progress on the
> issues. I will re-read the description of the security issues with more
> calm over the next days, check latest code and try to liaise directly with
> the maintainer if I have a patch.
>
> Cheers
> Bruno
>
>
> Sent from Yahoo Mail on Android
> 
>
> On Tue, 25 Jul 2017 at 0:06, Oleg Nenashev
>  wrote:
> Hi Bruno,
>
> Generally I am +1 with this request. Having more people is definitely
> useful.
>
> OTOH you probably do not need to be a member of the Security team if you
> *just* want to fix Scriptler. It's vulnerabilities are publicly listed in
> this advisory: https://jenkins.io/security/advisory/2017-04-10/ .
> Regarding plugins maintained by active contributors, we usually assign
> security issues to them. In all other cases like core fixes, yes it makes
> sense to join the security team.
>
> Best regards,
> Oleg
>
> суббота, 22 июля 2017 г., 12:38:12 UTC+3 пользователь kinow написал:
>
> Hi,
>
> I would like to request to be added to the Jenkins Security Team. My main
> interest is in helping to fix issues in any dependency of the plug-ins I
> maintain, as well as in the core. Right now Scriptler is a plug-in I would
> like to try and see if I could help, as it is blocking
> active-choices-plugin.
>
> GitHub with 2FA enabled: kinow
> CLA: https://github.com/jenkinsci/ infra-cla/pull/48
> 
> FreeNode user: kinow
>
> Thank you
> Bruno
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/
> msgid/jenkinsci-dev/20d20e3c-a222-4d53-8309-3dd6daee74a0%
> 40googlegroups.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/
> msgid/jenkinsci-dev/614930702.4539161.1500901468492%40mail.yahoo.com
> 
> .
>
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMynB%2B%3D0afMpt9q_SDa%2BENAChyiR7OepuQ72BkMH%3Dsu4LQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: Request to join the Jenkins Security Team

2017-07-24 Thread 'Bruno P. Kinoshita' via Jenkins Developers
Hi Oleg,
I had seen the security advisory, and in the Wiki and GitHub I can see some 
progress made to fix some of the 5 issues.
But I think the maintainer is the only one with access to read and comment in 
the SECURITY-XXX tickets.
At least that's what I recall from when I worked on an SECURITY issue. My 
intention was to check the progress of tickets, see if there was a patch 
somewhere to be tested, or a discussion going on. And then try to help 
scriptler and any other plugin I use/used or that is a dependency in one of the 
plugins I use.
But I can wait till the maintainer has made further progress on the issues. I 
will re-read the description of the security issues with more calm over the 
next days, check latest code and try to liaise directly with the maintainer if 
I have a patch.
CheersBruno 

Sent from Yahoo Mail on Android 
 
  On Tue, 25 Jul 2017 at 0:06, Oleg Nenashev wrote:   
Hi Bruno,

Generally I am +1 with this request. Having more people is definitely useful.

OTOH you probably do not need to be a member of the Security team if you just 
want to fix Scriptler. It's vulnerabilities are publicly listed in this 
advisory: https://jenkins.io/security/advisory/2017-04-10/ . Regarding plugins 
maintained by active contributors, we usually assign security issues to them. 
In all other cases like core fixes, yes it makes sense to join the security 
team. 

Best regards,
Oleg

суббота, 22 июля 2017 г., 12:38:12 UTC+3 пользователь kinow написал:
Hi,
I would like to request to be added to the Jenkins Security Team. My main 
interest is in helping to fix issues in any dependency of the plug-ins I 
maintain, as well as in the core. Right now Scriptler is a plug-in I would like 
to try and see if I could help, as it is blocking active-choices-plugin.
GitHub with 2FA enabled: kinowCLA: https://github.com/jenkinsci/ 
infra-cla/pull/48FreeNode user: kinow
Thank youBruno



-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/20d20e3c-a222-4d53-8309-3dd6daee74a0%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
  

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/614930702.4539161.1500901468492%40mail.yahoo.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Adopt a plugin] S3Plugin

2017-07-24 Thread Oleg Nenashev
Hi Gergely,

>From what I see the plugin is being maintained by Alexander Akbashev. It is 
not marked for adoption. I have pinged alexander, so hopefully he will 
check this thread to let you sync-up on the next steps. Apart from the 
plugin ownership sode, having more contributors is always useful.

BR, Oleg

понедельник, 24 июля 2017 г., 14:22:19 UTC+3 пользователь Gergely Brautigam 
написал:
>
> Hi Folks. 
>
> So, first things first. I don't have an account on Jenkins JIRA yet. I'm 
> going to create one if adopting the plugin is feasible.
>
> I have 13+ years of Java experience, HOWEVER, 0.1 years of experience 
> writing / building Jenkins Plugins. :)
>
> Thus, might I take over the plugin? It needs some serious love and 
> attention and merging of PRs and addressing of Issues a lot. :)
>
> Cheers,
> Gergely.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/f6feeac5-716b-4f8f-8bb1-9bbcbf4e559c%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Jetty Http2 connector for Jenkins

2017-07-24 Thread Oleg Nenashev
The feature has been released in 2.71
Thanks for doing it, Oliver

пятница, 21 июля 2017 г., 8:43:39 UTC+3 пользователь Olivier Lamy написал:
>
> Hi
> It's now merged.
> Thanks guys for the reviews.
> I have added documentation to the page. let me know if this makes sense 
> especially how to get the right alpn-boot jar.
> Maybe next week, I will try to provide a more easy way to get this jar. 
> (some tools to automatically download it)
> Cheers
> Olivier
>
>
>
> On 17 July 2017 at 10:57, Olivier Lamy > 
> wrote:
>
>> Hi
>> Once all prs are merged I will improve the wiki page here [1] to add 
>> http2 parameter and explain how to include alpn.
>>
>> Cheers
>> Olivier
>> [1] 
>> https://wiki.jenkins-ci.org/display/JENKINS/Starting+and+Accessing+Jenkins
>>
>>
>> On 14 July 2017 at 02:35, Oleg Nenashev > > wrote:
>>
>>> Even if alpn is not available by default, it will be a useful 
>>> enhancement.
>>> Let's see if we can land it till the next LTS baseline cut-off.
>>>
>>> BR, Oleg
>>>
>>> вторник, 11 июля 2017 г., 7:18:03 UTC+2 пользователь Olivier Lamy 
>>> написал:
>>>
 Hi
 I found a bit of time to finsih the changes to add http2 capability for 
 Jenkins via Jetty.
 So it's 3 prs to review:
 * winstone: https://github.com/jenkinsci/winstone/pull/39
 * extras-executable-war: 
 https://github.com/jenkinsci/extras-executable-war/pull/11
 * jenkins: https://github.com/jenkinsci/jenkins/pull/2937

 To test this http2 connector you need to start jenkins adding alpn-boot 
 in -Xbootclasspath (alpn is not available in java8 but should be in java9 
 but that's an other story :-) )

 In my case, I run with such command:

 /Library/Java/JavaVirtualMachines/jdk1.8.0_121.jdk/Contents/Home/bin/java 
 -Xbootclasspath/p:/Users/olamy/repository/org/mortbay/jetty/alpn/alpn-boot/
 8.1.11.v20170118/alpn-boot-8.1.11.v20170118.jar -jar 
 target/jenkins.war --http2Port=9090
 Note the option --http2Port (using default home made generated ssl 
 certificate)
 The alpnboot version depends on your jdk version.
 I usually find it looking at the mapping in the jetty pom: 
 https://github.com/eclipse/jetty.project/blob/jetty-9.4.x/pom.xml

 You will have profiles such:
 
   8u121
   
 
   java.version
   1.8.0_121
 
   
   
 8.1.11.v20170118
   
 

 So you have the alpn.version to use.
 Then get it:

 http://repo.maven.apache.org/maven2/org/mortbay/jetty/alpn/alpn-boot/8.1.9.v20160720/alpn-boot-8.1.9.v20160720.jar
 or 

 http://repo.maven.apache.org/maven2/org/mortbay/jetty/alpn/alpn-boot/${alpn.version}/alpn-boot-${alpn.version}.jar
 -Xbootclasspath/p:  only need to contain the downloaded jar.

 Cheers
 -- 
 Olivier Lamy
 http://twitter.com/olamy | http://linkedin.com/in/olamy

>>> -- 
>>> You received this message because you are subscribed to the Google 
>>> Groups "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send 
>>> an email to jenkinsci-de...@googlegroups.com .
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/jenkinsci-dev/9d92fdca-7b07-4b41-83d7-23e187f04be9%40googlegroups.com
>>>  
>>> 
>>> .
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>> -- 
>>> Olivier Lamy
>>> http://twitter.com/olamy | http://linkedin.com/in/olamy
>>>
>>> -- 
>>> 
>>> Olivier Lamy
>>> http://twitter.com/olamy | 
>>> http://linkedin.com/in/olamy
>>>
>>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/8a4b2845-2e45-409b-bfa7-d727ccb30041%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Blue Ocean] 【Help】Unknown java.lang.RuntimeException: java.lang.ClassNotFoundException

2017-07-24 Thread Oleg Nenashev
Hi,

Likely you have a binary conflict between the Jenkins/BO library dependency 
and the client introduced in your plugin. You would have to shade the 
library in your plugin or to align the version with the Jenkins dependency.

Hopefully it helps,


пятница, 21 июля 2017 г., 18:53:58 UTC+3 пользователь CrazyPotato написал:
>
> Hi!
>
>  I am developing a plugin for jenkins/blue ocean  base on jenkinsci 
> /blueocean-plugin 
> .  I introduce the 
>  dependency  gmessner/*gitlab4j*-api 
>  which contain 
> org.glassfish.jersey.core:jersey-client:jar:2.25.1. 
> When I debug my code , the following code throw an exception:
>
> GitLabApi gitLabApi = new GitLabApi(GitLabApi.ApiVersion.V3, url, 
>>> accessToken);
>>
>> try{
>>
>> gitLabApi.getGroupApi().getGroups();
>>
>> .
>>
>> }
>>
>>
>  The attached stack trace :
>
> org.gitlab4j.api.GitLabApiException: java.lang.ClassNotFoundException: 
> org.glassfish.jersey.client.JerseyClientBuilder
> at org.gitlab4j.api.AbstractApi.handle(AbstractApi.java:304)
> at org.gitlab4j.api.AbstractApi.get(AbstractApi.java:63)
> at org.gitlab4j.api.GroupApi.getGroups(GroupApi.java:33)
> at 
> io.jenkins.blueocean.GitlabEnterpriseScm.validateAccessToken(GitlabEnterpriseScm.java:186)
> at 
> io.jenkins.blueocean.GitlabEnterpriseScm.validateAndCreate(GitlabEnterpriseScm.java:136)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at 
> org.kohsuke.stapler.Function$InstanceFunction.invoke(Function.java:324)
> at org.kohsuke.stapler.Function.bindAndInvoke(Function.java:167)
> at 
> org.kohsuke.stapler.SelectionInterceptedFunction$Adapter.invoke(SelectionInterceptedFunction.java:36)
> at 
> org.kohsuke.stapler.verb.HttpVerbInterceptor.invoke(HttpVerbInterceptor.java:48)
> at 
> org.kohsuke.stapler.SelectionInterceptedFunction.bindAndInvoke(SelectionInterceptedFunction.java:26)
> at 
> org.kohsuke.stapler.Function.bindAndInvokeAndServeResponse(Function.java:100)
> at org.kohsuke.stapler.MetaClass$1.doDispatch(MetaClass.java:124)
> at 
> org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:58)
> at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:746)
> at org.kohsuke.stapler.Stapler.invoke(Stapler.java:876)
> at org.kohsuke.stapler.MetaClass$11.dispatch(MetaClass.java:380)
> at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:746)
> at org.kohsuke.stapler.Stapler.invoke(Stapler.java:876)
> at org.kohsuke.stapler.MetaClass$11.dispatch(MetaClass.java:380)
> at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:746)
> at org.kohsuke.stapler.Stapler.invoke(Stapler.java:876)
> at org.kohsuke.stapler.MetaClass$11.dispatch(MetaClass.java:380)
> at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:746)
> at org.kohsuke.stapler.Stapler.invoke(Stapler.java:876)
> at org.kohsuke.stapler.MetaClass$11.dispatch(MetaClass.java:380)
> at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:746)
> at org.kohsuke.stapler.Stapler.invoke(Stapler.java:876)
> at org.kohsuke.stapler.MetaClass$11.dispatch(MetaClass.java:380)
> at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:746)
> at org.kohsuke.stapler.Stapler.invoke(Stapler.java:876)
> at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:686)
> at org.kohsuke.stapler.Stapler.invoke(Stapler.java:876)
> at org.kohsuke.stapler.MetaClass$11.dispatch(MetaClass.java:380)
> at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:746)
> at org.kohsuke.stapler.Stapler.invoke(Stapler.java:876)
> at org.kohsuke.stapler.Stapler.invoke(Stapler.java:649)
> at org.kohsuke.stapler.Stapler.service(Stapler.java:238)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
> at 
> org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:812)
> at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1669)
> at 
> hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:135)
> at 
> org.jenkinsci.plugins.ssegateway.Endpoint$SSEListenChannelFilter.doFilter(Endpoint.java:225)
> at 
> hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:132)
> at 
> io.jenkins.blueocean.auth.jwt.impl.JwtAuthenticationFilter.doFilter(JwtAuthenticationFilter.java:51)
> at 
> hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.j

Re: [Adopt a plugin] - vsphere-cloud

2017-07-24 Thread Oleg Nenashev
Hi all,

Commit access is granted, thanks for your work on this plugin!
Please let me know if you want to change the default assignee in JIRA as 
well.

BR, Oleg


суббота, 22 июля 2017 г., 3:48:23 UTC+3 пользователь Jason Swager написал:
>
> Hello,
>
> I am the current owner of the vsphere-cloud plugin.  And I very much 
> approve and endorse this request; please approve it  My github id is 
> "jswager", my Jenkins ID is "jswager1"
>
> I've been looking for new owners to adopt this plugin due to my own lack 
> of time and resources to dedicate to this project.  Peter and Eric have 
> graciously volunteered to adopt it.
>
> Thank you,
> Jason
>
> On Friday, July 21, 2017 at 8:53:58 AM UTC-7, Peter Darton wrote:
>>
>> Hi folks,
>>
>> The vsphere-cloud plugin has a number of outstanding PRs, some of them 
>> from early this year.
>> The only plugin owner with commit access (Jason) no longer has the 
>> time/resources to continue working on the plugin (or access to the 
>> resources required to test it) and is on record saying that he would like 
>> someone else to take over (
>> https://groups.google.com/d/msg/jenkinsci-dev/gowLQQXBUec/CgGZ-hQvBQAJ).
>> I was discussing a takeover with the other plugin maintainer (Eric, who 
>> does not have commit access at present) when Jason said he was trying to 
>> hand over commit-access to us (
>> https://github.com/jenkinsci/vsphere-cloud-plugin/pull/76#issuecomment-313497218)
>>  
>> ... but as there's no sign of further activity on that front it would 
>> appear that this process has stalled.
>> I would like to get that process (re?)started so we can get this sorted.
>>
>> I understand (from https://wiki.jenkins.io/display/JENKINS/Adopt+a+Plugin) 
>> that you need github and jenkins-infrastructure IDs to grant people commit 
>> access...
>>  - My github ID is "pjdarton", and my Jenkins-infrastructure ID is also 
>> "pjdarton".
>>  - Eric's github ID is "elordahl" and I believe that his 
>> Jenkins-infrastructure ID is the same (
>> https://issues.jenkins-ci.org/secure/ViewProfile.jspa?name=elordahl).
>>
>> Please can you grant us both commit-access to the vsphere-cloud plugin?
>>
>> We could then work on clearing the backlog of PRs...
>>
>> Regards,
>>
>>   Peter
>>
>>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/689dae3e-791d-4a4a-a7df-2961b8d7f180%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Request to join the Jenkins Security Team

2017-07-24 Thread Oleg Nenashev
Hi Bruno,

Generally I am +1 with this request. Having more people is definitely 
useful.

OTOH you probably do not need to be a member of the Security team if you 
*just* want to fix Scriptler. It's vulnerabilities are publicly listed in 
this advisory: https://jenkins.io/security/advisory/2017-04-10/ . Regarding 
plugins maintained by active contributors, we usually assign security 
issues to them. In all other cases like core fixes, yes it makes sense to 
join the security team. 

Best regards,
Oleg

суббота, 22 июля 2017 г., 12:38:12 UTC+3 пользователь kinow написал:
>
> Hi,
>
> I would like to request to be added to the Jenkins Security Team. My main 
> interest is in helping to fix issues in any dependency of the plug-ins I 
> maintain, as well as in the core. Right now Scriptler is a plug-in I would 
> like to try and see if I could help, as it is blocking 
> active-choices-plugin.
>
> GitHub with 2FA enabled: kinow
> CLA: https://github.com/jenkinsci/infra-cla/pull/48
> FreeNode user: kinow
>
> Thank you
> Bruno
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/20d20e3c-a222-4d53-8309-3dd6daee74a0%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[Adopt a plugin] S3Plugin

2017-07-24 Thread Gergely Brautigam
Hi Folks. 

So, first things first. I don't have an account on Jenkins JIRA yet. I'm 
going to create one if adopting the plugin is feasible.

I have 13+ years of Java experience, HOWEVER, 0.1 years of experience 
writing / building Jenkins Plugins. :)

Thus, might I take over the plugin? It needs some serious love and 
attention and merging of PRs and addressing of Issues a lot. :)

Cheers,
Gergely.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/2b2a8bdf-ba82-4536-8954-7d7b9ed4020e%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.