Re: Bitbucket Branch Source Plugin Maintainer

2018-09-04 Thread Baptiste Mathus 
Commit access is still only granted by the bot. As Michael said.

As Antonio approved it, I just granted casz commit access to the plugin. As
usual, the invitation must be accepted first so it takes effect.

[23:16] <+ batmat> | jenkins-admin: hello old friend
[23:16] <@jenkins-adm> | Hello batmat!
[23:17] <+ batmat> | jenkins-admin: make casz committer on
bitbucket-branch-source-plugin
[23:17] <@jenkins-adm> | Added casz as a GitHub committer for repository
bitbucket-branch-source-plugin
[23:17] <+ batmat> | jenkins-admin


Filing a PR as described by Antonio is going to be needed to if Joseph
wants to be able to also release.

Le lun. 3 sept. 2018 à 12:05, Antonio Muñiz  a écrit :

> Sure! You are "casz" on GitHub, right? Thanks for all your contributions!
>
> Send a PR to
> https://github.com/jenkins-infra/repository-permissions-updater/blob/master/permissions/plugin-cloudbees-bitbucket-branch-source.yml
> to include yourself in the committers list. It needs approvals by 2
> maintainers (I think). You have mine already :)
>
> On Mon, 3 Sep 2018 at 02:10, Michael Neale  wrote:
>
>> I think we can still grant committer access via the irc bot (but will
>> need to be added to permissions repo) - Antonio that makes sense? Interest
>> is increasing in this plugin.
>>
>> On Saturday, September 1, 2018 at 6:43:21 AM UTC+10, Joseph P wrote:
>>>
>>> I am pretty familiar with the code base, contributed and reviewed a lot
>>> of the PRs, so if your up for it wouldn't mind being the second maintainer.
>>> Also maintainer on the bitbucket webhook plugin for non native webhook
>>> bitbucket.
>>>
>>> 💪
>>>
>>> torsdag den 30. august 2018 kl. 09.47.21 UTC+2 skrev Antonio Muñiz:

 BTW, I'm one of the maintainers, but I'd like to get at least one more
 review from another maintainer.

 On Thu, 30 Aug 2018 at 09:18, Antonio Muñiz 
 wrote:

> Review done.
>
> On Wed, 29 Aug 2018 at 04:05, Richard Bywater 
> wrote:
>
>> Hi
>>
>> Just wanted to put out a call to see who identifies with being the
>> maintainer for the Bitbucket Branch Source Plugin at the moment.
>>
>> Reason I ask is that there's a few PRs building up at the moment and
>> one of them (
>> https://github.com/jenkinsci/bitbucket-branch-source-plugin/pull/115 )
>> would be of great use for those of us who use a different URL for HTTP &
>> SSH.
>>
>> Thanks in advance :)
>> Richard.
>>
>> --
>> You received this message because you are subscribed to the Google
>> Groups "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it,
>> send an email to jenkinsci-de...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/CAMui946PmsQ-M%2B%3DV2vOcAvwdqz5D%2BP0AVv4_CuVKxuvPH5Hr-g%40mail.gmail.com
>> 
>> .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
> --
> Antonio Muñiz
> Software Engineer
> CloudBees, Inc.
>


 --
 Antonio Muñiz
 Software Engineer
 CloudBees, Inc.

>>> --
>> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/325c63bb-9db0-4c20-9563-9966649513e3%40googlegroups.com
>> 
>> .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
> --
> Antonio Muñiz
> Software Engineer
> CloudBees, Inc.
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAJc7kzQiM-2T-5KbnP%2BGqX9NuO1FTO%2Bd-fEg5gYM_vLM6Aa6TA%40mail.gmail.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS

Re: Adopt a plugin

2018-09-04 Thread Baptiste Mathus 
> have reached out to Lars Sjostrom

Any evidence for this somewhere? This element can obviously reduce the
timeout period
(which BTW out of this context as it stands would not have *really* started
yet as the current maintainer(s) is not in CC).

Le sam. 1 sept. 2018 à 02:46, Marky Jackson  a
écrit :

> The following plugin is up for adoption. I would like to maintain this
> plugin and have reached out to Lars Sjostrom
> https://plugins.jenkins.io/prometheus
>
>
> GitHub user: markyjackson-taulia
> Jenkins Infra username: jequals5
>
>
> Should I file a pull request in repository-permissions-updater right away
> or wait for the two weeks grace period to end?
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/945F7363-722F-4709-AD75-BBCFF00506AF%40gmail.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS56hxiQy-Cvs8njnbzZo3eP6Hzgn%3DgEa41OGnNVJVwgBw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: Looking to be added as a maintainer for pam-auth-plugin

2018-09-04 Thread Matt Sicker 
I thought we handled this on IRC already? GitHub is jvz. JIRA is also jvz
from what I remember (JIRA looks like it's down at the moment).

On Mon, Sep 3, 2018 at 6:52 AM Oleg Nenashev  wrote:

> Hi Stephen, thanks for the response.
> I am ready to transfer the permissions. @Matt, I need you JIRA and Github
> ID to do the transfer.
>
> BR, Oleg
>
> On Monday, September 3, 2018 at 11:35:24 AM UTC+2, Stephen Connolly wrote:
>>
>> I have no recollection of ever being a maintainer of that plugin
>>
>> On Fri, 17 Aug 2018 at 15:51, Matt Sicker  wrote:
>>
>>> CCing Jesse and Stephen who seem to be the two most active maintainers
>>> historically for this plugin.
>>>
>>> On Fri, Aug 17, 2018 at 6:45 AM Oleg Nenashev 
>>> wrote:
>>>
 Please reach out to the maintainer and get his explicit confirmation in
 this thread.
 If you want to request ownership transfer, the process is described
 here:
 https://wiki.jenkins.io/display/JENKINS/Adopt+a+Plugin#AdoptaPlugin-Requestcommitaccess

 BR, Oleg

 On Thursday, August 16, 2018 at 9:22:39 PM UTC+2, Matt Sicker wrote:
>
> I've got an open PR there, and I'd like to be added as a maintainer.
>
> --
> Matt Sicker
> Software Engineer, CloudBees
>
 --
 You received this message because you are subscribed to the Google
 Groups "Jenkins Developers" group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to jenkinsci-de...@googlegroups.com.
 To view this discussion on the web visit
 https://groups.google.com/d/msgid/jenkinsci-dev/66d8deb8-1661-44c9-8efe-c2fdcfbe8cc0%40googlegroups.com
 
 .
 For more options, visit https://groups.google.com/d/optout.

>>>
>>>
>>> --
>>> Matt Sicker
>>> Software Engineer, CloudBees
>>>
>>
>>
>> --
>> *Stephen Connolly*
>> Software Developer & Architect
>> CloudBees, Inc.
>>
>> [image: CloudBees-Logo.png] 
>> E: scon...@cloudbees.com
>> Twitter: @connolly_s 
>>
>> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/dd9d6af3-cb0a-4a19-aa8b-d48323ba83cb%40googlegroups.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>


-- 
Matt Sicker
Software Engineer, CloudBees

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAEot4owXTfqp5OYJ3DYJ9rO-bLJV0Aqv%2BJhrv%3DzPhidxj39N2g%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Developing custom label support on Gerrit trigger plugin

2018-09-04 Thread George Cimpoies 
Hi!

I've began to work on adding custom label support on Gerrit Trigger plugin.
Currently, there are 2 default labels:Code-Review and Verified, which have
hardcoded votes on the 5 distinct build outcomes (successful, failed,
started, unstable and not built)

Those votes on each label are persisted with the help of a databound
setter, like so:

${%Verify}




@DataBoundSetter
public void setGerritBuildStartedVerifiedValue(Integer
gerritBuildStartedVerifiedValue) {
this.gerritBuildStartedVerifiedValue = gerritBuildStartedVerifiedValue;
}

So it's a 1-to-1 relationship between the java field and the actual textbox
in the web UI section.
The persistance is done by reflection, so the
gerritBuildStartedVerifiedValue is matched by
setGerritBuildVerifiedStartedValue automatically.

Now my question:
How do I persist a custom list of labels? Since I don't know how many
labels there are at some point (and what their names will be) I can't work
with databound setters.






${p.verdictValue}





























This is what I currently have in order to display custom labels and their
custom votes, but I don't see how I can persist the custom votes values. On
the UI, it looks like this (currently added only 1 custom label called
Validated) :
[image: image.png]

I already have a data structure containing all the custom labels and their
custom votes on each build outcome available through
*instance.getVerdictCategoriesList()
*but I don't know how I can set those values from the UI.
Any help is much appreciated!

P.S. Keep in mind that there can be an indefinite number of custom labels
that you can add.
-- 
George Cimpoies
R&D • Itiviti
Software Engineer

Mobile: +40 751 048 489
george.cimpo...@ullink.com

1 Victor Deleu Street | Cluj-Napoca, Cluj 400112

-- 



Visit: itiviti.com  / ullink.com 
 »
Read the latest news from Itiviti » 





*The information contained in or 
attached to this email is strictly confidential. If you are not the 
intended recipient, please notify us immediately by telephone and return 
the message to us.*

*
*

*Email communications by definition contain 
personal information. The ITIVITI group of companies (of which ULLINK forms 
part) is subject to European data protection regulations. ULLINK’s Privacy 
Policy is available at www.ullink.com . ULLINK 
expects the recipient of this email to be compliant with ULLINK’s Privacy 
Policy and applicable regulations. Please advise us immediately at 
dataprotect...@ullink.com  if you are not 
compliant with these.*

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CABE7CDe8%2BDT1fiATYep2_xCphqjUkX90Ya_wUJPR-MrMJ3KZ%2BQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: Request access to build-blocker-plugin

2018-09-04 Thread Oleg Nenashev 
Hi Martin,

Thanks for the interest!
Would it be possible to add maintainers to CC? It is required to start the 
response timeout countdown

Thanks in advance,
Oleg


On Tuesday, September 4, 2018 at 4:11:24 AM UTC+2, Martin Reinhardt wrote:
>
> Hi together,
>
> i want to adopt the build-blocker plugin:
>
> GitHub id: hypery2k
> Jenkins Account ID: mreinhardt
>
> See permission pr: 
> https://github.com/jenkins-infra/repository-permissions-updater/pull/832
>
> -- 
> Martin Reinhardt
> Sent with Airmail
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/8d82dfeb-67e0-4e75-be7e-4796ac422edb%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.