Re: Jenkins CI Windows Attempting Failsafe Tests

2019-04-18 Thread Ullrich Hafner
This happens quite often and indicates an infrastructure problem. Normally it 
disappears after a while...

> Am 18.04.2019 um 22:55 schrieb 'Craig Barber' via Jenkins Developers 
> :
> 
> We're running into an issue where the Jenkins CI is trying to run failsafe 
> tests and failing: 
> https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fgoogle-kubernetes-engine-plugin/detail/PR-50/1/pipeline
>  
> 
> 
> Anyone have an idea what might be causing this?
> 
> -- 
> Craig Barber
> Software Engineer
> Cloud Graphite: Platforms
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CANO%2BKbVd%2By2bxDnc%2BC0pg7SpN0UKSgoziL_gbkuFG8Tx93QziA%40mail.gmail.com
>  
> .
> For more options, visit https://groups.google.com/d/optout 
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/8976F6A4-01CA-41EA-B012-DBDCB76C4ED9%40gmail.com.
For more options, visit https://groups.google.com/d/optout.


Jenkins CI Windows Attempting Failsafe Tests

2019-04-18 Thread 'Craig Barber' via Jenkins Developers
We're running into an issue where the Jenkins CI is trying to run failsafe
tests and failing:
https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fgoogle-kubernetes-engine-plugin/detail/PR-50/1/pipeline

Anyone have an idea what might be causing this?

-- 
Craig Barber
Software Engineer
Cloud Graphite: Platforms

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANO%2BKbVd%2By2bxDnc%2BC0pg7SpN0UKSgoziL_gbkuFG8Tx93QziA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: Plugin idea: publish the analysis result (reading from the jxlint xml format)

2019-04-18 Thread Ullrich Hafner

> Am 18.04.2019 um 08:41 schrieb Jérémie Bresson :
> 
> I know this thread is old, but I took time to work again on this idea.
> 
> Since then, the code was reorganized into: 
> * Jenkins' warnings next generation plug-in 
> .
> * Analysis Parsers Library .
> 
> I would like to collect feedback on the format that could be used, I have 
> opened JENKINS-57098 to discuss this. 
> https://issues.jenkins-ci.org/browse/JENKINS-57098 
> 
> 
> In particular, in the asciidoctor case, I am facing the fact that the 
> log-appender that I can create is not notified when the analysis is 
> terminated.
> This means that working with a file format where I can just append a new 
> record is easier... This is why I have switched from XML (where a root 
> container is required) to a file containing a list of JSON structures on each 
> line (à la logstash).
> 
> I would appreciate feedback…

I’ll comment in Jira…  

> 
> Le samedi 19 août 2017 11:02:14 UTC+2, Jérémie Bresson a écrit :
> Thank you a lot for this pointer.
> 
> I know about the Warnings Plugin, but I was thinking that it parses Log Files 
> (console or a specific configured file), line by line with a regex.
> An XML Report is not a Log file and therefor I was thinking that I could not 
> do it like this.
> 
> I will have a look at the source code.
> 
> 
> Le vendredi 18 août 2017 21:58:12 UTC+2, Ullrich Hafner a écrit :
> You don’t need to create a new plugin. What you need is an XML parser for the 
> warnings plugin (which uses analysis-core). In [1] you find some hints on how 
> to create your own parser. You can also look at some other XML parsers in the 
> parsers package to see what actually needs to be done.
> 
> If your parser is ready, you can file a PR for this plugin in order to get 
> the parser included for the next release. 
> 
> [1] https://wiki.jenkins.io/display/JENKINS/Warnings+Plugin 
> 
> 
> 
>> Am 18.08.2017 um 05:56 schrieb Jérémie Bresson >:
>> 
>> Dear Jenkins Developers,
>> 
>>  
>> In the “Before starting a new plugin” section of the documentation, you 
>> mention that we should contact you.
>> 
>>  
>> JXLint is a framework to create static analysis tool (linter) in java. See 
>> http://selesse.com/jxlint/ 
>> I am working on a tool based on this framework.
>> 
>> There is the possibility to obtain an HTML report or to get an XML report 
>> that looks like this:
>> 
>>  
>> 
>> 
>> 
>> 
>> > 
>> name="Lines should not be longer than 80 characters"
>> 
>> severity="Warning"
>> 
>> message="Line 2 is too long (length: 105)"
>> 
>> category="Format"
>> 
>> summary="The line length should be less than or equal to 80."
>> 
>> explanation="In a text file (ending with `.txt`) the line should not 
>> be longer than 80 characters..."
>> 
>> location="***/example-project-txt/src/file.txt"
>> 
>> lineNumber="2"
>> 
>> />
>> 
>> > 
>> name="Multiple new lines at the end of the document"
>> 
>> severity="Warning"
>> 
>> message="Line 9 is one of the multiple empty new lines at the end of 
>> the document. This is not allowed"
>> 
>> category="Format"
>> 
>> summary="Text document should end with zero or one new line. 
>> Additional new lines should be removed."
>> 
>> explanation="In a text file (ending with `.txt`) there should be no 
>> multiple new line at the end of the document..."
>> 
>> location="***/example-project-txt/src/file.txt"
>> 
>> lineNumber="9"
>> 
>> />
>> 
>> 
>> 
>>  
>> I would like to be able to see the results directly in Jenkins. There is 
>> already great support with the analysis-core functionality. I somehow need 
>> to bridge both frameworks together. This would be a new 
>> "jxlint-analysis-plugin" project (similar to "android-lint-plugin" for 
>> example https://wiki.jenkins.io/display/JENKINS/Android+Lint+Plugin 
>>  ).
>> 
>>  
>> Features are straight forward:
>> 
>> This add a new post-processing build step
>> One input (configuration in the Job) to indicates where the xml Files are 
>> located.
>> During the build the files are parsed and transformed to the structure that 
>> Jenkins needs to produce its report.
>> Thank you in advance for your feedback,
>> 
>>  
>> Cheers,
>> 
>> Jérémie
>> 
>> 
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-de...@googlegroups.com <>.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/82dedac3-1a57-4dca-b8fa-ba4c2e2950f6%40googlegroups.com

Re: Migrate a token stored in plain text to one that uses Secret

2019-04-18 Thread Mez Pahlan
> The plain text tokens are already potentially compromised and need to
> be regenerated and stored encrypted anyways. This is specific to each
> plugin on how to go about regenerating keys and whatnot.
>

Yes, when you put it like that it makes more sense not to worry about
migration.

Thank you all again.

>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAD7v5GuTwZWcUebtpbAjuz4wm3Gm8GcjGNvx%3Dhcae-r8wXMnug%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: Migrate a token stored in plain text to one that uses Secret

2019-04-18 Thread Matt Sicker
On Thu, Apr 18, 2019 at 8:57 AM Mez Pahlan  wrote:
> I could ignore it, for sure. But that was the reason I received a security 
> bug that I'm looking to fix. That the tokens in my plugin were being stored 
> in plain text. If I leave them in plain text what am I actually fixing? I'm 
> fixing forward for new configurations but for existing configurations I'd 
> like to do something.

The plain text tokens are already potentially compromised and need to
be regenerated and stored encrypted anyways. This is specific to each
plugin on how to go about regenerating keys and whatnot.


-- 
Matt Sicker
Senior Software Engineer, CloudBees

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAEot4oypMhap7dxMyyrePWWcH_6G5pvY4j0NL3G4vz74eZNzWg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: Migrate a token stored in plain text to one that uses Secret

2019-04-18 Thread Daniel Beck



> On 18. Apr 2019, at 15:50, Jesse Glick  wrote:
> 
> On Thu, Apr 18, 2019 at 2:53 AM Mez Pahlan  wrote:
>> What's the best way to migrate those over without asking the user to go into 
>> each of their jobs updating it?
> 
> There is not any good way that I know of. I would just ignore it.

This.

As a courtesy you can provide a script to run in the script console that just 
saves every job again, but otherwise ignore it except perhaps documenting this.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/16C3A0BE-B192-40BE-A1C3-160C8E9C1659%40beckweb.net.
For more options, visit https://groups.google.com/d/optout.


Re: Migrate a token stored in plain text to one that uses Secret

2019-04-18 Thread Mez Pahlan
>
> There is not any good way that I know of. I would just ignore it.
>

I could ignore it, for sure. But that was the reason I received a security
bug that I'm looking to fix. That the tokens in my plugin were being stored
in plain text. If I leave them in plain text what am I actually fixing? I'm
fixing forward for new configurations but for existing configurations I'd
like to do something.

Anyways, thanks for the suggestions so far.

>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAD7v5Guy7%3DtvcvgGJkhO_D-YELLdC7cLt4JqkKkPWdxAwbGLbQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: Migrate a token stored in plain text to one that uses Secret

2019-04-18 Thread Jesse Glick
On Thu, Apr 18, 2019 at 2:53 AM Mez Pahlan  wrote:
> What's the best way to migrate those over without asking the user to go into 
> each of their jobs updating it?

There is not any good way that I know of. I would just ignore it.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3YY0m23WbZz7t1Dfn3e9xjFeUdtMJnQwNF5bjhEexEKA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: Any idea what could cause Jenkins console output to be mixed like this in a pipeline job?

2019-04-18 Thread Jesse Glick
On Wed, Apr 17, 2019 at 3:53 PM Martin Weber  wrote:
> Could this cause JENKINS-55215?

Unlikely. That is just using the normal
`ProcStarter.stdout(TaskListener)` which should not need any special
`flush` call, either before or after

https://github.com/jenkinsci/jenkins/pull/3961

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr1r0Pa8PSaZ9rEZEvQFWfmDZJVG%3DqQ4qkwSGLiXc5x3Ng%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: Migrate a token stored in plain text to one that uses Secret

2019-04-18 Thread Robert Sandell
Maybe you can try and report the job to the old data monitor somehow?
That way an admin can batch save the affected jobs, I think :)

/B

Den tors 18 apr. 2019 kl 12:44 skrev Slide :

> Did you mark the old field as transient in your code? If you mark it as
> transient and have a readResolve, it shouldn't get resaved once the upgrade
> happens.
>
> On Wed, Apr 17, 2019 at 11:53 PM Mez Pahlan  wrote:
>
>> Morning
>>
>> I'm trying to migrate a plugin that used to use plain text for handling
>> tokens to one that uses Secret. I am following
>> https://wiki.jenkins.io/display/JENKINS/Hint+on+retaining+backward+compatibility
>>  and
>> have converted all my field types to Secret from String for the token in
>> question.
>>
>> This all works fine when I run the plugin (I think the readResolve method
>> is doing some magic at runtime) and if I create a new job configuration (I
>> can see an encrypted form of my entered token in the config.xml file).
>> However for existing jobs that already that an unencrypted plain text token
>> in the config.xml it remains that way and appears never to get resaved in
>> the encrypted form. So whilst the plugin uses Secrets, there is still old
>> data that is persisted in plain text form.
>>
>> What's the best way to migrate those over without asking the user to go
>> into each of their jobs updating it?
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/f532cd94-4af2-4c13-bdb9-7a94e024620d%40googlegroups.com
>> 
>> .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
> --
> Website: http://earl-of-code.com
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAPiUgVfFWwkECj9FSFToVGnATFasOAVr2iBrE%3DiZnFi5YVePgg%40mail.gmail.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>


-- 
*Robert Sandell*
Software Engineer
CloudBees, Inc.
[image: CloudBees-Logo.png] 
E: rsand...@cloudbees.com
Twitter: robert_sandell

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CALzHZS1%3DzFERENWFA7O8MEiY7Y_NZ%3DQMziz5FriyUY4aC8g48g%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: Migrate a token stored in plain text to one that uses Secret

2019-04-18 Thread Slide
Did you mark the old field as transient in your code? If you mark it as
transient and have a readResolve, it shouldn't get resaved once the upgrade
happens.

On Wed, Apr 17, 2019 at 11:53 PM Mez Pahlan  wrote:

> Morning
>
> I'm trying to migrate a plugin that used to use plain text for handling
> tokens to one that uses Secret. I am following
> https://wiki.jenkins.io/display/JENKINS/Hint+on+retaining+backward+compatibility
>  and
> have converted all my field types to Secret from String for the token in
> question.
>
> This all works fine when I run the plugin (I think the readResolve method
> is doing some magic at runtime) and if I create a new job configuration (I
> can see an encrypted form of my entered token in the config.xml file).
> However for existing jobs that already that an unencrypted plain text token
> in the config.xml it remains that way and appears never to get resaved in
> the encrypted form. So whilst the plugin uses Secrets, there is still old
> data that is persisted in plain text form.
>
> What's the best way to migrate those over without asking the user to go
> into each of their jobs updating it?
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/f532cd94-4af2-4c13-bdb9-7a94e024620d%40googlegroups.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>


-- 
Website: http://earl-of-code.com

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAPiUgVfFWwkECj9FSFToVGnATFasOAVr2iBrE%3DiZnFi5YVePgg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.