Re: Enabling ImgBot in jenkinsci and in jenkins-infra/jenkins.io?

[Oleg Nenashev]

Thanks all, I have enabled it in the org. Feel free to add it to your 
repositories which have images.
First pull request: 
https://github.com/jenkinsci/role-strategy-plugin/pull/108


On Tuesday, October 8, 2019 at 12:45:52 AM UTC+2, Oleg Nenashev wrote:
>
> Yes, it is only about the served/packaged size. There is no practical way 
> to change the repo size, and optimizing images will actually increase that 
> slightly.
> But it is important to have content size optimized to improve loading 
> times over network and to reduce package sizes
>
> P.S: Don't forget to test it on the Chuck Norris plugin!
>
> On Monday, October 7, 2019 at 5:37:12 PM UTC+2, Liam Newman wrote:
>>
>> It's not about size in the repo but size being served.  +1. 
>>
>> On Mon, Oct 7, 2019 at 8:25 AM Baptiste Mathus  
>> wrote:
>>
>>> I'm a bit unconvinced this really changes the situation given things are 
>>> still versioned and kept in the repo history, but still +1 why not! :)
>>>
>>> Le lun. 7 oct. 2019 à 10:09, Oleg Nenashev  a 
>>> écrit :
>>>
 Hi all,

 I would like to enable ImgBot in 
 some of my plugins in order to optimize image sizes. ImgBot is a bot which 
 creates pull requests with image optimizations, e.g. here is a sample pull 
 requests for the Jenkins Core: 
 https://github.com/oleg-nenashev/jenkins/pull/38. There are a lot of 
 historical images in Jenkins, and it could be a good opportunity to 
 optimize them. 

 There is a free open-source plan for ImgBot, so I think enabling the 
 bot should not be a problem. As for other bots, I suggest we enable it in 
 the org but do not enable it widely by default. Each plugin maintainer 
 will 
 be able to enable it on his/her own.

 What do you think?

 Thanks in advance,
 Oleg

 -- 
 You received this message because you are subscribed to the Google 
 Groups "Jenkins Developers" group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to jenkin...@googlegroups.com.
 To view this discussion on the web visit 
 https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLDM57J9zbP-MKrvQ64R%3Dm5xKLu%2BY235WM41NUYkr6EEQw%40mail.gmail.com
  
 
 .

>>> -- 
>>> You received this message because you are subscribed to the Google 
>>> Groups "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send 
>>> an email to jenkin...@googlegroups.com.
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/jenkinsci-dev/CAPyTVp3wet6VecECQqZDLAiTOHERfuPXsZ%2BhpNDLefDxS8tr6w%40mail.gmail.com
>>>  
>>> 
>>> .
>>>
>>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/c3b28a11-7c25-4e90-a71e-2ed0c80388eb%40googlegroups.com.

Re: Proposal teams: GitHub teams for active contributors without write permissions

[Oleg Nenashev]

Thanks all for the feedback! I went ahead and implemented it inside the 
jenkinsci GitHub org.
Please feel free to nominate members if you see that any active contributor 
is missing

On Monday, October 7, 2019 at 9:22:30 PM UTC+2, Oleg Nenashev wrote:
>
> No other real benefits unfortunately. It would be great to send some swag 
> in parallel, but we do not have any confirmed policy for it. Maybe we could 
> discuss it later once the board/officer elections are over
>
> On Mon, Oct 7, 2019, 20:35 Tim Jacomb  wrote:
>
>> What benefit does the team have? Over just adding the person to the org
>>
>> On Sun, 6 Oct 2019 at 01:12, Oleg Nenashev  
>> wrote:
>>
>>> Hi all,
>>>
>>> I would like to sign-off creating GitHub teams for active contributors 
>>> who do not have write access to repositories in jenkinsci and jenkins-infra 
>>> organizations.
>>>
>>> *Why?* We have many contributors who help the Jenkins project a lot but 
>>> not listed as organization members on GitHub... just because they do not 
>>> need any special permissions for their work. For example, René Scheibe 
>>>  and Zbynek Konecny 
>>>  contributed dozens of pull requests to 
>>> improve documentation and code across multiple components... but they are 
>>> not members of jenkinsci. Adding such contributors to the organization is 
>>> IMHO a way to recognize their contributions, and it allows contributors to 
>>> put the Jenkins org badge to their GitHub profiles. It would also allow to 
>>> request their reviews in the components if needed.
>>>
>>> *What do I propose?*
>>>
>>>- Private "contributors" teams are created in jenkinsci and 
>>>jenkins-infra. Teams are private so that they cannot be mentioned 
>>>unintentionally. Teams have no specific access to the repositories
>>>- External contributors can be added to the organization if they 
>>>remain active in the community for 1 month or above and create 5+ pull 
>>>requests (feel free to propose different numbers, I am just trying to 
>>> set 
>>>some criteria)
>>>- Jenkins GitHub admins can add people to the teams upon request
>>>- ChatOps bot command may be implemented later to enable other 
>>>maintainers to add contributors
>>>
>>>  What do you think?
>>>
>>> Thanks in advance,
>>> Oleg
>>>
>>> -- 
>>> You received this message because you are subscribed to the Google 
>>> Groups "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send 
>>> an email to jenkinsci-dev+unsubscr...@googlegroups.com.
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLDPu77BovhUiGamx1t5FewLgq-Xu0hcQwjBk07D39Z99w%40mail.gmail.com
>>>  
>>> 
>>> .
>>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Advocacy and Outreach SIG" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkins-advocacy-and-outreach-sig+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkins-advocacy-and-outreach-sig/CAH-3BidgBQ8F8CeJCj-ZLB2K6Q-Syp90pb4ubSBp%2BtD%3DCL7MZQ%40mail.gmail.com
>>  
>> 
>> .
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/e87017c3-fe99-40ff-a09b-4cf27562a3d0%40googlegroups.com.

Re: Enabling ImgBot in jenkinsci and in jenkins-infra/jenkins.io?

[Oleg Nenashev]

Yes, it is only about the served/packaged size. There is no practical way 
to change the repo size, and optimizing images will actually increase that 
slightly.
But it is important to have content size optimized to improve loading times 
over network and to reduce package sizes

P.S: Don't forget to test it on the Chuck Norris plugin!

On Monday, October 7, 2019 at 5:37:12 PM UTC+2, Liam Newman wrote:
>
> It's not about size in the repo but size being served.  +1. 
>
> On Mon, Oct 7, 2019 at 8:25 AM Baptiste Mathus  > wrote:
>
>> I'm a bit unconvinced this really changes the situation given things are 
>> still versioned and kept in the repo history, but still +1 why not! :)
>>
>> Le lun. 7 oct. 2019 à 10:09, Oleg Nenashev > > a écrit :
>>
>>> Hi all,
>>>
>>> I would like to enable ImgBot in 
>>> some of my plugins in order to optimize image sizes. ImgBot is a bot which 
>>> creates pull requests with image optimizations, e.g. here is a sample pull 
>>> requests for the Jenkins Core: 
>>> https://github.com/oleg-nenashev/jenkins/pull/38. There are a lot of 
>>> historical images in Jenkins, and it could be a good opportunity to 
>>> optimize them. 
>>>
>>> There is a free open-source plan for ImgBot, so I think enabling the bot 
>>> should not be a problem. As for other bots, I suggest we enable it in the 
>>> org but do not enable it widely by default. Each plugin maintainer will be 
>>> able to enable it on his/her own.
>>>
>>> What do you think?
>>>
>>> Thanks in advance,
>>> Oleg
>>>
>>> -- 
>>> You received this message because you are subscribed to the Google 
>>> Groups "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send 
>>> an email to jenkin...@googlegroups.com .
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLDM57J9zbP-MKrvQ64R%3Dm5xKLu%2BY235WM41NUYkr6EEQw%40mail.gmail.com
>>>  
>>> 
>>> .
>>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkin...@googlegroups.com .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/CAPyTVp3wet6VecECQqZDLAiTOHERfuPXsZ%2BhpNDLefDxS8tr6w%40mail.gmail.com
>>  
>> 
>> .
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/c910f335-5f7a-43b2-abcb-94786363657c%40googlegroups.com.

Re: Proposal teams: GitHub teams for active contributors without write permissions

[Oleg Nenashev]

No other real benefits unfortunately. It would be great to send some swag
in parallel, but we do not have any confirmed policy for it. Maybe we could
discuss it later once the board/officer elections are over

On Mon, Oct 7, 2019, 20:35 Tim Jacomb  wrote:

> What benefit does the team have? Over just adding the person to the org
>
> On Sun, 6 Oct 2019 at 01:12, Oleg Nenashev  wrote:
>
>> Hi all,
>>
>> I would like to sign-off creating GitHub teams for active contributors
>> who do not have write access to repositories in jenkinsci and jenkins-infra
>> organizations.
>>
>> *Why?* We have many contributors who help the Jenkins project a lot but
>> not listed as organization members on GitHub... just because they do not
>> need any special permissions for their work. For example, René Scheibe
>>  and Zbynek Konecny
>>  contributed dozens of pull requests to
>> improve documentation and code across multiple components... but they are
>> not members of jenkinsci. Adding such contributors to the organization is
>> IMHO a way to recognize their contributions, and it allows contributors to
>> put the Jenkins org badge to their GitHub profiles. It would also allow to
>> request their reviews in the components if needed.
>>
>> *What do I propose?*
>>
>>- Private "contributors" teams are created in jenkinsci and
>>jenkins-infra. Teams are private so that they cannot be mentioned
>>unintentionally. Teams have no specific access to the repositories
>>- External contributors can be added to the organization if they
>>remain active in the community for 1 month or above and create 5+ pull
>>requests (feel free to propose different numbers, I am just trying to set
>>some criteria)
>>- Jenkins GitHub admins can add people to the teams upon request
>>- ChatOps bot command may be implemented later to enable other
>>maintainers to add contributors
>>
>>  What do you think?
>>
>> Thanks in advance,
>> Oleg
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLDPu77BovhUiGamx1t5FewLgq-Xu0hcQwjBk07D39Z99w%40mail.gmail.com
>> 
>> .
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Advocacy and Outreach SIG" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkins-advocacy-and-outreach-sig+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkins-advocacy-and-outreach-sig/CAH-3BidgBQ8F8CeJCj-ZLB2K6Q-Syp90pb4ubSBp%2BtD%3DCL7MZQ%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLDfzbVU4Kngj1KYicgzwdw3YEwR1R0RVawEjv9sLfXTtA%40mail.gmail.com.

Re: Proposal teams: GitHub teams for active contributors without write permissions

[Tim Jacomb]

What benefit does the team have? Over just adding the person to the org

On Sun, 6 Oct 2019 at 01:12, Oleg Nenashev  wrote:

> Hi all,
>
> I would like to sign-off creating GitHub teams for active contributors who
> do not have write access to repositories in jenkinsci and jenkins-infra
> organizations.
>
> *Why?* We have many contributors who help the Jenkins project a lot but
> not listed as organization members on GitHub... just because they do not
> need any special permissions for their work. For example, René Scheibe
>  and Zbynek Konecny
>  contributed dozens of pull requests to
> improve documentation and code across multiple components... but they are
> not members of jenkinsci. Adding such contributors to the organization is
> IMHO a way to recognize their contributions, and it allows contributors to
> put the Jenkins org badge to their GitHub profiles. It would also allow to
> request their reviews in the components if needed.
>
> *What do I propose?*
>
>- Private "contributors" teams are created in jenkinsci and
>jenkins-infra. Teams are private so that they cannot be mentioned
>unintentionally. Teams have no specific access to the repositories
>- External contributors can be added to the organization if they
>remain active in the community for 1 month or above and create 5+ pull
>requests (feel free to propose different numbers, I am just trying to set
>some criteria)
>- Jenkins GitHub admins can add people to the teams upon request
>- ChatOps bot command may be implemented later to enable other
>maintainers to add contributors
>
>  What do you think?
>
> Thanks in advance,
> Oleg
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLDPu77BovhUiGamx1t5FewLgq-Xu0hcQwjBk07D39Z99w%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BidgBQ8F8CeJCj-ZLB2K6Q-Syp90pb4ubSBp%2BtD%3DCL7MZQ%40mail.gmail.com.

Re: Plugin for freestyle job and pipeline with environment variables

[Slide]

You access environment variables differently based on the type of job. So,
in the free style Notifier/Recorder/etc you would use
https://javadoc.jenkins-ci.org/hudson/model/Run.html#getEnvironment-hudson.model.TaskListener-.
For pipeline, in your Step implemention, you do what Jesse mentioned:
getContext().get(EnvVars.class).

On Mon, Oct 7, 2019 at 11:09 AM Matthias  wrote:

> I see. But then again I still have the problem with the missing
> environment variables from the groovy script in the builder class or is
> this only an issue for pipelines?
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/8c363905-65c5-4c95-b178-acc30ca736ca%40googlegroups.com
> .
>


-- 
Website: http://earl-of-code.com

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAPiUgVdSJieMzDn%2BGS6LUixFtuKFkfDm_%3DxMy_RxBTJ9q0ci2Q%40mail.gmail.com.

Re: Plugin for freestyle job and pipeline with environment variables

[Matthias]

I see. But then again I still have the problem with the missing environment 
variables from the groovy script in the builder class or is this only an issue 
for pipelines?

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/8c363905-65c5-4c95-b178-acc30ca736ca%40googlegroups.com.

Re: Plugin for freestyle job and pipeline with environment variables

[Slide]

Yes, that is the pipeline step implementation, then
https://github.com/jenkinsci/junit-plugin/blob/master/src/main/java/hudson/tasks/junit/JUnitResultArchiver.java
is
the implementation of the free style step (a Recorder).

On Mon, Oct 7, 2019 at 10:35 AM Matthias  wrote:

> Do you mean
> https://github.com/jenkinsci/junit-plugin/tree/master/src/main/java/hudson/tasks/junit/pipeline
> ?
> I compared it to my implementation and its structure looks similar to what
> I described above.
>
> Am Montag, 7. Oktober 2019 18:57:34 UTC+2 schrieb slide:
>>
>> Do you mean the same class? Having a pipeline step and a
>> Builder/Notifier/etc implemented in the same plugin works just fine. You
>> can look at the JUnit plugin for an example of something that has both a
>> pipeline Step implementation and a Publisher implemented for use in
>> freestyle.
>>
>> On Mon, Oct 7, 2019 at 9:53 AM Matthias  wrote:
>>
>>> Understood.
>>> But is there something where I can go with just one plugin for Freestyle
>>> and Pipeline not having the drawback of the missing environment variables?
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to jenkin...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/jenkinsci-dev/aa8f7fd0-23f5-44a2-aa1d-685015820419%40googlegroups.com
>>> 
>>> .
>>>
>>
>>
>> --
>> Website: http://earl-of-code.com
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/fda513af-0c0e-4979-b1cd-10f39cb29e1a%40googlegroups.com
> 
> .
>


-- 
Website: http://earl-of-code.com

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAPiUgVcnduOBTiZ9gBHXOFAm_XSvu5qB%2BAKK8vSGq9gMyEqvJQ%40mail.gmail.com.

Re: Plugin for freestyle job and pipeline with environment variables

[Matthias]

Do you mean 
https://github.com/jenkinsci/junit-plugin/tree/master/src/main/java/hudson/tasks/junit/pipeline?
I compared it to my implementation and its structure looks similar to what 
I described above.

Am Montag, 7. Oktober 2019 18:57:34 UTC+2 schrieb slide:
>
> Do you mean the same class? Having a pipeline step and a 
> Builder/Notifier/etc implemented in the same plugin works just fine. You 
> can look at the JUnit plugin for an example of something that has both a 
> pipeline Step implementation and a Publisher implemented for use in 
> freestyle.
>
> On Mon, Oct 7, 2019 at 9:53 AM Matthias  > wrote:
>
>> Understood. 
>> But is there something where I can go with just one plugin for Freestyle 
>> and Pipeline not having the drawback of the missing environment variables?
>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkin...@googlegroups.com .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/aa8f7fd0-23f5-44a2-aa1d-685015820419%40googlegroups.com
>>  
>> 
>> .
>>
>
>
> -- 
> Website: http://earl-of-code.com
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/fda513af-0c0e-4979-b1cd-10f39cb29e1a%40googlegroups.com.

Re: Plugin for freestyle job and pipeline with environment variables

[Slide]

Do you mean the same class? Having a pipeline step and a
Builder/Notifier/etc implemented in the same plugin works just fine. You
can look at the JUnit plugin for an example of something that has both a
pipeline Step implementation and a Publisher implemented for use in
freestyle.

On Mon, Oct 7, 2019 at 9:53 AM Matthias  wrote:

> Understood.
> But is there something where I can go with just one plugin for Freestyle
> and Pipeline not having the drawback of the missing environment variables?
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/aa8f7fd0-23f5-44a2-aa1d-685015820419%40googlegroups.com
> 
> .
>


-- 
Website: http://earl-of-code.com

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAPiUgVcpR%3DRNCFGKaWd9_uWUey2t3ScFw4Pi8%2BYUdTqEK1J5wg%40mail.gmail.com.

Re: Plugin for freestyle job and pipeline with environment variables

[Matthias]

Understood. 
But is there something where I can go with just one plugin for Freestyle 
and Pipeline not having the drawback of the missing environment variables?

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/aa8f7fd0-23f5-44a2-aa1d-685015820419%40googlegroups.com.

Re: Proposal teams: GitHub teams for active contributors without write permissions

[Matt Sicker]

I like this idea, too. +1

On Sat, Oct 5, 2019 at 8:10 PM Rick  wrote:

> +1 from me
>
> On Sun, Oct 6, 2019 at 8:18 AM Mark Waite 
> wrote:
>
>> +1 from me.  Thresholds seem reasonable and I really like it as a way to
>> request reviews from them.
>>
>> On Sat, Oct 5, 2019 at 6:14 PM Marky Jackson 
>> wrote:
>>
>>> I am +1 for this
>>>
>>> {
>>> "regards" : {
>>>  "name" : “marky”,
>>>  "phone" : "+1 (408) 464 2965 <+1%20(408)%20464%202965>”,
>>>  "email" : “marky.r.jack...@gmail.com",
>>>  "team" : “jackson5“,
>>>  “role” : “software engineer"
>>>  }
>>>  }
>>>
>>> On Oct 5, 2019, at 5:11 PM, Oleg Nenashev 
>>> wrote:
>>>
>>> 
>>> Hi all,
>>>
>>> I would like to sign-off creating GitHub teams for active contributors
>>> who do not have write access to repositories in jenkinsci and jenkins-infra
>>> organizations.
>>>
>>> *Why?* We have many contributors who help the Jenkins project a lot but
>>> not listed as organization members on GitHub... just because they do not
>>> need any special permissions for their work. For example, René Scheibe
>>>  and Zbynek Konecny
>>>  contributed dozens of pull requests to
>>> improve documentation and code across multiple components... but they are
>>> not members of jenkinsci. Adding such contributors to the organization is
>>> IMHO a way to recognize their contributions, and it allows contributors to
>>> put the Jenkins org badge to their GitHub profiles. It would also allow to
>>> request their reviews in the components if needed.
>>>
>>> *What do I propose?*
>>>
>>>- Private "contributors" teams are created in jenkinsci and
>>>jenkins-infra. Teams are private so that they cannot be mentioned
>>>unintentionally. Teams have no specific access to the repositories
>>>- External contributors can be added to the organization if they
>>>remain active in the community for 1 month or above and create 5+ pull
>>>requests (feel free to propose different numbers, I am just trying to set
>>>some criteria)
>>>- Jenkins GitHub admins can add people to the teams upon request
>>>- ChatOps bot command may be implemented later to enable other
>>>maintainers to add contributors
>>>
>>>  What do you think?
>>>
>>> Thanks in advance,
>>> Oleg
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "Jenkins Advocacy and Outreach SIG" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to
>>> jenkins-advocacy-and-outreach-sig+unsubscr...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/jenkins-advocacy-and-outreach-sig/CAPfivLDPu77BovhUiGamx1t5FewLgq-Xu0hcQwjBk07D39Z99w%40mail.gmail.com
>>> 
>>> .
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "Jenkins Advocacy and Outreach SIG" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to
>>> jenkins-advocacy-and-outreach-sig+unsubscr...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/jenkins-advocacy-and-outreach-sig/9C289DA3-4BB9-447E-8EE1-213D77F61E82%40gmail.com
>>> 
>>> .
>>>
>>
>>
>> --
>> Thanks!
>> Mark Waite
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtHRk-5D2qWx0sPUAn7Z8CO2wkgMZQiJ0V2XmgYzyzGbxg%40mail.gmail.com
>> 
>> .
>>
>
>
> --
> Zhao Xiaojie (Rick)
> Blog: https://github.com/LinuxSuRen
> Twitter: https://twitter.com/suren69811254
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAMM7nTEPCWHyF4324PmjtezZ-JarS2-X32q27OPmnnc8XQ_jQQ%40mail.gmail.com
> 
> .
>


-- 
Matt Sicker
Senior Software Engineer, CloudBees

-- 
You received this 

Re: Enabling ImgBot in jenkinsci and in jenkins-infra/jenkins.io?

[Liam Newman]

It's not about size in the repo but size being served.  +1.

On Mon, Oct 7, 2019 at 8:25 AM Baptiste Mathus 
wrote:

> I'm a bit unconvinced this really changes the situation given things are
> still versioned and kept in the repo history, but still +1 why not! :)
>
> Le lun. 7 oct. 2019 à 10:09, Oleg Nenashev  a
> écrit :
>
>> Hi all,
>>
>> I would like to enable ImgBot in
>> some of my plugins in order to optimize image sizes. ImgBot is a bot which
>> creates pull requests with image optimizations, e.g. here is a sample pull
>> requests for the Jenkins Core:
>> https://github.com/oleg-nenashev/jenkins/pull/38. There are a lot of
>> historical images in Jenkins, and it could be a good opportunity to
>> optimize them.
>>
>> There is a free open-source plan for ImgBot, so I think enabling the bot
>> should not be a problem. As for other bots, I suggest we enable it in the
>> org but do not enable it widely by default. Each plugin maintainer will be
>> able to enable it on his/her own.
>>
>> What do you think?
>>
>> Thanks in advance,
>> Oleg
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLDM57J9zbP-MKrvQ64R%3Dm5xKLu%2BY235WM41NUYkr6EEQw%40mail.gmail.com
>> 
>> .
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAPyTVp3wet6VecECQqZDLAiTOHERfuPXsZ%2BhpNDLefDxS8tr6w%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAA0qCNzD7ooPvwZjher7JpJeN3taAfhg1qkiQXABhWZ0CepGzA%40mail.gmail.com.

Re: GitHub Actions in jenkins-infra

[Olblak]

> So right now Olbak the ACI agents are failing creating large queue.
> 
> ci.jenkins.io must be stable if you want us to continue using it.

What I tried to say in my previous answer was, if the issue is ci.jenkins.io 
then first let try to fix it.
And if there is a another use case then let's discuss it.
Regarding ci.j.io I'll probably start a document to collect feedback in the 
coming days

---
-> gpg --keyserver keys.gnupg.net --recv-key 52210D3D
---




On Fri, Oct 4, 2019, at 9:07 PM, Victor Martinez wrote:
> I do understand the value for using other CI/CD systems. My only concerns are 
> when there are different GitHub checks and some of them are green and some 
> others are red. That particular lack of reliability might imply more steps to 
> troubleshoot to debug logs in different systems. I like the idea of 
> dog-fooding even though when it does imply suffering some issues that other 
> CI/CD systems might not have.
> 
> As a consequence of decoupling this from the ci.jenkins.io then it could be 
> more difficult to solve those issues in the ci.jenkins.io. That's something 
> quite valuable no just for us as users but also for other users of the 
> Jenkins project. 
> 
> I'd be happy to discuss this in another thread, if it has not been discussed 
> recently, provide more feedback and gather other's point of view.
> 
> Cheers
> 
> 
> 
> 

> --
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/097e8aff-f133-4bd8-8ca3-2af74488d047%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/7f636c64-ee22-43e0-b1b8-11e9cd23ff40%40www.fastmail.com.

Re: Enabling ImgBot in jenkinsci and in jenkins-infra/jenkins.io?

[Baptiste Mathus]

I'm a bit unconvinced this really changes the situation given things are
still versioned and kept in the repo history, but still +1 why not! :)

Le lun. 7 oct. 2019 à 10:09, Oleg Nenashev  a
écrit :

> Hi all,
>
> I would like to enable ImgBot in
> some of my plugins in order to optimize image sizes. ImgBot is a bot which
> creates pull requests with image optimizations, e.g. here is a sample pull
> requests for the Jenkins Core:
> https://github.com/oleg-nenashev/jenkins/pull/38. There are a lot of
> historical images in Jenkins, and it could be a good opportunity to
> optimize them.
>
> There is a free open-source plan for ImgBot, so I think enabling the bot
> should not be a problem. As for other bots, I suggest we enable it in the
> org but do not enable it widely by default. Each plugin maintainer will be
> able to enable it on his/her own.
>
> What do you think?
>
> Thanks in advance,
> Oleg
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLDM57J9zbP-MKrvQ64R%3Dm5xKLu%2BY235WM41NUYkr6EEQw%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAPyTVp3wet6VecECQqZDLAiTOHERfuPXsZ%2BhpNDLefDxS8tr6w%40mail.gmail.com.

Re: Plugin for freestyle job and pipeline with environment variables

[Jesse Glick]

On Mon, Oct 7, 2019 at 10:07 AM Matthias  wrote:
> Now, I need to pass credentials via environment variables to the plugin. I 
> found out that this is not possible with SimpleBuildStep (JENKINS-29144).

You mean from an enclosing `withCredentials` step? Indeed that is a
scoped environment variable, rather than build-wide, so not currently
available from this API.

> I found advices to extend Step instead. I finally got it working for the 
> pipeline

Looking up `getContext().get(EnvVars.class)` I guess.

> my problem is now that the plugin is not anymore selectable from the "add 
> build step" dropdown in freestyle jobs. Do I have to use another interface 
> for this?

Yes, `Step` is for Pipeline only. If you want a freestyle-only build
step, use `Builder` or `Publisher` without implementing
`SimpleBuildStep`. Basically `SimpleBuildStep` just offers the
convenience of writing a single extension which can be used for any
kind of project.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr16bXTWAV5Zw-d9oiWQJmym-Of9_boXaYmWa5d9zyK1xQ%40mail.gmail.com.

Plugin for freestyle job and pipeline with environment variables

[Matthias]

Hello

I implemented a plugin that works as a build step for freestyle jobs and as 
a pipeline step in groovy by implementing SimpleBuildStep.
Now, I need to pass credentials via environment variables to the plugin. I 
found out that this is not possible with *SimpleBuildStep *
(https://issues.jenkins-ci.org/browse/JENKINS-29144).

Searching further, I found advices to extend *Step *instead. I finally got 
it working for the pipeline by using the following classes.

public class MyPlugin extends Step implements Serializable {

@Extension
@Symbol("myPlugin")
public static final class DescriptorImpl extends StepDescriptor {

public class MyPluginStepExecution extends 
SynchronousNonBlockingStepExecution {


However, my problem is now that the plugin is not anymore selectable from 
the "add build step" dropdown in freestyle jobs. Do I have to use another 
interface for this?

I tried to use *SimpleBuildWrapper, BuildWrapperDescriptor, and 
StepExecution* but now I only get "java.lang.IllegalStateException: There 
is no body to invoke"

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/64e4f6d7-8bb9-4996-8f86-99df8c8337b0%40googlegroups.com.

Re: Enabling ImgBot in jenkinsci and in jenkins-infra/jenkins.io?

[Marky Jackson]

+1

{ 
"regards" : {
 "name" : “marky”,
 "phone" : "+1 (408) 464 2965”,
 "email" : “marky.r.jack...@gmail.com",
 "team" : “jackson5“,
 “role” : “software engineer"
 }
 }

> On Oct 7, 2019, at 6:06 AM, Rick  wrote:
> 
> 
> +1
> 
>> On Mon, Oct 7, 2019 at 8:17 PM Tim Jacomb  wrote:
>> +1
>> 
>>> On Mon, 7 Oct 2019 at 11:10, Raihaan Shouhell  
>>> wrote:
>>> I think its a good idea  +1
>>> 
 On Monday, 7 October 2019 16:09:29 UTC+8, Oleg Nenashev wrote:
 Hi all,
 
 I would like to enable ImgBot in some of my plugins in order to optimize 
 image sizes. ImgBot is a bot which creates pull requests with image 
 optimizations, e.g. here is a sample pull requests for the Jenkins Core: 
 https://github.com/oleg-nenashev/jenkins/pull/38. There are a lot of 
 historical images in Jenkins, and it could be a good opportunity to 
 optimize them. 
 
 There is a free open-source plan for ImgBot, so I think enabling the bot 
 should not be a problem. As for other bots, I suggest we enable it in the 
 org but do not enable it widely by default. Each plugin maintainer will be 
 able to enable it on his/her own.
 
 What do you think?
 
 Thanks in advance,
 Oleg
 
>>> 
>>> -- 
>>> You received this message because you are subscribed to the Google Groups 
>>> "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an 
>>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/jenkinsci-dev/98b1fe89-d010-40e2-8103-a70d085fcdd0%40googlegroups.com.
>> 
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3Bif8h7iOuAD9tROEJ2apH4ZVSOASHC1mVA5nsT9oY1t%2BVA%40mail.gmail.com.
> 
> 
> -- 
> Zhao Xiaojie (Rick)
> Blog: https://github.com/LinuxSuRen
> Twitter: https://twitter.com/suren69811254
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAMM7nTEGMK%3DGYb6u-19OpZwZBE8se4SoPK%2BrcecN3r4Q8JQ_DA%40mail.gmail.com.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/01AAB4DA-D8E5-444E-BE15-B3BA53458551%40gmail.com.

Re: Enabling ImgBot in jenkinsci and in jenkins-infra/jenkins.io?

[Mark Waite]

+1

On Mon, Oct 7, 2019 at 6:17 AM Tim Jacomb  wrote:

> +1
>
> On Mon, 7 Oct 2019 at 11:10, Raihaan Shouhell 
> wrote:
>
>> I think its a good idea  +1
>>
>> On Monday, 7 October 2019 16:09:29 UTC+8, Oleg Nenashev wrote:
>>>
>>> Hi all,
>>>
>>> I would like to enable ImgBot in
>>> some of my plugins in order to optimize image sizes. ImgBot is a bot which
>>> creates pull requests with image optimizations, e.g. here is a sample pull
>>> requests for the Jenkins Core:
>>> https://github.com/oleg-nenashev/jenkins/pull/38. There are a lot of
>>> historical images in Jenkins, and it could be a good opportunity to
>>> optimize them.
>>>
>>> There is a free open-source plan for ImgBot, so I think enabling the bot
>>> should not be a problem. As for other bots, I suggest we enable it in the
>>> org but do not enable it widely by default. Each plugin maintainer will be
>>> able to enable it on his/her own.
>>>
>>> What do you think?
>>>
>>> Thanks in advance,
>>> Oleg
>>>
>>> --
>> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/98b1fe89-d010-40e2-8103-a70d085fcdd0%40googlegroups.com
>> 
>> .
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3Bif8h7iOuAD9tROEJ2apH4ZVSOASHC1mVA5nsT9oY1t%2BVA%40mail.gmail.com
> 
> .
>


-- 
Thanks!
Mark Waite

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtGMvsaJchQPY6Z3Myx_GyQJETUcmZOhv5tw6pRC8%3DBZew%40mail.gmail.com.

Re: Enabling ImgBot in jenkinsci and in jenkins-infra/jenkins.io?

[Rick]

+1

On Mon, Oct 7, 2019 at 8:17 PM Tim Jacomb  wrote:

> +1
>
> On Mon, 7 Oct 2019 at 11:10, Raihaan Shouhell 
> wrote:
>
>> I think its a good idea  +1
>>
>> On Monday, 7 October 2019 16:09:29 UTC+8, Oleg Nenashev wrote:
>>>
>>> Hi all,
>>>
>>> I would like to enable ImgBot in
>>> some of my plugins in order to optimize image sizes. ImgBot is a bot which
>>> creates pull requests with image optimizations, e.g. here is a sample pull
>>> requests for the Jenkins Core:
>>> https://github.com/oleg-nenashev/jenkins/pull/38. There are a lot of
>>> historical images in Jenkins, and it could be a good opportunity to
>>> optimize them.
>>>
>>> There is a free open-source plan for ImgBot, so I think enabling the bot
>>> should not be a problem. As for other bots, I suggest we enable it in the
>>> org but do not enable it widely by default. Each plugin maintainer will be
>>> able to enable it on his/her own.
>>>
>>> What do you think?
>>>
>>> Thanks in advance,
>>> Oleg
>>>
>>> --
>> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/98b1fe89-d010-40e2-8103-a70d085fcdd0%40googlegroups.com
>> 
>> .
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3Bif8h7iOuAD9tROEJ2apH4ZVSOASHC1mVA5nsT9oY1t%2BVA%40mail.gmail.com
> 
> .
>


-- 
Zhao Xiaojie (Rick)
Blog: https://github.com/LinuxSuRen
Twitter: https://twitter.com/suren69811254

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAMM7nTEGMK%3DGYb6u-19OpZwZBE8se4SoPK%2BrcecN3r4Q8JQ_DA%40mail.gmail.com.

Re: Enabling ImgBot in jenkinsci and in jenkins-infra/jenkins.io?

[Tim Jacomb]

+1

On Mon, 7 Oct 2019 at 11:10, Raihaan Shouhell 
wrote:

> I think its a good idea  +1
>
> On Monday, 7 October 2019 16:09:29 UTC+8, Oleg Nenashev wrote:
>>
>> Hi all,
>>
>> I would like to enable ImgBot in
>> some of my plugins in order to optimize image sizes. ImgBot is a bot which
>> creates pull requests with image optimizations, e.g. here is a sample pull
>> requests for the Jenkins Core:
>> https://github.com/oleg-nenashev/jenkins/pull/38. There are a lot of
>> historical images in Jenkins, and it could be a good opportunity to
>> optimize them.
>>
>> There is a free open-source plan for ImgBot, so I think enabling the bot
>> should not be a problem. As for other bots, I suggest we enable it in the
>> org but do not enable it widely by default. Each plugin maintainer will be
>> able to enable it on his/her own.
>>
>> What do you think?
>>
>> Thanks in advance,
>> Oleg
>>
>> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/98b1fe89-d010-40e2-8103-a70d085fcdd0%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3Bif8h7iOuAD9tROEJ2apH4ZVSOASHC1mVA5nsT9oY1t%2BVA%40mail.gmail.com.

Re: JENKINS-37557: Allow passing variables to repo SCM inside pipeline

[Robert Sandell]

I have been reviewing PRs to the repo plugin in the past, since the former
maintainers left the project. But lately I've had limited time and when I
sit down to do reviews other plugins that I maintain get higher priority
and then my time runs out again :'(
That's why I put the plugin up for adoption a few years ago hoping that
someone with more dedicated time could take over, but so far none has
volunteered.
Hopefully I can set aside some time in the coming weeks as time allows.

/B

Den fre 4 okt. 2019 kl 16:39 skrev Typz :

> Hello,
>
> I made a pull request to improve support for pipeline to the repo plugin,
> to support passing environment variable, but I still got no feedback. The
> patch is here: https://github.com/jenkinsci/repo-plugin/pull/54
>
> Can anybody give some feedback?
>
> Best regards,
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAKEkdc5JTYF7p74RentweqUzzpKh%3DaXbWrOBjC0oxhLNgJAw9Q%40mail.gmail.com
> 
> .
>


-- 
*Robert Sandell*
Software Engineer
CloudBees, Inc.
[image: CloudBees-Logo.png] 
E: rsand...@cloudbees.com
Twitter: robert_sandell

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CALzHZS3iUHZxJsBtoxYcT0oxo5mAcr2zFF%2B3LKrrNRMpHu3SfQ%40mail.gmail.com.

Re: Enabling ImgBot in jenkinsci and in jenkins-infra/jenkins.io?

[Raihaan Shouhell]

I think its a good idea  +1

On Monday, 7 October 2019 16:09:29 UTC+8, Oleg Nenashev wrote:
>
> Hi all,
>
> I would like to enable ImgBot in 
> some of my plugins in order to optimize image sizes. ImgBot is a bot which 
> creates pull requests with image optimizations, e.g. here is a sample pull 
> requests for the Jenkins Core: 
> https://github.com/oleg-nenashev/jenkins/pull/38. There are a lot of 
> historical images in Jenkins, and it could be a good opportunity to 
> optimize them. 
>
> There is a free open-source plan for ImgBot, so I think enabling the bot 
> should not be a problem. As for other bots, I suggest we enable it in the 
> org but do not enable it widely by default. Each plugin maintainer will be 
> able to enable it on his/her own.
>
> What do you think?
>
> Thanks in advance,
> Oleg
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/98b1fe89-d010-40e2-8103-a70d085fcdd0%40googlegroups.com.

Enabling ImgBot in jenkinsci and in jenkins-infra/jenkins.io?

[Oleg Nenashev]

Hi all,

I would like to enable ImgBot in
some of my plugins in order to optimize image sizes. ImgBot is a bot which
creates pull requests with image optimizations, e.g. here is a sample pull
requests for the Jenkins Core:
https://github.com/oleg-nenashev/jenkins/pull/38. There are a lot of
historical images in Jenkins, and it could be a good opportunity to
optimize them.

There is a free open-source plan for ImgBot, so I think enabling the bot
should not be a problem. As for other bots, I suggest we enable it in the
org but do not enable it widely by default. Each plugin maintainer will be
able to enable it on his/her own.

What do you think?

Thanks in advance,
Oleg

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLDM57J9zbP-MKrvQ64R%3Dm5xKLu%2BY235WM41NUYkr6EEQw%40mail.gmail.com.