Re: Stapler IntelliJ Plugin JetBrains Marketplace listing

2021-08-09 Thread Denys Digtiar 
Tim,
Does it mean that you have accepted the Developer Agreement? Is it OK?

On Tuesday, 3 August 2021 at 06:28:32 UTC+10 timja...@gmail.com wrote:

> Looks like it’s been released now 
>
> https://plugins.jetbrains.com/plugin/1885-stapler-framework-support/versions
>
> On Fri, 30 Jul 2021 at 06:57, Denys Digtiar  wrote:
>
>> Thank you Kohsuke! The new release has not completed a JetBrains approval 
>> yet but it is already a part of the Jenkins project on JetBrains 
>> Marketplace.
>> Now JetBrains requires legal agreement to 
>> https://plugins.jetbrains.com/legal/developer-agreement and 
>> https://plugins.jetbrains.com/legal/approval-guidelines to be able to 
>> manage the plugin. 
>>
>> On Monday, July 26, 2021 at 6:20:59 PM UTC+10 timja...@gmail.com wrote:
>>
>>> cc Kohsuke
>>>
>>> On Fri, 28 May 2021 at 22:37, Oleg Nenashev  wrote:
>>>
 FTR the plugin was moved to the jenkinsci GitHub organization: 
 https://github.com/jenkinsci/idea-stapler-plugin
 Denys will be an admin there once he accepts the invitation to the 
 GitHub org

 On Monday, May 10, 2021 at 6:33:22 PM UTC+2 Oleg Nenashev wrote:

> FTR I started https://groups.google.com/g/jenkinsci-dev/c/1T3yDHl1nEQ 
> . I have a partially-completed proposal for Stapler in my drafts, so I 
> went 
> ahead and started the discussion
>
> On Monday, May 10, 2021 at 2:16:38 PM UTC+2 Jesse Glick wrote:
>
>> On Fri, May 7, 2021 at 7:13 PM Oleg Nenashev  
>> wrote:
>>
>>> should we go ahead and move the repository to the jenkinsci org?
>>>
>>
>> Fine with me. We should probably move `stapler/stapler` itself 
>> (INFRA-2908); we have already started publishing to the Jenkins 
>> Artifactory 
>> rather than OSSRH. 
>>
> -- 

>>> You received this message because you are subscribed to the Google 
 Groups "Jenkins Developers" group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to jenkinsci-de...@googlegroups.com.

>>> To view this discussion on the web visit 
 https://groups.google.com/d/msgid/jenkinsci-dev/9e8ecbc2-adb2-4a65-bd5d-ee2b53d7b384n%40googlegroups.com
  
 
 .

>>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-de...@googlegroups.com.
>>
> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/333be135-5f7e-496a-a411-69866b1049d1n%40googlegroups.com
>>  
>> 
>> .
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/75d2210b-65f9-4971-8286-e4e17f3dcc59n%40googlegroups.com.

Re: Using sshd-core in the git plugin

2021-08-09 Thread Mark Waite 
The test failure that started this investigation is actually unrelated to 
the changes made in the pull request.

The git plugin master branch fails in the same way when `jenkins.version` 
is changed from 2.263.1 to 2.289.1.  No change in any other component, 
simply increase the minimum required Jenkins version and the test fails 
with an ASM related exception.

I'm prone to disable that test for now and leave it for later investigation.

On Friday, August 6, 2021 at 10:15:29 AM UTC-6 timja...@gmail.com wrote:

> I replied on the PR. 
>
> You aren't using the sshd provided copy but instead are using the jenkins 
> cli one
>
> On Fri, 6 Aug 2021 at 16:08, Mark Waite  wrote:
>
>> The git credentials binding project in Google Summer of Code is making 
>> progress on private key support.  Private keys are working on Windows with 
>> investigation exploring non-Windows environments.
>>
>> The pull request  
>> includes a reference to the sshd-core library from the Apache Mina 
>> project.  That reference allows the plugin to read and write private key 
>> files, including passphrase protected private key files.  However, that 
>> reference also causes two unrelated automated tests 
>>  
>> to fail with the message:
>>
>> java.lang.ClassNotFoundException: 
>> org.jenkinsci.main.modules.sshd.SshCommandFactory
>> at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
>> at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
>> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
>> at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
>> Caused: java.lang.NoClassDefFoundError: 
>> org/jenkinsci/main/modules/sshd/SshCommandFactory
>> at java.lang.ClassLoader.defineClass1(Native Method)
>>
>> The Apache Mina classes are referenced through their shaded location 
>>  as 
>> provided by the sshd plugin.  That works at runtime (at least on Windows), 
>> but causes these test failures.
>>
>> Any guidance on the preferred approach to use a library (sshd-core) that 
>> is part of a plugin (sshd) that was previously part of Jenkins core?
>>
>> Mark Waite
>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-de...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/016fd04a-f2e5-45e8-9ece-b7a89353ce33n%40googlegroups.com
>>  
>> 
>> .
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/761b5f8d-fd18-450b-bb15-ad1de00aea6dn%40googlegroups.com.