Re: Submission process of a new plugin

2022-04-05 Thread Qasim Mehmood
The pattern I saw was that both GitHub and Bitbucket had separate plugins for 
Kubernetes Credential Provider so I assumed it has to be a separate plugin. I 
am also not aware how optional dependencies are managed and what impact it 
would have on the Gitea plugin if we add this functionality there.

Regards,
Qasim Mehmood

> On 06-Apr-2022, at 12:44 AM, 'Gavin Mogan' via Jenkins Developers 
>  wrote:
> 
> Is it worth submitting a PR to add the functionality to the gitea
> plugin? its an optional dependency on the kubernetes secrets plugin
> anyways.
> 
> On Tue, Apr 5, 2022 at 12:29 PM Qasim Mehmood  wrote:
>> 
>> Hi Alexander,
>> 
>> Thank you for pointing me to the right direction. I have create the hosting 
>> request issue.
>> 
>> Though I'm unsure if there's a guideline how to deal with forks of existing 
>> plugins on the jenkinsci organization.
>> 
>> 
>> You were right about the fork. The bot did not like the fork attachment so I 
>> had to detach it. I have also squashed the commits from the original plugin 
>> so it's a standalone plugin now. The code is definitely borrowed from the 
>> other plugin but the two are functionally non-interchangeable so they 
>> shouldn’t be a fork.
>> 
>> Thanks again,
>> Qasim
>> 
>> On 05-Apr-2022, at 6:49 PM, Alexander Brandes  wrote:
>> 
>> Heyo,
>> 
>> there is this guide that outlines how to open a hosting request alongside 
>> the general information for publishing plugins. Though I'm unsure if there's 
>> a guideline how to deal with forks of existing plugins on the jenkinsci 
>> organization.
>> 
>> ~ Alex
>> 
>> On Tuesday, 5 April 2022 at 15:00:21 UTC+2 qas...@outlook.com wrote:
>>> 
>>> Hi,
>>> 
>>> I have written a plugin for creating a Gitea Personal Access Token 
>>> Credential from a Kubernetes Secret. I am not a Java developer so I forked 
>>> a similar plugin for creating a Github App credential and basically brute 
>>> forced it with my changes till it started working.
>>> 
>>> gitea-pat-kubernetes-credentials-plugin
>>> 
>>> I want to submit this plugin to Jenkins org so that anyone looking to 
>>> integrate their Gitea deployment with Jenkins on Kubernetes can do so.
>>> 
>>> I would appreciate any guidance on the next steps.
>>> 
>>> Thanks,
>>> Qasim
>> 
>> 
>> --
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/619de4db-e94b-4d78-bae8-364b5560d332n%40googlegroups.com.
>> 
>> 
>> --
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/MW4PR17MB46520211DBA49693E4C632DFB8E49%40MW4PR17MB4652.namprd17.prod.outlook.com.
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_Duu%3DGAYnM0eCMTsOHNvB3bAapxy9HxLE2kyOtDa%2B9gSZpA%40mail.gmail.com.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/MW4PR17MB465275A29FD9794991225DB7B8E49%40MW4PR17MB4652.namprd17.prod.outlook.com.


Re: Submission process of a new plugin

2022-04-05 Thread Qasim Mehmood
Hi Alexander,

Thank you for pointing me to the right direction. I have create the hosting 
request issue 
.

> Though I'm unsure if there's a guideline how to deal with forks of existing 
> plugins on the jenkinsci organization.

You were right about the fork. The bot did not like the fork attachment so I 
had to detach it. I have also squashed the commits from the original plugin so 
it's a standalone plugin now. The code is definitely borrowed from the other 
plugin but the two are functionally non-interchangeable so they shouldn’t be a 
fork.

Thanks again,
Qasim

> On 05-Apr-2022, at 6:49 PM, Alexander Brandes  wrote:
> 
> Heyo,
> 
> there is this guide 
>  that 
> outlines how to open a hosting request alongside the general information for 
> publishing plugins . Though 
> I'm unsure if there's a guideline how to deal with forks of existing plugins 
> on the jenkinsci organization.
> 
> ~ Alex
> 
> On Tuesday, 5 April 2022 at 15:00:21 UTC+2 qas...@outlook.com 
>  wrote:
> Hi,
> 
> I have written a plugin for creating a Gitea Personal Access Token Credential 
> from a Kubernetes Secret. I am not a Java developer so I forked a similar 
> plugin 
>  for 
> creating a Github App credential and basically brute forced it with my 
> changes till it started working.
> 
> gitea-pat-kubernetes-credentials-plugin 
> 
> 
> I want to submit this plugin to Jenkins org so that anyone looking to 
> integrate their Gitea deployment with Jenkins on Kubernetes can do so.
> 
> I would appreciate any guidance on the next steps.
> 
> Thanks,
> Qasim
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/619de4db-e94b-4d78-bae8-364b5560d332n%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/MW4PR17MB46520211DBA49693E4C632DFB8E49%40MW4PR17MB4652.namprd17.prod.outlook.com.