Request for feedback (Git Plugin)

[iwarapter]

Hi All,

I have recently had a go at 
solving https://issues.jenkins-ci.org/browse/JENKINS-28335 (GitPublisher 
support) the solution i have could do with a some refactoring so just after 
feedback/suggestions.

https://github.com/jenkinsci/git-plugin/pull/452 


-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/85ec810a-2655-4620-a378-972093ec440c%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: New Credentials Provider

[iwarapter]

hi,stephen,

i have a working system provider now, and i can add a credential which gets 
retrieved from a backend on use. its still got some ways to go but id certainly 
appreciate any guides!

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/5810b298-16ef-4b00-8583-bdc438b84f68%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

New Credentials Provider

[iwarapter]

Hi,

I'm currently in the process of creating a new credentials provider and 
looking for feedback on the based where to implement its authentication 
with the backend. 

I have two ways i can probably go with this one is provide the 
authentication through credentials similar to the kubernetes plugin for 
example:

















The alternative is i provide it directly using something similar to the private 
key source 

 
mechanic used in the ssh-credentials plugin:



The problem with the second option is providing a 'Test Connection' style 
button is very hard (i have no idea if Jelly could even do it). Whilst 
providing that feature with the first option is easy, however it seems a 
little silly using the original credentials provider as i would have to 
implement a new credential impl (for tokens). Am i over thinking this? I'm 
aware poor choices early on have the potential to cause alot of pain later 
down the line.

Happy for feedback!

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/6366b390-4a7b-4880-b35b-e661cc73d645%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.