Re: RFC: Removal of the auto refresh feature

2017-08-22 Thread Jesse Glick
On Tue, Aug 22, 2017 at 6:07 AM, Daniel Beck  wrote:
> we could always revert it (or, more likely, create a plugin that does this)

IIUC you could not create a plugin which does it as well, since the
`isAutoRefresh` calls have been removed, and possibly also
`norefresh="true"` markers (as I queried in the PR). So any such
plugin would probably have to add the refresh (mis)feature to URLs (or
Stapler ancestor tails, whatever) which have been explicitly
whitelisted as safe to refresh, such as folder index pages (with some
tricks to deal with `editDescription` which does not change the page
URL).

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr2cWcxDCUEKXGeA81oMA4zddKNSmvG0fi7PKmY90p26tw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: RFC: Removal of the auto refresh feature

2017-08-21 Thread Ullrich Hafner
Since you are removing a (IMO very often used) feature: shouldn’t you better 
ask the users than the developers?

> Am 21.08.2017 um 20:06 schrieb Daniel Beck :
> 
> Hi everyone,
> 
> I recently opened a PR to core, removing the 'auto refresh' feature, with 
> accompanying explanation:
> 
> https://github.com/jenkinsci/jenkins/pull/2979
> 
> If you care one way or the other, please comment there. Initial feedback was 
> supportive, so this will probably go into 2.76 unless there are objections.
> 
> Thanks!
> Daniel
> 
> --
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/824CAC89-7A49-478A-9904-5C77D8FF5A80%40beckweb.net.
> For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/0B7620A9-0BC2-4E84-9C6B-FE58020D00FC%40gmail.com.
For more options, visit https://groups.google.com/d/optout.


signature.asc
Description: Message signed with OpenPGP


Re: RFC: Removal of the auto refresh feature

2017-08-21 Thread R. Tyler Croy
(replies inline)

On Mon, 21 Aug 2017, Daniel Beck wrote:

> Hi everyone,
> 
> I recently opened a PR to core, removing the 'auto refresh' feature, with 
> accompanying explanation:
> 
> https://github.com/jenkinsci/jenkins/pull/2979
> 
> If you care one way or the other, please comment there. Initial feedback was 
> supportive, so this will probably go into 2.76 unless there are objections.


I am strongly in favor of removing this unfeature :D



- R. Tyler Croy

--
 Code: 
  Chatter: 
 xmpp: rty...@jabber.org

  % gpg --keyserver keys.gnupg.net --recv-key 1426C7DC3F51E16F
--

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/20170821202259.cvoxctcusbt3snzc%40blackberry.coupleofllamas.com.
For more options, visit https://groups.google.com/d/optout.


signature.asc
Description: PGP signature


RFC: Removal of the auto refresh feature

2017-08-21 Thread Daniel Beck
Hi everyone,

I recently opened a PR to core, removing the 'auto refresh' feature, with 
accompanying explanation:

https://github.com/jenkinsci/jenkins/pull/2979

If you care one way or the other, please comment there. Initial feedback was 
supportive, so this will probably go into 2.76 unless there are objections.

Thanks!
Daniel

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/824CAC89-7A49-478A-9904-5C77D8FF5A80%40beckweb.net.
For more options, visit https://groups.google.com/d/optout.