Re: Proposal: Jenkins Core PR reviewers team

2022-06-25 Thread Tim Jacomb
Taking the 4 +1s, I've added Alex to the Core PR reviewers team.

On Mon, 20 Jun 2022 at 19:15, Basil Crow  wrote:

> On Mon, Jun 20, 2022 at 2:19 AM Alexander Brandes 
> wrote:
> > where the latter would only be for review requests
>
> +1 from me that Alex becomes part of the "core PR reviewers" team.
>
> > I'm already inheriting these permissions as release team member.
>
> Yes, for "release activities, e.g. backporting, build fixes" (per this
> message
> ).
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjpP1hWXbf%2BksiOZWffwKe_BWDrF9k4DWd_krfDffrBfGA%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BiehRonL58ieHuvpoTsmosQ3Wm2KUZGZ4Z8k2DELb54HuQ%40mail.gmail.com.


Re: Proposal: Jenkins Core PR reviewers team

2022-06-20 Thread Basil Crow
On Mon, Jun 20, 2022 at 2:19 AM Alexander Brandes 
wrote:
> where the latter would only be for review requests

+1 from me that Alex becomes part of the "core PR reviewers" team.

> I'm already inheriting these permissions as release team member.

Yes, for "release activities, e.g. backporting, build fixes" (per this
message
).

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjpP1hWXbf%2BksiOZWffwKe_BWDrF9k4DWd_krfDffrBfGA%40mail.gmail.com.


Re: Proposal: Jenkins Core PR reviewers team

2022-06-20 Thread Damien Duportal
+1 for me as well (with the hat of infra officer)

Le lundi 20 juin 2022 à 11:19:47 UTC+2, mc.ca...@gmail.com a écrit :

> Follow up to my initial message, I would like to join both teams, the core 
> maintainer and reviewer one, where the latter would only be for review 
> requests, as I'm already inheriting these permissions as release team 
> member.
>
> Cheers
>
> On Sunday, 19 June 2022 at 21:44:12 UTC+2 Mark Waite wrote:
>
>> +1 from me as well.
>>
>> On Sun, Jun 19, 2022 at 1:33 PM Tim Jacomb  wrote:
>>
>>> +1 although I'd also be +1 on core maintainer status as well for Alex.
>>>
>>> He's helped out a lot recently
>>>
>>> Cheers
>>> Tim
>>>
>>> On Sun, 19 Jun 2022 at 17:36, Alexander Brandes  
>>> wrote:
>>>
 Hey everyone,

 late reply but I would be interested in joining as well.

 Since I joined the release team a few months ago to take care of the 
 last point release and the upcoming 2.346 LTS release, I moderate a bunch 
 of core PRs by applying labels, fixing up changelog entries, PR titles or 
 spinning up ATH and bom runs, if needed; granted by the permissions as 
 release team member, besides the typical reviews for PRs.
 Aside the LTS PRs, I merged a few minor ones in the past fulfilling the 
 requirements to be eligible for a merge too, to facilitate a backport into 
 LTS or to unblock and prevent a delay of a weekly release e.g.

 Kind regards
 Alex

 On Friday, 16 April 2021 at 22:51:04 UTC+2 Oleg Nenashev wrote:

> Welcome aboard Basil! I have updated the permissions and added you to 
> the Jenkins Core PR reviewers team.
>
> Just for the record, the Pull request review guidelines and other 
> maintainer docs are available here 
> .
>  
> We are always interested in onboarding more core maintainers, and 
> everyone 
> is welcome to participate.
>
> Best regards,
> Oleg Nenashev
>
>
> On Thu, Apr 15, 2021 at 10:35 PM Oleg Nenashev  
> wrote:
>
>> +1. I will grant Basil permissions tomorrow if no negative feedback. 
>> And again, thanks to Basil for all the contributions to Jenkins!
>>
>> On Thu, Apr 15, 2021, 22:33 Tim Jacomb  wrote:
>>
>>> +1
>>>
>>> On Thu, 15 Apr 2021 at 19:07, Mark Waite  
>>> wrote:
>>>
 +1 from me that Basil becomes part of the core PR reviewers team.

 On Thu, Apr 15, 2021 at 11:54 AM Basil Crow  
 wrote:

> I'm interested in joining the Core PR reviewers team as well.
>
> -- 
> You received this message because you are subscribed to the Google 
> Groups "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, 
> send an email to jenkinsci-de...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjrnHZmDg-JmtP%2B3fO%3Df1w_uNRFevrOy9dHfsq29n0xDnA%40mail.gmail.com
> .
>
 -- 
 You received this message because you are subscribed to the Google 
 Groups "Jenkins Developers" group.
 To unsubscribe from this group and stop receiving emails from it, 
 send an email to jenkinsci-de...@googlegroups.com.
 To view this discussion on the web visit 
 https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtFoN%3DsiPzRHcLHJyJbs1xBqnFVAkfQONGcwcE4a90hGhw%40mail.gmail.com
  
 
 .

>>> -- 
>>> You received this message because you are subscribed to a topic in 
>>> the Google Groups "Jenkins Developers" group.
>>> To unsubscribe from this topic, visit 
>>> https://groups.google.com/d/topic/jenkinsci-dev/0sdrcSOQW64/unsubscribe
>>> .
>>> To unsubscribe from this group and all its topics, send an email to 
>>> jenkinsci-de...@googlegroups.com.
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BifbZ_nDppzESg7VQSzM3-HKzk96V%2B7WYDP5-LFwoHZhRg%40mail.gmail.com
>>>  
>>> 
>>> .
>>>
>> -- 
 You received this message because you are subscribed to the Google 
 Groups "Jenkins Developers" group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to jenkinsci-de...@googlegroups.com.
 To view this discussion on the web visit 
 https://groups.google.com/d/msgid/jenkinsci-dev/b3c16811-4f63-4550-99ed-02179c2e1b5en%40googlegroups.com
  

Re: Proposal: Jenkins Core PR reviewers team

2022-06-19 Thread Mark Waite
+1 from me as well.

On Sun, Jun 19, 2022 at 1:33 PM Tim Jacomb  wrote:

> +1 although I'd also be +1 on core maintainer status as well for Alex.
>
> He's helped out a lot recently
>
> Cheers
> Tim
>
> On Sun, 19 Jun 2022 at 17:36, Alexander Brandes 
> wrote:
>
>> Hey everyone,
>>
>> late reply but I would be interested in joining as well.
>>
>> Since I joined the release team a few months ago to take care of the last
>> point release and the upcoming 2.346 LTS release, I moderate a bunch of
>> core PRs by applying labels, fixing up changelog entries, PR titles or
>> spinning up ATH and bom runs, if needed; granted by the permissions as
>> release team member, besides the typical reviews for PRs.
>> Aside the LTS PRs, I merged a few minor ones in the past fulfilling the
>> requirements to be eligible for a merge too, to facilitate a backport into
>> LTS or to unblock and prevent a delay of a weekly release e.g.
>>
>> Kind regards
>> Alex
>>
>> On Friday, 16 April 2021 at 22:51:04 UTC+2 Oleg Nenashev wrote:
>>
>>> Welcome aboard Basil! I have updated the permissions and added you to
>>> the Jenkins Core PR reviewers team.
>>>
>>> Just for the record, the Pull request review guidelines and other
>>> maintainer docs are available here
>>> .
>>> We are always interested in onboarding more core maintainers, and everyone
>>> is welcome to participate.
>>>
>>> Best regards,
>>> Oleg Nenashev
>>>
>>>
>>> On Thu, Apr 15, 2021 at 10:35 PM Oleg Nenashev 
>>> wrote:
>>>
 +1. I will grant Basil permissions tomorrow if no negative feedback.
 And again, thanks to Basil for all the contributions to Jenkins!

 On Thu, Apr 15, 2021, 22:33 Tim Jacomb  wrote:

> +1
>
> On Thu, 15 Apr 2021 at 19:07, Mark Waite  wrote:
>
>> +1 from me that Basil becomes part of the core PR reviewers team.
>>
>> On Thu, Apr 15, 2021 at 11:54 AM Basil Crow 
>> wrote:
>>
>>> I'm interested in joining the Core PR reviewers team as well.
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it,
>>> send an email to jenkinsci-de...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjrnHZmDg-JmtP%2B3fO%3Df1w_uNRFevrOy9dHfsq29n0xDnA%40mail.gmail.com
>>> .
>>>
>> --
>> You received this message because you are subscribed to the Google
>> Groups "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it,
>> send an email to jenkinsci-de...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtFoN%3DsiPzRHcLHJyJbs1xBqnFVAkfQONGcwcE4a90hGhw%40mail.gmail.com
>> 
>> .
>>
> --
> You received this message because you are subscribed to a topic in the
> Google Groups "Jenkins Developers" group.
> To unsubscribe from this topic, visit
> https://groups.google.com/d/topic/jenkinsci-dev/0sdrcSOQW64/unsubscribe
> .
> To unsubscribe from this group and all its topics, send an email to
> jenkinsci-de...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BifbZ_nDppzESg7VQSzM3-HKzk96V%2B7WYDP5-LFwoHZhRg%40mail.gmail.com
> 
> .
>
 --
>> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/b3c16811-4f63-4550-99ed-02179c2e1b5en%40googlegroups.com
>> 
>> .
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3Bidk-comtFzXQA4o640QaSL2kd0gTEXqr%3DD8Su76UoERbg%40mail.gmail.com
> 
> .
>


Re: Proposal: Jenkins Core PR reviewers team

2022-06-19 Thread Tim Jacomb
+1 although I'd also be +1 on core maintainer status as well for Alex.

He's helped out a lot recently

Cheers
Tim

On Sun, 19 Jun 2022 at 17:36, Alexander Brandes 
wrote:

> Hey everyone,
>
> late reply but I would be interested in joining as well.
>
> Since I joined the release team a few months ago to take care of the last
> point release and the upcoming 2.346 LTS release, I moderate a bunch of
> core PRs by applying labels, fixing up changelog entries, PR titles or
> spinning up ATH and bom runs, if needed; granted by the permissions as
> release team member, besides the typical reviews for PRs.
> Aside the LTS PRs, I merged a few minor ones in the past fulfilling the
> requirements to be eligible for a merge too, to facilitate a backport into
> LTS or to unblock and prevent a delay of a weekly release e.g.
>
> Kind regards
> Alex
>
> On Friday, 16 April 2021 at 22:51:04 UTC+2 Oleg Nenashev wrote:
>
>> Welcome aboard Basil! I have updated the permissions and added you to the
>> Jenkins Core PR reviewers team.
>>
>> Just for the record, the Pull request review guidelines and other
>> maintainer docs are available here
>> .
>> We are always interested in onboarding more core maintainers, and everyone
>> is welcome to participate.
>>
>> Best regards,
>> Oleg Nenashev
>>
>>
>> On Thu, Apr 15, 2021 at 10:35 PM Oleg Nenashev 
>> wrote:
>>
>>> +1. I will grant Basil permissions tomorrow if no negative feedback. And
>>> again, thanks to Basil for all the contributions to Jenkins!
>>>
>>> On Thu, Apr 15, 2021, 22:33 Tim Jacomb  wrote:
>>>
 +1

 On Thu, 15 Apr 2021 at 19:07, Mark Waite  wrote:

> +1 from me that Basil becomes part of the core PR reviewers team.
>
> On Thu, Apr 15, 2021 at 11:54 AM Basil Crow 
> wrote:
>
>> I'm interested in joining the Core PR reviewers team as well.
>>
>> --
>> You received this message because you are subscribed to the Google
>> Groups "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it,
>> send an email to jenkinsci-de...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjrnHZmDg-JmtP%2B3fO%3Df1w_uNRFevrOy9dHfsq29n0xDnA%40mail.gmail.com
>> .
>>
> --
> You received this message because you are subscribed to the Google
> Groups "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to jenkinsci-de...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtFoN%3DsiPzRHcLHJyJbs1xBqnFVAkfQONGcwcE4a90hGhw%40mail.gmail.com
> 
> .
>
 --
 You received this message because you are subscribed to a topic in the
 Google Groups "Jenkins Developers" group.
 To unsubscribe from this topic, visit
 https://groups.google.com/d/topic/jenkinsci-dev/0sdrcSOQW64/unsubscribe
 .
 To unsubscribe from this group and all its topics, send an email to
 jenkinsci-de...@googlegroups.com.
 To view this discussion on the web visit
 https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BifbZ_nDppzESg7VQSzM3-HKzk96V%2B7WYDP5-LFwoHZhRg%40mail.gmail.com
 
 .

>>> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/b3c16811-4f63-4550-99ed-02179c2e1b5en%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3Bidk-comtFzXQA4o640QaSL2kd0gTEXqr%3DD8Su76UoERbg%40mail.gmail.com.


Re: Proposal: Jenkins Core PR reviewers team

2022-06-19 Thread Alexander Brandes
Hey everyone,

late reply but I would be interested in joining as well.

Since I joined the release team a few months ago to take care of the last 
point release and the upcoming 2.346 LTS release, I moderate a bunch of 
core PRs by applying labels, fixing up changelog entries, PR titles or 
spinning up ATH and bom runs, if needed; granted by the permissions as 
release team member, besides the typical reviews for PRs.
Aside the LTS PRs, I merged a few minor ones in the past fulfilling the 
requirements to be eligible for a merge too, to facilitate a backport into 
LTS or to unblock and prevent a delay of a weekly release e.g.

Kind regards
Alex

On Friday, 16 April 2021 at 22:51:04 UTC+2 Oleg Nenashev wrote:

> Welcome aboard Basil! I have updated the permissions and added you to the 
> Jenkins Core PR reviewers team.
>
> Just for the record, the Pull request review guidelines and other 
> maintainer docs are available here 
> .
>  
> We are always interested in onboarding more core maintainers, and everyone 
> is welcome to participate.
>
> Best regards,
> Oleg Nenashev
>
>
> On Thu, Apr 15, 2021 at 10:35 PM Oleg Nenashev  
> wrote:
>
>> +1. I will grant Basil permissions tomorrow if no negative feedback. And 
>> again, thanks to Basil for all the contributions to Jenkins!
>>
>> On Thu, Apr 15, 2021, 22:33 Tim Jacomb  wrote:
>>
>>> +1
>>>
>>> On Thu, 15 Apr 2021 at 19:07, Mark Waite  wrote:
>>>
 +1 from me that Basil becomes part of the core PR reviewers team.

 On Thu, Apr 15, 2021 at 11:54 AM Basil Crow  wrote:

> I'm interested in joining the Core PR reviewers team as well.
>
> -- 
> You received this message because you are subscribed to the Google 
> Groups "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send 
> an email to jenkinsci-de...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjrnHZmDg-JmtP%2B3fO%3Df1w_uNRFevrOy9dHfsq29n0xDnA%40mail.gmail.com
> .
>
 -- 
 You received this message because you are subscribed to the Google 
 Groups "Jenkins Developers" group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to jenkinsci-de...@googlegroups.com.
 To view this discussion on the web visit 
 https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtFoN%3DsiPzRHcLHJyJbs1xBqnFVAkfQONGcwcE4a90hGhw%40mail.gmail.com
  
 
 .

>>> -- 
>>> You received this message because you are subscribed to a topic in the 
>>> Google Groups "Jenkins Developers" group.
>>> To unsubscribe from this topic, visit 
>>> https://groups.google.com/d/topic/jenkinsci-dev/0sdrcSOQW64/unsubscribe.
>>> To unsubscribe from this group and all its topics, send an email to 
>>> jenkinsci-de...@googlegroups.com.
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BifbZ_nDppzESg7VQSzM3-HKzk96V%2B7WYDP5-LFwoHZhRg%40mail.gmail.com
>>>  
>>> 
>>> .
>>>
>>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/b3c16811-4f63-4550-99ed-02179c2e1b5en%40googlegroups.com.


Re: Proposal: Jenkins Core PR reviewers team

2021-04-16 Thread Oleg Nenashev
Welcome aboard Basil! I have updated the permissions and added you to the
Jenkins Core PR reviewers team.

Just for the record, the Pull request review guidelines and other
maintainer docs are available here
.
We are always interested in onboarding more core maintainers, and everyone
is welcome to participate.

Best regards,
Oleg Nenashev


On Thu, Apr 15, 2021 at 10:35 PM Oleg Nenashev 
wrote:

> +1. I will grant Basil permissions tomorrow if no negative feedback. And
> again, thanks to Basil for all the contributions to Jenkins!
>
> On Thu, Apr 15, 2021, 22:33 Tim Jacomb  wrote:
>
>> +1
>>
>> On Thu, 15 Apr 2021 at 19:07, Mark Waite 
>> wrote:
>>
>>> +1 from me that Basil becomes part of the core PR reviewers team.
>>>
>>> On Thu, Apr 15, 2021 at 11:54 AM Basil Crow  wrote:
>>>
 I'm interested in joining the Core PR reviewers team as well.

 --
 You received this message because you are subscribed to the Google
 Groups "Jenkins Developers" group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to jenkinsci-dev+unsubscr...@googlegroups.com.
 To view this discussion on the web visit
 https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjrnHZmDg-JmtP%2B3fO%3Df1w_uNRFevrOy9dHfsq29n0xDnA%40mail.gmail.com
 .

>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to jenkinsci-dev+unsubscr...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtFoN%3DsiPzRHcLHJyJbs1xBqnFVAkfQONGcwcE4a90hGhw%40mail.gmail.com
>>> 
>>> .
>>>
>> --
>> You received this message because you are subscribed to a topic in the
>> Google Groups "Jenkins Developers" group.
>> To unsubscribe from this topic, visit
>> https://groups.google.com/d/topic/jenkinsci-dev/0sdrcSOQW64/unsubscribe.
>> To unsubscribe from this group and all its topics, send an email to
>> jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BifbZ_nDppzESg7VQSzM3-HKzk96V%2B7WYDP5-LFwoHZhRg%40mail.gmail.com
>> 
>> .
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLCX_kb1ZB%3DQTqP%2BBpqbE37u0v%2BT4Bh4n6NKgSZZZ-1Nzg%40mail.gmail.com.


Re: Proposal: Jenkins Core PR reviewers team

2021-04-15 Thread Oleg Nenashev
+1. I will grant Basil permissions tomorrow if no negative feedback. And
again, thanks to Basil for all the contributions to Jenkins!

On Thu, Apr 15, 2021, 22:33 Tim Jacomb  wrote:

> +1
>
> On Thu, 15 Apr 2021 at 19:07, Mark Waite 
> wrote:
>
>> +1 from me that Basil becomes part of the core PR reviewers team.
>>
>> On Thu, Apr 15, 2021 at 11:54 AM Basil Crow  wrote:
>>
>>> I'm interested in joining the Core PR reviewers team as well.
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to jenkinsci-dev+unsubscr...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjrnHZmDg-JmtP%2B3fO%3Df1w_uNRFevrOy9dHfsq29n0xDnA%40mail.gmail.com
>>> .
>>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtFoN%3DsiPzRHcLHJyJbs1xBqnFVAkfQONGcwcE4a90hGhw%40mail.gmail.com
>> 
>> .
>>
> --
> You received this message because you are subscribed to a topic in the
> Google Groups "Jenkins Developers" group.
> To unsubscribe from this topic, visit
> https://groups.google.com/d/topic/jenkinsci-dev/0sdrcSOQW64/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BifbZ_nDppzESg7VQSzM3-HKzk96V%2B7WYDP5-LFwoHZhRg%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLBs%3Ds6d2%3D_D1uoG2G%3DqnePyEEKmhd758aQMUFYN4FaN2A%40mail.gmail.com.


Re: Proposal: Jenkins Core PR reviewers team

2021-04-15 Thread Tim Jacomb
+1

On Thu, 15 Apr 2021 at 19:07, Mark Waite  wrote:

> +1 from me that Basil becomes part of the core PR reviewers team.
>
> On Thu, Apr 15, 2021 at 11:54 AM Basil Crow  wrote:
>
>> I'm interested in joining the Core PR reviewers team as well.
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjrnHZmDg-JmtP%2B3fO%3Df1w_uNRFevrOy9dHfsq29n0xDnA%40mail.gmail.com
>> .
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtFoN%3DsiPzRHcLHJyJbs1xBqnFVAkfQONGcwcE4a90hGhw%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BifbZ_nDppzESg7VQSzM3-HKzk96V%2B7WYDP5-LFwoHZhRg%40mail.gmail.com.


Re: Proposal: Jenkins Core PR reviewers team

2021-04-15 Thread Mark Waite
+1 from me that Basil becomes part of the core PR reviewers team.

On Thu, Apr 15, 2021 at 11:54 AM Basil Crow  wrote:

> I'm interested in joining the Core PR reviewers team as well.
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjrnHZmDg-JmtP%2B3fO%3Df1w_uNRFevrOy9dHfsq29n0xDnA%40mail.gmail.com
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtFoN%3DsiPzRHcLHJyJbs1xBqnFVAkfQONGcwcE4a90hGhw%40mail.gmail.com.


Re: Proposal: Jenkins Core PR reviewers team

2021-04-15 Thread Basil Crow
I'm interested in joining the Core PR reviewers team as well.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjrnHZmDg-JmtP%2B3fO%3Df1w_uNRFevrOy9dHfsq29n0xDnA%40mail.gmail.com.


Re: Proposal: Jenkins Core PR reviewers team

2020-02-24 Thread Oleg Nenashev
Done, welcome Marky aboard!

On Monday, February 24, 2020 at 4:39:30 AM UTC+1, Marky Jackson wrote:
>
> Thank you Oleg and everyone else for the +1
>
> { 
> "regards" : {
>  "name" : “marky”,
>  "phone" : "+1 (408) 464 2965”,
>  "email" : “marky@gmail.com ",
>  "team" : “jackson5“,
>  “role” : “software engineer"
>  }
>  }
>
> On Feb 22, 2020, at 11:26 AM, Oleg Nenashev  > wrote:
>
> 
> I will add Marky to the reviewers team on Monday if there is no negative 
> feedback provided in this thread. I have an action item to document the 
> processes, but I am behind the schedule on that (and pretty much everything 
> else, sorry).
> One of the major TODO items for me is to clarify what "substantial 
> contributions" mean in the Core PR previewer prerequisites, but I believe 
> that we should focus on contributors, not on bureaucracy.
>
> On Thursday, February 20, 2020 at 6:15:24 PM UTC+1, Matt Sicker wrote:
>>
>> +1 from me as well! 
>>
>> On Tue, Feb 18, 2020 at 3:33 AM Baptiste Mathus  
>> wrote: 
>> > 
>> > +1 to add Marky too. 
>> > 
>> > On Tue, Feb 18, 2020 at 9:59 AM Tim Jacomb  wrote: 
>> >> 
>> >> +1 from my side 
>> >> 
>> >> On Tue, 18 Feb 2020 at 08:10, Francisco Javier Fernandez <
>> fjfer...@cloudbees.com> wrote: 
>> >>> 
>> >>> Oleg, Marky, +1 from my side. Any help is always more than welcome! 
>> >>> 
>> >>> El domingo, 16 de febrero de 2020, 19:59:06 (UTC+1), Marky Jackson 
>> escribió: 
>>  
>>  Thank you kindly Oleg, please do get well. Sending healing thoughts. 
>>  
>>  On Feb 16, 2020, at 10:30 AM, Oleg Nenashev  
>> wrote: 
>>  
>>  Hi Marky. As we discussed in PM, I have an action item to follow-up 
>> on that. Sorry that I cannot provide the response time you expect, but I 
>> was mostly off over past days (sick leave). I will do my best to propose 
>> formal criteria for newcomer core PR reviewers next week. The informal 
>> criteria before was several months of activities in the core and a number 
>> of substantial contributions. 
>>  
>>  If others vote in favor of adding Marky to the Core PR Reviewers, I 
>> am +1 w.r.t that. 
>>  
>>  BR, Oleg 
>>  
>>  
>>  
>>  On Sun, Feb 16, 2020, 19:10 Marky Jackson  
>> wrote: 
>> > 
>> > I wanted to circle back around on this 
>> > 
>> > On Thursday, February 13, 2020 at 4:48:44 PM UTC-8, Marky Jackson 
>> wrote: 
>> >> 
>> >> I am happy to be included and thank you Gavin 
>> >> 
>> >> On Feb 13, 2020, at 4:46 PM, 'Gavin Mogan' via Jenkins Developers <
>> jenkin...@googlegroups.com> wrote: 
>> >> 
>> >> Sorry ya'll, with the new approved core developers, I'm going to 
>> step down as a core-pr-reviewer. Its a little overwhelming to me, and I'm 
>> not comfortable with core/java, but i'm still up for helping out randomly 
>> where i can, especially for plugins, and web/javascript stuff. I'll lurk 
>> randomly elsewhere. 
>> >> 
>> >> (this leaves room for Marky though) 
>> >> 
>> >> On Sun, Feb 2, 2020 at 1:04 AM Marky Jackson  
>> wrote: 
>> >>> 
>> >>> I love a good challenge. 
>> >>> Let’s hold off on this request and I will get some general 
>> reviews under my belt for some time and reapply at a later date. 
>> >>> Thanks kindly for the consideration. 
>> >>> 
>> >>> On Feb 1, 2020, at 11:53 PM, Daniel Beck  
>> wrote: 
>> >>> 
>> >>> 
>> >>> Extrapolating from the introduction of this team would mean 
>> people should first be regular core PR reviewers. There's no process 
>> barrier to just start doing that. 
>> >>> 
>> >>> Right now, 
>> https://github.com/jenkinsci/jenkins/pulls?utf8=%E2%9C%93=is%3Apr+involves%3Amarkyjackson-taulia
>>  
>> looks a little empty. 
>> >>> 
>> >>> -- 
>> >>> You received this message because you are subscribed to the 
>> Google Groups "Jenkins Developers" group. 
>> >>> To unsubscribe from this group and stop receiving emails from it, 
>> send an email to jenkin...@googlegroups.com. 
>> >>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtLNMKCiby_hamQ%2BpUBZyVZBzyTphw8LiTE1Y1xsbz9EOw%40mail.gmail.com.
>>  
>>
>> >>> 
>> >>> 
>> >>> -- 
>> >>> You received this message because you are subscribed to the 
>> Google Groups "Jenkins Developers" group. 
>> >>> To unsubscribe from this group and stop receiving emails from it, 
>> send an email to jenkin...@googlegroups.com. 
>> >>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/6001CF17-C6EB-4F86-ABF0-3754580C0BE3%40gmail.com.
>>  
>>
>> >> 
>> >> 
>> >> -- 
>> >> You received this message because you are subscribed to the Google 
>> Groups "Jenkins Developers" group. 
>> >> To unsubscribe from this group and stop receiving emails from it, 
>> send an email to jenkin...@googlegroups.com. 
>> >> 

Re: Proposal: Jenkins Core PR reviewers team

2020-02-23 Thread Marky Jackson
Thank you Oleg and everyone else for the +1

{ 
"regards" : {
 "name" : “marky”,
 "phone" : "+1 (408) 464 2965”,
 "email" : “marky.r.jack...@gmail.com",
 "team" : “jackson5“,
 “role” : “software engineer"
 }
 }

> On Feb 22, 2020, at 11:26 AM, Oleg Nenashev  wrote:
> 
> 
> I will add Marky to the reviewers team on Monday if there is no negative 
> feedback provided in this thread. I have an action item to document the 
> processes, but I am behind the schedule on that (and pretty much everything 
> else, sorry).
> One of the major TODO items for me is to clarify what "substantial 
> contributions" mean in the Core PR previewer prerequisites, but I believe 
> that we should focus on contributors, not on bureaucracy.
> 
>> On Thursday, February 20, 2020 at 6:15:24 PM UTC+1, Matt Sicker wrote:
>> +1 from me as well! 
>> 
>> On Tue, Feb 18, 2020 at 3:33 AM Baptiste Mathus  
>> wrote: 
>> > 
>> > +1 to add Marky too. 
>> > 
>> > On Tue, Feb 18, 2020 at 9:59 AM Tim Jacomb  wrote: 
>> >> 
>> >> +1 from my side 
>> >> 
>> >> On Tue, 18 Feb 2020 at 08:10, Francisco Javier Fernandez 
>> >>  wrote: 
>> >>> 
>> >>> Oleg, Marky, +1 from my side. Any help is always more than welcome! 
>> >>> 
>> >>> El domingo, 16 de febrero de 2020, 19:59:06 (UTC+1), Marky Jackson 
>> >>> escribió: 
>>  
>>  Thank you kindly Oleg, please do get well. Sending healing thoughts. 
>>  
>>  On Feb 16, 2020, at 10:30 AM, Oleg Nenashev  wrote: 
>>  
>>  Hi Marky. As we discussed in PM, I have an action item to follow-up on 
>>  that. Sorry that I cannot provide the response time you expect, but I 
>>  was mostly off over past days (sick leave). I will do my best to 
>>  propose formal criteria for newcomer core PR reviewers next week. The 
>>  informal criteria before was several months of activities in the core 
>>  and a number of substantial contributions. 
>>  
>>  If others vote in favor of adding Marky to the Core PR Reviewers, I am 
>>  +1 w.r.t that. 
>>  
>>  BR, Oleg 
>>  
>>  
>>  
>>  On Sun, Feb 16, 2020, 19:10 Marky Jackson  wrote: 
>> > 
>> > I wanted to circle back around on this 
>> > 
>> > On Thursday, February 13, 2020 at 4:48:44 PM UTC-8, Marky Jackson 
>> > wrote: 
>> >> 
>> >> I am happy to be included and thank you Gavin 
>> >> 
>> >> On Feb 13, 2020, at 4:46 PM, 'Gavin Mogan' via Jenkins Developers 
>> >>  wrote: 
>> >> 
>> >> Sorry ya'll, with the new approved core developers, I'm going to step 
>> >> down as a core-pr-reviewer. Its a little overwhelming to me, and I'm 
>> >> not comfortable with core/java, but i'm still up for helping out 
>> >> randomly where i can, especially for plugins, and web/javascript 
>> >> stuff. I'll lurk randomly elsewhere. 
>> >> 
>> >> (this leaves room for Marky though) 
>> >> 
>> >> On Sun, Feb 2, 2020 at 1:04 AM Marky Jackson  
>> >> wrote: 
>> >>> 
>> >>> I love a good challenge. 
>> >>> Let’s hold off on this request and I will get some general reviews 
>> >>> under my belt for some time and reapply at a later date. 
>> >>> Thanks kindly for the consideration. 
>> >>> 
>> >>> On Feb 1, 2020, at 11:53 PM, Daniel Beck  
>> >>> wrote: 
>> >>> 
>> >>> 
>> >>> Extrapolating from the introduction of this team would mean people 
>> >>> should first be regular core PR reviewers. There's no process 
>> >>> barrier to just start doing that. 
>> >>> 
>> >>> Right now, 
>> >>> https://github.com/jenkinsci/jenkins/pulls?utf8=%E2%9C%93=is%3Apr+involves%3Amarkyjackson-taulia
>> >>>  looks a little empty. 
>> >>> 
>> >>> -- 
>> >>> You received this message because you are subscribed to the Google 
>> >>> Groups "Jenkins Developers" group. 
>> >>> To unsubscribe from this group and stop receiving emails from it, 
>> >>> send an email to jenkin...@googlegroups.com. 
>> >>> To view this discussion on the web visit 
>> >>> https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtLNMKCiby_hamQ%2BpUBZyVZBzyTphw8LiTE1Y1xsbz9EOw%40mail.gmail.com.
>> >>>  
>> >>> 
>> >>> 
>> >>> -- 
>> >>> You received this message because you are subscribed to the Google 
>> >>> Groups "Jenkins Developers" group. 
>> >>> To unsubscribe from this group and stop receiving emails from it, 
>> >>> send an email to jenkin...@googlegroups.com. 
>> >>> To view this discussion on the web visit 
>> >>> https://groups.google.com/d/msgid/jenkinsci-dev/6001CF17-C6EB-4F86-ABF0-3754580C0BE3%40gmail.com.
>> >>>  
>> >> 
>> >> 
>> >> -- 
>> >> You received this message because you are subscribed to the Google 
>> >> Groups "Jenkins Developers" group. 
>> >> To unsubscribe from this group and stop receiving emails from it, 
>> >> send an email to 

Re: Proposal: Jenkins Core PR reviewers team

2020-02-22 Thread Oleg Nenashev
I will add Marky to the reviewers team on Monday if there is no negative 
feedback provided in this thread. I have an action item to document the 
processes, but I am behind the schedule on that (and pretty much everything 
else, sorry).
One of the major TODO items for me is to clarify what "substantial 
contributions" mean in the Core PR previewer prerequisites, but I believe 
that we should focus on contributors, not on bureaucracy.

On Thursday, February 20, 2020 at 6:15:24 PM UTC+1, Matt Sicker wrote:
>
> +1 from me as well! 
>
> On Tue, Feb 18, 2020 at 3:33 AM Baptiste Mathus  > wrote: 
> > 
> > +1 to add Marky too. 
> > 
> > On Tue, Feb 18, 2020 at 9:59 AM Tim Jacomb  > wrote: 
> >> 
> >> +1 from my side 
> >> 
> >> On Tue, 18 Feb 2020 at 08:10, Francisco Javier Fernandez <
> fjfer...@cloudbees.com > wrote: 
> >>> 
> >>> Oleg, Marky, +1 from my side. Any help is always more than welcome! 
> >>> 
> >>> El domingo, 16 de febrero de 2020, 19:59:06 (UTC+1), Marky Jackson 
> escribió: 
>  
>  Thank you kindly Oleg, please do get well. Sending healing thoughts. 
>  
>  On Feb 16, 2020, at 10:30 AM, Oleg Nenashev  
> wrote: 
>  
>  Hi Marky. As we discussed in PM, I have an action item to follow-up 
> on that. Sorry that I cannot provide the response time you expect, but I 
> was mostly off over past days (sick leave). I will do my best to propose 
> formal criteria for newcomer core PR reviewers next week. The informal 
> criteria before was several months of activities in the core and a number 
> of substantial contributions. 
>  
>  If others vote in favor of adding Marky to the Core PR Reviewers, I 
> am +1 w.r.t that. 
>  
>  BR, Oleg 
>  
>  
>  
>  On Sun, Feb 16, 2020, 19:10 Marky Jackson  
> wrote: 
> > 
> > I wanted to circle back around on this 
> > 
> > On Thursday, February 13, 2020 at 4:48:44 PM UTC-8, Marky Jackson 
> wrote: 
> >> 
> >> I am happy to be included and thank you Gavin 
> >> 
> >> On Feb 13, 2020, at 4:46 PM, 'Gavin Mogan' via Jenkins Developers <
> jenkin...@googlegroups.com> wrote: 
> >> 
> >> Sorry ya'll, with the new approved core developers, I'm going to 
> step down as a core-pr-reviewer. Its a little overwhelming to me, and I'm 
> not comfortable with core/java, but i'm still up for helping out randomly 
> where i can, especially for plugins, and web/javascript stuff. I'll lurk 
> randomly elsewhere. 
> >> 
> >> (this leaves room for Marky though) 
> >> 
> >> On Sun, Feb 2, 2020 at 1:04 AM Marky Jackson  
> wrote: 
> >>> 
> >>> I love a good challenge. 
> >>> Let’s hold off on this request and I will get some general reviews 
> under my belt for some time and reapply at a later date. 
> >>> Thanks kindly for the consideration. 
> >>> 
> >>> On Feb 1, 2020, at 11:53 PM, Daniel Beck  
> wrote: 
> >>> 
> >>> 
> >>> Extrapolating from the introduction of this team would mean people 
> should first be regular core PR reviewers. There's no process barrier to 
> just start doing that. 
> >>> 
> >>> Right now, 
> https://github.com/jenkinsci/jenkins/pulls?utf8=%E2%9C%93=is%3Apr+involves%3Amarkyjackson-taulia
>  
> looks a little empty. 
> >>> 
> >>> -- 
> >>> You received this message because you are subscribed to the Google 
> Groups "Jenkins Developers" group. 
> >>> To unsubscribe from this group and stop receiving emails from it, 
> send an email to jenkin...@googlegroups.com. 
> >>> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtLNMKCiby_hamQ%2BpUBZyVZBzyTphw8LiTE1Y1xsbz9EOw%40mail.gmail.com.
>  
>
> >>> 
> >>> 
> >>> -- 
> >>> You received this message because you are subscribed to the Google 
> Groups "Jenkins Developers" group. 
> >>> To unsubscribe from this group and stop receiving emails from it, 
> send an email to jenkin...@googlegroups.com. 
> >>> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/6001CF17-C6EB-4F86-ABF0-3754580C0BE3%40gmail.com.
>  
>
> >> 
> >> 
> >> -- 
> >> You received this message because you are subscribed to the Google 
> Groups "Jenkins Developers" group. 
> >> To unsubscribe from this group and stop receiving emails from it, 
> send an email to jenkin...@googlegroups.com. 
> >> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_DusuUMUQuMqXYwbQ6vf%2BqaXgNzT9cg_5M9QYJzh7c%3DVbWg%40mail.gmail.com.
>  
>
> >> 
> >> 
> > -- 
> > You received this message because you are subscribed to a topic in 
> the Google Groups "Jenkins Developers" group. 
> > To unsubscribe from this topic, visit 
> https://groups.google.com/d/topic/jenkinsci-dev/0sdrcSOQW64/unsubscribe. 
> > To unsubscribe from this group and all its topics, send an email to 
> jenkin...@googlegroups.com. 

Re: Proposal: Jenkins Core PR reviewers team

2020-02-20 Thread Matt Sicker
+1 from me as well!

On Tue, Feb 18, 2020 at 3:33 AM Baptiste Mathus  wrote:
>
> +1 to add Marky too.
>
> On Tue, Feb 18, 2020 at 9:59 AM Tim Jacomb  wrote:
>>
>> +1 from my side
>>
>> On Tue, 18 Feb 2020 at 08:10, Francisco Javier Fernandez 
>>  wrote:
>>>
>>> Oleg, Marky, +1 from my side. Any help is always more than welcome!
>>>
>>> El domingo, 16 de febrero de 2020, 19:59:06 (UTC+1), Marky Jackson escribió:

 Thank you kindly Oleg, please do get well. Sending healing thoughts.

 On Feb 16, 2020, at 10:30 AM, Oleg Nenashev  wrote:

 Hi Marky. As we discussed in PM, I have an action item to follow-up on 
 that. Sorry that I cannot provide the response time you expect, but I was 
 mostly off over past days (sick leave). I will do my best to propose 
 formal criteria for newcomer core PR reviewers next week. The informal 
 criteria before was several months of activities in the core and a number 
 of substantial contributions.

 If others vote in favor of adding Marky to the Core PR Reviewers, I am +1 
 w.r.t that.

 BR, Oleg



 On Sun, Feb 16, 2020, 19:10 Marky Jackson  wrote:
>
> I wanted to circle back around on this
>
> On Thursday, February 13, 2020 at 4:48:44 PM UTC-8, Marky Jackson wrote:
>>
>> I am happy to be included and thank you Gavin
>>
>> On Feb 13, 2020, at 4:46 PM, 'Gavin Mogan' via Jenkins Developers 
>>  wrote:
>>
>> Sorry ya'll, with the new approved core developers, I'm going to step 
>> down as a core-pr-reviewer. Its a little overwhelming to me, and I'm not 
>> comfortable with core/java, but i'm still up for helping out randomly 
>> where i can, especially for plugins, and web/javascript stuff. I'll lurk 
>> randomly elsewhere.
>>
>> (this leaves room for Marky though)
>>
>> On Sun, Feb 2, 2020 at 1:04 AM Marky Jackson  wrote:
>>>
>>> I love a good challenge.
>>> Let’s hold off on this request and I will get some general reviews 
>>> under my belt for some time and reapply at a later date.
>>> Thanks kindly for the consideration.
>>>
>>> On Feb 1, 2020, at 11:53 PM, Daniel Beck  wrote:
>>>
>>>
>>> Extrapolating from the introduction of this team would mean people 
>>> should first be regular core PR reviewers. There's no process barrier 
>>> to just start doing that.
>>>
>>> Right now, 
>>> https://github.com/jenkinsci/jenkins/pulls?utf8=%E2%9C%93=is%3Apr+involves%3Amarkyjackson-taulia
>>>  looks a little empty.
>>>
>>> --
>>> You received this message because you are subscribed to the Google 
>>> Groups "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send 
>>> an email to jenkin...@googlegroups.com.
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtLNMKCiby_hamQ%2BpUBZyVZBzyTphw8LiTE1Y1xsbz9EOw%40mail.gmail.com.
>>>
>>>
>>> --
>>> You received this message because you are subscribed to the Google 
>>> Groups "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send 
>>> an email to jenkin...@googlegroups.com.
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/jenkinsci-dev/6001CF17-C6EB-4F86-ABF0-3754580C0BE3%40gmail.com.
>>
>>
>> --
>> You received this message because you are subscribed to the Google 
>> Groups "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send 
>> an email to jenkin...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_DusuUMUQuMqXYwbQ6vf%2BqaXgNzT9cg_5M9QYJzh7c%3DVbWg%40mail.gmail.com.
>>
>>
> --
> You received this message because you are subscribed to a topic in the 
> Google Groups "Jenkins Developers" group.
> To unsubscribe from this topic, visit 
> https://groups.google.com/d/topic/jenkinsci-dev/0sdrcSOQW64/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to 
> jenkin...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/46d147a4-3f81-4eea-93ad-3a355329eb28%40googlegroups.com.

 --
 You received this message because you are subscribed to the Google Groups 
 "Jenkins Developers" group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to jenkin...@googlegroups.com.
 To view this discussion on the web visit 
 https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLDFMapzJLRGneO1M7aD1ontMYFF-fUDH93Gspp5VfnzBA%40mail.gmail.com.
>>>
>>> --
>>> You received this message because you are subscribed to the Google Groups 
>>> "Jenkins Developers" 

Re: Proposal: Jenkins Core PR reviewers team

2020-02-18 Thread Baptiste Mathus
+1 to add Marky too.

On Tue, Feb 18, 2020 at 9:59 AM Tim Jacomb  wrote:

> +1 from my side
>
> On Tue, 18 Feb 2020 at 08:10, Francisco Javier Fernandez <
> fjfernan...@cloudbees.com> wrote:
>
>> Oleg, Marky, +1 from my side. Any help is always more than welcome!
>>
>> El domingo, 16 de febrero de 2020, 19:59:06 (UTC+1), Marky Jackson
>> escribió:
>>>
>>> Thank you kindly Oleg, please do get well. Sending healing thoughts.
>>>
>>> On Feb 16, 2020, at 10:30 AM, Oleg Nenashev  wrote:
>>>
>>> Hi Marky. As we discussed in PM, I have an action item to follow-up on
>>> that. Sorry that I cannot provide the response time you expect, but I was
>>> mostly off over past days (sick leave). I will do my best to propose formal
>>> criteria for newcomer core PR reviewers next week. The informal criteria
>>> before was several months of activities in the core and a number of
>>> substantial contributions.
>>>
>>> If others vote in favor of adding Marky to the Core PR Reviewers, I am
>>> +1 w.r.t that.
>>>
>>> BR, Oleg
>>>
>>>
>>>
>>> On Sun, Feb 16, 2020, 19:10 Marky Jackson  wrote:
>>>
 I wanted to circle back around on this

 On Thursday, February 13, 2020 at 4:48:44 PM UTC-8, Marky Jackson wrote:
>
> I am happy to be included and thank you Gavin
>
> On Feb 13, 2020, at 4:46 PM, 'Gavin Mogan' via Jenkins Developers <
> jenkin...@googlegroups.com> wrote:
>
> Sorry ya'll, with the new approved core developers, I'm going to step
> down as a core-pr-reviewer. Its a little overwhelming to me, and I'm not
> comfortable with core/java, but i'm still up for helping out randomly 
> where
> i can, especially for plugins, and web/javascript stuff. I'll lurk 
> randomly
> elsewhere.
>
> (this leaves room for Marky though)
>
> On Sun, Feb 2, 2020 at 1:04 AM Marky Jackson 
> wrote:
>
>> I love a good challenge.
>> Let’s hold off on this request and I will get some general reviews
>> under my belt for some time and reapply at a later date.
>> Thanks kindly for the consideration.
>>
>> On Feb 1, 2020, at 11:53 PM, Daniel Beck  wrote:
>>
>>
>> Extrapolating from the introduction of this team would mean people
>> should first be regular core PR reviewers. There's no process barrier to
>> just start doing that.
>>
>> Right now,
>> https://github.com/jenkinsci/jenkins/pulls?utf8=%E2%9C%93=is%3Apr+involves%3Amarkyjackson-taulia
>> looks a little empty.
>>
>> --
>> You received this message because you are subscribed to the Google
>> Groups "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it,
>> send an email to jenkin...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtLNMKCiby_hamQ%2BpUBZyVZBzyTphw8LiTE1Y1xsbz9EOw%40mail.gmail.com
>> 
>> .
>>
>>
>> --
>> You received this message because you are subscribed to the Google
>> Groups "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it,
>> send an email to jenkin...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/6001CF17-C6EB-4F86-ABF0-3754580C0BE3%40gmail.com
>> 
>> .
>>
>
> --
> You received this message because you are subscribed to the Google
> Groups "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to jenkin...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_DusuUMUQuMqXYwbQ6vf%2BqaXgNzT9cg_5M9QYJzh7c%3DVbWg%40mail.gmail.com
> 
> .
>
>
> --
 You received this message because you are subscribed to a topic in the
 Google Groups "Jenkins Developers" group.
 To unsubscribe from this topic, visit
 https://groups.google.com/d/topic/jenkinsci-dev/0sdrcSOQW64/unsubscribe
 .
 To unsubscribe from this group and all its topics, send an email to
 jenkin...@googlegroups.com.
 To view this discussion on the web visit
 https://groups.google.com/d/msgid/jenkinsci-dev/46d147a4-3f81-4eea-93ad-3a355329eb28%40googlegroups.com
 
 .

>>> --
>>> You received this 

Re: Proposal: Jenkins Core PR reviewers team

2020-02-18 Thread Tim Jacomb
+1 from my side

On Tue, 18 Feb 2020 at 08:10, Francisco Javier Fernandez <
fjfernan...@cloudbees.com> wrote:

> Oleg, Marky, +1 from my side. Any help is always more than welcome!
>
> El domingo, 16 de febrero de 2020, 19:59:06 (UTC+1), Marky Jackson
> escribió:
>>
>> Thank you kindly Oleg, please do get well. Sending healing thoughts.
>>
>> On Feb 16, 2020, at 10:30 AM, Oleg Nenashev  wrote:
>>
>> Hi Marky. As we discussed in PM, I have an action item to follow-up on
>> that. Sorry that I cannot provide the response time you expect, but I was
>> mostly off over past days (sick leave). I will do my best to propose formal
>> criteria for newcomer core PR reviewers next week. The informal criteria
>> before was several months of activities in the core and a number of
>> substantial contributions.
>>
>> If others vote in favor of adding Marky to the Core PR Reviewers, I am +1
>> w.r.t that.
>>
>> BR, Oleg
>>
>>
>>
>> On Sun, Feb 16, 2020, 19:10 Marky Jackson  wrote:
>>
>>> I wanted to circle back around on this
>>>
>>> On Thursday, February 13, 2020 at 4:48:44 PM UTC-8, Marky Jackson wrote:

 I am happy to be included and thank you Gavin

 On Feb 13, 2020, at 4:46 PM, 'Gavin Mogan' via Jenkins Developers <
 jenkin...@googlegroups.com> wrote:

 Sorry ya'll, with the new approved core developers, I'm going to step
 down as a core-pr-reviewer. Its a little overwhelming to me, and I'm not
 comfortable with core/java, but i'm still up for helping out randomly where
 i can, especially for plugins, and web/javascript stuff. I'll lurk randomly
 elsewhere.

 (this leaves room for Marky though)

 On Sun, Feb 2, 2020 at 1:04 AM Marky Jackson 
 wrote:

> I love a good challenge.
> Let’s hold off on this request and I will get some general reviews
> under my belt for some time and reapply at a later date.
> Thanks kindly for the consideration.
>
> On Feb 1, 2020, at 11:53 PM, Daniel Beck  wrote:
>
>
> Extrapolating from the introduction of this team would mean people
> should first be regular core PR reviewers. There's no process barrier to
> just start doing that.
>
> Right now,
> https://github.com/jenkinsci/jenkins/pulls?utf8=%E2%9C%93=is%3Apr+involves%3Amarkyjackson-taulia
> looks a little empty.
>
> --
> You received this message because you are subscribed to the Google
> Groups "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to jenkin...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtLNMKCiby_hamQ%2BpUBZyVZBzyTphw8LiTE1Y1xsbz9EOw%40mail.gmail.com
> 
> .
>
>
> --
> You received this message because you are subscribed to the Google
> Groups "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to jenkin...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/6001CF17-C6EB-4F86-ABF0-3754580C0BE3%40gmail.com
> 
> .
>

 --
 You received this message because you are subscribed to the Google
 Groups "Jenkins Developers" group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to jenkin...@googlegroups.com.
 To view this discussion on the web visit
 https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_DusuUMUQuMqXYwbQ6vf%2BqaXgNzT9cg_5M9QYJzh7c%3DVbWg%40mail.gmail.com
 
 .


 --
>>> You received this message because you are subscribed to a topic in the
>>> Google Groups "Jenkins Developers" group.
>>> To unsubscribe from this topic, visit
>>> https://groups.google.com/d/topic/jenkinsci-dev/0sdrcSOQW64/unsubscribe.
>>> To unsubscribe from this group and all its topics, send an email to
>>> jenkin...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/jenkinsci-dev/46d147a4-3f81-4eea-93ad-3a355329eb28%40googlegroups.com
>>> 
>>> .
>>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkin...@googlegroups.com.
>> To view 

Re: Proposal: Jenkins Core PR reviewers team

2020-02-18 Thread Francisco Javier Fernandez
Oleg, Marky, +1 from my side. Any help is always more than welcome!

El domingo, 16 de febrero de 2020, 19:59:06 (UTC+1), Marky Jackson escribió:
>
> Thank you kindly Oleg, please do get well. Sending healing thoughts.
>
> On Feb 16, 2020, at 10:30 AM, Oleg Nenashev  > wrote:
>
> 
> Hi Marky. As we discussed in PM, I have an action item to follow-up on 
> that. Sorry that I cannot provide the response time you expect, but I was 
> mostly off over past days (sick leave). I will do my best to propose formal 
> criteria for newcomer core PR reviewers next week. The informal criteria 
> before was several months of activities in the core and a number of 
> substantial contributions.
>
> If others vote in favor of adding Marky to the Core PR Reviewers, I am +1 
> w.r.t that.
>
> BR, Oleg
>
>
>
> On Sun, Feb 16, 2020, 19:10 Marky Jackson  > wrote:
>
>> I wanted to circle back around on this
>>
>> On Thursday, February 13, 2020 at 4:48:44 PM UTC-8, Marky Jackson wrote:
>>>
>>> I am happy to be included and thank you Gavin
>>>
>>> On Feb 13, 2020, at 4:46 PM, 'Gavin Mogan' via Jenkins Developers <
>>> jenkin...@googlegroups.com > wrote:
>>>
>>> Sorry ya'll, with the new approved core developers, I'm going to step 
>>> down as a core-pr-reviewer. Its a little overwhelming to me, and I'm not 
>>> comfortable with core/java, but i'm still up for helping out randomly where 
>>> i can, especially for plugins, and web/javascript stuff. I'll lurk randomly 
>>> elsewhere.
>>>
>>> (this leaves room for Marky though)
>>>
>>> On Sun, Feb 2, 2020 at 1:04 AM Marky Jackson >> > wrote:
>>>
 I love a good challenge.
 Let’s hold off on this request and I will get some general reviews 
 under my belt for some time and reapply at a later date.
 Thanks kindly for the consideration.

 On Feb 1, 2020, at 11:53 PM, Daniel Beck >>> > wrote:


 
 Extrapolating from the introduction of this team would mean people 
 should first be regular core PR reviewers. There's no process barrier to 
 just start doing that.

 Right now, 
 https://github.com/jenkinsci/jenkins/pulls?utf8=%E2%9C%93=is%3Apr+involves%3Amarkyjackson-taulia
  
 looks a little empty.

 -- 
 You received this message because you are subscribed to the Google 
 Groups "Jenkins Developers" group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to jenkin...@googlegroups.com .
 To view this discussion on the web visit 
 https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtLNMKCiby_hamQ%2BpUBZyVZBzyTphw8LiTE1Y1xsbz9EOw%40mail.gmail.com
  
 
 .


 -- 
 You received this message because you are subscribed to the Google 
 Groups "Jenkins Developers" group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to jenkin...@googlegroups.com .
 To view this discussion on the web visit 
 https://groups.google.com/d/msgid/jenkinsci-dev/6001CF17-C6EB-4F86-ABF0-3754580C0BE3%40gmail.com
  
 
 .

>>>
>>> -- 
>>> You received this message because you are subscribed to the Google 
>>> Groups "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send 
>>> an email to jenkin...@googlegroups.com .
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_DusuUMUQuMqXYwbQ6vf%2BqaXgNzT9cg_5M9QYJzh7c%3DVbWg%40mail.gmail.com
>>>  
>>> 
>>> .
>>>
>>>
>>> -- 
>> You received this message because you are subscribed to a topic in the 
>> Google Groups "Jenkins Developers" group.
>> To unsubscribe from this topic, visit 
>> https://groups.google.com/d/topic/jenkinsci-dev/0sdrcSOQW64/unsubscribe.
>> To unsubscribe from this group and all its topics, send an email to 
>> jenkin...@googlegroups.com .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/46d147a4-3f81-4eea-93ad-3a355329eb28%40googlegroups.com
>>  
>> 
>> .
>>
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkin...@googlegroups.com .
> To view this discussion on the web visit 
> 

Re: Proposal: Jenkins Core PR reviewers team

2020-02-16 Thread Marky Jackson
Thank you kindly Oleg, please do get well. Sending healing thoughts.

> On Feb 16, 2020, at 10:30 AM, Oleg Nenashev  wrote:
> 
> 
> Hi Marky. As we discussed in PM, I have an action item to follow-up on that. 
> Sorry that I cannot provide the response time you expect, but I was mostly 
> off over past days (sick leave). I will do my best to propose formal criteria 
> for newcomer core PR reviewers next week. The informal criteria before was 
> several months of activities in the core and a number of substantial 
> contributions.
> 
> If others vote in favor of adding Marky to the Core PR Reviewers, I am +1 
> w.r.t that.
> 
> BR, Oleg
> 
> 
> 
>> On Sun, Feb 16, 2020, 19:10 Marky Jackson  wrote:
>> I wanted to circle back around on this
>> 
>>> On Thursday, February 13, 2020 at 4:48:44 PM UTC-8, Marky Jackson wrote:
>>> I am happy to be included and thank you Gavin
>>> 
 On Feb 13, 2020, at 4:46 PM, 'Gavin Mogan' via Jenkins Developers 
  wrote:
 
 Sorry ya'll, with the new approved core developers, I'm going to step down 
 as a core-pr-reviewer. Its a little overwhelming to me, and I'm not 
 comfortable with core/java, but i'm still up for helping out randomly 
 where i can, especially for plugins, and web/javascript stuff. I'll lurk 
 randomly elsewhere.
 
 (this leaves room for Marky though)
 
> On Sun, Feb 2, 2020 at 1:04 AM Marky Jackson  
> wrote:
> I love a good challenge.
> Let’s hold off on this request and I will get some general reviews under 
> my belt for some time and reapply at a later date.
> Thanks kindly for the consideration.
> 
>> On Feb 1, 2020, at 11:53 PM, Daniel Beck  wrote:
>> 
>> 
>> Extrapolating from the introduction of this team would mean people 
>> should first be regular core PR reviewers. There's no process barrier to 
>> just start doing that.
>> 
>> Right now, 
>> https://github.com/jenkinsci/jenkins/pulls?utf8=%E2%9C%93=is%3Apr+involves%3Amarkyjackson-taulia
>>  looks a little empty.
>> 
>> -- 
>> You received this message because you are subscribed to the Google 
>> Groups "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send 
>> an email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtLNMKCiby_hamQ%2BpUBZyVZBzyTphw8LiTE1Y1xsbz9EOw%40mail.gmail.com.
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/6001CF17-C6EB-4F86-ABF0-3754580C0BE3%40gmail.com.
 
 
 -- 
 You received this message because you are subscribed to the Google Groups 
 "Jenkins Developers" group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to jenkinsci-dev+unsubscr...@googlegroups.com.
 To view this discussion on the web visit 
 https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_DusuUMUQuMqXYwbQ6vf%2BqaXgNzT9cg_5M9QYJzh7c%3DVbWg%40mail.gmail.com.
>>> 
>> 
>> -- 
>> You received this message because you are subscribed to a topic in the 
>> Google Groups "Jenkins Developers" group.
>> To unsubscribe from this topic, visit 
>> https://groups.google.com/d/topic/jenkinsci-dev/0sdrcSOQW64/unsubscribe.
>> To unsubscribe from this group and all its topics, send an email to 
>> jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/46d147a4-3f81-4eea-93ad-3a355329eb28%40googlegroups.com.
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLDFMapzJLRGneO1M7aD1ontMYFF-fUDH93Gspp5VfnzBA%40mail.gmail.com.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/62DE49DA-0ADE-47AC-B373-B70553281C70%40gmail.com.


Re: Proposal: Jenkins Core PR reviewers team

2020-02-16 Thread Oleg Nenashev
Hi Marky. As we discussed in PM, I have an action item to follow-up on
that. Sorry that I cannot provide the response time you expect, but I was
mostly off over past days (sick leave). I will do my best to propose formal
criteria for newcomer core PR reviewers next week. The informal criteria
before was several months of activities in the core and a number of
substantial contributions.

If others vote in favor of adding Marky to the Core PR Reviewers, I am +1
w.r.t that.

BR, Oleg



On Sun, Feb 16, 2020, 19:10 Marky Jackson  wrote:

> I wanted to circle back around on this
>
> On Thursday, February 13, 2020 at 4:48:44 PM UTC-8, Marky Jackson wrote:
>>
>> I am happy to be included and thank you Gavin
>>
>> On Feb 13, 2020, at 4:46 PM, 'Gavin Mogan' via Jenkins Developers <
>> jenkinsci-dev@googlegroups.com> wrote:
>>
>> Sorry ya'll, with the new approved core developers, I'm going to step
>> down as a core-pr-reviewer. Its a little overwhelming to me, and I'm not
>> comfortable with core/java, but i'm still up for helping out randomly where
>> i can, especially for plugins, and web/javascript stuff. I'll lurk randomly
>> elsewhere.
>>
>> (this leaves room for Marky though)
>>
>> On Sun, Feb 2, 2020 at 1:04 AM Marky Jackson 
>> wrote:
>>
>>> I love a good challenge.
>>> Let’s hold off on this request and I will get some general reviews under
>>> my belt for some time and reapply at a later date.
>>> Thanks kindly for the consideration.
>>>
>>> On Feb 1, 2020, at 11:53 PM, Daniel Beck  wrote:
>>>
>>>
>>> 
>>> Extrapolating from the introduction of this team would mean people
>>> should first be regular core PR reviewers. There's no process barrier to
>>> just start doing that.
>>>
>>> Right now,
>>> https://github.com/jenkinsci/jenkins/pulls?utf8=%E2%9C%93=is%3Apr+involves%3Amarkyjackson-taulia
>>> looks a little empty.
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to jenkinsci-dev+unsubscr...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtLNMKCiby_hamQ%2BpUBZyVZBzyTphw8LiTE1Y1xsbz9EOw%40mail.gmail.com
>>> 
>>> .
>>>
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to jenkinsci-dev+unsubscr...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/jenkinsci-dev/6001CF17-C6EB-4F86-ABF0-3754580C0BE3%40gmail.com
>>> 
>>> .
>>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_DusuUMUQuMqXYwbQ6vf%2BqaXgNzT9cg_5M9QYJzh7c%3DVbWg%40mail.gmail.com
>> 
>> .
>>
>>
>> --
> You received this message because you are subscribed to a topic in the
> Google Groups "Jenkins Developers" group.
> To unsubscribe from this topic, visit
> https://groups.google.com/d/topic/jenkinsci-dev/0sdrcSOQW64/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to
> jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/46d147a4-3f81-4eea-93ad-3a355329eb28%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLDFMapzJLRGneO1M7aD1ontMYFF-fUDH93Gspp5VfnzBA%40mail.gmail.com.


Re: Proposal: Jenkins Core PR reviewers team

2020-02-13 Thread Marky Jackson
I am happy to be included and thank you Gavin

> On Feb 13, 2020, at 4:46 PM, 'Gavin Mogan' via Jenkins Developers 
>  wrote:
> 
> Sorry ya'll, with the new approved core developers, I'm going to step down as 
> a core-pr-reviewer. Its a little overwhelming to me, and I'm not comfortable 
> with core/java, but i'm still up for helping out randomly where i can, 
> especially for plugins, and web/javascript stuff. I'll lurk randomly 
> elsewhere.
> 
> (this leaves room for Marky though)
> 
> On Sun, Feb 2, 2020 at 1:04 AM Marky Jackson  > wrote:
> I love a good challenge.
> Let’s hold off on this request and I will get some general reviews under my 
> belt for some time and reapply at a later date.
> Thanks kindly for the consideration.
> 
> On Feb 1, 2020, at 11:53 PM, Daniel Beck  > wrote:
>> 
>> 
>> Extrapolating from the introduction of this team would mean people should 
>> first be regular core PR reviewers. There's no process barrier to just start 
>> doing that.
>> 
>> Right now, 
>> https://github.com/jenkinsci/jenkins/pulls?utf8=%E2%9C%93=is%3Apr+involves%3Amarkyjackson-taulia
>>  
>> 
>>  looks a little empty.
>> 
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-dev+unsubscr...@googlegroups.com 
>> .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtLNMKCiby_hamQ%2BpUBZyVZBzyTphw8LiTE1Y1xsbz9EOw%40mail.gmail.com
>>  
>> .
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/6001CF17-C6EB-4F86-ABF0-3754580C0BE3%40gmail.com
>  
> .
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_DusuUMUQuMqXYwbQ6vf%2BqaXgNzT9cg_5M9QYJzh7c%3DVbWg%40mail.gmail.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/04BD050C-4C95-4A65-AC85-38D2119D99EE%40gmail.com.


Re: Proposal: Jenkins Core PR reviewers team

2020-02-13 Thread 'Gavin Mogan' via Jenkins Developers
Sorry ya'll, with the new approved core developers, I'm going to step down
as a core-pr-reviewer. Its a little overwhelming to me, and I'm not
comfortable with core/java, but i'm still up for helping out randomly where
i can, especially for plugins, and web/javascript stuff. I'll lurk randomly
elsewhere.

(this leaves room for Marky though)

On Sun, Feb 2, 2020 at 1:04 AM Marky Jackson 
wrote:

> I love a good challenge.
> Let’s hold off on this request and I will get some general reviews under
> my belt for some time and reapply at a later date.
> Thanks kindly for the consideration.
>
> On Feb 1, 2020, at 11:53 PM, Daniel Beck  wrote:
>
>
> 
> Extrapolating from the introduction of this team would mean people should
> first be regular core PR reviewers. There's no process barrier to just
> start doing that.
>
> Right now,
> https://github.com/jenkinsci/jenkins/pulls?utf8=%E2%9C%93=is%3Apr+involves%3Amarkyjackson-taulia
> looks a little empty.
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtLNMKCiby_hamQ%2BpUBZyVZBzyTphw8LiTE1Y1xsbz9EOw%40mail.gmail.com
> 
> .
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/6001CF17-C6EB-4F86-ABF0-3754580C0BE3%40gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_DusuUMUQuMqXYwbQ6vf%2BqaXgNzT9cg_5M9QYJzh7c%3DVbWg%40mail.gmail.com.


Re: Proposal: Jenkins Core PR reviewers team

2020-02-02 Thread Marky Jackson
I love a good challenge.
Let’s hold off on this request and I will get some general reviews under my 
belt for some time and reapply at a later date.
Thanks kindly for the consideration.

On Feb 1, 2020, at 11:53 PM, Daniel Beck  wrote:
> 
> 
> Extrapolating from the introduction of this team would mean people should 
> first be regular core PR reviewers. There's no process barrier to just start 
> doing that.
> 
> Right now, 
> https://github.com/jenkinsci/jenkins/pulls?utf8=%E2%9C%93=is%3Apr+involves%3Amarkyjackson-taulia
>  looks a little empty.
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtLNMKCiby_hamQ%2BpUBZyVZBzyTphw8LiTE1Y1xsbz9EOw%40mail.gmail.com.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/6001CF17-C6EB-4F86-ABF0-3754580C0BE3%40gmail.com.


Re: Proposal: Jenkins Core PR reviewers team

2020-02-01 Thread Daniel Beck
Extrapolating from the introduction of this team would mean people should
first be regular core PR reviewers. There's no process barrier to just
start doing that.

Right now,
https://github.com/jenkinsci/jenkins/pulls?utf8=%E2%9C%93=is%3Apr+involves%3Amarkyjackson-taulia
looks a little empty.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtLNMKCiby_hamQ%2BpUBZyVZBzyTphw8LiTE1Y1xsbz9EOw%40mail.gmail.com.


Re: Proposal: Jenkins Core PR reviewers team

2020-02-01 Thread Oleg Nenashev
Hi Marky,

Thanks for the interest! I am definitely +1 taking all your contributions 
in other areas.
One potential concern is that you have not contributed much to the Jenkins 
core yet, and for a reviewer.it would be useful to have some experience 
with the review process from another side.
We do not have it in the requirements defined above, would be nice to hear 
what others say about it.

BR, Oleg

On Sunday, February 2, 2020 at 1:18:32 AM UTC+1, Marky Jackson wrote:
>
> Hello all!
> I would like to be added to this team if possible.
>
> On Friday, September 20, 2019 at 2:03:17 AM UTC-7, Oleg Nenashev wrote:
>>
>> Thanks to all for the feedback!
>> I have created the team: 
>> https://github.com/orgs/jenkinsci/teams/core-pr-reviewers
>> Please let me know if it works for you.
>>
>> Best regards,
>> Oleg
>>
>>
>> On Friday, September 20, 2019 at 10:18:04 AM UTC+2, Tim Jacomb wrote:
>>>
>>> I would be interested in joining this team
>>>
>>> On Thursday, 19 September 2019 12:26:46 UTC+1, Oleg Nenashev wrote:

 Hi all,

 I would like to make a proposal w.r.t the Jenkins Core review process. 

 As you may see from the pull requests 
 , currently we have a 
 pretty heavy process which includes multiple reviews, labeling PRs for 
 automatic changelog drafts, and so on. This process helps us to maintain 
 high quality of weekly releases. Over the last year we have had many 
 contributors who helped to review core pull requests on a regular basis. 
 These contributors do not have WRITE permission in the repo, and they had 
 no way no assign labels, request reviews, re-trigger CI, and so on. 
 Only jenkinsci/Core members have permission to do that, and it is a 
 serious 
 overhead since we do not have many active core maintainers in 
 jenkinsci/Core looking at PRs.

 Few months ago GitHub introduced a new TRIAGE 
 
  permission 
 for the repository which basically gives permissions to manage issues/pull 
 requests without being actually able to merge them. IMO it gives us a 
 great 
 opportunity to expand the core reviewers bandwidth and at the same time to 
 offer a path for onboarding new core maintainers (contributor => Triage => 
 Write permissions).

 What I suggest to do:

- Introduce a new jenkinsci/core-pr-reviewers team
- Grant the team TRIAGE permission in  
https://github.com/jenkinsci/jenkins
- Maybe?: Add CODEOWNERS to GitHub to automatically request reviews 
from the new team for new pull requests
- Invite contributors who regularly review Jenkins core pull 
requests: alecharp , varyvol 
, MarkEWaite 
, res0nance 
, jvz , 
MRamonLeon, halkeye  (sorry if I missed 
anyone!)

 If the approach works well, later we can expand it to components which 
 are a part of the Jenkins core (libraries, modules, etc.).

 What do you think?

 Best regards,
 Oleg









-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/4295a166-e94b-4fc3-b941-9e7b163f81f3%40googlegroups.com.


Re: Proposal: Jenkins Core PR reviewers team

2020-02-01 Thread Marky Jackson
Hello all!
I would like to be added to this team if possible.

On Friday, September 20, 2019 at 2:03:17 AM UTC-7, Oleg Nenashev wrote:
>
> Thanks to all for the feedback!
> I have created the team: 
> https://github.com/orgs/jenkinsci/teams/core-pr-reviewers
> Please let me know if it works for you.
>
> Best regards,
> Oleg
>
>
> On Friday, September 20, 2019 at 10:18:04 AM UTC+2, Tim Jacomb wrote:
>>
>> I would be interested in joining this team
>>
>> On Thursday, 19 September 2019 12:26:46 UTC+1, Oleg Nenashev wrote:
>>>
>>> Hi all,
>>>
>>> I would like to make a proposal w.r.t the Jenkins Core review process. 
>>>
>>> As you may see from the pull requests 
>>> , currently we have a 
>>> pretty heavy process which includes multiple reviews, labeling PRs for 
>>> automatic changelog drafts, and so on. This process helps us to maintain 
>>> high quality of weekly releases. Over the last year we have had many 
>>> contributors who helped to review core pull requests on a regular basis. 
>>> These contributors do not have WRITE permission in the repo, and they had 
>>> no way no assign labels, request reviews, re-trigger CI, and so on. 
>>> Only jenkinsci/Core members have permission to do that, and it is a serious 
>>> overhead since we do not have many active core maintainers in 
>>> jenkinsci/Core looking at PRs.
>>>
>>> Few months ago GitHub introduced a new TRIAGE 
>>> 
>>>  permission 
>>> for the repository which basically gives permissions to manage issues/pull 
>>> requests without being actually able to merge them. IMO it gives us a great 
>>> opportunity to expand the core reviewers bandwidth and at the same time to 
>>> offer a path for onboarding new core maintainers (contributor => Triage => 
>>> Write permissions).
>>>
>>> What I suggest to do:
>>>
>>>- Introduce a new jenkinsci/core-pr-reviewers team
>>>- Grant the team TRIAGE permission in  
>>>https://github.com/jenkinsci/jenkins
>>>- Maybe?: Add CODEOWNERS to GitHub to automatically request reviews 
>>>from the new team for new pull requests
>>>- Invite contributors who regularly review Jenkins core pull 
>>>requests: alecharp , varyvol 
>>>, MarkEWaite 
>>>, res0nance 
>>>, jvz , 
>>>MRamonLeon, halkeye  (sorry if I missed 
>>>anyone!)
>>>
>>> If the approach works well, later we can expand it to components which 
>>> are a part of the Jenkins core (libraries, modules, etc.).
>>>
>>> What do you think?
>>>
>>> Best regards,
>>> Oleg
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/cebb15af-35ec-41f6-929d-c2cc8c5a73d0%40googlegroups.com.


Re: Proposal: Jenkins Core PR reviewers team

2019-09-20 Thread Oleg Nenashev
Thanks Raihaan and Gavin!

I did not add people to the group without explicit consent, but I have 
added you taking the feedback here.
So we have officially added 9 more reviewers to the Core, and it at least 
doubles our review capacity there.
Thanks all!

P.S: We also have https://github.com/orgs/jenkinsci/teams/code-reviewers/ for 
general review pings and 
https://github.com/orgs/jenkinsci/teams/hacktoberfest/ for the 
Hacktoberfest reviews.
If someone is interested, please feel free to send a join request to these 
teams.

Best regards,
Oleg

On Friday, September 20, 2019 at 9:27:25 PM UTC+2, Gavin Mogan wrote:

> Doesnt look like I'm on the team afterall
>
> I think this is a great idea.
>
> I'm taking night school so I don't know how much I can help, but I will at 
> least be up.gor helping reviewing during hacktober at the very least.
>
> Gavin
>
> On Fri., Sep. 20, 2019, 2:56 a.m. Olblak, > 
> wrote:
>
>> \o/
>>
>> ---
>> -> gpg --keyserver keys.gnupg.net --recv-key 52210D3D
>> ---
>>
>>
>>
>>
>> On Fri, Sep 20, 2019, at 11:23 AM, Raihaan Shouhell wrote:
>>
>> I'd be keen on this +1
>>
>> On Thursday, 19 September 2019 19:26:46 UTC+8, Oleg Nenashev wrote:
>>
>> Hi all,
>>
>> I would like to make a proposal w.r.t the Jenkins Core review process. 
>>
>> As you may see from the pull requests 
>> , currently we have a pretty 
>> heavy process which includes multiple reviews, labeling PRs for automatic 
>> changelog drafts, and so on. This process helps us to maintain high quality 
>> of weekly releases. Over the last year we have had many contributors who 
>> helped to review core pull requests on a regular basis. These contributors 
>> do not have WRITE permission in the repo, and they had no way no assign 
>> labels, request reviews, re-trigger CI, and so on. Only jenkinsci/Core 
>> members have permission to do that, and it is a serious overhead since we 
>> do not have many active core maintainers in jenkinsci/Core looking at PRs.
>>
>> Few months ago GitHub introduced a new TRIAGE 
>> 
>>  permission 
>> for the repository which basically gives permissions to manage issues/pull 
>> requests without being actually able to merge them. IMO it gives us a great 
>> opportunity to expand the core reviewers bandwidth and at the same time to 
>> offer a path for onboarding new core maintainers (contributor => Triage => 
>> Write permissions).
>>
>> What I suggest to do:
>>
>>- Introduce a new jenkinsci/core-pr-reviewers team
>>- Grant the team TRIAGE permission in  
>>https://github.com/jenkinsci/jenkins
>>- Maybe?: Add CODEOWNERS to GitHub to automatically request reviews 
>>from the new team for new pull requests
>>- Invite contributors who regularly review Jenkins core pull 
>>requests: alecharp , varyvol 
>>, MarkEWaite 
>>, res0nance 
>>, jvz , 
>>MRamonLeon, halkeye  (sorry if I missed 
>>anyone!)
>>
>> If the approach works well, later we can expand it to components which 
>> are a part of the Jenkins core (libraries, modules, etc.).
>>
>> What do you think?
>>
>> Best regards,
>> Oleg
>>
>>
>>
>>
>>
>>
>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkin...@googlegroups.com .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/191d48e2-1898-4266-8c39-0b2465bef2d9%40googlegroups.com
>>  
>> 
>> .
>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkin...@googlegroups.com .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/3f07d55f-dc0e-4c1d-8fee-3a8016ef7d03%40www.fastmail.com
>>  
>> 
>> .
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/85e026ee-fb54-47b5-83a5-354035e6f8d5%40googlegroups.com.


Re: Proposal: Jenkins Core PR reviewers team

2019-09-20 Thread Gavin
Doesnt look like I'm on the team afterall

I think this is a great idea.

I'm taking night school so I don't know how much I can help, but I will at
least be up.gor helping reviewing during hacktober at the very least.

Gavin

On Fri., Sep. 20, 2019, 2:56 a.m. Olblak,  wrote:

> \o/
>
> ---
> -> gpg --keyserver keys.gnupg.net --recv-key 52210D3D
> ---
>
>
>
>
> On Fri, Sep 20, 2019, at 11:23 AM, Raihaan Shouhell wrote:
>
> I'd be keen on this +1
>
> On Thursday, 19 September 2019 19:26:46 UTC+8, Oleg Nenashev wrote:
>
> Hi all,
>
> I would like to make a proposal w.r.t the Jenkins Core review process.
>
> As you may see from the pull requests
> , currently we have a pretty
> heavy process which includes multiple reviews, labeling PRs for automatic
> changelog drafts, and so on. This process helps us to maintain high quality
> of weekly releases. Over the last year we have had many contributors who
> helped to review core pull requests on a regular basis. These contributors
> do not have WRITE permission in the repo, and they had no way no assign
> labels, request reviews, re-trigger CI, and so on. Only jenkinsci/Core
> members have permission to do that, and it is a serious overhead since we
> do not have many active core maintainers in jenkinsci/Core looking at PRs.
>
> Few months ago GitHub introduced a new TRIAGE
> 
>  permission
> for the repository which basically gives permissions to manage issues/pull
> requests without being actually able to merge them. IMO it gives us a great
> opportunity to expand the core reviewers bandwidth and at the same time to
> offer a path for onboarding new core maintainers (contributor => Triage =>
> Write permissions).
>
> What I suggest to do:
>
>- Introduce a new jenkinsci/core-pr-reviewers team
>- Grant the team TRIAGE permission in
>https://github.com/jenkinsci/jenkins
>- Maybe?: Add CODEOWNERS to GitHub to automatically request reviews
>from the new team for new pull requests
>- Invite contributors who regularly review Jenkins core pull requests:
>alecharp , varyvol
>, MarkEWaite
>, res0nance
>, jvz ,
>MRamonLeon, halkeye  (sorry if I missed
>anyone!)
>
> If the approach works well, later we can expand it to components which are
> a part of the Jenkins core (libraries, modules, etc.).
>
> What do you think?
>
> Best regards,
> Oleg
>
>
>
>
>
>
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/191d48e2-1898-4266-8c39-0b2465bef2d9%40googlegroups.com
> 
> .
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/3f07d55f-dc0e-4c1d-8fee-3a8016ef7d03%40www.fastmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_Duv-mpC_5F%2B5eoW3r2jvg5yO0VPiOh2zudLRq%2BN742AkPA%40mail.gmail.com.


Re: Proposal: Jenkins Core PR reviewers team

2019-09-20 Thread Olblak
\o/

---
-> gpg --keyserver keys.gnupg.net --recv-key 52210D3D
---




On Fri, Sep 20, 2019, at 11:23 AM, Raihaan Shouhell wrote:
> I'd be keen on this +1
> 
> On Thursday, 19 September 2019 19:26:46 UTC+8, Oleg Nenashev wrote:
>> Hi all,
>> 
>> I would like to make a proposal w.r.t the Jenkins Core review process. 
>> 
>> As you may see from the pull requests 
>> , currently we have a pretty 
>> heavy process which includes multiple reviews, labeling PRs for automatic 
>> changelog drafts, and so on. This process helps us to maintain high quality 
>> of weekly releases. Over the last year we have had many contributors who 
>> helped to review core pull requests on a regular basis. These contributors 
>> do not have WRITE permission in the repo, and they had no way no assign 
>> labels, request reviews, re-trigger CI, and so on. Only jenkinsci/Core 
>> members have permission to do that, and it is a serious overhead since we do 
>> not have many active core maintainers in jenkinsci/Core looking at PRs.
>> 
>> Few months ago GitHub introduced a new TRIAGE 
>> 
>>  permission for the repository which basically gives permissions to manage 
>> issues/pull requests without being actually able to merge them. IMO it gives 
>> us a great opportunity to expand the core reviewers bandwidth and at the 
>> same time to offer a path for onboarding new core maintainers (contributor 
>> => Triage => Write permissions).
>> 
>> What I suggest to do:
>>  * Introduce a new jenkinsci/core-pr-reviewers team
>>  * Grant the team TRIAGE permission in https://github.com/jenkinsci/jenkins
>>  * Maybe?: Add CODEOWNERS to GitHub to automatically request reviews from 
>> the new team for new pull requests
>>  * Invite contributors who regularly review Jenkins core pull requests: 
>> alecharp , varyvol 
>> , MarkEWaite , 
>> res0nance , jvz , 
>> MRamonLeon , halkeye  (sorry 
>> if I missed anyone!)
>> If the approach works well, later we can expand it to components which are a 
>> part of the Jenkins core (libraries, modules, etc.).
>> 
>> What do you think?
>> 
>> Best regards,
>> Oleg
>> 
>> 
>> 
>> 
>> 
>> 
>> 
> 

> --
>  You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
>  To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>  To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/191d48e2-1898-4266-8c39-0b2465bef2d9%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/3f07d55f-dc0e-4c1d-8fee-3a8016ef7d03%40www.fastmail.com.


Re: Proposal: Jenkins Core PR reviewers team

2019-09-20 Thread Raihaan Shouhell
I'd be keen on this +1

On Thursday, 19 September 2019 19:26:46 UTC+8, Oleg Nenashev wrote:
>
> Hi all,
>
> I would like to make a proposal w.r.t the Jenkins Core review process. 
>
> As you may see from the pull requests 
> , currently we have a pretty 
> heavy process which includes multiple reviews, labeling PRs for automatic 
> changelog drafts, and so on. This process helps us to maintain high quality 
> of weekly releases. Over the last year we have had many contributors who 
> helped to review core pull requests on a regular basis. These contributors 
> do not have WRITE permission in the repo, and they had no way no assign 
> labels, request reviews, re-trigger CI, and so on. Only jenkinsci/Core 
> members have permission to do that, and it is a serious overhead since we 
> do not have many active core maintainers in jenkinsci/Core looking at PRs.
>
> Few months ago GitHub introduced a new TRIAGE 
> 
>  permission 
> for the repository which basically gives permissions to manage issues/pull 
> requests without being actually able to merge them. IMO it gives us a great 
> opportunity to expand the core reviewers bandwidth and at the same time to 
> offer a path for onboarding new core maintainers (contributor => Triage => 
> Write permissions).
>
> What I suggest to do:
>
>- Introduce a new jenkinsci/core-pr-reviewers team
>- Grant the team TRIAGE permission in  
>https://github.com/jenkinsci/jenkins
>- Maybe?: Add CODEOWNERS to GitHub to automatically request reviews 
>from the new team for new pull requests
>- Invite contributors who regularly review Jenkins core pull requests: 
>alecharp , varyvol 
>, MarkEWaite 
>, res0nance 
>, jvz , 
>MRamonLeon, halkeye  (sorry if I missed 
>anyone!)
>
> If the approach works well, later we can expand it to components which are 
> a part of the Jenkins core (libraries, modules, etc.).
>
> What do you think?
>
> Best regards,
> Oleg
>
>
>
>
>
>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/191d48e2-1898-4266-8c39-0b2465bef2d9%40googlegroups.com.


Re: Proposal: Jenkins Core PR reviewers team

2019-09-20 Thread Oleg Nenashev
Thanks to all for the feedback!
I have created the team: 
https://github.com/orgs/jenkinsci/teams/core-pr-reviewers
Please let me know if it works for you.

Best regards,
Oleg


On Friday, September 20, 2019 at 10:18:04 AM UTC+2, Tim Jacomb wrote:
>
> I would be interested in joining this team
>
> On Thursday, 19 September 2019 12:26:46 UTC+1, Oleg Nenashev wrote:
>>
>> Hi all,
>>
>> I would like to make a proposal w.r.t the Jenkins Core review process. 
>>
>> As you may see from the pull requests 
>> , currently we have a pretty 
>> heavy process which includes multiple reviews, labeling PRs for automatic 
>> changelog drafts, and so on. This process helps us to maintain high quality 
>> of weekly releases. Over the last year we have had many contributors who 
>> helped to review core pull requests on a regular basis. These contributors 
>> do not have WRITE permission in the repo, and they had no way no assign 
>> labels, request reviews, re-trigger CI, and so on. Only jenkinsci/Core 
>> members have permission to do that, and it is a serious overhead since we 
>> do not have many active core maintainers in jenkinsci/Core looking at PRs.
>>
>> Few months ago GitHub introduced a new TRIAGE 
>> 
>>  permission 
>> for the repository which basically gives permissions to manage issues/pull 
>> requests without being actually able to merge them. IMO it gives us a great 
>> opportunity to expand the core reviewers bandwidth and at the same time to 
>> offer a path for onboarding new core maintainers (contributor => Triage => 
>> Write permissions).
>>
>> What I suggest to do:
>>
>>- Introduce a new jenkinsci/core-pr-reviewers team
>>- Grant the team TRIAGE permission in  
>>https://github.com/jenkinsci/jenkins
>>- Maybe?: Add CODEOWNERS to GitHub to automatically request reviews 
>>from the new team for new pull requests
>>- Invite contributors who regularly review Jenkins core pull 
>>requests: alecharp , varyvol 
>>, MarkEWaite 
>>, res0nance 
>>, jvz , 
>>MRamonLeon, halkeye  (sorry if I missed 
>>anyone!)
>>
>> If the approach works well, later we can expand it to components which 
>> are a part of the Jenkins core (libraries, modules, etc.).
>>
>> What do you think?
>>
>> Best regards,
>> Oleg
>>
>>
>>
>>
>>
>>
>>
>>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/4ab8d12a-b90f-4a45-99b2-d0d5ce89de85%40googlegroups.com.


Re: Proposal: Jenkins Core PR reviewers team

2019-09-20 Thread Tim Jacomb
I would be interested in joining this team

On Thursday, 19 September 2019 12:26:46 UTC+1, Oleg Nenashev wrote:
>
> Hi all,
>
> I would like to make a proposal w.r.t the Jenkins Core review process. 
>
> As you may see from the pull requests 
> , currently we have a pretty 
> heavy process which includes multiple reviews, labeling PRs for automatic 
> changelog drafts, and so on. This process helps us to maintain high quality 
> of weekly releases. Over the last year we have had many contributors who 
> helped to review core pull requests on a regular basis. These contributors 
> do not have WRITE permission in the repo, and they had no way no assign 
> labels, request reviews, re-trigger CI, and so on. Only jenkinsci/Core 
> members have permission to do that, and it is a serious overhead since we 
> do not have many active core maintainers in jenkinsci/Core looking at PRs.
>
> Few months ago GitHub introduced a new TRIAGE 
> 
>  permission 
> for the repository which basically gives permissions to manage issues/pull 
> requests without being actually able to merge them. IMO it gives us a great 
> opportunity to expand the core reviewers bandwidth and at the same time to 
> offer a path for onboarding new core maintainers (contributor => Triage => 
> Write permissions).
>
> What I suggest to do:
>
>- Introduce a new jenkinsci/core-pr-reviewers team
>- Grant the team TRIAGE permission in  
>https://github.com/jenkinsci/jenkins
>- Maybe?: Add CODEOWNERS to GitHub to automatically request reviews 
>from the new team for new pull requests
>- Invite contributors who regularly review Jenkins core pull requests: 
>alecharp , varyvol 
>, MarkEWaite 
>, res0nance 
>, jvz , 
>MRamonLeon, halkeye  (sorry if I missed 
>anyone!)
>
> If the approach works well, later we can expand it to components which are 
> a part of the Jenkins core (libraries, modules, etc.).
>
> What do you think?
>
> Best regards,
> Oleg
>
>
>
>
>
>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/1458d898-d647-47b1-8d03-3021d361eef8%40googlegroups.com.


Re: Proposal: Jenkins Core PR reviewers team

2019-09-19 Thread Baptiste Mathus
+1 great idea, and feature indeed.
Thanks a lot Oleg

Le jeu. 19 sept. 2019 à 23:14, Oleg Nenashev  a
écrit :

> Looks like we have a consensus here. I will proceed with the change
> tomorrow if no negative feedback
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/a5fe6214-7fb5-44a2-8ec2-9b53c6dd629c%40googlegroups.com
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS6evN%2BH74BZiq%2BEK%3DReL8R1RVx4AX6qVGzG8syMHX5kew%40mail.gmail.com.


Re: Proposal: Jenkins Core PR reviewers team

2019-09-19 Thread Oleg Nenashev
Looks like we have a consensus here. I will proceed with the change tomorrow if 
no negative feedback

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/a5fe6214-7fb5-44a2-8ec2-9b53c6dd629c%40googlegroups.com.


Re: Proposal: Jenkins Core PR reviewers team

2019-09-19 Thread Daniel Beck
+1

> On 19. Sep 2019, at 13:26, Oleg Nenashev  wrote:
> 
> Hi all,
> 
> I would like to make a proposal w.r.t the Jenkins Core review process. 
> 
> As you may see from the pull requests, currently we have a pretty heavy 
> process which includes multiple reviews, labeling PRs for automatic changelog 
> drafts, and so on. This process helps us to maintain high quality of weekly 
> releases. Over the last year we have had many contributors who helped to 
> review core pull requests on a regular basis. These contributors do not have 
> WRITE permission in the repo, and they had no way no assign labels, request 
> reviews, re-trigger CI, and so on. Only jenkinsci/Core members have 
> permission to do that, and it is a serious overhead since we do not have many 
> active core maintainers in jenkinsci/Core looking at PRs.
> 
> Few months ago GitHub introduced a new TRIAGE permission for the repository 
> which basically gives permissions to manage issues/pull requests without 
> being actually able to merge them. IMO it gives us a great opportunity to 
> expand the core reviewers bandwidth and at the same time to offer a path for 
> onboarding new core maintainers (contributor => Triage => Write permissions).
> 
> What I suggest to do:
>   • Introduce a new jenkinsci/core-pr-reviewers team
>   • Grant the team TRIAGE permission in  
> https://github.com/jenkinsci/jenkins
>   • Maybe?: Add CODEOWNERS to GitHub to automatically request reviews 
> from the new team for new pull requests
>   • Invite contributors who regularly review Jenkins core pull requests: 
> alecharp, varyvol, MarkEWaite, res0nance, jvz, MRamonLeon, halkeye (sorry if 
> I missed anyone!)
> If the approach works well, later we can expand it to components which are a 
> part of the Jenkins core (libraries, modules, etc.).
> 
> What do you think?
> 
> Best regards,
> Oleg
> 
> 
> 
> 
> 
> 
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLAypnU_vnh3GB3_DVDD5R2vZePjzvsuGtpvXEQTsyOrjQ%40mail.gmail.com.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/DC096577-39A9-42BC-A1ED-6CBFE8885BC5%40beckweb.net.


Re: Proposal: Jenkins Core PR reviewers team

2019-09-19 Thread Matt Sicker
I like this idea, too.

On Thu, Sep 19, 2019 at 7:09 AM Mark Waite  wrote:
>
> I like the idea very much.  GitHub triage looks like a really nice addition 
> without granting more permissions than necessary.
>
> On Thu, Sep 19, 2019 at 5:58 AM Tim Jacomb  wrote:
>>
>> Sounds good to me
>>
>> On Thu, 19 Sep 2019 at 12:26, Oleg Nenashev  wrote:
>>>
>>> Hi all,
>>>
>>> I would like to make a proposal w.r.t the Jenkins Core review process.
>>>
>>> As you may see from the pull requests, currently we have a pretty heavy 
>>> process which includes multiple reviews, labeling PRs for automatic 
>>> changelog drafts, and so on. This process helps us to maintain high quality 
>>> of weekly releases. Over the last year we have had many contributors who 
>>> helped to review core pull requests on a regular basis. These contributors 
>>> do not have WRITE permission in the repo, and they had no way no assign 
>>> labels, request reviews, re-trigger CI, and so on. Only jenkinsci/Core 
>>> members have permission to do that, and it is a serious overhead since we 
>>> do not have many active core maintainers in jenkinsci/Core looking at PRs.
>>>
>>> Few months ago GitHub introduced a new TRIAGE permission for the repository 
>>> which basically gives permissions to manage issues/pull requests without 
>>> being actually able to merge them. IMO it gives us a great opportunity to 
>>> expand the core reviewers bandwidth and at the same time to offer a path 
>>> for onboarding new core maintainers (contributor => Triage => Write 
>>> permissions).
>>>
>>> What I suggest to do:
>>>
>>> Introduce a new jenkinsci/core-pr-reviewers team
>>> Grant the team TRIAGE permission in  https://github.com/jenkinsci/jenkins
>>> Maybe?: Add CODEOWNERS to GitHub to automatically request reviews from the 
>>> new team for new pull requests
>>> Invite contributors who regularly review Jenkins core pull requests: 
>>> alecharp, varyvol, MarkEWaite, res0nance, jvz, MRamonLeon, halkeye (sorry 
>>> if I missed anyone!)
>>>
>>> If the approach works well, later we can expand it to components which are 
>>> a part of the Jenkins core (libraries, modules, etc.).
>>>
>>> What do you think?
>>>
>>> Best regards,
>>> Oleg
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> --
>>> You received this message because you are subscribed to the Google Groups 
>>> "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an 
>>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLAypnU_vnh3GB3_DVDD5R2vZePjzvsuGtpvXEQTsyOrjQ%40mail.gmail.com.
>>
>> --
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BifMF%2B8X%3D8wG4Pbh4Q8cguSzx2j-RmtUmORmw10MsB7aLw%40mail.gmail.com.
>
>
>
> --
> Thanks!
> Mark Waite
>
> --
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtHVQq%2BdciSsHU0w5jVhrJ%3DYemzUqeERV7-6sCRYASfyuQ%40mail.gmail.com.



-- 
Matt Sicker
Senior Software Engineer, CloudBees

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAEot4oy%2BOUkozcYzErMpUqexxexX9OMx6aYRKaiFzCQcd5dJ9Q%40mail.gmail.com.


Re: Proposal: Jenkins Core PR reviewers team

2019-09-19 Thread Mark Waite
I like the idea very much.  GitHub triage looks like a really nice addition
without granting more permissions than necessary.

On Thu, Sep 19, 2019 at 5:58 AM Tim Jacomb  wrote:

> Sounds good to me
>
> On Thu, 19 Sep 2019 at 12:26, Oleg Nenashev 
> wrote:
>
>> Hi all,
>>
>> I would like to make a proposal w.r.t the Jenkins Core review process.
>>
>> As you may see from the pull requests
>> , currently we have a pretty
>> heavy process which includes multiple reviews, labeling PRs for automatic
>> changelog drafts, and so on. This process helps us to maintain high quality
>> of weekly releases. Over the last year we have had many contributors who
>> helped to review core pull requests on a regular basis. These contributors
>> do not have WRITE permission in the repo, and they had no way no assign
>> labels, request reviews, re-trigger CI, and so on. Only jenkinsci/Core
>> members have permission to do that, and it is a serious overhead since we
>> do not have many active core maintainers in jenkinsci/Core looking at PRs.
>>
>> Few months ago GitHub introduced a new TRIAGE
>> 
>>  permission
>> for the repository which basically gives permissions to manage issues/pull
>> requests without being actually able to merge them. IMO it gives us a great
>> opportunity to expand the core reviewers bandwidth and at the same time to
>> offer a path for onboarding new core maintainers (contributor => Triage =>
>> Write permissions).
>>
>> What I suggest to do:
>>
>>- Introduce a new jenkinsci/core-pr-reviewers team
>>- Grant the team TRIAGE permission in
>>https://github.com/jenkinsci/jenkins
>>- Maybe?: Add CODEOWNERS to GitHub to automatically request reviews
>>from the new team for new pull requests
>>- Invite contributors who regularly review Jenkins core pull
>>requests: alecharp , varyvol
>>, MarkEWaite
>>, res0nance
>>, jvz ,
>>MRamonLeon, halkeye  (sorry if I missed
>>anyone!)
>>
>> If the approach works well, later we can expand it to components which
>> are a part of the Jenkins core (libraries, modules, etc.).
>>
>> What do you think?
>>
>> Best regards,
>> Oleg
>>
>>
>>
>>
>>
>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLAypnU_vnh3GB3_DVDD5R2vZePjzvsuGtpvXEQTsyOrjQ%40mail.gmail.com
>> 
>> .
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BifMF%2B8X%3D8wG4Pbh4Q8cguSzx2j-RmtUmORmw10MsB7aLw%40mail.gmail.com
> 
> .
>


-- 
Thanks!
Mark Waite

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtHVQq%2BdciSsHU0w5jVhrJ%3DYemzUqeERV7-6sCRYASfyuQ%40mail.gmail.com.


Re: Proposal: Jenkins Core PR reviewers team

2019-09-19 Thread Tim Jacomb
Sounds good to me

On Thu, 19 Sep 2019 at 12:26, Oleg Nenashev  wrote:

> Hi all,
>
> I would like to make a proposal w.r.t the Jenkins Core review process.
>
> As you may see from the pull requests
> , currently we have a pretty
> heavy process which includes multiple reviews, labeling PRs for automatic
> changelog drafts, and so on. This process helps us to maintain high quality
> of weekly releases. Over the last year we have had many contributors who
> helped to review core pull requests on a regular basis. These contributors
> do not have WRITE permission in the repo, and they had no way no assign
> labels, request reviews, re-trigger CI, and so on. Only jenkinsci/Core
> members have permission to do that, and it is a serious overhead since we
> do not have many active core maintainers in jenkinsci/Core looking at PRs.
>
> Few months ago GitHub introduced a new TRIAGE
> 
>  permission
> for the repository which basically gives permissions to manage issues/pull
> requests without being actually able to merge them. IMO it gives us a great
> opportunity to expand the core reviewers bandwidth and at the same time to
> offer a path for onboarding new core maintainers (contributor => Triage =>
> Write permissions).
>
> What I suggest to do:
>
>- Introduce a new jenkinsci/core-pr-reviewers team
>- Grant the team TRIAGE permission in
>https://github.com/jenkinsci/jenkins
>- Maybe?: Add CODEOWNERS to GitHub to automatically request reviews
>from the new team for new pull requests
>- Invite contributors who regularly review Jenkins core pull requests:
>alecharp , varyvol
>, MarkEWaite
>, res0nance
>, jvz ,
>MRamonLeon, halkeye  (sorry if I missed
>anyone!)
>
> If the approach works well, later we can expand it to components which are
> a part of the Jenkins core (libraries, modules, etc.).
>
> What do you think?
>
> Best regards,
> Oleg
>
>
>
>
>
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLAypnU_vnh3GB3_DVDD5R2vZePjzvsuGtpvXEQTsyOrjQ%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BifMF%2B8X%3D8wG4Pbh4Q8cguSzx2j-RmtUmORmw10MsB7aLw%40mail.gmail.com.


Re: Proposal: Jenkins Core PR reviewers team

2019-09-19 Thread Marky Jackson
+1 from me

{ 
"regards" : {
 "name" : “marky”,
 "phone" : "+1 (408) 464 2965”,
 "email" : “marky.r.jack...@gmail.com",
 "team" : “jackson5“,
 “role” : “software engineer"
 }
 }

> On Sep 19, 2019, at 4:26 AM, Oleg Nenashev  wrote:
> 
> Hi all,
> 
> I would like to make a proposal w.r.t the Jenkins Core review process. 
> 
> As you may see from the pull requests, currently we have a pretty heavy 
> process which includes multiple reviews, labeling PRs for automatic changelog 
> drafts, and so on. This process helps us to maintain high quality of weekly 
> releases. Over the last year we have had many contributors who helped to 
> review core pull requests on a regular basis. These contributors do not have 
> WRITE permission in the repo, and they had no way no assign labels, request 
> reviews, re-trigger CI, and so on. Only jenkinsci/Core members have 
> permission to do that, and it is a serious overhead since we do not have many 
> active core maintainers in jenkinsci/Core looking at PRs.
> 
> Few months ago GitHub introduced a new TRIAGE permission for the repository 
> which basically gives permissions to manage issues/pull requests without 
> being actually able to merge them. IMO it gives us a great opportunity to 
> expand the core reviewers bandwidth and at the same time to offer a path for 
> onboarding new core maintainers (contributor => Triage => Write permissions).
> 
> What I suggest to do:
> Introduce a new jenkinsci/core-pr-reviewers team
> Grant the team TRIAGE permission in  https://github.com/jenkinsci/jenkins
> Maybe?: Add CODEOWNERS to GitHub to automatically request reviews from the 
> new team for new pull requests
> Invite contributors who regularly review Jenkins core pull requests: 
> alecharp, varyvol, MarkEWaite, res0nance, jvz, MRamonLeon, halkeye (sorry if 
> I missed anyone!)
> If the approach works well, later we can expand it to components which are a 
> part of the Jenkins core (libraries, modules, etc.).
> 
> What do you think?
> 
> Best regards,
> Oleg
> 
> 
> 
> 
> 
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLAypnU_vnh3GB3_DVDD5R2vZePjzvsuGtpvXEQTsyOrjQ%40mail.gmail.com.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/681846C1-89AD-423E-BD7D-E9F171A8DFB7%40gmail.com.