Well, and this is purely from a if I were the plugin maintainer would I
merge this PoV:
* Your pull request includes changes that are not relevant to fixing the
issue (e.g. upping the versions of some plugins and other stuff in the
pom.xml)... these may be good changes, but they are not related to the
issue. Best practice is to split out these other changes into a different
pull request if you think they are good. (Unless they are necessary for the
fix... but it doesn't look like that to me) [your fix looks like 3 lines
plus some test case adjustment:
https://github.com/jenkinsci/ccm-plugin/pull/1/files#L1R91]
* Pay attention to line ending changes... this can make it hard to figure
out what the actual difference is, e.g.
https://github.com/jenkinsci/ccm-plugin/pull/1/files#L2L1 could be leaving
the file unchanged or it could be making radical changes... if you can
reformat the changes so that the line ending style in the repository is
preserved this will make a nicer pull request... (The same goes for
maintaining whatever crappy code style the original code is in... unless
you are making a pull request to fix up the code style everywhere... in
this case you have maintained the code style, but just pointing out that
this is in the same bucket)
If you addressed those two issues, then I suspect your pull request will
look nice, simple and *low risk* to merge which will give the maintainer no
excuses ;-)
On 10 July 2013 11:28, Louis Henry Nayegon louis.henry.naye...@gmail.comwrote:
Hi,
Having just read this
https://wiki.jenkins-ci.org/display/JENKINS/Pull+Request+to+RepositoriesI
though it was about time I got in contact with someone.
I have been waiting months for this pull request
https://github.com/jenkinsci/ccm-plugin/pull/1
The change is quite simple and I would of though it would be released by
now.
What can I do ?
Regards
Louis
--
You received this message because you are subscribed to the Google Groups
Jenkins Developers group.
To unsubscribe from this group and stop receiving emails from it, send an
email to jenkinsci-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
--
You received this message because you are subscribed to the Google Groups
Jenkins Developers group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
