Re: Use case for testing the triggerIfResult functionality (NodeLabelParameter plugin)

2014-05-18 Thread Martin Ende
Hi Oliver,
thanks for this quick response. I published a runable test in

https://github.com/uhafner/acceptance-test-harness/pull/30

As I already mentioned in my PR comment my assumption is that the
NodeLabelParameter plugin's triggerIfResult functionality only considers
the main build action. I didn't care about the difference between main
build action result and the job result before because I did a lot of trials
manually with a local jenkins installation before writing the test. Now,
having the test running I noticed the console output  *INFO:
frequent_trial #1 main build action completed: SUCCESS *during the test
which may be an explanation why the failed build is not considered.

The main question is: How can I simulate a build on a dumb slave which
fails for the main build action? This would be necessary to proof my
assumption that the triggerIfResult setting would work as designed for the
main build action. Nevertheless, I think if my assumption is correct, this
should result in a bug report then.

--
Martin


2014-05-17 8:33 GMT+02:00 oliver gondža ogon...@gmail.com:

 Thanks for the test you have already created. Can you publish what you
 have in a PR, so we can discuss actual code?

 --
 oliver


-- 
You received this message because you are subscribed to the Google Groups 
Jenkins Developers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Use case for testing the triggerIfResult functionality (NodeLabelParameter plugin)

2014-05-17 Thread oliver gondža
Thanks for the test you have already created. Can you publish what you  
have in a PR, so we can discuss actual code?


--
oliver

--
You received this message because you are subscribed to the Google Groups Jenkins 
Developers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Use case for testing the triggerIfResult functionality (NodeLabelParameter plugin)

2014-05-16 Thread Martin Ende
I'm currently working on further acceptance tests for the 
NodeLabelParameter plugin within the scope of U. Hafners student projects.
At the moment I'm struggling to define a valid use case to test the 
triggerIfResult options (run next build only if build succeeds, etc.) of 
the plugin. 

I tried to set up a freestyle job parameterized with a node parameter (no 
default node, no node restriction, next build triggered only if build 
succeeds and node eligibility set to all nodes). To simulate failed or 
unstable builds I use the text-finder plugin as post build action. The 
particular slave the job shall be build on contains a text file in its 
workspace which causes the plugin to mark the build as failed or unstable.
I built the job on multiple (dumb) slaves which were prepared to get a 
failed result. My expectation was that as the first build is failed the 
other builds won't start. But I always get builds on all slaves.

It would be helpful to know in which case those triggerIfResult options are 
evaluated and whether I need to add further settings, parameters and / or 
post build actions to the job. Or may be the text-finder plugin is not the 
appropriate way to simulate failed builds. I'm open to alternative 
suggestions.

--
Martin

-- 
You received this message because you are subscribed to the Google Groups 
Jenkins Developers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.