[JIRA] (JENKINS-58504) P4 Plugin tries to make depot location of Jenkinsfile available regardless of SCM type
Title: Message Title Aaron Ling created an issue Jenkins / JENKINS-58504 P4 Plugin tries to make depot location of Jenkinsfile available regardless of SCM type Issue Type: Bug Assignee: Unassigned Components: p4-plugin Created: 2019-07-15 23:53 Environment: Jenkins ver. 2.176.1 P4 Plugin v 1.10.2 Priority: Minor Reporter: Aaron Ling https://github.com/jenkinsci/p4-plugin/blob/master/src/main/java/org/jenkinsci/plugins/p4/PerforceScm.java#L545 This code was added to address JENKINS-39107. We have a use-case where our jobs use lightweight checkout to load build scripts from gitlab, but the Jenkinsfiles themselves checkout from p4 to get the actual code that we build. The added code then tries to run 'p4 where' on the Jenkinsfile, but it doesn't exist in p4. This doesn't cause any build failures, but does print the following message: 16:26:55 (p4):cmd:... p4 where E:\workspace\folder\to\Jenkinsfile.groovy 16:26:55 p4 where E:\workspace\folder\to\Jenkinsfile.groovy 16:26:55 E:\workspace\folder\to\Jenkinsfile.groovy - file(s) not in client view. which causes our failure tracking to erroneously pick it up (because it's a legitimate failure at times in other cases).
[JIRA] (JENKINS-38508) git scm poll doesn't ignore changes with pipeline
Title: Message Title Aaron Ling commented on JENKINS-38508 Re: git scm poll doesn't ignore changes with pipeline I hit this issue as well. Setting changelog to false and restarting Jenkins seems to bypass the issue. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51048) Setting workspace type to 'READONLY' doesn't work with servers running < 2017.1
Title: Message Title Aaron Ling updated an issue Jenkins / JENKINS-51048 Setting workspace type to 'READONLY' doesn't work with servers running < 2017.1 Change By: Aaron Ling Summary: Setting workspace type to 'READONLY' doesn't work for with servers running < 2017.1 Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-51048) Setting workspace type to 'READONLY' doesn't work for servers running < 2017.1
Title: Message Title
Aaron Ling created an issue
Jenkins / JENKINS-51048
Setting workspace type to 'READONLY' doesn't work for servers running < 2017.1
Issue Type:
Bug
Assignee:
Unassigned
Components:
p4-plugin
Created:
2018-04-30 18:46
Environment:
P4 Plugin 1.8.9 p4 server 2016.2 Jenkins Enterprise 2.89.4.2-rolling
Priority:
Minor
Reporter:
Aaron Ling
I’m trying to implement readonly workspaces on one of our servers, which is running 2016.2. Readonly workspaces were introduced in 2015.2, so as expected, I can create them manually. However, if I go through the plugin, the workspace type is blank. I’ve uncovered this is because of a couple of if statements that restrict setting workspace type to server versions 2017.1 or later: In src\main\java\org\jenkinsci\plugins\p4\workspace\ManualWorkspaceImpl.java (Line 112) if (connection.getServerVersionNumber() >= 20171) { WorkspaceSpecType type = parseClientType(getSpec().getType()); implClient.setType(type.getId()); } [...] (Line 149) if (connection.getServerVersionNumber() >= 20171) { WorkspaceSpecType type = parseClientType(getSpec().getType()); [...] } I created a custom version of the plugin that replaces 20171 in both if statements with 20162, and everything works as expected – workspaces created through the plugin are correctly set as ‘READONLY’. The changes were added in this commit: https://github.com/jenkinsci/p4-plugin/commit/91e3a3c8284d2bb84061f1afe2d16f63aeb95ee7 for JENKINS-39753
