[JIRA] (JENKINS-58340) docker-plugin-1.1.6 docker cloud does not work with >=ssh-slaves-plugin-1.30.0
Title: Message Title Alon Bar-Lev created an issue Jenkins / JENKINS-58340 docker-plugin-1.1.6 docker cloud does not work with >=ssh-slaves-plugin-1.30.0 Issue Type: Improvement Assignee: Nicolas De Loof Components: docker-plugin, ssh-slaves-plugin Created: 2019-07-04 08:44 Environment: Regression: SSH Slaves 1.30.0 Good:: SSH Slaves 1.29.4 Docker plugin: 1.1.6 Labels: regression Priority: Major Reporter: Alon Bar-Lev When using docker plugin With docker cloud With Docker agent template of connect method "Connect with SSH" and with "Inject SSH key". Everything is working nicely with SSH Slaves 1.29.4 and breaks in SSH Slaves 1.30.0. The docker slave is running but the jenkins is not succeeding in opening the SSH channel. Add Comment
[JIRA] (JENKINS-54505) Expose plugin manager to groovy
Title: Message Title Alon Bar-Lev created an issue Jenkins / JENKINS-54505 Expose plugin manager to groovy Issue Type: Improvement Assignee: Unassigned Components: workflow-cps-plugin Created: 2018-11-06 23:28 Priority: Minor Reporter: Alon Bar-Lev I am sorry if this is not the right component. It is important for a generic groovy script to detect installed plugins so it can operate based on the availability of plugins. I could not find any option to do so, even the binding.hasVariable and getMetaClass are blocked, so detection of symbols in current scope is probably blocked. It will be nice if this.hasVariable can be enabled to detect steps/methods/variables, or at least have a way to query what plugins are installed, for example getPlugins which return a dictionary of plugin with its version. I found some references of people require the same, however, I could not see if/where a bug was opened, so I am sorry if this is a duplicate. Thanks! Add Comment
[JIRA] (JENKINS-27873) Gerrit trigger to support custom labels
Title: Message Title Alon Bar-Lev commented on JENKINS-27873 Re: Gerrit trigger to support custom labels Hi, I worked around the issue by disabling use of restapi and provide custom commands for the ssh, losing the event stream. I would like to believe that sending Verified or a different label should be trivial to do, please consider to prioritize. Thanks! Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-54224) Rework all json construction
Title: Message Title Alon Bar-Lev started work on JENKINS-54224 Change By: Alon Bar-Lev Status: Open In Progress Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-54224) Rework all json construction
Title: Message Title Alon Bar-Lev updated JENKINS-54224 Jenkins / JENKINS-54224 Rework all json construction Change By: Alon Bar-Lev Status: In Progress Review Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-54224) Rework all json construction
Title: Message Title Alon Bar-Lev updated an issue Jenkins / JENKINS-54224 Rework all json construction Change By: Alon Bar-Lev URL: https://github.com/jenkinsci/gerrit-code-review-plugin/pull/24 Labels: patch Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-54224) Rework all json construction
Title: Message Title Alon Bar-Lev commented on JENKINS-54224 Re: Rework all json construction there is no need to use custom serialization as the gerrit api is perfectly capable of doing everything. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-50586) SSH support
Title: Message Title Alon Bar-Lev commented on JENKINS-50586 Re: SSH support This is important for proper authentication, the http is weak and problematic. Thanks! Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-54224) Rework all json construction
Title: Message Title
Alon Bar-Lev created an issue
Jenkins / JENKINS-54224
Rework all json construction
Issue Type:
Bug
Assignee:
lucamilanesio
Components:
gerrit-code-review-plugin
Created:
2018-10-24 15:01
Priority:
Major
Reporter:
Alon Bar-Lev
Hi, While going over the code I noticed that you use string construction for json requests to gerrit. This is highly risky as users may put special characters within the variables and alter the request to gain access to other functionality the user is authorized. For example message="\", something=\"xxx" will add 'something' to the json as own field. The code must be refactored to use jackson or any json serialization that handles proper escaping. Jackson support pojos and serialize into json, the pojo can be a simple map of Map if you do not want to have pojo per use case. Then use mapper.writeValueAsString(pojo) to construct json.
@JsonInclude(JsonInclude.Include.NON_NULL)
class C {
@JsonProperty
String property1;
@JsonProperty
String property2;
};
ObjectMapper mapper = new ObjectMapper();
C c1 = new C();
c1.property1 = "value1";
String json = mapper.writeValueasString(c1); // request
C c2 = mapper.readValue(json, C.class) // response
[JIRA] (JENKINS-50783) Support file based comments
Title: Message Title Alon Bar-Lev commented on JENKINS-50783 Re: Support file based comments One minor comment I wanted to add to github but it seems to be dead. Maybe I do not understand the logic... The default label cannot be verified as it will impact the previous settings, for example: gerritComment label: CI-Static, score:1, message: 'Static analysis was passed' gerritComment path:'path/to/file', line: 10, message: 'invalid syntax' Or: gerritComment score:1, message: 'ok' gerritComment path:'path/to/file', line: 10, message: 'invalid syntax' Or even: gerritComment score:1, message: 'ok' gerritComment message: 'I have more to say' In all cases the verified label will be modified by the last gerritComment invocation which is not expected. Options: Have null as default label, this allows differentiate between intentional and non intentional. Split the gerritComment into two commands, one to control the commit and one to control the file based comments, however even in this situation adding plain messages should be handled somehow, so back to (1). Thanks! Add Comment
[JIRA] (JENKINS-50783) Support file based comments
Title: Message Title Alon Bar-Lev commented on JENKINS-50783 Re: Support file based comments That's great! I've read the documentation, and it looks nice, the use of draft and publish one time is good idea. The problem is that from documentation I do not understand how to install the plugin and if the current gerrit trigger plugin is required or not to trigger the job, I would like to remove the current plugin if possible. I also do not understand what component will eventually submit the draft comments. As there is no closure, I am unsure how a job which was not directly triggered can comment, for example, I have CI which runs only integration tests, it is not triggered directly from the review, but is aware of the review and like to put comments. I guess all the above are installation related and not per this specific feature. Thanks! Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-53563) RegistryKeyMaterialFactory should support multiple credentials
Title: Message Title
Alon Bar-Lev created an issue
Jenkins / JENKINS-53563
RegistryKeyMaterialFactory should support multiple credentials
Issue Type:
Bug
Assignee:
Unassigned
Components:
docker-commons-plugin
Created:
2018-09-13 15:47
Environment:
master
Priority:
Major
Reporter:
Alon Bar-Lev
Hello, We have a process that fetches a file from one repo then push to different repository.
dir('docker') {
docker.withRegistry(BASE_IMAGE_REGISTRY_URL, BASE_IMAGE_REGISTRY_JENKINS,) {
docker.withRegistry(LOCAL_REGISTRY_URL, LOCAL_REGISTRY_JENKINS,) {
stage("package/docker") {
sh([script: 'make'])
}
}
}
}
We have discovered that the docker.withRegistry create a new `DOCKER_CONFIG` for each docker.withRegistry and traced it to `org.jenkinsci.plugins.docker.commons.impl.RegistryKeyMaterialFactory`. Per each materialize() there is unconditional call to `createSecretsDirectory()` which loses loses the credentials in previous block. In this implementation only a single docker registry may be authenticated, while docker supports many. Suggested implementation:
Do not create new secrets directory if already exist, it can be checked via the `DOCKER_CONFIG` variable. Maybe force first time creation within the entire instance to i
[JIRA] (JENKINS-50783) Support file based comments
Title: Message Title
Alon Bar-Lev created an issue
Jenkins / JENKINS-50783
Support file based comments
Issue Type:
Improvement
Assignee:
lucamilanesio
Components:
gerrit-code-review-plugin
Created:
2018-04-13 06:51
Priority:
Major
Reporter:
Alon Bar-Lev
Hi, It would be super great to be able to submit a file based (given file + lineno) comments and not only change comments. This will enable to make use of gerrit as frontend for managing warnings/errors of build, static code analysis (such as sonar or style) etc... As far as I imagine there can be two ways to perform this: 1. The simple - have an optional array of [ {file, lineno, comment} ] provided to the current API. 2. The cool - use a transaction syntax such as:
Unable to find source-code formatter for language: groovy. Available languages are: actionscript, html, java, _javascript_, none, sql, xhtml, xml
withGerritReview() {
gerritAddComment("file1", 12, "bla bla")
gerritAddComment("file2", 44, "bla bla sdf")
gerritSetFlag("Code-Review", "+1")
}
Please also keep in mind parallel work. I could not understand how the magic of triggering is working due to lack of documentation, however, if a parallel job is invoked it should share the context/state of the parent job so that the parallel job can also add its information, two options here as well: 1. The simple - parallel job has its own comments, share is only the change information, can be given as standard job parameters. 2. The super-cool - the parallel job, if
