[JIRA] (JENKINS-57298) List View Column (Core)

2019-05-02 Thread andr...@reiser.fun (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Andreas Reiser assigned an issue to Andreas Reiser  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-57298  
 
 
  List View Column (Core)   
 

  
 
 
 
 

 
Change By: 
 Andreas Reiser  
 
 
Assignee: 
 Andreas Reiser  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-57277) Source Code View

2019-05-02 Thread andr...@reiser.fun (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Andreas Reiser assigned an issue to Andreas Reiser  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-57277  
 
 
  Source Code View   
 

  
 
 
 
 

 
Change By: 
 Andreas Reiser  
 
 
Assignee: 
 Andreas Reiser  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56714) Add unit tests for IssuesChartPortlet

2019-04-10 Thread andr...@reiser.fun (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Andreas Reiser commented on  JENKINS-56714  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Add unit tests for IssuesChartPortlet   
 

  
 
 
 
 

 
 Seems like this is another class that's pretty hard to test. I'm not sure how exactly I can stub a history of builds to generate the chart and the _expression_ in the class itself is hard to debug due to streams. I'm not sure how to proceed because I can't really tell what is expected.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56718) Add unit tests for BlameFactory

2019-04-03 Thread andr...@reiser.fun (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Andreas Reiser commented on  JENKINS-56718  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Add unit tests for BlameFactory   
 

  
 
 
 
 

 
 Actually I think I can do it without an extra argument. I just noticed the @VisibleForTesting annotation and will use that to prevent public API changes, but I still need to change the original class a bit.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56718) Add unit tests for BlameFactory

2019-04-03 Thread andr...@reiser.fun (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Andreas Reiser commented on  JENKINS-56718  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Add unit tests for BlameFactory   
 

  
 
 
 
 

 
 I have trouble testing this class because it invokes calls to JenkinsFacade that try to access the jenkins instance (which is null and leads to NullPointerExceptions in tests). Is it ok to refactor the createBlamer() method so that the JenkinsFacade gets passed as an argument and can be mocked? Otherwise there is no possibility of unit testing this class.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56714) Add unit tests for IssuesChartPortlet

2019-04-03 Thread andr...@reiser.fun (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Andreas Reiser assigned an issue to Andreas Reiser  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-56714  
 
 
  Add unit tests for IssuesChartPortlet   
 

  
 
 
 
 

 
Change By: 
 Andreas Reiser  
 
 
Assignee: 
 Andreas Reiser  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56718) Add unit tests for BlameFactory

2019-04-03 Thread andr...@reiser.fun (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Andreas Reiser assigned an issue to Andreas Reiser  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-56718  
 
 
  Add unit tests for BlameFactory   
 

  
 
 
 
 

 
Change By: 
 Andreas Reiser  
 
 
Assignee: 
 Andreas Reiser  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.