[JIRA] (JENKINS-36121) Github Branch Source plugin trips api rate limit
Title: Message Title Dominic Scheirlinck edited a comment on JENKINS-36121 Re: Github Branch Source plugin trips api rate limit Not sure where the code is, but it looks like this in configuration: !screenshot-1.png|thumbnail! I assume these strings should make it easy to track down :) I've also verified that it's functional, and you get an error logged if the signature is wrong. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36121) Github Branch Source plugin trips api rate limit
Title: Message Title Dominic Scheirlinck edited a comment on JENKINS-36121 Re: Github Branch Source plugin trips api rate limit Not sure where the code is, but it looks like this in configuration: !screenshot-1.png|thumbnail!I assume these strings should make it easy to track down :) Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36121) Github Branch Source plugin trips api rate limit
Title: Message Title Dominic Scheirlinck updated an issue Jenkins / JENKINS-36121 Github Branch Source plugin trips api rate limit Change By: Dominic Scheirlinck Attachment: screenshot-1.png Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36121) Github Branch Source plugin trips api rate limit
Title: Message Title Dominic Scheirlinck commented on JENKINS-36121 Re: Github Branch Source plugin trips api rate limit Not sure where the code is, but it looks like this in configuration: Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36121) Github Branch Source plugin trips api rate limit
Title: Message Title Dominic Scheirlinck edited a comment on JENKINS-36121 Re: Github Branch Source plugin trips api rate limit > bq. github plugin does not support secret validation on webhooks, at least last I checked.No, like I said, it does validate the secret if you provide one. It just doesn't _require_ one, nor allow other plugins to check for the presence of one. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36121) Github Branch Source plugin trips api rate limit
Title: Message Title Dominic Scheirlinck commented on JENKINS-36121 Re: Github Branch Source plugin trips api rate limit > github plugin does not support secret validation on webhooks, at least last I checked. No, like I said, it does validate the secret if you provide one. It just doesn't require one, nor allow other plugins to check for the presence of one. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36121) Github Branch Source plugin trips api rate limit
Title: Message Title Dominic Scheirlinck edited a comment on JENKINS-36121 Re: Github Branch Source plugin trips api rate limit [~michaelneale] Yeah, good summary, I think.What's really necessary, IMO, is some flag/signal/getter from github-api that the signature validation has taken place. Then we can smartly either trust the content of the hook, or if we don't, go out and do some sort of 'single-branch reindexing' head-fetch that only consumes a few API requests. (The validation already exists, and takes place if you configure it. It's just unconfigured by default.)These are incremental improvements. i.e. once we know whether the secret was validated, we can leave full branch reindexing in place for cases when the hook isn't validated. Then add the single-branch ' " fetch this head from github because we can't trust the hook implicitly wasn ' t validated" behaviour as an optimisation (basically, just for those too lazy to set up webhook validation ( webhooks with a secret? much lower priority) . ( Against that, however, even triggering full-branch reindexing from unvalidated webhooks would be enough to cause DoS via this issue - so, we should _should_ probably completely ignore unvalidated hooks altogether. I don't understand the use-case for not having a secret in place. ) Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.
[JIRA] (JENKINS-36121) Github Branch Source plugin trips api rate limit
Title: Message Title Dominic Scheirlinck edited a comment on JENKINS-36121 Re: Github Branch Source plugin trips api rate limit [~michaelneale] Yeah, good summary, I think.What's really necessary, IMO, is some flag/signal/getter from github-api that the signature check validation has taken place. Then we can smartly _either _trust either trust the content of the hook, or go out and do some sort of 'single-branch reindexing' head-fetch that only consumes a few API requests. (The validation already exists, and takes place if you configure it. It's just unconfigured by default.) These are incremental improvements. i.e. once we know whether the secret was validated, we can leave full branch reindexing in place for cases when the hook isn't validated. Then add the single-branch 'fetch this head from github because we can't trust the hook implicitly' behaviour as an optimisation for those too lazy to set up webhook validation (much lower priority). (Against that, however, even triggering full-branch reindexing from unvalidated webhooks would be enough to cause DoS via this issue - so, we should probably completely ignore unvalidated hooks altogether. I don't understand the use-case for not having a secret in place.) Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36121) Github Branch Source plugin trips api rate limit
Title: Message Title Dominic Scheirlinck edited a comment on JENKINS-36121 Re: Github Branch Source plugin trips api rate limit [~michaelneale] Yeah, good summary, I think.What's really necessary, IMO, is some flag/signal/getter from github-api that the signature validation has taken place. Then we can smartly either trust the content of the hook, or if we don't, go out and do some sort of 'single-branch reindexing' head-fetch that only consumes a few API requests. (The validation already exists, and takes place if you configure it. It's just unconfigured by default.)These are incremental improvements. i.e. once we know whether the secret was validated, we can leave full branch reindexing in place for cases when the hook isn't validated. Then add the single-branch 'fetch this head from github because we can't trust the hook implicitly' behaviour as an optimisation for those too lazy to set up webhook validation (much lower priority). (Against that, however, even triggering full-branch reindexing from unvalidated webhooks would be enough to cause DoS via this issue - so, we should probably completely ignore unvalidated hooks altogether. I don't understand the use-case for not having a secret in place.) Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36121) Github Branch Source plugin trips api rate limit
Title: Message Title Dominic Scheirlinck edited a comment on JENKINS-36121 Re: Github Branch Source plugin trips api rate limit [~michaelneale] Yeah, good summary, I think.What's really necessary, IMO, is some flag/ signal /getter from branch github -api that the signature check has taken place. Then we can smartly _either _trust the content of the hook, or go out and do some sort of 'single-branch reindexing' head-fetch that only consumes a few API requests.These are incremental improvements. i.e. once we know whether the secret was validated, we can leave full branch reindexing in place for cases when the hook isn't validated. Then add the single-branch 'fetch this head from github because we can't trust the hook implicitly' behaviour as an optimisation for those too lazy to set up webhook validation (much lower priority). (Against that, however, even triggering full-branch reindexing from unvalidated webhooks would be enough to cause DoS via this issue - so, we should probably completely ignore unvalidated hooks altogether. I don't understand the use-case for not having a secret in place.) Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36121) Github Branch Source plugin trips api rate limit
Title: Message Title Dominic Scheirlinck commented on JENKINS-36121 Re: Github Branch Source plugin trips api rate limit Michael Neale Yeah, good summary, I think. What's really necessary, IMO, is some signal from branch-api that the signature check has taken place. Then we can smartly _either _trust the content of the hook, or go out and do some sort of 'single-branch reindexing' head-fetch that only consumes a few API requests. These are incremental improvements. i.e. once we know whether the secret was validated, we can leave full branch reindexing in place for cases when the hook isn't validated. Then add the single-branch 'fetch this head from github because we can't trust the hook implicitly' behaviour as an optimisation for those too lazy to set up webhook validation (much lower priority). (Against that, however, even triggering full-branch reindexing from unvalidated webhooks would be enough to cause DoS via this issue - so, we should probably completely ignore unvalidated hooks altogether. I don't understand the use-case for not having a secret in place.) Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36121) Github Branch Source plugin trips api rate limit
Title: Message Title Dominic Scheirlinck edited a comment on JENKINS-36121 Re: Github Branch Source plugin trips api rate limit My hacky fix branch is at https://github.com/vend/github-branch-source-plugin/pull/1 - - it'll only work for PR builds for now . - Comments welcome.In this implementation, each PR event webhook triggers up to two builds (merged/unmerged), and takes about one Github API request to do so (I think, checking the collaborators for .isTrusted? Maybe 2-3). Pushes to a PR that is already open won't trigger a build, which is a shame (need to rewrite this logic into a pull event subscriber too). But editing the PR, or adding/removing a label should. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36121) Github Branch Source plugin trips api rate limit
Title: Message Title Dominic Scheirlinck edited a comment on JENKINS-36121 Re: Github Branch Source plugin trips api rate limit My hacky fix branch is at https://github.com/vend/github-branch-source-plugin/pull/1 -- it'll only work for PR builds for now.- Comments welcome.In this implementation, each PR event webhook triggers up to two builds (merged/unmerged), and takes about one Github API request to do so (I think, checking the collaborators for .isTrusted? Maybe 2-3). Pushes to a PR that is already open won't trigger a build, which is a shame (need to rewrite this logic into a pull event subscriber too). But editing the PR, or adding/removing a label should. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36121) Github Branch Source plugin trips api rate limit
Title: Message Title Dominic Scheirlinck edited a comment on JENKINS-36121 Re: Github Branch Source plugin trips api rate limit My hacky fix branch is at https://github.com/vend/github-branch-source-plugin/pull/1 - - it'll only work for PR builds for now. - Comments welcome.In this implementation, each PR event webhook triggers up to two builds (merged/unmerged), and takes about one Github API request to do so (I think, checking the collaborators for .isTrusted? Maybe 2-3). Pushes to a PR that is already open won't trigger a build, which is a shame (need to rewrite this logic into a pull event subscriber too). But editing the PR, or adding/removing a label should. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36121) Github Branch Source plugin trips api rate limit
Title: Message Title Dominic Scheirlinck edited a comment on JENKINS-36121 Re: Github Branch Source plugin trips api rate limit Had a quick go at a throwaway implementation of a fix. Mainly a hacky use of ParameterizedJobMixIn.scheduleBuild2 to schedule a new build for the branches specified in a push event. - However, I quickly ran into JENKINS-37920 - GBS's GitHubWebhookListenerImpl cannot receive the information it needs from github-plugin. (I notice github-plugin also correctly deals with the secret if one is configured, so if it weren't for the fact it's so hard to get the relevant information out, we could easily check for an authenticated webhook, parse the list of branches/PRs, and do the right thing) - In the meantime, I've had to completely disable webhooks.If you simply created a few dozen branches in the multibranch-demo repo, you'd be easily able to reproduce this issue after a few pushes. After all, the set up instructions say to "Add a new webhook, ask to Send me everything" - which is a configuration in which branch indexing will trigger several times as you just click around GitHub e.g. adding labels to PRs. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36121) Github Branch Source plugin trips api rate limit
Title: Message Title Dominic Scheirlinck edited a comment on JENKINS-36121 Re: Github Branch Source plugin trips api rate limit OK, I've submitted an upstream PR at https://github.com/jenkinsci/github-branch-source-plugin/pull/74 There's an .hpi at https://github.com/vend/github-branch-source-plugin/releases/tag/github-branch-source-0.10-SNAPSHOT%2Bvend-webhook Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36121) Github Branch Source plugin trips api rate limit
Title: Message Title Dominic Scheirlinck edited a comment on JENKINS-36121 Re: Github Branch Source plugin trips api rate limit OK, I've submitted an upstream PR at https://github.com/jenkinsci/github-branch-source-plugin/pull/74 There's an .hpi at https://github.com/vend/github-branch-source-plugin/releases/tag/github-branch-source-0.10-SNAPSHOT%2Bvend-webhook Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36121) Github Branch Source plugin trips api rate limit
Title: Message Title Dominic Scheirlinck commented on JENKINS-36121 Re: Github Branch Source plugin trips api rate limit OK, I've submitted an upstream PR at https://github.com/jenkinsci/github-branch-source-plugin/pull/74 Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36121) Github Branch Source plugin trips api rate limit
Title: Message Title Dominic Scheirlinck edited a comment on JENKINS-36121 Re: Github Branch Source plugin trips api rate limit My hacky fix branch is at https://github.com/vend/github-branch-source-plugin/pull/1 - it'll only work for PR builds for now. Comments welcome.In this implementation, each PR event webhook triggers up to two builds (merged/unmerged), and takes about one Github API request to do so (I think, checking the collaborators for .isTrusted? Maybe 2-3 ). Pushes to a PR that is already open won't trigger a build, which is a shame (need to rewrite this logic into a pull event subscriber too). But editing the PR, or adding/removing a label should. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36121) Github Branch Source plugin trips api rate limit
Title: Message Title Dominic Scheirlinck commented on JENKINS-36121 Re: Github Branch Source plugin trips api rate limit My hacky fix branch is at https://github.com/vend/github-branch-source-plugin/pull/1 - it'll only work for PR builds for now. Comments welcome. In this implementation, each PR event webhook triggers up to two builds (merged/unmerged), and takes about one Github API request to do so (I think, checking the collaborators for .isTrusted?). Pushes to a PR that is already open won't trigger a build, which is a shame (need to rewrite this logic into a pull event subscriber too). But editing the PR, or adding/removing a label should. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37920) DefaultPushGHEventSubscriber does not pass important details of the webhook to GitHubWebHook.Listener
Title: Message Title Dominic Scheirlinck commented on JENKINS-37920 Re: DefaultPushGHEventSubscriber does not pass important details of the webhook to GitHubWebHook.Listener Thank you very much for the hints. I'll have a go at implementing the better extension point. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36121) Github Branch Source plugin trips api rate limit
Title: Message Title Dominic Scheirlinck commented on JENKINS-36121 Re: Github Branch Source plugin trips api rate limit Had a quick go at a throwaway implementation of a fix. Mainly a hacky use of ParameterizedJobMixIn.scheduleBuild2 to schedule a new build for the branches specified in a push event. However, I quickly ran into JENKINS-37920 - GBS's GitHubWebhookListenerImpl cannot receive the information it needs from github-plugin. (I notice github-plugin also correctly deals with the secret if one is configured, so if it weren't for the fact it's so hard to get the relevant information out, we could easily check for an authenticated webhook, parse the list of branches/PRs, and do the right thing) In the meantime, I've had to completely disable webhooks. If you simply created a few dozen branches in the multibranch-demo repo, you'd be easily able to reproduce this issue after a few pushes. After all, the set up instructions say to "Add a new webhook, ask to Send me everything" - which is a configuration in which branch indexing will trigger several times as you just click around GitHub e.g. adding labels to PRs. Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-37920) DefaultPushGHEventSubscriber does not pass important details of the webhook to GitHubWebHook.Listener
Title: Message Title Dominic Scheirlinck created an issue Jenkins / JENKINS-37920 DefaultPushGHEventSubscriber does not pass important details of the webhook to GitHubWebHook.Listener Issue Type: Bug Assignee: Kirill Merkushev Components: github-plugin Created: 2016/Sep/02 5:44 AM Priority: Minor Reporter: Dominic Scheirlinck The DefaultPushGHEventSubscriber provides an extension point for "other plugins [that] may be interested in listening for these updates" (GitHubWebHook.Listener). However, the only information those other plugins can receive is the name of the pusher and the repository URL. It'd be useful to also give the GHEvent, the string payload, or both to the listener, so that the extension can make useful decisions about what to do on the push event. As it is, a listener can know a push happened on a repo, but not what was pushed. This restricts the ability of the listeners to perform useful tasks such as only updating a single branch (e.g. https://github.com/jenkinsci/github-branch-source-plugin/blob/master@%7B2016-09-02%7D/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubWebhookListenerImpl.java#L49) - seems to be the root cause behind major missing functionality in github-branch-source, for instance
[JIRA] (JENKINS-36121) Github Branch Source plugin trips api rate limit
Title: Message Title Dominic Scheirlinck commented on JENKINS-36121 Re: Github Branch Source plugin trips api rate limit Reading https://github.com/jenkinsci/github-branch-source-plugin/blob/master/src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestGHEventSubscriber.java#L100 - it certainly appears than any PR event will cause a full branch reindexing. Is that right? Well, given that the downside of this is noted at JENKINS-34600, it's definitely not fair to complain to Github about that Jesse Glick. You're expected to authenticate the webhook and use the information it contains, not use it as a trigger for an unbounded number of API requests... Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36121) Github Branch Source plugin trips api rate limit
Title: Message Title Dominic Scheirlinck commented on JENKINS-36121 Re: Github Branch Source plugin trips api rate limit I'm seeing the rate limit exhausted on a repo with just a hundred or so branches - this repo has a similar number of PRs, so the existing options about what gets built don't provide me with any help. Is there any way I can control the frequency of branch indexing? It seems to be happening far, far too frequently for this repo (every few minutes by the looks?!) Is it doing something silly like triggering a full branch indexing run when it gets a 'new branch created' webhook? Otherwise I can't see why it would need to reindex so often. Seems to be exacerbated by lack of visibility into how often branch indexing is triggering (you can only see the last run, not the frequency or history of runs, so it's easy to miss the fact it's scanning every few minutes, and consuming vast amounts of API requests.) Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-36574) Add option to choose static notification context
Title: Message Title Dominic Scheirlinck commented on JENKINS-36574 Re: Add option to choose static notification context The option to change to a dynamic context string aggravates the problem of not being able to disable the default SCM commit status. If you could disable it, Pipeline authors could easily choose to use either a static or varied context string via GitHubCommitStatusSetter. Protected branches are not the only thing out there that assumes the number of commit status context strings will be low across an entire project. (This current implementation will create 100 contexts for 100 branches if you're doing GithubFlow; and that prevents Jenkins Pipeline users from taking advantage of the entire ecosystem of Github integrations that use the context strings normally.) Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [github-branch-source-plugin] (JENKINS-35453) Allow disabling the default commit status notifier
Title: Message Title Dominic Scheirlinck created an issue Jenkins / JENKINS-35453 Allow disabling the default commit status notifier Issue Type: Improvement Assignee: Jesse Glick Components: github-branch-source-plugin Created: 2016/Jun/08 12:16 AM Priority: Minor Reporter: Dominic Scheirlinck In JENKINS-33151 , giving users the option to disable the default commit status notifier was raised (in lieu of more complex configuration, such as the ability to change the context string, which is hard-coded to 'Jenkins': https://github.com/jenkinsci/github-branch-source-plugin/blob/master@%7B2016-06-08%7D/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubBuildStatusNotification.java#L78) I think there's probably a use case for this, and it would allow users with more complicated status logic (such as in that ticket) to implement their own, and just opt out of the default one. Add Comment
[JIRA] [github-oauth-plugin] (JENKINS-34775) Broken jobs after upgrade to 1.651.2 security update
Title: Message Title
Dominic Scheirlinck commented on JENKINS-34775
Re: Broken jobs after upgrade to 1.651.2 security update
Sam Gleske I've prepared a patch at https://github.com/jenkinsci/github-oauth-plugin/pull/56 - it looks like the problem is just a bad assumption/cast to GithubAuthenticationToken, and the fix just adds an `instanceof` check. I don't think I have to convert the UserPasswordAuthenticationToken as well (just bailing out of loadUserByUsername works fine for me).
Roberto Sanchez That's an unrelated error ("LDAP: error code 1 - 2020: Operation unavailable without authentication") from your LDAP server. Please start a new issue.
Add Comment
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
