[JIRA] [jira-plugin] (JENKINS-30333) Thread Leak due to use of deprecated JiraSize.createSession

[gerha...@java.net (JIRA)]

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 gerhard6 created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Jenkins /  JENKINS-30333 
 
 
 
  Thread Leak due to use of deprecated JiraSize.createSession  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Bug 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Components:
 

 jira-plugin 
 
 
 

Created:
 

 08/Sep/15 8:41 AM 
 
 
 

Environment:
 

 Jenkins 1.532.2  Jira Plugin 2.0 
 
 
 

Priority:
 
  Major 
 
 
 

Reporter:
 
 gerhard6 
 
 
 
 
 
 
 
 
 
 
We use the 2.0 Jira Plugin to add comments to Jiras. We have the problem that every such request causes a Thread Leak - see the "diff" output of "jstack" below. 
Seems that this is caused by using JiraSite.createSession instead of getSession() in Updater class. Changing it to getSession worked for me. Mind that I havent yet tested for the "// TODO: we should check for session timeout, too" in JiraSite. 
 
Output of the thread-list diff - we can see many additional "httpclient-" threads  

 

glangs@cgm-1194:/opt/docker_volumes/jenkins3$ diff *tid
1c1,20
< "httpclient-callbacks:thread-1" daemon prio=10 tid=0x00c83800 nid=0x5364 waiting on condition [0x7ff7a73f2000]
---
> "RequestHandlerThread[#12]" daemon prio=10 tid=0x7ff7a800b800 nid=0x53c2 waiting on 

[JIRA] [cygpath] (JENKINS-22149) cygpath plugin should not fail on windows when cygwin is not installed

[gerha...@java.net (JIRA)]

gerhard6
 created  JENKINS-22149


cygpath plugin should not fail on windows when cygwin is not installed















Issue Type:


Improvement



Affects Versions:


current



Assignee:


Unassigned


Components:


cygpath



Created:


12/Mar/14 10:50 AM



Description:


We have a landscape, where only a subset of our windows jenkins slaves have cygwin installed.
On the slaves without cygwin, the jenkins cygpath plugin gets an error. Note that also happens on steps, that are not related to cygwin, as can be seend in the error appended at the end - in that case invocation of a maven task.


Suggestion is NOT to fail, and simply do nothing, passing the commands thru without any modifications.

Will attach a patch that provides a solution.




FATAL: command execution failed
hudson.util.IOException2: Failed to locate Cygwin installation. Is Cygwin installed?
	at hudson.plugins.cygpath.CygpathLauncherDecorator$GetCygpathTask.getCygwinRoot(CygpathLauncherDecorator.java:138)
	at hudson.plugins.cygpath.CygpathLauncherDecorator$GetCygpathTask.call(CygpathLauncherDecorator.java:142)
	at hudson.plugins.cygpath.CygpathLauncherDecorator$GetCygpathTask.call(CygpathLauncherDecorator.java:112)
	at hudson.remoting.UserRequest.perform(UserRequest.java:118)
	at hudson.remoting.UserRequest.perform(UserRequest.java:48)
	at hudson.remoting.Request$2.run(Request.java:326)
	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
	at java.util.concurrent.FutureTask.run(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at hudson.remoting.Engine$1$1.run(Engine.java:61)
	at java.lang.Thread.run(Unknown Source)
Caused by: hudson.util.jna.JnaException: Win32 error: 2 - null
	at hudson.util.jna.RegistryKey.check(RegistryKey.java:124)
	at hudson.util.jna.RegistryKey.open(RegistryKey.java:223)
	at hudson.util.jna.RegistryKey.openReadonly(RegistryKey.java:218)
	at hudson.plugins.cygpath.CygpathLauncherDecorator$GetCygpathTask.getCygwinRoot(CygpathLauncherDecorator.java:127)
	... 11 more
Build step 'Invoke top-level Maven targets' marked build as failure	... 11 more




Project:


Jenkins



Priority:


Major



Reporter:


gerhard6

























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] [cygpath] (JENKINS-22149) cygpath plugin should not fail on windows when cygwin is not installed

[gerha...@java.net (JIRA)]

gerhard6
 updated  JENKINS-22149


cygpath plugin should not fail on windows when cygwin is not installed
















attached patch





Change By:


gerhard6
(12/Mar/14 11:00 AM)




Attachment:


patch.txt



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.