[JIRA] (JENKINS-29314) Improving teamforge-collabnet plugin.

2016-11-22 Thread jmcna...@collab.net (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 John McNally closed an issue as Fixed  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Change is committed. Will be in 2.0 release.  
 

  
 
 
 
 

 
 Jenkins /  JENKINS-29314  
 
 
  Improving teamforge-collabnet plugin.   
 

  
 
 
 
 

 
Change By: 
 John McNally  
 
 
Status: 
 Open Closed  
 
 
Assignee: 
 JCAT John McNally  
 
 
Resolution: 
 Fixed  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the 

[JIRA] [collabnet] (JENKINS-17152) Large file upload fails using collabnet plugin

2013-05-16 Thread jmcna...@collab.net (JIRA)















































John McNally
 resolved  JENKINS-17152 as Fixed


Large file upload fails using collabnet plugin
















Pull request closed and released as version 1.1.8





Change By:


John McNally
(17/May/13 3:15 AM)




Status:


InProgress
Resolved





Fix Version/s:


current





Resolution:


Fixed



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] (JENKINS-13742) Field validation does not pass required query parameters when some fields are specified in a nested Describable

2013-03-05 Thread jmcna...@collab.net (JIRA)














































John McNally
 updated  JENKINS-13742


Field validation does not pass required query parameters when some fields are specified in a nested Describable
















Change By:


John McNally
(06/Mar/13 2:04 AM)




Assignee:


KohsukeKawaguchi
JohnMcNally



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] (JENKINS-13742) Field validation does not pass required query parameters when some fields are specified in a nested Describable

2013-03-05 Thread jmcna...@collab.net (JIRA)















































John McNally
 resolved  JENKINS-13742 as Fixed


Field validation does not pass required query parameters when some fields are specified in a nested Describable
















Committing the fix for JENKINS-16676 would allow override of the global auth credentials, but the work that can be accomplished in the plugin is complete.





Change By:


John McNally
(06/Mar/13 2:06 AM)




Status:


Open
Resolved





Fix Version/s:


current





Resolution:


Fixed



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] (JENKINS-16957) Tracker and File Release field validations not working in CollabNet plugin

2013-02-28 Thread jmcna...@collab.net (JIRA)














































John McNally
 updated  JENKINS-16957


Tracker and File Release field validations not working in CollabNet plugin
















Change By:


John McNally
(28/Feb/13 3:24 PM)




Affects Version/s:


current



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] (JENKINS-16957) Tracker and File Release field validations not working in CollabNet plugin

2013-02-28 Thread jmcna...@collab.net (JIRA)















































John McNally
 resolved  JENKINS-16957 as Fixed


Tracker and File Release field validations not working in CollabNet plugin
















Fixed in v1.1.7





Change By:


John McNally
(28/Feb/13 3:26 PM)




Status:


Open
Resolved





Resolution:


Fixed



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] (JENKINS-16957) Tracker and File Release field validations not working in CollabNet plugin

2013-02-28 Thread jmcna...@collab.net (JIRA)














































John McNally
 commented on  JENKINS-16957


Tracker and File Release field validations not working in CollabNet plugin















Fixed in version 1.1.7



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] (JENKINS-16957) Tracker field validations not working in CollabNet plugin

2013-02-26 Thread jmcna...@collab.net (JIRA)














































John McNally
 commented on  JENKINS-16957


Tracker field validations not working in CollabNet plugin















Adding a minor File Release fix as part of this issue. Previously the entered package was not being used when filling the release combobox, so it would list releases in other packages.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] (JENKINS-16957) Tracker and File Release field validations not working in CollabNet plugin

2013-02-26 Thread jmcna...@collab.net (JIRA)














































John McNally
 updated  JENKINS-16957


Tracker and File Release field validations not working in CollabNet plugin
















Change By:


John McNally
(26/Feb/13 5:23 PM)




Summary:


Tracker
andFileRelease
fieldvalidationsnotworkinginCollabNetplugin



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] (JENKINS-16957) Tracker field validations not working in CollabNet plugin

2013-02-25 Thread jmcna...@collab.net (JIRA)














































John McNally
 created  JENKINS-16957


Tracker field validations not working in CollabNet plugin















Issue Type:


Bug



Affects Versions:


current



Assignee:


John McNally



Components:


collabnet



Created:


25/Feb/13 10:17 PM



Description:


The tracker field is always showing the error 
"The tracker is required."
even when a valid tracker is entered.
And the assignee field does not validate at all. 




Project:


Jenkins



Priority:


Minor



Reporter:


John McNally

























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] (JENKINS-16719) Combobox with relative dependencies does not work

2013-02-08 Thread jmcna...@collab.net (JIRA)














































John McNally
 created  JENKINS-16719


Combobox with relative dependencies does not work















Issue Type:


Bug



Affects Versions:


current



Assignee:


Unassigned


Components:


core



Created:


08/Feb/13 7:51 PM



Description:


A combobox whose fill method involves RelativePath arguments will have those arguments set to null.  The fix is very simply to increase an index on the Behaviour.specify call.  A pull request including test will be entered shortly.




Project:


Jenkins



Priority:


Major



Reporter:


John McNally

























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] (JENKINS-16719) Combobox with relative dependencies does not work

2013-02-08 Thread jmcna...@collab.net (JIRA)














































John McNally
 commented on  JENKINS-16719


Combobox with relative dependencies does not work















Pull request including test:
https://github.com/jenkinsci/jenkins/pull/700



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] (JENKINS-13742) Field validation does not pass required query parameters when some fields are specified in a nested Describable

2013-02-08 Thread jmcna...@collab.net (JIRA)














































John McNally
 commented on  JENKINS-13742


Field validation does not pass required query parameters when some fields are specified in a nested Describable















Kohsuke,
As you pointed out there was some work in the collabnet plugin which could improve this behavior and I have used this issue for a commit to the plugin.  However, there are a couple of issues in the core that still prevent the plugin from optimium behavior.  Feel free to assign this issue to me. But could you look at JENKINS-16676 and JENKINS-16719 for bugs in core Jenkins?



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] (JENKINS-16676) RelativePath dependent field validations do not work

2013-02-06 Thread jmcna...@collab.net (JIRA)














































John McNally
 created  JENKINS-16676


RelativePath dependent field validations do not work















Issue Type:


Bug



Affects Versions:


current



Assignee:


Unassigned


Components:


core



Created:


06/Feb/13 10:07 PM



Description:


Use of @RelativePath in field validation methods does not work on initial page load and do not work at all for optional fields. Also affects validations using compound fields where @RelativePath is used in the stapler.

A couple relatively minor changes in hudson-behavior.js can fix this.  I will be submitting a pull request which includes a test which should provide the details better than further prose description.




Project:


Jenkins



Priority:


Major



Reporter:


John McNally

























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] (JENKINS-16676) RelativePath dependent field validations do not work

2013-02-06 Thread jmcna...@collab.net (JIRA)














































John McNally
 commented on  JENKINS-16676


RelativePath dependent field validations do not work















Pull request initiated:
https://github.com/jenkinsci/jenkins/pull/695



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] (JENKINS-13742) Field validation does not pass required query parameters when some fields are specified in a nested Describable

2012-05-15 Thread jmcna...@collab.net (JIRA)

[ 
https://issues.jenkins-ci.org/browse/JENKINS-13742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=162799#comment-162799
 ] 

John McNally commented on JENKINS-13742:


In case the short presentation of the plugin code is not clear, here is the 
entire commit:
https://github.com/jenkinsci/collabnet-plugin/commit/4c7b516a7975ffc126ddf717476cefe4e0a84081

 Field validation does not pass required query parameters when some fields are 
 specified in a nested Describable
 ---

 Key: JENKINS-13742
 URL: https://issues.jenkins-ci.org/browse/JENKINS-13742
 Project: Jenkins
  Issue Type: Bug
  Components: collabnet, core, validating-string-parameter
Affects Versions: current
 Environment: Problem is not environment dependent, but testing was on 
 Ubuntu 10.04 using Firefox 11 as client.
Reporter: John McNally
Assignee: whsu
  Labels: jenkins
 Attachments: findNearBy.patch


 The collabnet plugin was updated/modernized a couple years ago to include 
 code like the following:
 CNDocumentUploader.java DescriptorImpl
 /**
   * Form validation for upload path.
   */
 public FormValidation doCheckUploadPath(CollabNetApp app, @QueryParameter 
 String project, @QueryParameter String value)
 CollabNetApp.java
 public static CollabNetApp fromStapler(@QueryParameter boolean 
 overrideAuth, @QueryParameter String url,
@QueryParameter String username, 
 @QueryParameter String password) 
 config.jelly
   f:property field=connectionFactory /
 ...
   f:entry title=Upload Folder Path field=uploadPath
 f:textbox /
   /f:entry
 ConnectionFactory has url, username, and password properties
 The generated field validation javascript then uses the 'nearBy' function 
 when passing query parameters to the checkUploadPath backend in order to find 
 values of url, username, and password.  However uploadPath has a parent 
 element with name 'publisher', while the direct parent of url, username, and 
 password is a div has name 'connectionFactory'.  'publisher' is then a 
 grandparent of url, username, and password and because of this, the needed 
 query parameters are not included.
 One might argue that the collabnet plugin should avoid this design, since it 
 does not work, but the changes came from Kohsuke, so attempting find a fix 
 which preserves the current design.
 A patch to the findNearBy function in hudson-behavior.js is attached.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[JIRA] (JENKINS-13742) Field validation does not pass required query parameters when some fields are specified in a nested Describable

2012-05-10 Thread jmcna...@collab.net (JIRA)
John McNally created JENKINS-13742:
--

 Summary: Field validation does not pass required query parameters 
when some fields are specified in a nested Describable
 Key: JENKINS-13742
 URL: https://issues.jenkins-ci.org/browse/JENKINS-13742
 Project: Jenkins
  Issue Type: Bug
  Components: collabnet, core, validating-string-parameter
Affects Versions: current
 Environment: Problem is not environment dependent, but testing was on 
Ubuntu 10.04 using Firefox 11 as client.
Reporter: John McNally
Assignee: whsu
 Attachments: findNearBy.patch

The collabnet plugin was updated/modernized a couple years ago to include code 
like the following:

CNDocumentUploader.java DescriptorImpl
/**
  * Form validation for upload path.
  */
public FormValidation doCheckUploadPath(CollabNetApp app, @QueryParameter 
String project, @QueryParameter String value)


CollabNetApp.java
public static CollabNetApp fromStapler(@QueryParameter boolean 
overrideAuth, @QueryParameter String url,
   @QueryParameter String username, 
@QueryParameter String password) 

config.jelly
  f:property field=connectionFactory /
...
  f:entry title=Upload Folder Path field=uploadPath
f:textbox /
  /f:entry

ConnectionFactory has url, username, and password properties

The generated field validation javascript then uses the 'nearBy' function when 
passing query parameters to the checkUploadPath backend in order to find values 
of url, username, and password.  However uploadPath has a parent element with 
name 'publisher', while the direct parent of url, username, and password is a 
div has name 'connectionFactory'.  'publisher' is then a grandparent of url, 
username, and password and because of this, the needed query parameters are not 
included.

One might argue that the collabnet plugin should avoid this design, since it 
does not work, but the changes came from Kohsuke, so attempting find a fix 
which preserves the current design.

A patch to the findNearBy function in hudson-behavior.js is attached.



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira