[JIRA] (JENKINS-53646) Agent command isn't in sync with remoting agent options

2018-09-20 Thread jtbo...@gmail.com (JIRA) 
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jeremy Bouse commented on  JENKINS-53646  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Agent command isn't in sync with remoting agent options   
 

  
 
 
 
 

 
 So I did some digging into this and looking at the differences I mentioned. It appears that there is a distinct difference between how the Jenkins -> Node ->   UI page shows to launch the agent and how the ECS Plugin and Docker image entrypoint are launching the agent. The Jenkins UI shows you to basically call it via: java -jar /usr/share/jenkins/slave.jar -jnlpUrl /computer//slave-agent.jnlp -secret  Which as I've deduced is calling using the hudson.remoting.launcher class using the jnlpUrl to pull down the encrypted JNLP file which it then decrypts using the secret and executes the hudson.remoting.jnlp.Main class with the arguments specified in the JNLP file. Whereas the ECS plugin and the typical Docker image entrypoint script launches the agent using a call like: java -Dorg.jenkinsci.remoting.engine.JnlpProtocol3.disabled=true -cp /usr/share/jenkins/slave.jar hudson.remoting.jnlp.Main -headless -url  -tunnelWhich directly calls the hudson.remoting.jnlp.Main class and passes the arguments directly requiring it to have intrinsic knowledge of the arguments needed. The hudson.remoting.launcher already appears that it executes with -headless already enabled and seems that calling the JNLP URL would be much more future proof. Obviously if the array built by the com.cloudbees.jenkins.plugins.amazonecs.ECSCloud.getDockerRunCommand() is changed this would require a change to how the entrypoint script handles it. So does it make more sense to do so?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-53646) Agent command isn't in sync with remoting agent options

2018-09-18 Thread jtbo...@gmail.com (JIRA) 
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jeremy Bouse created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-53646  
 
 
  Agent command isn't in sync with remoting agent options   
 

  
 
 
 
 

 
Issue Type: 
  Improvement  
 
 
Assignee: 
 Jan Roehrich  
 
 
Components: 
 amazon-ecs-plugin  
 
 
Created: 
 2018-09-18 20:00  
 
 
Environment: 
 OS: ECS-optimized AMI 2018.03.f  Jenkins : v2.138.1  ECS plugin v1.16  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Jeremy Bouse  
 

  
 
 
 
 

 
 Current versions of Jenkins remoting (3.x) do not appear to support the -url and -tunnel options any more and instead favor using the -jnlpUrl option with the tunnel being added to the JNLPLauncher.   Suggest updating the command being used in the ECS Task to be more in line with current versions of Jenkins: -jnlpUrl /computer//slave-agent.jnlp -secret  -workDir    instead of: -url  -tunnel 
 

  
 
 
 
 

 
 
 

 
 
 Add Comment