[JIRA] (JENKINS-38305) Remove --tty from docker exec

[kass...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Rafael Kassner commented on  JENKINS-38305  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Remove --tty from docker exec   
 

  
 
 
 
 

 
 dan tran It is a fault of docker exec command: 

 
kassner@w:~$ DOCKER_ID=$(docker run -d -it php:7.0 /bin/cat)
kassner@w:~$ docker exec -it ${DOCKER_ID} php -r "exit(2);"
kassner@w:~$ echo $?
129
kassner@w:~$ docker exec -i ${DOCKER_ID} php -r "exit(2);"
kassner@w:~$ echo $?
2
kassner@w:~$
 

 Removing the tty from plugin's call avoids that, but I am not sure if we can just drop the TTY from it, even though it is non-interactive.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-38305) Remove --tty from docker exec

[kass...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Rafael Kassner created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-38305  
 
 
  Remove --tty from docker exec   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Nicolas De Loof  
 
 
Components: 
 docker-custom-build-environment-plugin  
 
 
Created: 
 2016/Sep/17 9:46 PM  
 
 
Environment: 
 Plugin version 1.6.5  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Rafael Kassner  
 

  
 
 
 
 

 
 Hi, As pointed out here, docker exec will return the wrong status code when --tty is provided, thus failing jobs in Jenkins even though they should have been successful. I've written a small PR for that, but I'm not sure if we can just disable the tty. Any comments?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment