[JIRA] [envinject] (JENKINS-16316) global variable not updated

2013-05-27 Thread klaus.azesber...@gmail.com (JIRA)














































Klaus Azesberger
 commented on  JENKINS-16316


global variable not updated















i updated my pull request 12 days ago - providing:

	tests to reproduce/cover the issue/fix
	a better fix (my first attempt was as "wrong" as the original version)



i hope this gets reviewed/pulled.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] [envinject] (JENKINS-16316) global variable not updated

2013-04-26 Thread klaus.azesber...@gmail.com (JIRA)














































Klaus Azesberger
 reopened  JENKINS-16316


global variable not updated
















I've encountered this to still be an issue in specific cases on slave node execution (maybe some of this behaviour is intended?):

how to reproduce:

	hpi:run on current head with jenkins-version set to "1.480.3" (current LTS verison)
	configure a global property on master K/V: TESTVAR/value1
	configure a slave and start it
	configure a job restricted to run on that slave and to echo $TESTVAR.
	run the job (it will echo "value1")
	configure the global property on master to be: TESTVAR/value2
	dont restart anything
	rerun the job (it will still echo "value1")



however a job on master will recognize the changed value.

there are 2 pieces of code that lead to this behaviour. I'm pretty uncertain about the fix i made, but it resolves at least our problem with the plugin as i described it above, although i'm pretty sure it breaks some other intended feature.

https://github.com/kazesberger/envinject-plugin.git
https://github.com/kazesberger/envinject-plugin/commits/master

maybe someone can have a look at it and/or tell me what's the story behind this (Core)EnvironmentContributor thing.





Change By:


Klaus Azesberger
(26/Apr/13 1:35 PM)




Resolution:


Fixed





Status:


Resolved
Reopened





Assignee:


GregoryBoissinot



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] (JENKINS-10628) SCM build trigger not working correctly with variables in SVN URL

2013-01-15 Thread klaus.azesber...@gmail.com (JIRA)














































Klaus Azesberger
 commented on  JENKINS-10628


SCM build trigger not working correctly with variables in SVN URL















due to my automated formatting the change set caused a lot of conflicts and reduced visibility of the actually small change set, so my pull request got closed.
- i rebased the changeset without the formatting-mess. it should be possible to integrate this fixes now.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira






[JIRA] (JENKINS-10628) SCM build trigger not working correctly with variables in SVN URL

2012-12-13 Thread klaus.azesber...@gmail.com (JIRA)














































Klaus Azesberger
 commented on  JENKINS-10628


SCM build trigger not working correctly with variables in SVN URL















hi, i just recognized that you were already aware of my problem (JENKINS-16116).

i can provide you a patch for:

	doCommitNotification considers GlobalNodeProperties environment variables before checks of svnUrl
	repositoryLocationsNoLongerExist check within scmPolling considers GlobalNodeProperties environment variables before checks of svnUrl
	doCommitNotification does not cut the first 4 characters of SVNUrl in order to Cut the "U   " from the "U   /your/changed/files" string instead it cuts the first character and trims the string. this was needed for compatibility to either post-commit hook or svn-version (didnt analyze this that precisely)






























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira






[JIRA] (JENKINS-10628) SCM build trigger not working correctly with variables in SVN URL

2012-12-13 Thread klaus.azesber...@gmail.com (JIRA)














































Klaus Azesberger
 updated  JENKINS-10628


SCM build trigger not working correctly with variables in SVN URL
















sorry about the format changes - was not aware of autoformat of my eclipse





Change By:


Klaus Azesberger
(13/Dec/12 10:56 AM)




Attachment:


subversion-plugin-1.43-Jenkins-16116.patch



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira






[JIRA] (JENKINS-16116) subversion-plugin commit notification (1.43) does not consider global node properties in SCM URLs

2012-12-13 Thread klaus.azesber...@gmail.com (JIRA)














































Klaus Azesberger
 commented on  JENKINS-16116


subversion-plugin commit notification (1.43) does not consider global node properties in SCM URLs















i provided code via pull request with following fixes:

	doCommitNotification considers GlobalNodeProperties environment variables before checks of svnUrl
	repositoryLocationsNoLongerExist check within scmPolling considers GlobalNodeProperties environment variables before checks of svnUrl
	doCommitNotification does not cut the first 4 characters of SVNUrl in order to Cut the "U " from the "U /your/changed/files" string instead it cuts the first character and trims the string. this was needed for compatibility to either post-commit hook or svn-version (didnt analyze this that precisely)





























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira






[JIRA] (JENKINS-10628) SCM build trigger not working correctly with variables in SVN URL

2012-12-13 Thread klaus.azesber...@gmail.com (JIRA)














































Klaus Azesberger
 commented on  JENKINS-10628


SCM build trigger not working correctly with variables in SVN URL















provided a pull request for upcoming 1.44 version



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira






[JIRA] (JENKINS-10628) SCM build trigger not working correctly with variables in SVN URL

2012-12-13 Thread klaus.azesber...@gmail.com (JIRA)














































Klaus Azesberger
 commented on  JENKINS-10628


SCM build trigger not working correctly with variables in SVN URL















@Markus Maki: you can build your hpi-file from my fork at https://github.com/kazesberger/subversion-plugin

it contains the upcoming 1.44 code and fixes from me and bela.

hth



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira






[JIRA] (JENKINS-6450) post-commit hook does no handle svn:externals

2012-06-06 Thread klaus.azesber...@gmail.com (JIRA)

[ 
https://issues.jenkins-ci.org/browse/JENKINS-6450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=163538#comment-163538
 ] 

Klaus Azesberger edited comment on JENKINS-6450 at 6/6/12 9:14 AM:
---

we too have a similar (probably the same) issue, using a customized 
subversion-plugin based on 1.41-snapshot (fixed 2 issues with variables like 
$MY_PROJECT_SVN_URL in scm-url of projects) with jenkins 1.465

we dont use post-commit-hook, we use simple scm-polling as build trigger.

the svn polling protocol says no changes, but when i manually trigger the 
build it updates changes behind an svn external correctly.

  was (Author: mcklaus):
we too have this issue, using a customized subversion-plugin based on 
1.41-snapshot (fixed 2 issues with variables like $MY_PROJECT_SVN_URL in 
scm-url of projects) with jenkins 1.465
  
 post-commit hook does no handle svn:externals
 -

 Key: JENKINS-6450
 URL: https://issues.jenkins-ci.org/browse/JENKINS-6450
 Project: Jenkins
  Issue Type: Bug
  Components: subversion
Affects Versions: current
 Environment: Windows, Hudson V1.356, Subversion Plug-in V1.17, Poll 
 SCM enabled and left empty 
Reporter: Axel Heider

 I've set up a post-commit hook that send a post request with the changed 
 files (http://%HUDSON%/hudson/subversion/%UUID%/notifyCommit?rev=%REV%). It 
 works fine except for changes in directories or files referenced via 
 svn:externals. If something changes there, the project is no rebuild. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira