[JIRA] [core] (JENKINS-27739) Changes to slave environment variables are ignored by master
Title: Message Title Milo Hyson commented on JENKINS-27739 Re: Changes to slave environment variables are ignored by master Jochen Ulrich: Restarting the master impacts ALL slaves, not just one. It brings the entire system to a screeching halt. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-27739) Changes to slave environment variables are ignored by master
Title: Message Title Milo Hyson commented on JENKINS-27739 Re: Changes to slave environment variables are ignored by master Just tried the above procedure on v1.606 without EnvInject. Problem still occurred. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-27739) Changes to slave environment variables are ignored by master
Title: Message Title
Milo Hyson commented on JENKINS-27739
Re: Changes to slave environment variables are ignored by master
I've only just started looking at the source, so I may be off base here. But it seems to me that hudson.model.Computer is taking a snapshot upon first request and then never querying the slave again:
public EnvVars getEnvironment() throws IOException, InterruptedException {
EnvVars cachedEnvironment = this.cachedEnvironment;
if (cachedEnvironment != null) {
return new EnvVars(cachedEnvironment);
}
cachedEnvironment = EnvVars.getRemote(getChannel());
this.cachedEnvironment = cachedEnvironment;
return new EnvVars(cachedEnvironment);
}
Looking at the context for the introduction of this code I understand there was a desire to minimize network calls, but I would think there are times when the cost is worth it. At the start of a build, for instance, or when the system-information is requested. These are relative one-offs that would not unduly suffer from a second or two of delay.
Add Comment
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [snsnotify-plugin] (JENKINS-28542) SNS notifier plugin missing httpcore dependency
Title: Message Title Milo Hyson updated an issue Jenkins / JENKINS-28542 SNS notifier plugin missing httpcore dependency Change By: Milo Hyson Priority: Blocker Major Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [snsnotify-plugin] (JENKINS-28542) SNS notifier plugin missing httpcore dependency
Title: Message Title Milo Hyson created an issue Jenkins / JENKINS-28542 SNS notifier plugin missing httpcore dependency Issue Type: Bug Assignee: Unassigned Components: snsnotify-plugin Created: 21/May/15 9:22 PM Environment: Stock Jenkins v1.614 snsnotify-plugin v1.9 Priority: Blocker Reporter: Milo Hyson Installing the released snsnotify-plugin v1.9 on a completely stock Jenkins v1.614 does not work. Builds using the plugin fail with the following exception: java.lang.NoClassDefFoundError: org/apache/http/util/Args at org.apache.http.conn.scheme.Scheme.(Scheme.java:90) at org.apache.http.impl.conn.SchemeRegistryFactory.createDefault(SchemeRegistryFactory.java:50) at com.amazonaws.http.ConnectionManagerFactory.createPoolingClientConnManager(ConnectionManagerFactory.java:29) at com.amazonaws.http.HttpClientFactory.createHttpClient(HttpClientFactory.java:104) at com.amazonaws.http.AmazonHttpClient.(AmazonHttpClient.java:198) at com.amazonaws.AmazonWebServiceClient.(AmazonWebServiceClient.java:132) at com.amazonaws.AmazonWebServiceClient.(AmazonWebServiceClient.java:116) at com.amazonaws.services.sns.AmazonSNSClient.(AmazonSNSClient.java:147) at com.amazonaws.services.sns.AmazonSNSClient.(AmazonSNSClient.java:128) at org.jenkinsci.plugins.snsnotify.AmazonSNSNotifier.send(AmazonSNSNotifier.java:1
[JIRA] [snsnotify-plugin] (JENKINS-28542) SNS notifier plugin missing httpcore dependency
Title: Message Title Milo Hyson updated an issue Jenkins / JENKINS-28542 SNS notifier plugin missing httpcore dependency Change By: Milo Hyson Installing the released snsnotify-plugin v1.9 on a completely stock Jenkins v1.614 does not work. Builds using the plugin fail with the following exception on stdout :java.lang.NoClassDefFoundError: org/apache/http/util/Args at org.apache.http.conn.scheme.Scheme.(Scheme.java:90) at org.apache.http.impl.conn.SchemeRegistryFactory.createDefault(SchemeRegistryFactory.java:50) at com.amazonaws.http.ConnectionManagerFactory.createPoolingClientConnManager(ConnectionManagerFactory.java:29) at com.amazonaws.http.HttpClientFactory.createHttpClient(HttpClientFactory.java:104) at com.amazonaws.http.AmazonHttpClient.(AmazonHttpClient.java:198) at com.amazonaws.AmazonWebServiceClient.(AmazonWebServiceClient.java:132) at com.amazonaws.AmazonWebServiceClient.(AmazonWebServiceClient.java:116) at com.amazonaws.services.sns.AmazonSNSClient.(AmazonSNSClient.java:147) at com.amazonaws.services.sns.AmazonSNSClient.(AmazonSNSClient.java:128) at org.jenkinsci.plugins.snsnotify.AmazonSNSNotifier.send(AmazonSNSNotifier.java:156) at org.jenkinsci.plugins.snsnotify.AmazonSNSNotifier.sendSafe(AmazonSNSNotifier.java:102) at org.jenkinsci.plugins.snsnotify.AmazonSNSNotifier.onStarted(AmazonSNSNotifier.java:79) at org.jenkinsci.plugins.snsnotify.BuildListener.onStarted(BuildListener.java:19) at org.jenkinsci.plugins.snsnotify.BuildListener.onStarted(BuildListener.java:8) at hudson.model.listeners.RunListener.fireStarted(RunListener.java:215) at hudson.model.Run.execute(Run.java:1740) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:98) at hudson.model.Executor.run(Executor.java:374)Caused by: java.lang.ClassNotFoundException: org.apache.http.util.Args at jenkins.util.AntClassLoader.findClassInComponents(AntClassLoader.java:1376) at jenkins.util.AntClassLoader.findClass(AntClassLoader.java:1326) at jenkins.util.AntClassLoader.loadClass(AntClassLoader.java:1079) at java.lang.ClassLoader.loadClass(ClassLoader.java:358) ... 19 moreAn easy fix is to add the following to the pom.xml and rebuild:org.apache.httpcomponentshttpcore4.4.1 Add Comment
[JIRA] [snsnotify-plugin] (JENKINS-28542) SNS notifier plugin missing httpcore dependency
Title: Message Title Milo Hyson commented on JENKINS-28542 Re: SNS notifier plugin missing httpcore dependency Submitted a pull-request with a fix: https://github.com/jenkinsci/snsnotify-plugin/pull/6 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-28794) Environment variable caching should be pluggable
Title: Message Title Milo Hyson created an issue Jenkins / JENKINS-28794 Environment variable caching should be pluggable Issue Type: Improvement Assignee: Unassigned Components: core Created: 08/Jun/15 5:07 PM Priority: Major Reporter: Milo Hyson As of JENKINS-27739, the environment variable cache for a node is cleared whenever that node comes online. Different parties are likely to want different caching behavior, however. Some may, for instance, prefer the caches are cleared at the start of every job. Alternatively, someone may want to completely disable caching altogether. By allowing plugins to affect the caching behavior, different options can be installed by the user. Add Comment
[JIRA] [core] (JENKINS-28794) Environment variable caching should be pluggable
Title: Message Title Milo Hyson commented on JENKINS-28794 Re: Environment variable caching should be pluggable You're right. I was getting my scopes confused. Non-issue. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [snsnotify-plugin] (JENKINS-28542) SNS notifier plugin missing httpcore dependency
Title: Message Title Milo Hyson commented on JENKINS-28542 Re: SNS notifier plugin missing httpcore dependency PR merged to master at beb7beead4. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [snsnotify-plugin] (JENKINS-28542) SNS notifier plugin missing httpcore dependency
Title: Message Title Milo Hyson closed an issue as Fixed Jenkins / JENKINS-28542 SNS notifier plugin missing httpcore dependency Change By: Milo Hyson Status: Open Closed Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [git] (JENKINS-21886) Push notifications don't work if JOB_NAME variable is in repository URL
Milo Hyson
created JENKINS-21886
Push notifications don't work if JOB_NAME variable is in repository URL
Issue Type:
Bug
Assignee:
Nicolas De Loof
Components:
git
Created:
19/Feb/14 9:23 PM
Description:
Having configured a project with a Git SCM whose repository URL includes ${JOB_NAME}, push notifications to that project do not trigger polling. Everything works fine if the variable is replaced with a hard-coded name.
Project:
Jenkins
Priority:
Minor
Reporter:
Milo Hyson
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-27739) Changes to slave environment variables are ignored by master
Milo Hyson created JENKINS-27739 Changes to slave environment variables are ignored by master Issue Type: Bug Assignee: Unassigned Components: core Created: 03/Apr/15 6:23 PM Description: A slave's environment variables seem to be cached upon first connect and then never considered again. This prevents legitimate changes to a slave's environment from having any effect on builds. The only workaround I can find is to delete a slave and recreate it, which in a complex environment is unacceptable. This may be a consequence of JENKINS-26755. Environment: Jenkins 1.606 Project: Jenkins Labels: envinronment-variables slaves Priority: Major Reporter: Milo Hyson This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-27739) Changes to slave environment variables are ignored by master
Milo Hyson commented on JENKINS-27739 Changes to slave environment variables are ignored by master Installed Plugins: Ant Plugin (ant) v1.2 buildgraph-view (buildgraph-view) v1.1.1 CloudBees Build Flow plugin (build-flow-plugin) v0.16 conditional-buildstep (conditional-buildstep) v1.3.3 Copy Artifact Plugin (copyartifact) v1.32.1 Credentials Binding Plugin (credentials-binding) v1.3 Credentials Plugin (credentials) v1.21 Email Extension Plugin (email-ext) v2.39 embeddable-build-status (embeddable-build-status) v1.5 Environment Injector Plugin (envinject) v1.90 External Monitor Job Type Plugin (external-monitor-job) v1.4 GitHub API Plugin (github-api) v1.59 GitHub plugin (github) v1.10 GitHub Pull Request Builder (ghprb) v1.16-5 Green Balls (greenballs) v1.14 Javadoc Plugin (javadoc) v1.3 Jenkins Active Directory plugin (active-directory) v1.39 Jenkins build timeout plugin (build-timeout) v1.14 Jenkins Cobertura Plugin (cobertura) v1.9.6 Jenkins CVS Plug-in (cvs) v2.12 Jenkins description setter plugin (description-setter) v1.9 Jenkins Exclusion Plug-in (Exclusion) v0.10 Jenkins GIT client plugin (git-client) v1.11.1 Jenkins GIT plugin (git) v2.3 Jenkins Gradle plugin (gradle) v1.24 Jenkins Gravatar plugin (gravatar) v2.1 Jenkins Job Configuration History Plugin (jobConfigHistory) v2.10 Jenkins jQuery plugin (jquery) v1.7.2-1 Jenkins Mailer Plugin (mailer) v1.12 Jenkins Multijob plugin (jenkins-multijob-plugin) v1.15 Jenkins Parameterized Trigger plugin (parameterized-trigger) v2.25 Jenkins Priority Sorter Plugin (PrioritySorter) v2.9 Jenkins promoted builds plugin (promoted-builds) v2.19 Jenkins SSH Slaves plugin (ssh-slaves) v1.9 Jenkins Subversion Plug-in (subversion) v2.4.5 Jenkins TextFinder plugin (text-finder) v1.10 Jenkins Throttle Concurrent Builds Plug-in (throttle-concurrents) v1.8.4 Jenkins Translation Assistance plugin (translation) v1.12 Job Import Plugin (job-import-plugin) v1.2 Join plugin (join) v1.15 JUnit Plugin (junit) v1.2 LDAP Plugin (ldap) v1.11 MapDB API Plugin (mapdb-api) v1.0.6.0 Matrix Authorization Strategy Plugin (matrix-auth) v1.2 Matrix Project Plugin (matrix-project) v1.4 Maven Integration plugin (maven-plugin) v2.7.1 Monitoring (monitoring) v1.53.1 Next Build Number Plugin (next-build-number) v1.1 Node and Label parameter plugin (nodelabelparameter) v1.5.1 NodeJS Plugin (nodejs) v0.2.1 OWASP Markup Formatter Plugin (antisamy-markup-formatter) v1.3 PAM Authentication plugin (pam-auth) v1.2 Performance plugin (performance) v1.11 Plain Credentials Plugin (plain-credentials) v1.1 Plot plugin (plot) v1.8 Publish Over SSH (publish-over-ssh) v1.12 Run Condition Plugin (run-condition) v1.0 SCM API Plugin (scm-api) v0.2 Script Security Plugin (script-security) v1.13 Semantic Versioning Plugin (semantic-versioning-plugin) v1.7 Simple Theme Plugin (simple-theme-plugin) v0.3 SSH Agent Plugin (ssh-agent) v1.5 SSH Credentials Plugin (ssh-credentials) v1.10 Token Macro Plugin (token-macro) v1.10 Windows Slaves Plugin (windows-slaves) v1.0 Workflow: Step API (workflow-step-api) v1.2 xUnit plugin (xunit) v1.92 youtrack-plugin (youtrack-plugin) v0.6.3 Reproduction: 1) Add a slave node to a master connecting via JNLP. 2) Start slave.jar on the slave machine. 3) On the master, view the new node's system information and note the PATH environment variable. 4) Kill slave.jar. 5) Change the PATH on the slave machine. 6) Restart slave.jar. 7) Look again at the node's system information on the master and note the PATH variable has not changed. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-27739) Changes to slave environment variables are ignored by master
Milo Hyson commented on JENKINS-27739 Changes to slave environment variables are ignored by master I just used PATH as an example. In my actual case I had three custom variables set on the slave machine. When I removed them and restarted slave.jar, those variables remained. I made other changes to test my suspicions (e.g. altering PATH) and they too remained unaltered. It's not a regression to my knowledge. We've never needed to change slave variables before. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-27739) Changes to slave environment variables are ignored by master
Milo Hyson commented on JENKINS-27739 Changes to slave environment variables are ignored by master Looks like the problem might have occurred around v1.606. For each of the tests I conducted the following procedure: 1) Started with the following environment variables on the slave machine PATH = /usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin SOME_ENVVAR = value 2) Launched java -jar jenkins.war on the master machine 3) Added a new node to the master 4) Started slave.jar on the slave 5) Ensured PATH and SOME_ENVVAR showed up on master 6) Killed slave.jar 7) Appended :/nonexistent to PATH 8) Removed SOME_ENVVAR 9) Ensured variables changed on slave machine 10) Restarted slave.jar 11) Refreshed node's system-information page on master The following were the results: v1.599 without EnvInject PATH updated on master SOME_ENVVAR disappeared from master v1.599 with EnvInject PATH updated on master SOME_ENVVAR disappeared from master v1.606 with EnvInject PATH did not update on master SOME_ENVVAR remained on master This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-27739) Changes to slave environment variables are ignored by master
Milo Hyson edited a comment on JENKINS-27739 Changes to slave environment variables are ignored by master Looks like the problem might have occurred around v1.606. For each of the tests I conducted the following procedure: 1) Started with the following environment variables on the slave machine PATH = /usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin SOME_ENVVAR = value 2) Launched java -jar jenkins.war on the master machine 3) Added a new node to the master 4) Started slave.jar on the slave 5) Ensured PATH and SOME_ENVVAR showed up on master 6) Killed slave.jar 7) Appended :/nonexistent to PATH 8) Removed SOME_ENVVAR 9) Ensured variables changed on slave machine 10) Restarted slave.jar 11) Refreshed node's system-information page on master The following were the results: v1.599 without EnvInject PATH updated on master SOME_ENVVAR disappeared from master v1.599 with EnvInject PATH updated on master SOME_ENVVAR disappeared from master v1.606 with EnvInject PATH did not update on master SOME_ENVVAR remained on master This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-27739) Changes to slave environment variables are ignored by master
Milo Hyson edited a comment on JENKINS-27739 Changes to slave environment variables are ignored by master Looks like the problem might have occurred around v1.606. For each of the tests I conducted the following procedure: Started with the following environment variables on the slave machine PATH = /usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin SOME_ENVVAR = value Launched java -jar jenkins.war on the master machine Added a new node to the master Started slave.jar on the slave Ensured PATH and SOME_ENVVAR showed up on master Killed slave.jar Appended :/nonexistent to PATH Removed SOME_ENVVAR Ensured variables changed on slave machine Restarted slave.jar Refreshed node's system-information page on master The following were the results: v1.599 without EnvInject PATH updated on master SOME_ENVVAR disappeared from master v1.599 with EnvInject PATH updated on master SOME_ENVVAR disappeared from master v1.606 with EnvInject PATH did not update on master SOME_ENVVAR remained on master This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-27739) Changes to slave environment variables are ignored by master
Milo Hyson edited a comment on JENKINS-27739 Changes to slave environment variables are ignored by master Looks like the problem might have occurred around v1.606. For each of the tests I conducted the following procedure: Started with the following environment variables on the slave machine PATH = /usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin SOME_ENVVAR = value Launched java -jar jenkins.war on the master machine Added a new node to the master Started slave.jar on the slave Ensured PATH and SOME_ENVVAR showed up on master Killed slave.jar Appended :/nonexistent to PATH Removed SOME_ENVVAR Ensured variables changed on slave machine Restarted slave.jar Refreshed node's system-information page on master The following were the results: v1.599 without EnvInject PATH updated on master SOME_ENVVAR disappeared from master v1.599 with EnvInject PATH updated on master SOME_ENVVAR disappeared from master v1.606 with EnvInject PATH did not update on master SOME_ENVVAR remained on master This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
