[JIRA] [github] (JENKINS-23661) github webhook failing
Nukul Bhasin commented on JENKINS-23661 github webhook failing https://github.com/github/github-services/commit/19a3c876e483e2470f21f756ac9ee0499b5c4322#diff-96256a1827d9dfd0cd6a1f068b18831dR12 I will put up a new fix for the plugin, for now the change in github services will suffice to get folks rolling. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [github] (JENKINS-23661) github webhook failing
Nukul Bhasin edited a comment on JENKINS-23661 github webhook failing I explained here what exactly happened here. https://github.com/github/github-services/commit/19a3c876e483e2470f21f756ac9ee0499b5c4322#diff-96256a1827d9dfd0cd6a1f068b18831dR12 I will put up a new fix for the plugin, for now the change in github services will suffice to get folks rolling. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [github] (JENKINS-22071) 'pull_request' type webhook from Github throws an exception
Nukul Bhasin commented on JENKINS-22071 pull_request type webhook from Github throws an exception Kohshuke, I have opened a pull request so people can debug their issues more easily https://github.com/jenkinsci/github-plugin/pull/40 This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [github] (JENKINS-18165) NPE in github status notification, if build not triggered by github push trigger
Nukul Bhasin commented on JENKINS-18165 NPE in github status notification, if build not triggered by github push trigger Also reproducible if you miss the 'GITHUB project' field in your configuration. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [github] (JENKINS-22071) 'pull_request' type webhook from Github throws an exception
Nukul Bhasin commented on JENKINS-22071 pull_request type webhook from Github throws an exception Kohshuke, thanks for having a look. I am simply interested in finding out why Jenkins (at least the github plugin) is unable to get the payload. Obviously I will need to write the parsing of the pull_request type webhook myself and I happy to contribute that back into the plugin. I just need help figuring out why its not getting a payload. If you can help me debug or give me some pointer I would greatly appreciate. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [github] (JENKINS-22071) 'pull_request' type webhook from Github throws an exception
Nukul Bhasin closed JENKINS-22071 as Not A Defect pull_request type webhook from Github throws an exception The reason why I was seeing this issue was because I had configured github to send a application/json content type instead of application/form After changing the format obviously the type 'pull_request' webhook still doesn't work because the plugin lacks support for that type of Webhook. I will be adding the support in the coming week (hopefully) and contributed it back to the plugin (hopefully) Change By: Nukul Bhasin (12/Mar/14 2:18 AM) Status: Open Closed Resolution: NotADefect This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [github] (JENKINS-22071) 'pull_request' type webhook from Github throws an exception
Nukul Bhasin created JENKINS-22071 pull_request type webhook from Github throws an exception Issue Type: Bug Assignee: Unassigned Components: github Created: 06/Mar/14 7:25 PM Description: When configuring a Webhook from github of type 'push' the post is succesfully processed by the plugin. When a Webhook from github is configured of type 'pull_request' the post, the plugin throws an exception complaining that there is no payload. Github support seems to suggest that they are sending the correct payload. Exact line throwing the exception maps to this line - https://github.com/jenkinsci/github-plugin/blob/master/src/main/java/com/cloudbees/jenkins/GitHubWebHook.java#L152 which maps to exception cause here Caused by: java.lang.IllegalArgumentException: Not intended to be browsed interactively (must specify payload parameter) at com.cloudbees.jenkins.GitHubWebHook.doIndex(GitHubWebHook.java:154) Fully detailed exception returned is right here. at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:778) at org.kohsuke.stapler.Stapler.invoke(Stapler.java:858) at org.kohsuke.stapler.MetaClass$12.dispatch(MetaClass.java:390) at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:728) at org.kohsuke.stapler.Stapler.invoke(Stapler.java:858) at org.kohsuke.stapler.Stapler.invoke(Stapler.java:631) at org.kohsuke.stapler.Stapler.service(Stapler.java:225) at javax.servlet.http.HttpServlet.service(HttpServlet.java:848) at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:686) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1494) at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:96) at hudson.util.PluginServletFilter.doFilter(PluginServletFilter.java:88) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1482) at hudson.security.csrf.CrumbFilter.doFilter(CrumbFilter.java:48) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1482) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:84) at hudson.security.UnwrapSecurityExceptionFilter.doFilter(UnwrapSecurityExceptionFilter.java:51) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at jenkins.security.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:117) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at org.acegisecurity.providers.anonymous.AnonymousProcessingFilter.doFilter(AnonymousProcessingFilter.java:125) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at org.acegisecurity.ui.rememberme.RememberMeProcessingFilter.doFilter(RememberMeProcessingFilter.java:142) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at org.acegisecurity.ui.AbstractProcessingFilter.doFilter(AbstractProcessingFilter.java:271) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at org.acegisecurity.ui.basicauth.BasicProcessingFilter.doFilter(BasicProcessingFilter.java:174) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at jenkins.security.ApiTokenFilter.doFilter(ApiTokenFilter.java:79) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at org.acegisecurity.context.HttpSessionContextIntegrationFilter.doFilter(HttpSessionContextIntegrationFilter.java:249) at hudson.security.HttpSessionContextIntegrationFilter2.doFilter(HttpSessionContextIntegrationFilter2.java:67) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at hudson.security.ChainedServletFilter.doFilter(ChainedServletFilter.java:76) at hudson.security.HudsonFilter.doFilter(HudsonFilter.java:164) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1482) at org.kohsuke.stapler.compression.CompressionFilter.doFilter(CompressionFilter.java:46) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1482) at