[JIRA] (JENKINS-56997) this.me NullPointerException in GithubAuthenticationToken.java oauth

2019-04-12 Thread mail+jenk...@nh2.me (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Niklas Hambuechen commented on  JENKINS-56997  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: this.me NullPointerException in GithubAuthenticationToken.java oauth   
 

  
 
 
 
 

 
 I found a workaround for the above to use with nginx: 

 

proxy_set_header Authorization "";
 

 This makes sure nginx does not pass through any HTTP Basic Auth (or other authorization) header to Jenkins. So the remaining tasks for this ticket should probably be: 
 
Better error messages (don't swallow Bad credentials from Github, don't use assert here) 
Make it somehow possible to disable the plugin picking up Basic Auth and passing it to Github, especially after just switching from another Jenkins auth method to Github auth 
  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56997) this.me NullPointerException in GithubAuthenticationToken.java oauth

2019-04-12 Thread mail+jenk...@nh2.me (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Niklas Hambuechen edited a comment on  JENKINS-56997  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: this.me NullPointerException in GithubAuthenticationToken.java oauth   
 

  
 
 
 
 

 
 OK, I think I found a key underlying problem for why the NullPointerException comes back to me repeatedly , and also why it only appeared the first time after I shortly turned on Basic Auth in nginx .If I try to fix the problem by switching back to {{HudsonPrivateSecurityRealm}}, logging in as some local user, say {{admin}}, Jenkins prompts me with HTTP Basic Auth, into which I have to put my user {{admin}}. If I then then enable Github login, then I'll also get the {{NullPointerException}}, because in this codehttps://github.com/jenkinsci/github-oauth-plugin/blob/6165ab2acc4e9e39cbc67d231187e859f3524ff3/src/main/java/org/jenkinsci/plugins/GithubSecurityRealm.java#L531the {{authentication}} printed shows as{code}org.acegisecurity.providers.UsernamePasswordAuthenticationToken@8cffbcaa: Username: admin; Password: [PROTECTED]{code}Se how there's {{admin}} in here. That's because I haven't had a chance to log out of HTTP Basic Auth. I can see the {{Authorization: Basic ...}} header being set in the dev tools, and in fact, browsers like Firefox have no method to display visually that it's still being sent, or even to clear HTTP basic auth for just a single site (see https://bugzilla.mozilla.org/show_bug.cgi?id=540516#c2), but Firefox's {{Clear History... -> [x] Active Logins}} does the trick (wiping all sites' Basic Auth). And Jenkins / the Github plugin seems to pick up this Basic Auth header, and thus try to authenticate me to Github as {{admin}} (which can't work) instead of doing a normal Github OAuth.Then when that happens, the above-found problems with lack of error reporting that the auth failed kick in, and the NullPointerException is thrown.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and 

[JIRA] (JENKINS-56997) this.me NullPointerException in GithubAuthenticationToken.java oauth

2019-04-12 Thread mail+jenk...@nh2.me (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Niklas Hambuechen commented on  JENKINS-56997  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: this.me NullPointerException in GithubAuthenticationToken.java oauth   
 

  
 
 
 
 

 
 Finally, let's get back to Basic Auth in the nginx reverse proxy in front of Jenkins. When I have cleared the Basic Auth as described and everything is working, and I then enable Basic Auth in nginx, I get a password prompt (into which I put my nginx-configured credentials, let's say username niklas), and everything continues working fine (I'm still logged in in Jenkins and can browse around). But as soon as I click Logout in Jenkins, everything breaks, and I cannot get logged back in with Github. That is because we now have the same problem as before: The plugin picks up nginx's Basic Auth and uses that user to Github: 

 

org.acegisecurity.providers.UsernamePasswordAuthenticationToken@dc12364c: Username: niklas; Password: [PROTECTED]
 

 Which is wrong, because it should use the normal OAuth and ignore nginx's Basic Auth. That means right now, you can't run Jenkins behind nginx with Basic Auth while also using the github-oauth-plugin. So it seems there should be a way to disable the second branch in 

 

if (authentication instanceof GithubAuthenticationToken)
return authentication;
if (authentication instanceof UsernamePasswordAuthenticationToken)
try {
 

 being taken, and forcing Github auth no matter the HTTP auth.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 
  

[JIRA] (JENKINS-56997) this.me NullPointerException in GithubAuthenticationToken.java oauth

2019-04-12 Thread mail+jenk...@nh2.me (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Niklas Hambuechen commented on  JENKINS-56997  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: this.me NullPointerException in GithubAuthenticationToken.java oauth   
 

  
 
 
 
 

 
 OK, I think I found a key underlying problem for why the NullPointerException comes back to me repeatedly. If I try to fix the problem by switching back to HudsonPrivateSecurityRealm, logging in as some local user, say admin, Jenkins prompts me with HTTP Basic Auth, into which I have to put my user admin. If I then then enable Github login, then I'll also get the NullPointerException, because in this code https://github.com/jenkinsci/github-oauth-plugin/blob/6165ab2acc4e9e39cbc67d231187e859f3524ff3/src/main/java/org/jenkinsci/plugins/GithubSecurityRealm.java#L531 the authentication printed shows as 

 

org.acegisecurity.providers.UsernamePasswordAuthenticationToken@8cffbcaa: Username: admin; Password: [PROTECTED]
 

 Se how there's admin in here. That's because I haven't had a chance to log out of HTTP Basic Auth. I can see the Authorization: Basic ... header being set in the dev tools, and in fact, browsers like Firefox have no method to display visually that it's still being sent, or even to clear HTTP basic auth for just a single site (see https://bugzilla.mozilla.org/show_bug.cgi?id=540516#c2), but Firefox's Clear History... -> [x] Active Logins does the trick (wiping all sites' Basic Auth). And Jenkins / the Github plugin seems to pick up this Basic Auth header, and thus try to authenticate me to Github as admin (which can't work) instead of doing a normal Github OAuth. Then when that happens, the above-found problems with lack of error reporting that the auth failed kick in, and the NullPointerException is thrown.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 
   

[JIRA] (JENKINS-56997) this.me NullPointerException in GithubAuthenticationToken.java oauth

2019-04-12 Thread mail+jenk...@nh2.me (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Niklas Hambuechen commented on  JENKINS-56997  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: this.me NullPointerException in GithubAuthenticationToken.java oauth   
 

  
 
 
 
 

 
 OK, with more logging I found a couple more things that are wrong here. This code is triggered: https://github.com/jenkinsci/github-oauth-plugin/blob/6165ab2acc4e9e39cbc67d231187e859f3524ff3/src/main/java/org/jenkinsci/plugins/GithubAuthenticationToken.java#L494 

 

} catch (IOException e) {
LOGGER.log(Level.FINEST, e.getMessage(), e);
me = UNKNOWN_TOKEN;
usersByTokenCache.put(token, UNKNOWN_TOKEN);
 

 but because it uses FINEST logging, the error message never appears anywhere. The exeception e is: 

 

org.kohsuke.github.GHFileNotFoundException: {"message":"Bad credentials","documentation_url":"https://developer.github.com/v3"}
 

 Why does the code catch the much more general IOException instead of GHFileNotFoundException or some general Github-specific error? The code then also does me = UNKNOWN_TOKEN; where UNKNOWN_TOKEN = new GithubMyself(null);, so that's where the null comes from. In the face of this, the use of assert mentioned above looks quite certainly wrong, as Github complaining about bad credentials is a normal code path that can be taken, and should thus be always checked. It seems right now there's no code path that clearly tells the user what Github's error message is ("Bad credentials"), which is bad.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
  

[JIRA] (JENKINS-56997) this.me NullPointerException in GithubAuthenticationToken.java oauth

2019-04-12 Thread mail+jenk...@nh2.me (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Niklas Hambuechen commented on  JENKINS-56997  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: this.me NullPointerException in GithubAuthenticationToken.java oauth   
 

  
 
 
 
 

 
 OK, I compiled the plugin from source and added some logs. This assertion https://github.com/jenkinsci/github-oauth-plugin/blob/6165ab2acc4e9e39cbc67d231187e859f3524ff3/src/main/java/org/jenkinsci/plugins/GithubAuthenticationToken.java#L201 has no effect, it is just continued past. This is most likely because assertions are off by default on the JVM unless you enable them with java -ea (which is short for -enableassertions). Should this really be an assertion, or should this be a proper check with if and throwing an exception?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56997) this.me NullPointerException in GithubAuthenticationToken.java oauth

2019-04-12 Thread mail+jenk...@nh2.me (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Niklas Hambuechen commented on  JENKINS-56997  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: this.me NullPointerException in GithubAuthenticationToken.java oauth   
 

  
 
 
 
 

 
 For others also trying to use HTTP Basic Auth in front of Jenkins, an important trick is that after doing the HudsonPrivateSecurityRealm reset, one cannot login at all if the basic auth is enabled in nginx; that has to be turned off first.  Otherwise it keeps asking for a HTTP basic auth password in the browser and accepts none, not even the one it had accepted before.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56997) this.me NullPointerException in GithubAuthenticationToken.java oauth

2019-04-12 Thread mail+jenk...@nh2.me (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Niklas Hambuechen commented on  JENKINS-56997  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: this.me NullPointerException in GithubAuthenticationToken.java oauth   
 

  
 
 
 
 

 
 And indeed, deleting the ,repo part and restarting Jenkins brings back the NullPointerException, and adding it back afterwards does not help and it persists, and I have to wipe the credentials again to fix it. That feels like a bug. I suspec that the change that introduced this into my Jenkins was this (included first time in github-oauth-0.31): https://github.com/jenkinsci/github-oauth-plugin/commit/7a4539f8c6f245b83c78b61acb3c94bfe43652b5#diff-fab2dd7bd575663bdf8f8879e047ba54R109  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56997) this.me NullPointerException in GithubAuthenticationToken.java oauth

2019-04-12 Thread mail+jenk...@nh2.me (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Niklas Hambuechen edited a comment on  JENKINS-56997  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: this.me NullPointerException in GithubAuthenticationToken.java oauth   
 

  
 
 
 
 

 
 Here's one thing I noticed:Before, in the broken setup, {{config.xml}} contained{ { code} } read:org,user:email{ { code} } Now in the fixed setup, it contains{ { code} } read:org,user:email,repo{ { code} } Beyond that, nothing but the saved client {{clientSecret}} (apparently encoded in some form as it's longer than what's shown in Github) changed.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56997) this.me NullPointerException in GithubAuthenticationToken.java oauth

2019-04-12 Thread mail+jenk...@nh2.me (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Niklas Hambuechen edited a comment on  JENKINS-56997  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: this.me NullPointerException in GithubAuthenticationToken.java oauth   
 

  
 
 
 
 

 
 Here's one thing I noticed:Before, in the broken setup, {{config.xml}} contained{{code}}read:org,user:email{{code}} Now in the fixed setup, it contains {{code}} read:org,user:email,repo {{code}} Beyond that, nothing but the saved client {{clientSecret}} (apparently encoded in some form as it's longer than what's shown in Github) changed.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56997) this.me NullPointerException in GithubAuthenticationToken.java oauth

2019-04-12 Thread mail+jenk...@nh2.me (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Niklas Hambuechen commented on  JENKINS-56997  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: this.me NullPointerException in GithubAuthenticationToken.java oauth   
 

  
 
 
 
 

 
 Here's one thing I noticed: Before, in the broken setup, config.xml contained code read:org,user:email code codecode  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56997) this.me NullPointerException in GithubAuthenticationToken.java oauth

2019-04-12 Thread mail+jenk...@nh2.me (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Niklas Hambuechen commented on  JENKINS-56997  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: this.me NullPointerException in GithubAuthenticationToken.java oauth   
 

  
 
 
 
 

 
 I've worked around it by now by following https://github.com/jenkinsci/github-oauth-plugin/tree/6165ab2acc4e9e39cbc67d231187e859f3524ff3#troubleshooting-installation, resetting the relevant sections in Jenkins's config.xml to 

 

"hudson.security.HudsonPrivateSecurityRealm">
 

 and thus re-initialising the plugin (note this sets Jenkins back into a state where any user can register by themselves, so better disconnect it from the Internet before so that nobody can exploit this). After re-entering my unchanged Github OAuth client ID and secrent, and confirming the Github question whether to approve it, it's working again (and now also behind HTTP basic auth which I added just after). It would still be good to figure out what caused this NullPointerException in case other people have the same problem.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56997) this.me NullPointerException in GithubAuthenticationToken.java oauth

2019-04-12 Thread mail+jenk...@nh2.me (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Niklas Hambuechen updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-56997  
 
 
  this.me NullPointerException in GithubAuthenticationToken.java oauth   
 

  
 
 
 
 

 
Change By: 
 Niklas Hambuechen  
 
 
Summary: 
 this.me NullPointerException  in GithubAuthenticationToken.java oauth  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-56997) NullPointerException

2019-04-12 Thread mail+jenk...@nh2.me (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Niklas Hambuechen created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-56997  
 
 
  NullPointerException   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Sam Gleske  
 
 
Components: 
 github-oauth-plugin  
 
 
Created: 
 2019-04-12 23:11  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Niklas Hambuechen  
 

  
 
 
 
 

 
 With github-oauth-0.31 as well as github-oauth-0.32 (to which I upgraded by manually placing it into the plugins directory in an attempt to fix the issue), since today my Jenkins refuses to work at all because I can't log in with Github, with the following exception: 

 

java.lang.NullPointerException
	at org.jenkinsci.plugins.GithubAuthenticationToken.(GithubAuthenticationToken.java:205)
	at org.jenkinsci.plugins.GithubSecurityRealm$1.authenticate(GithubSecurityRealm.java:538)
	at jenkins.security.BasicHeaderRealPasswordAuthenticator.authenticate(BasicHeaderRealPasswordAuthenticator.java:56)
	at jenkins.security.BasicHeaderProcessor.doFilter(BasicHeaderProcessor.java:79)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at org.acegisecurity.context.HttpSessionContextIntegrationFilter.doFilter(HttpSessionContextIntegrationFilter.java:249)
	at hudson.security.HttpSessionContextIntegrationFilter2.doFilter(HttpSessionContextIntegrationFilter2.java:67)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at hudson.security.ChainedServletFilter.doFilter(ChainedServletFilter.java:90)
	at hudson.security.HudsonFilter.doFilter(HudsonFilter.java:171)
	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1642)
	at org.kohsuke.stapler.compression.CompressionFilter.doFilter(CompressionFilter.java:49)
	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1642)
	at hudson.util.CharacterEncodingFilter.doFilter(CharacterEncodingFilter.java:82)
	at 

[JIRA] (JENKINS-51161) Blue Ocean spinner animation uses 100% CPU

2018-05-08 Thread mail+jenk...@nh2.me (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Niklas Hambuechen commented on  JENKINS-51161  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Blue Ocean spinner animation uses 100% CPU   
 

  
 
 
 
 

 
 Hey Nicolae, to reproduce I simply start a build or re-build, an then htop shows the CPU usage in my Chromium 65, see attached screenshot.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-51161) Blue Ocean spinner animation uses 100% CPU

2018-05-08 Thread mail+jenk...@nh2.me (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Niklas Hambuechen updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-51161  
 
 
  Blue Ocean spinner animation uses 100% CPU   
 

  
 
 
 
 

 
Change By: 
 Niklas Hambuechen  
 
 
Attachment: 
 Screenshot from 2018-05-08 10-59-35.png  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-51161) Blue Ocean spinner animation uses 100% CPU

2018-05-06 Thread mail+jenk...@nh2.me (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Niklas Hambuechen created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-51161  
 
 
  Blue Ocean spinner animation uses 100% CPU   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Components: 
 blueocean-plugin  
 
 
Created: 
 2018-05-06 18:12  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Niklas Hambuechen  
 

  
 
 
 
 

 
 The new blue ocean spinner animation for running builds creates 100% CPU usage in Chrome on my laptop, making it last ~2 hours on battery instead of 10. The speed of the machine almost doesn't matter, it'll try to make the animation as smooth as possible. Note this is a common problem with lots of software; Chromium had this issue with their tab notification highligts, Firefox had this problem with their spinner. The solution is always to cap the speed of the spinner animation (e.g. to 25 FPS), or to use an animation that is designed to looks good at low FPS (e.g. using a "segmented" spinner like this one.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 

[JIRA] (JENKINS-49537) "Waiting for next available executor on master" solved by *looking* at other jobs

2018-03-03 Thread mail+jenk...@nh2.me (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Niklas Hambuechen commented on  JENKINS-49537  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: "Waiting for next available executor on master" solved by *looking* at other jobs   
 

  
 
 
 
 

 
 I got it again now and found out that going on the Jenkins main page (not the Blue one, the classic one) is what unlocks the build. Details: https://jenkins1.example.com/job/example/job/myfeaturebranch/3/console shows: Push event to branch myfeaturebranch {{ 19:52:57 Connecting to https://api.github.com using username/**}} {{ Obtained Jenkinsfile from ...}} {{ Running in Durability level: MAX_SURVIVABILITY}} {{ [Pipeline] slackSend}} {{ run slackstepsend, step null:false, desc :false}} {{ Slack Send Pipeline step configured values from global config - baseUrl: true, teamDomain: true, token: true, channel: true, color: false}} {{ [Pipeline] node}} {{ Still waiting to schedule task}} {{ Waiting for next available executor on master}} `journalctl -u jenkins -e` shows: Mar 03 19:56:52 jenkins1 jenkins-start[5197]: Mar 03, 2018 7:56:52 PM io.jenkins.blueocean.rest.impl.pipeline.PipelineNodeGraphVisitor  {{ Mar 03 19:56:52 jenkins1 jenkins-start[5197]: SEVERE: Could not find execution for run example/myfeaturebranch#2}} {{ Mar 03 19:56:52 jenkins1 jenkins-start[5197]: Mar 03, 2018 7:56:52 PM io.jenkins.blueocean.rest.impl.pipeline.PipelineNodeGraphVisitor }} {{ Mar 03 19:56:52 jenkins1 jenkins-start[5197]: SEVERE: Could not find execution for run example/myfeaturebranch#2}} {{ Mar 03 19:56:52 jenkins1 jenkins-start[5197]: Mar 03, 2018 7:56:52 PM io.jenkins.blueocean.rest.impl.pipeline.PipelineNodeGraphVisitor }} {{ Mar 03 19:56:52 jenkins1 jenkins-start[5197]: SEVERE: Could not find execution for run example/myfeaturebranch#2}} {{ Mar 03 19:56:52 jenkins1 jenkins-start[5197]: Mar 03, 2018 7:56:52 PM io.jenkins.blueocean.rest.impl.pipeline.PipelineNodeGraphVisitor }} {{ Mar 03 19:56:52 jenkins1 jenkins-start[5197]: SEVERE: Could not find execution for run example/myfeaturebranch#1}} {{ Mar 03 19:56:52 jenkins1 jenkins-start[5197]: Mar 03, 2018 7:56:52 PM io.jenkins.blueocean.rest.impl.pipeline.PipelineNodeGraphVisitor }} {{ Mar 03 19:56:52 jenkins1 jenkins-start[5197]: SEVERE: Could not find execution for run example/myfeaturebranch#1}} {{ Mar 03 19:56:52 jenkins1 jenkins-start[5197]: Mar 03, 2018 7:56:52 PM io.jenkins.blueocean.rest.impl.pipeline.PipelineNodeGraphVisitor }} {{ Mar 03 19:56:52 jenkins1 jenkins-start[5197]: SEVERE: Could not find execution for run example/myfeaturebranch#1}} Visiting https://jenkins1.example.com/job/example/job/myfeaturebranch/2/console had no effect Visiting https://jenkins1.example.com/blue/organizations/jenkins/example/detail/myfeaturebranch/2/pipeline/ printed into the logs: Mar 03 20:00:15 jenkins1 jenkins-start[5197]: Mar 03, 2018 8:00:15 PM io.jenkins.blueocean.rest.impl.pipeline.PipelineNodeGraphVisitor  {{ Mar 03 20:00:15 jenkins1 jenkins-start[5197]: SEVERE: Could not find execution for run example/myfeaturebranch#2}} {{ Mar 03 20:00:15 jenkins1 jenkins-start[5197]: Mar 03, 2018 8:00:15 PM io.jenkins.blueocean.rest.impl.pipeline.PipelineNodeGraphVisitor }} {{ Mar 03 20:00:15 jenkins1 jenkins-start[5197]: SEVERE: Could not find execution for run example/myfeaturebranch#2}} {{ Mar 03 20:00:15 jenkins1 jenkins-start[5197]: Mar 03, 2018 8:00:15 PM io.jenkins.blueocean.rest.impl.pipeline.PipelineNodeGraphVisitor }} {{ Mar 03 20:00:15 jenkins1 jenkins-start[5197]: SEVERE: Could not find execution for run example/myfeaturebranch#2}} {{ Mar 03 20:00:16 jenkins1 jenkins-start[5197]: Mar 03, 2018 8:00:16 PM io.jenkins.blueocean.rest.impl.pipeline.PipelineNodeGraphVisitor }} {{ Mar 03 20:00:16 jenkins1 jenkins-start[5197]: SEVERE: Could not find 

[JIRA] (JENKINS-49537) "Waiting for next available executor on master" solved by *looking* at other jobs

2018-03-03 Thread mail+jenk...@nh2.me (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Niklas Hambuechen commented on  JENKINS-49537  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: "Waiting for next available executor on master" solved by *looking* at other jobs   
 

  
 
 
 
 

 
 The style editing in this JIRA doesn't work at all  It inserts random characters even when using visual mode.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-49537) "Waiting for next available executor on master" solved by *looking* at other jobs

2018-02-13 Thread mail+jenk...@nh2.me (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Niklas Hambuechen created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-49537  
 
 
  "Waiting for next available executor on master" solved by *looking* at other jobs   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Components: 
 core  
 
 
Created: 
 2018-02-13 17:52  
 
 
Environment: 
 Jenins 2.95, on NixOS  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Niklas Hambuechen  
 

  
 
 
 
 

 
 OK so this is a weird one. Once a week or so, by Jenkins builds get stuck with Waiting for next available executor on master. E.g. now, the a build got stuck for 2 days this way. The funny thing is: I can resolve this bug simply by read-only-browsing around in the Jenkins UI. Once I view the console output of the finished build before the hanging build, the hanging build suddenly starts building. So, "looking angry at Jenkins" makes the issue go away. I could reproduce this 4 times so far, but it takes a week or so to happen again so it's not exactly easy to reproduce. After short consideration if you have any idea what might cause this, please advise how I can gather more information to figure this out. Thanks! (I've filed the bug as `core` but don't know if it might be caused by a different plugin.) 
 Jenkins 2.95 Plugins: {{ org.jenkins-ci.main:jenkins-war:2.95 org.jenkins-ci:crypto-util:1.1 commons-httpclient:commons-httpclient:3.1-jenkins-1 aopalliance:aopalliance:1.0 com.google.inject:guice:4.0 org.jenkins-ci.modules:slave-installer:1.6 org.springframework:spring-dao:1.2.9 org.jenkins-ci.modules:instance-identity:2.1 org.jenkins-ci:constant-pool-scanner:1.2 org.connectbot.jbcrypt:jbcrypt:1.0.0 org.jenkins-ci.modules:ssh-cli-auth:1.4 org.ow2.asm:asm-commons:5.0.3 org.jenkins-ci:symbol-annotation:1.1 com.github.jnr:jnr-constants:0.9.8 org.jenkins-ci.modules:windows-slave-installer:1.9.2 

[JIRA] (JENKINS-42494) Mention explicitly in docs that the Github user needs to have push permissions

2017-03-06 Thread mail+jenk...@nh2.me (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Niklas Hambuechen created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-42494  
 
 
  Mention explicitly in docs that the Github user needs to have push permissions   
 

  
 
 
 
 

 
Issue Type: 
  Improvement  
 
 
Assignee: 
 Raul Arabaolaza  
 
 
Components: 
 pipeline-githubnotify-step-plugin  
 
 
Created: 
 2017/Mar/06 12:23 PM  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Niklas Hambuechen  
 

  
 
 
 
 

 
 This has tricked many people already, and today me: The Github user given in the "account" config field needs to have "Write" permissions to the repository; having Read permissions plus explicit "repo:status" permissions is not enough. As https://developer.github.com/v3/repos/statuses/ says: "Users with push access can create commit statuses for a given ref:" This caused me a couple hours of confusion today, and also confused other projects, e.g. https://github.com/jonnyzzz/TeamCity.GitHub/issues/12 It would be great if the README that gets rendered onto https://wiki.jenkins-ci.org/display/JENKINS/Pipeline+Githubnotify+Step+Plugin could say explicitly that the user given with "account" has to have Write permission to the repo. Thanks!  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

 

[JIRA] (JENKINS-42493) Give error message when credential has the wrong type

2017-03-06 Thread mail+jenk...@nh2.me (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Niklas Hambuechen created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-42493  
 
 
  Give error message when credential has the wrong type   
 

  
 
 
 
 

 
Issue Type: 
  Improvement  
 
 
Assignee: 
 Raul Arabaolaza  
 
 
Components: 
 pipeline-githubnotify-step-plugin  
 
 
Created: 
 2017/Mar/06 12:15 PM  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Niklas Hambuechen  
 

  
 
 
 
 

 
 In this line:     https://github.com/jenkinsci/pipeline-githubnotify-step-plugin/blob/d88d474e93d96a264b82baa984be2a1096e92016/src/main/java/org/jenkinsci/plugins/pipeline/githubstatusnotification/GitHubStatusNotificationStep.java#L223   CREDENTIALS_ID_NOT_EXISTS is returned, even when the credentials do exist but are not of the right type (UsernamePasswordCredentials.class). It would be great if the plugin could give an explicit error when the credentials do exist but are of the wrong type (this cost me a couple hours debugging, having accidentally used a "Password" credential).   Thanks!  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 

[JIRA] [git] (JENKINS-5724) Choosing what to build is slow when using a lot of branches.

2014-03-31 Thread mail+jenk...@nh2.me (JIRA)














































Niklas Hambuechen
 commented on  JENKINS-5724


Choosing what to build is slow when using a lot of branches.















Ok, I rebased it (see the Github pull-request).

I also made a script to create a small test repo for reproducing this; find it at https://gist.github.com/nh2/9902001.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [git] (JENKINS-5724) Choosing what to build is slow when using a lot of branches.

2014-03-22 Thread mail+jenk...@nh2.me (JIRA)














































Niklas Hambuechen
 reopened  JENKINS-5724


Choosing what to build is slow when using a lot of branches.
















Change By:


Niklas Hambuechen
(22/Mar/14 5:38 PM)




Resolution:


Fixed





Status:


Closed
Reopened



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [git] (JENKINS-5724) Choosing what to build is slow when using a lot of branches.

2014-03-22 Thread mail+jenk...@nh2.me (JIRA)














































Niklas Hambuechen
 commented on  JENKINS-5724


Choosing what to build is slow when using a lot of branches.















I don't think this is resolved; https://github.com/jenkinsci/git-plugin/blob/master/src/main/java/hudson/plugins/git/util/GitUtils.java#L141 still looks like the original algorithm.

Unfortunately I don't have time to perform a rebase on top of a new major release (as asked for in https://github.com/jenkinsci/git-plugin/pull/156#issuecomment-26217539) until earliest in 2 weeks.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [subversion] (JENKINS-673) SCM catch up feature

2014-02-27 Thread mail+jenk...@nh2.me (JIRA)














































Niklas Hambuechen
 commented on  JENKINS-673


SCM catch up feature















Can anybody explain if this would be part of core Jenkins or the code source, e.g. the Git plugin?



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


[JIRA] [git] (JENKINS-18343) Another O(n^2) algorithm creates 100% CPU usage

2013-06-13 Thread mail+jenk...@nh2.me (JIRA)














































Niklas Hambuechen
 created  JENKINS-18343


Another O(n^2) algorithm creates 100% CPU usage















Issue Type:


Bug



Assignee:


Nicolas De Loof



Components:


git



Created:


14/Jun/13 1:02 AM



Description:


With the fix for bug #18274, getting all git HEADs does no longer run in O(n^2) of the number of potential HEADs.

However still, after the real HEADs are calculated, Jenkins's git runs `git show ... that head..some other commit` to obtain the list of changes.
It does so for each head, so this is another O(n^2) traversal of the repository and takes hours if you have 500 branches (which is a common thing).




Project:


Jenkins



Priority:


Major



Reporter:


Niklas Hambuechen

























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] [git] (JENKINS-5724) Choosing what to build is slow when using a lot of branches.

2013-06-07 Thread mail+jenk...@nh2.me (JIRA)














































Niklas Hambuechen
 started work on  JENKINS-5724


Choosing what to build is slow when using a lot of branches.
















Change By:


Niklas Hambuechen
(07/Jun/13 5:27 PM)




Status:


Open
InProgress



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] [git] (JENKINS-5724) Choosing what to build is slow when using a lot of branches.

2013-06-07 Thread mail+jenk...@nh2.me (JIRA)














































Niklas Hambuechen
 commented on  JENKINS-5724


Choosing what to build is slow when using a lot of branches.















I fixed that in this pull request:

https://github.com/jenkinsci/git-plugin/pull/156

It is much faster now, please try it and tell me if it works.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] [git] (JENKINS-5724) Choosing what to build is slow when using a lot of branches.

2013-06-07 Thread mail+jenk...@nh2.me (JIRA)















































Niklas Hambuechen
 assigned  JENKINS-5724 to Niklas Hambuechen



Choosing what to build is slow when using a lot of branches.
















Change By:


Niklas Hambuechen
(07/Jun/13 5:26 PM)




Assignee:


jbq
NiklasHambuechen



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] [git] (JENKINS-18232) How do I enable slave logging?

2013-06-06 Thread mail+jenk...@nh2.me (JIRA)














































Niklas Hambuechen
 created  JENKINS-18232


How do I enable slave logging?















Issue Type:


Task



Assignee:


Nicolas De Loof



Components:


git



Created:


06/Jun/13 10:39 AM



Description:


I need to see the output of this line:

https://github.com/kpfleming/jenkins-git-plugin/blob/3d9a73d26b129249c51fccfca6060280197b25eb/src/main/java/hudson/plugins/git/util/GitUtils.java#L123

on my slave server since the git plugin runs on 100% somewhere around that code.

What do I have to do in order to see this output?

Where can I set the log level?

Where will I find the output?

I know a bugtracker isn't the best place to ask, but I don't know of another place.

Thank you.




Project:


Jenkins



Priority:


Trivial



Reporter:


Niklas Hambuechen

























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.